Re: [PATCH v7 02/11] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 10/13/26 5:16 PM, Kathiravan Thirumoorthy wrote:
> 
> On 10/13/2026 8:11 PM, Konrad Dybcio wrote:
>> On 10/13/26 3:14 PM, Kathiravan Thirumoorthy wrote:
>>> On 10/12/2026 12:53 PM, Varadarajan Narayanan wrote:
>>>> RDP504 has USB, PCIe and SPI NAND devices populated. EMMC and NAND
>>>> share the GPIOs. The board has to be reworked to change from EMMC
>>>> to NAND variant. Rename ipq5210-rdp504.dts as ipq5210-rdp504-common.dtsi
>>>> and include it in variant specific DTS file.
>>>>
>>>> Describe the fixed USB regulators, PCIe reset GPIOs, QPIC SPI NAND flash
>>>> and required pinctrl states. Enable QPIC BAM, USB and PCIe for the board.
>>>>
>>>> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
>>>> ---
>>>>    .../arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi | 209 +++++++++++++++++++++
>>>>    arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts        |  66 +------
>>>>    2 files changed, 211 insertions(+), 64 deletions(-)
>>> [...]
>>>
>>>> +
>>>> +&qpic_bam {
>>>> +    status = "okay";
>>>> +};
>>> NAND is the only consumer of this BAM. Should we move it to NAND DTS?
>> Can we enable it by default? (i.e. is there any reason not to?)
> 
> I don't see any reason for not enabling this by default . Since nand is the only consumer of the BAM DMA, we enable both nodes together to keep the unneeded devices in disabled state.

The first sentence says "we can", the second says "we can't"

Konrad