* Re: [Linux-kernel-mentorship] [PATCH] selftest: pidfd: Omit long and repeating outputs [not found] ` <20230523232207.363136-1-astrajoan@yahoo.com> @ 2023-05-24 9:12 ` Christian Brauner 2023-06-05 19:26 ` Shuah Khan 0 siblings, 1 reply; 2+ messages in thread From: Christian Brauner @ 2023-05-24 9:12 UTC (permalink / raw) To: Ziqi Zhao; +Cc: skhan, linux-kernel, linux-kselftest On Tue, May 23, 2023 at 11:22:07PM +0000, Ziqi Zhao wrote: > An output message: > > > # # waitpid WEXITSTATUS=0 > > will be printed for 30,000+ times in the `pidfd_test` selftest, which > does not seem ideal. This patch removes the print logic in the > `wait_for_pid` function, so each call to this function does not output > a line by default. Any existing call sites where the extra line might > be beneficial have been modified to include extra print statements > outside of the function calls. > > Signed-off-by: Ziqi Zhao <astrajoan@yahoo.com> > --- Fine by me, Reviewed-by: Christian Brauner <brauner@kernel.org> ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Linux-kernel-mentorship] [PATCH] selftest: pidfd: Omit long and repeating outputs 2023-05-24 9:12 ` [Linux-kernel-mentorship] [PATCH] selftest: pidfd: Omit long and repeating outputs Christian Brauner @ 2023-06-05 19:26 ` Shuah Khan 0 siblings, 0 replies; 2+ messages in thread From: Shuah Khan @ 2023-06-05 19:26 UTC (permalink / raw) To: Christian Brauner, Ziqi Zhao; +Cc: linux-kernel, linux-kselftest, Shuah Khan On 5/24/23 03:12, Christian Brauner wrote: > On Tue, May 23, 2023 at 11:22:07PM +0000, Ziqi Zhao wrote: >> An output message: >> >>> # # waitpid WEXITSTATUS=0 >> >> will be printed for 30,000+ times in the `pidfd_test` selftest, which >> does not seem ideal. This patch removes the print logic in the >> `wait_for_pid` function, so each call to this function does not output >> a line by default. Any existing call sites where the extra line might >> be beneficial have been modified to include extra print statements >> outside of the function calls. >> >> Signed-off-by: Ziqi Zhao <astrajoan@yahoo.com> >> --- > > Fine by me, > Reviewed-by: Christian Brauner <brauner@kernel.org> Thank you. Applied to linux-kselftest next for Linux 6.5-rc1. thanks, -- Shuah ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-05 19:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230523232207.363136-1-astrajoan.ref@yahoo.com>
[not found] ` <20230523232207.363136-1-astrajoan@yahoo.com>
2023-05-24 9:12 ` [Linux-kernel-mentorship] [PATCH] selftest: pidfd: Omit long and repeating outputs Christian Brauner
2023-06-05 19:26 ` Shuah Khan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®