Re: [Linux-kernel-mentorship] [PATCH] selftest: pidfd: Omit long and repeating outputs

Re: [Linux-kernel-mentorship] [PATCH] selftest: pidfd: Omit long and repeating outputs

[Christian Brauner]

On Tue, May 23, 2023 at 11:22:07PM +0000, Ziqi Zhao wrote:
> An output message:
> 
> > # # waitpid WEXITSTATUS=0
> 
> will be printed for 30,000+ times in the `pidfd_test` selftest, which
> does not seem ideal. This patch removes the print logic in the
> `wait_for_pid` function, so each call to this function does not output
> a line by default. Any existing call sites where the extra line might
> be beneficial have been modified to include extra print statements
> outside of the function calls.
> 
> Signed-off-by: Ziqi Zhao <astrajoan@yahoo.com>
> ---

Fine by me,
Reviewed-by: Christian Brauner <brauner@kernel.org>

Re: [Linux-kernel-mentorship] [PATCH] selftest: pidfd: Omit long and repeating outputs

[Shuah Khan]

On 5/24/23 03:12, Christian Brauner wrote:
> On Tue, May 23, 2023 at 11:22:07PM +0000, Ziqi Zhao wrote:
>> An output message:
>>
>>> # # waitpid WEXITSTATUS=0
>>
>> will be printed for 30,000+ times in the `pidfd_test` selftest, which
>> does not seem ideal. This patch removes the print logic in the
>> `wait_for_pid` function, so each call to this function does not output
>> a line by default. Any existing call sites where the extra line might
>> be beneficial have been modified to include extra print statements
>> outside of the function calls.
>>
>> Signed-off-by: Ziqi Zhao <astrajoan@yahoo.com>
>> ---
> 
> Fine by me,
> Reviewed-by: Christian Brauner <brauner@kernel.org>

Thank you. Applied to linux-kselftest next for Linux 6.5-rc1.

thanks,
-- Shuah