mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ivan Mikhaylov <fr0st61te@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>, Conor Dooley <conor@kernel.org>,
	aspeedyh <yh_chung@aspeedtech.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery	 <andrew@codeconstruct.com.au>,
	Ryan Chen <ryan_chen@aspeedtech.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	devicetree@vger.kernel.org,
		linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, 	linux-kernel@vger.kernel.org,
	openbmc@lists.ozlabs.org, 	maciej.lawniczak@intel.com,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 0/7] soc: aspeed: Add AST2600 eSPI controller support
Date: Mon, 16 Mar 2026 09:06:36 +0300	[thread overview]
Message-ID: <4400f95392163ddc3997cbbc0b298f50910fe6f2.camel@gmail.com> (raw)
In-Reply-To: <23909400-4e7f-49c9-a982-14036372af98@app.fastmail.com>

On Fri, 2026-03-13 at 22:36 +0100, Arnd Bergmann wrote:
> On Fri, Mar 13, 2026, at 17:24, Conor Dooley wrote:
> > On Fri, Mar 13, 2026 at 06:07:35PM +0800, aspeedyh wrote:
> > > This series adds initial support for the eSPI controller found on
> > > ASPEED
> > > AST2600 BMC SoCs.
> > > 
> > > The series introduces a eSPI controller framework for ASPEED SoCs
> > > under
> > > drivers/soc/aspeed/, adds AST2600-specific controller support for
> > > peripheral and flash channels, defines the corresponding
> > > devicetree 
> > > binding, and adds the AST2600 eSPI controller node to the SoC
> > > dtsi.
> > > 
> > > The driver is intended to support host-BMC communication over the
> > > BMC-side
> > > eSPI slave controller present on AST2600 systems.
> > 
> > This all seems to be in the wrong places entirely, shouldn't an
> > eSPI
> > driver and bindings go in the spi subsystem?
> 
> From an initial reading, my impression is that patches 1, 2, 3 and 7
> should be modified to use the normal SPI interfaces to implement
> an spi target driver, possibly a combined host/target driver.
> Reworking this should be fairly straightforward because the
> interfaces
> to the SPI core are well documented.

Arnd, that's would be nice if it would be standard SPI device. But what
if eSPI would be a bus? So, I assume all other which lying underneath 
eSPI would be much easier to implement as standard driver data set
SPI/GPIO/I2C with something like devm_regmap_init_espi(like for i2c/spi
or anything else) for example as common part for these drivers.

Thanks.

  parent reply	other threads:[~2026-03-16  6:06 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 10:07 aspeedyh
2026-03-13 10:07 ` [PATCH 1/7] dt-bindings: soc: aspeed: Add AST2600 eSPI controller aspeedyh
2026-03-16  7:07   ` Krzysztof Kozlowski
2026-03-16  8:17     ` YH Chung
2026-03-16 11:04       ` Conor Dooley
2026-03-17  8:43         ` YH Chung
2026-03-13 10:07 ` [PATCH 2/7] soc: aspeed: Introduce core eSPI controller support aspeedyh
2026-03-16  9:57   ` Philipp Zabel
2026-03-17  8:40     ` YH Chung
2026-03-13 10:07 ` [PATCH 3/7] soc: aspeed: Add AST2600 peripheral channel port I/O support aspeedyh
2026-05-07 14:03   ` Shulzhenko, Oleksandr
2026-03-13 10:07 ` [PATCH 4/7] soc: aspeed: Add eSPI TAFS backend support aspeedyh
2026-03-13 10:07 ` [PATCH 5/7] soc: aspeed: Add eSPI flash channel support aspeedyh
2026-03-19 23:53   ` kernel test robot
2026-03-20  1:17   ` kernel test robot
2026-03-20  4:19   ` kernel test robot
2026-06-24 12:02   ` Markus Elfring
2026-06-29  8:10     ` YH Chung
2026-06-24 12:14   ` Markus Elfring
2026-06-29  8:15     ` YH Chung
2026-06-29  8:50       ` [5/7] " Markus Elfring
2026-06-30  5:02         ` YH Chung
2026-03-13 10:07 ` [PATCH 6/7] soc: aspeed: Add sysfs controls for flash backend selection aspeedyh
2026-03-13 10:07 ` [PATCH 7/7] arm: dts: aspeed: Add eSPI node for AST2600 aspeedyh
2026-03-13 16:24 ` [PATCH 0/7] soc: aspeed: Add AST2600 eSPI controller support Conor Dooley
2026-03-13 16:32   ` Mark Brown
2026-03-13 16:48     ` Mark Brown
2026-03-16  3:07       ` YH Chung
2026-03-13 21:36   ` Arnd Bergmann
2026-03-14  1:02     ` Mark Brown
2026-03-16  6:06     ` Ivan Mikhaylov [this message]
2026-03-16  6:34     ` Andrew Jeffery
2026-03-17  8:14       ` YH Chung
2026-03-17  9:50         ` Arnd Bergmann
2026-03-25  8:41           ` YH Chung
2026-03-25 10:30             ` Arnd Bergmann
2026-03-27  4:14               ` YH Chung
2026-04-07  9:36                 ` YH Chung
2026-05-07 16:00                   ` Shulzhenko, Oleksandr
2026-05-12  7:08                     ` YH Chung
2026-05-12  8:45                       ` Shulzhenko, Oleksandr
2026-05-19 10:40                         ` YH Chung
2026-06-03  5:25                           ` YH Chung
2026-06-22  7:31                           ` YH Chung
2026-06-24  3:59                             ` YH Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4400f95392163ddc3997cbbc0b298f50910fe6f2.camel@gmail.com \
    --to=fr0st61te@gmail.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.lawniczak@intel.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=ryan_chen@aspeedtech.com \
    --cc=yh_chung@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®