mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, Jack Steiner <steiner@sgi.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: tip: patches in git for irq and numa
Date: Mon, 18 May 2009 08:03:49 -0700	[thread overview]
Message-ID: <4A1178D5.5050900@kernel.org> (raw)
In-Reply-To: <1242654650.26820.429.camel@twins>

Peter Zijlstra wrote:
> On Mon, 2009-05-18 at 09:29 +0200, Ingo Molnar wrote:
>> * Yinghai Lu <yinghai@kernel.org> wrote:
>>
>>> irq related:
>>> git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-2.6-yinghai.git irq
>>> need to on top of tip/irq/numa
>> ok, these were nicely structured. the pci_routeirq patch had a build 
>> bug for !CONFIG_PCI.
>>
>> ( I added an #ifdef for now, it might make sense to send a clean-up 
>>   patch in the next merge window (not now) to factor out a 
>>   pci_routeirq_enable() method that does all this cleanly. )
>>
>> Also, please add appropriate Cc: lines to the commit logs in the 
>> future, beyond the LKML-Reference tgs.
>>
>>> for memoryless node support: 
>>> git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-2.6-yinghai.git numa
>>> and it is on top of tip/master
>> small note: you could have based these on x86/mm btw. - that's where 
>> these patches go, typically.
>>
>> regarding subject lines:
>>
>>  d03a6a4: mm: clear N_HIGH_MEMORY map before se set it again -v2
>>  02ce039: x86: fix system without memory on node0 -v2
>>  8c1aec8: x86: fix node_possible_map logic -v2
>>  44a633c: x86: remove MEMORY_HOTPLUG_RESERVE related code -v2
>>
>> please never put '-v2' type of tags into the title of commits. In 
>> the title of patches they can be put here:
>>
>>   [PATCH, v2] x86: fix system without memory on node0
>>
>> that saves maintainers a bit of typing work.
>>
>> Also, you included:
>>
>>  d03a6a4: mm: clear N_HIGH_MEMORY map before se set it again -v2
>>
>> with no Acks from MM folks yet. So i skipped that one and will 
>> follow up about it.
> 
> The below seems to wreck my opteron, ata1 interrupts fail to get
> through.
> 
> 
> [    6.951257] ata1.00: qc timeout (cmd 0x27)
> [    6.955354] ata1.00: failed to read native max address (err_mask=0x4)
> [    6.961781] ata1.00: HPA support seems broken, skipping HPA handling
> [    7.273044] ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300)
> [    7.285159] ata1.00: configured for UDMA/133
> [    7.290052] scsi 0:0:0:0: Direct-Access     ATA      WDC WD1200JS-00N 10.0 PQ: 0 ANSI: 5
> [    7.299294] sd 0:0:0:0: [sda] 234441648 512-byte hardware sectors: (120 GB/111 GiB)
> [    7.306968] sd 0:0:0:0: [sda] Write Protect is off
> [    7.311754] sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
> [    7.316839] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
> [    7.326312]  sda:<6>ata2: SATA link down (SStatus 4 SControl 300)
> [    7.938372] ata3: SATA link down (SStatus 4 SControl 300)
> [    8.258372] ata4: SATA link down (SStatus 4 SControl 300)
> [    8.264357] scsi 4:0:0:0: CD-ROM            TEAC     DV-516G          F4S7 PQ: 0 ANSI: 5
> [   37.704234] ata1: lost interrupt (Status 0x50)
> [   37.708695] sd 0:0:0:0: [sda] Unhandled error code
> [   37.713479] sd 0:0:0:0: [sda] Result: hostbyte=DID_OK driverbyte=DRIVER_TIMEOUT
> [   37.720791] end_request: I/O error, dev sda, sector 0
> [   37.725848] Buffer I/O error on device sda, logical block 0
> 
> ---
> 
> 
> commit b9c61b70075c87a8612624736faf4a2de5b1ed30
> Author: Yinghai Lu <yinghai@kernel.org>
> Date:   Wed May 6 10:10:06 2009 -0700
> 
>     x86/pci: update pirq_enable_irq() to setup io apic routing
>     
>     So we can set io apic routing only when enabling the device irq.
>     
>     This is advantageous for IRQ descriptor allocation affinity: if we set up
>     the IO-APIC entry later, we have a chance to allocate the IRQ descriptor
>     later and know which device it is on and can set affinity accordingly.
>     
>     [ Impact: standardize/enhance irq-enabling sequence for mptable irqs ]

can you post whole bootlog?
need to figure out 32bit/64bit? ACPI is disabled? MPtable is used?

also please check if pci=routeirq help to fix the problem.

YH

  parent reply	other threads:[~2009-05-18 15:05 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-09  6:45 [PATCH 1/3] x86: remove MEMORY_HOTPLUG_RESERVE related code Yinghai Lu
2009-05-09  6:48 ` [PATCH 2/3] x86: add numa_move_cpus_to_node Yinghai Lu
2009-05-09  7:05   ` Justin P. Mattock
2009-05-12  1:27   ` Christoph Lameter
2009-05-11 21:53     ` Yinghai Lu
2009-05-12 20:59       ` Christoph Lameter
2009-05-12 17:16         ` Yinghai Lu
2009-05-12 21:21           ` Christoph Lameter
2009-05-13  5:39             ` Yinghai Lu
2009-05-14 19:34               ` Christoph Lameter
2009-05-14 20:58                 ` Yinghai Lu
2009-05-09  6:50 ` [PATCH 3/3] x86: fix node_possible_map logic -v2 Yinghai Lu
2009-05-11 17:53   ` Jack Steiner
2009-05-11 19:15     ` Yinghai Lu
2009-05-11 19:36       ` Yinghai Lu
2009-05-11 19:27     ` David Rientjes
2009-05-11 21:12       ` H. Peter Anvin
2009-05-11 21:26         ` Alan Cox
2009-05-11 22:25         ` David Rientjes
2009-05-12 15:06           ` Jack Steiner
2009-05-12 15:10             ` Yinghai Lu
2009-05-12 16:16               ` Jack Steiner
2009-05-12 16:40                 ` Yinghai Lu
2009-05-12 18:03                   ` Jack Steiner
2009-05-12 21:31                     ` Yinghai Lu
2009-05-12 21:58                       ` Jack Steiner
2009-05-12 23:13                         ` Yinghai Lu
2009-05-12 23:26                           ` Yinghai Lu
2009-05-12 15:43             ` Andi Kleen
2009-05-13  1:34             ` [PATCH] x86: fix system without memory on node0 Yinghai Lu
2009-05-13  8:00               ` Andi Kleen
2009-05-13 15:58                 ` Yinghai Lu
2009-05-13 13:35               ` Ingo Molnar
2009-05-13 16:52               ` Jack Steiner
2009-05-13 17:43                 ` Yinghai Lu
2009-05-13 18:08                 ` Yinghai Lu
2009-05-12  7:15         ` [PATCH 3/3] x86: fix node_possible_map logic -v2 Andi Kleen
2009-05-11 21:33       ` Jack Steiner
2009-05-11 22:56         ` David Rientjes
2009-05-11 23:00           ` Yinghai Lu
2009-05-12  7:09       ` Andi Kleen
2009-05-12  1:02 ` [PATCH 1/3] x86: remove MEMORY_HOTPLUG_RESERVE related code Christoph Lameter
2009-05-12 11:16 ` Mel Gorman
2009-05-13  5:29   ` Yinghai Lu
2009-05-13  9:55     ` Mel Gorman
2009-05-13  6:13   ` [PATCH] x86: remove MEMORY_HOTPLUG_RESERVE related code -v2 Yinghai Lu
2009-05-13 14:59     ` Mel Gorman
2009-05-14 16:38       ` [PATCH 1/5] " Yinghai Lu
2009-05-14 16:40         ` [PATCH 2/5] x86: add numa_move_cpus_to_node Yinghai Lu
2009-05-14 16:41         ` [PATCH 3/5] x86: fix node_possible_map logic -v2 Yinghai Lu
2009-05-18  7:40           ` [tip:x86/mm] x86, mm: Fix node_possible_map logic tip-bot for Yinghai Lu
2009-05-14 16:42         ` [PATCH 4/5] x86: fix system without memory on node0 -v2 Yinghai Lu
2009-05-18  7:40           ` [tip:x86/mm] x86: fix system without memory on node0 tip-bot for Yinghai Lu
2009-05-14 16:43         ` [PATCH 5/5] mm: clear N_HIGH_MEMORY map before se set it again -v2 Yinghai Lu
2009-05-14 16:54           ` Andrew Morton
2009-05-14 17:05             ` Yinghai Lu
2009-05-14 17:25               ` Andrew Morton
2009-05-14 17:34                 ` Yinghai Lu
2009-05-14 19:44                   ` Christoph Lameter
2009-06-04  5:16                   ` [RESEND PATCH] " Yinghai Lu
2009-06-04 16:38                     ` Christoph Lameter
2009-06-04 16:48                       ` Yinghai Lu
2009-06-04 17:11                         ` Christoph Lameter
2009-06-04 17:26                           ` [PATCH] mm: clear N_HIGH_MEMORY map before se set it again -v4 Yinghai Lu
2009-06-19  6:42                             ` Nathan Lynch
2009-06-19  8:18                               ` Yinghai Lu
2009-06-19  8:43                                 ` Nathan Lynch
2009-06-19 16:16                                   ` Yinghai Lu
2009-06-20 23:43                                   ` Yinghai Lu
2009-06-22  4:39                                     ` Nathan Lynch
2009-06-22 15:38                                       ` [PATCH] x86: only clear node_states for 64bit Yinghai Lu
2009-06-26 20:54                                         ` Andrew Morton
2009-06-26 21:09                                           ` Yinghai Lu
2009-06-27 17:17                                             ` Ingo Molnar
2009-06-27 20:40                                               ` Yinghai Lu
2009-06-29  7:39                                                 ` Yinghai Lu
2009-05-18  7:39         ` [tip:x86/mm] mm, x86: remove MEMORY_HOTPLUG_RESERVE related code tip-bot for Yinghai Lu
     [not found] ` <20090511095022.GA23121@elte.hu>
     [not found]   ` <20090511163158.c4e4d334.akpm@linux-foundation.org>
     [not found]     ` <20090512090704.GC18004@elte.hu>
     [not found]       ` <4A0A6700.3070100@kernel.org>
     [not found]         ` <20090513133635.GB7384@elte.hu>
     [not found]           ` <4A0AFA6E.5050200@kernel.org>
     [not found]             ` <20090515173521.GA29647@elte.hu>
2009-05-15 21:38               ` tip: patches in git for irq and numa Yinghai Lu
2009-05-18  7:29                 ` Ingo Molnar
2009-05-18 13:50                   ` Peter Zijlstra
2009-05-18 13:56                     ` Ingo Molnar
2009-05-18 15:03                     ` Yinghai Lu [this message]
2009-05-18 15:09                       ` Ingo Molnar
2009-05-18 15:11                       ` Peter Zijlstra
2009-05-18 17:23                         ` Yinghai Lu
2009-05-19  9:37                           ` Ingo Molnar
2009-05-19 10:31                             ` Peter Zijlstra
2009-05-19 12:26                               ` Ingo Molnar
2009-05-19  9:39                           ` [tip:irq/numa] x86, io-apic: Don't mark pin_programmed early tip-bot for Yinghai Lu
2009-05-19 12:30                           ` tip-bot for Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A1178D5.5050900@kernel.org \
    --to=yinghai@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=steiner@sgi.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome