* [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices
@ 2017-07-30 10:58 Axel Lin
2017-07-31 4:15 ` Keerthy
2017-08-08 10:03 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2017-07-30 10:58 UTC (permalink / raw)
To: Lee Jones; +Cc: Keerthy, linux-kernel, Axel Lin
This fixes missing mfd_remove_devices() call when unload the module.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/mfd/lp87565.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c
index 340ad0c..32d2a07 100644
--- a/drivers/mfd/lp87565.c
+++ b/drivers/mfd/lp87565.c
@@ -73,10 +73,9 @@ static int lp87565_probe(struct i2c_client *client,
i2c_set_clientdata(client, lp87565);
- ret = mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, lp87565_cells,
- ARRAY_SIZE(lp87565_cells), NULL, 0, NULL);
-
- return ret;
+ return devm_mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO,
+ lp87565_cells, ARRAY_SIZE(lp87565_cells),
+ NULL, 0, NULL);
}
static const struct i2c_device_id lp87565_id_table[] = {
--
2.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices
2017-07-30 10:58 [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices Axel Lin
@ 2017-07-31 4:15 ` Keerthy
2017-08-08 10:03 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Keerthy @ 2017-07-31 4:15 UTC (permalink / raw)
To: Axel Lin, Lee Jones; +Cc: linux-kernel
On Sunday 30 July 2017 04:28 PM, Axel Lin wrote:
> This fixes missing mfd_remove_devices() call when unload the module.
Reviewed-by: Keerthy <j-keerthy@ti.com>
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/lp87565.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c
> index 340ad0c..32d2a07 100644
> --- a/drivers/mfd/lp87565.c
> +++ b/drivers/mfd/lp87565.c
> @@ -73,10 +73,9 @@ static int lp87565_probe(struct i2c_client *client,
>
> i2c_set_clientdata(client, lp87565);
>
> - ret = mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, lp87565_cells,
> - ARRAY_SIZE(lp87565_cells), NULL, 0, NULL);
> -
> - return ret;
> + return devm_mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO,
> + lp87565_cells, ARRAY_SIZE(lp87565_cells),
> + NULL, 0, NULL);
> }
>
> static const struct i2c_device_id lp87565_id_table[] = {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices
2017-07-30 10:58 [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices Axel Lin
2017-07-31 4:15 ` Keerthy
@ 2017-08-08 10:03 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2017-08-08 10:03 UTC (permalink / raw)
To: Axel Lin; +Cc: Keerthy, linux-kernel
On Sun, 30 Jul 2017, Axel Lin wrote:
> This fixes missing mfd_remove_devices() call when unload the module.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/lp87565.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c
> index 340ad0c..32d2a07 100644
> --- a/drivers/mfd/lp87565.c
> +++ b/drivers/mfd/lp87565.c
> @@ -73,10 +73,9 @@ static int lp87565_probe(struct i2c_client *client,
>
> i2c_set_clientdata(client, lp87565);
>
> - ret = mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, lp87565_cells,
> - ARRAY_SIZE(lp87565_cells), NULL, 0, NULL);
> -
> - return ret;
> + return devm_mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO,
> + lp87565_cells, ARRAY_SIZE(lp87565_cells),
> + NULL, 0, NULL);
> }
>
> static const struct i2c_device_id lp87565_id_table[] = {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-08 10:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-30 10:58 [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices Axel Lin
2017-07-31 4:15 ` Keerthy
2017-08-08 10:03 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®