Re: [PATCH v12 01/24] KVM: x86: Rename kvm_{g,s}et_msr()* to show that they emulate guest accesses

[Xiaoyao Li <xiaoyao.li@intel.com>]

On 8/12/2025 10:55 AM, Chao Gao wrote:

...

> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index f19a76d3ca0e..86e4d0b8469b 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -2149,11 +2149,11 @@ void kvm_prepare_event_vectoring_exit(struct kvm_vcpu *vcpu, gpa_t gpa);
>   
>   void kvm_enable_efer_bits(u64);
>   bool kvm_valid_efer(struct kvm_vcpu *vcpu, u64 efer);
> -int kvm_get_msr_with_filter(struct kvm_vcpu *vcpu, u32 index, u64 *data);
> -int kvm_set_msr_with_filter(struct kvm_vcpu *vcpu, u32 index, u64 data);
> +int kvm_emulate_msr_read(struct kvm_vcpu *vcpu, u32 index, u64 *data);
> +int kvm_emulate_msr_write(struct kvm_vcpu *vcpu, u32 index, u64 data);
...
> -int kvm_get_msr(struct kvm_vcpu *vcpu, u32 index, u64 *data);
> -int kvm_set_msr(struct kvm_vcpu *vcpu, u32 index, u64 data);
> +int __kvm_emulate_msr_read(struct kvm_vcpu *vcpu, u32 index, u64 *data);
> +int __kvm_emulate_msr_write(struct kvm_vcpu *vcpu, u32 index, u64 data);

I dislike the rename, it loses the information of filter.

can we keep the filer information and make them as below?

   kvm_get_msr_with_filter() -> kvm_emulate_msr_read_with_filter()
   kvm_get_msr() -> kvm_emulate_msr_read()
   kvm_set_msr_with_filter() -> kvm_emulate_msr_write_with_filter()
   kvm_set_msr() -> kvm_emulate_msr_write()