From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Jagadeesh Kona <quic_jkona@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Ajit Pandey <quic_ajipan@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Taniya Das <quic_tdas@quicinc.com>,
Satya Priya Kakitapalli <quic_skakitap@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/8] clk: qcom: videocc-sm8450: Move PLL & clk configuration to really probe
Date: Tue, 11 Mar 2025 09:54:49 +0000 [thread overview]
Message-ID: <7a5518ad-b470-4c5b-99f0-9b4952d332ba@linaro.org> (raw)
In-Reply-To: <20250306-videocc-pll-multi-pd-voting-v2-4-0cd00612bc0e@quicinc.com>
On 06/03/2025 08:55, Jagadeesh Kona wrote:
> +
> +static struct qcom_clk_cfg video_cc_sm8450_clocks_cfg[] = {
> + { .offset = 0x80e4, .mask = BIT(0) }, /* VIDEO_CC_AHB_CLK */
> + { .offset = 0x8114, .mask = BIT(0) }, /* VIDEO_CC_XO_CLK */
> + { .offset = 0x8130, .mask = BIT(0) }, /* VIDEO_CC_SLEEP_CLK */
> +};
>
> - /* Keep some clocks always-on */
> - qcom_branch_set_clk_en(regmap, 0x80e4); /* VIDEO_CC_AHB_CLK */
> - qcom_branch_set_clk_en(regmap, 0x8130); /* VIDEO_CC_SLEEP_CLK */
> - qcom_branch_set_clk_en(regmap, 0x8114); /* VIDEO_CC_XO_CLK */
Dmitry already said this but, this change feels like a loss of fidelity.
Please find a way to use the existing helper functions.
---
bod
next prev parent reply other threads:[~2025-03-11 9:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CMTYKKilQJYeHUYYKvlqnwv4Q2P-58Ic1v1ndS9HQ8Yhq2xpHuNThibFDjXDEQ1PyNbx__f9BVBr0peoTUdvPg==@protonmail.internalid>
2025-03-06 8:55 ` [PATCH v2 0/8] clk: qcom: Add support to attach multiple power domains in cc probe Jagadeesh Kona
2025-03-06 8:55 ` [PATCH v2 1/8] dt-bindings: clock: qcom,sm8450-videocc: Add MXC power domain Jagadeesh Kona
2025-03-06 10:10 ` Dmitry Baryshkov
2025-03-11 8:47 ` Jagadeesh Kona
2025-03-11 9:49 ` Bryan O'Donoghue
2025-03-11 10:21 ` Konrad Dybcio
2025-03-12 7:14 ` Jagadeesh Kona
2025-03-06 8:55 ` [PATCH v2 2/8] clk: qcom: common: Add support to configure PLL Jagadeesh Kona
2025-03-06 12:22 ` Konrad Dybcio
2025-03-11 8:56 ` Jagadeesh Kona
2025-03-13 22:39 ` Bjorn Andersson
2025-03-20 16:29 ` Jagadeesh Kona
2025-03-06 8:55 ` [PATCH v2 3/8] clk: qcom: common: Manage rpm, configure PLLs & AON clks in really probe Jagadeesh Kona
2025-03-06 12:45 ` Konrad Dybcio
2025-03-11 8:48 ` Jagadeesh Kona
2025-03-07 8:47 ` Dmitry Baryshkov
2025-03-11 8:48 ` Jagadeesh Kona
2025-03-06 8:55 ` [PATCH v2 4/8] clk: qcom: videocc-sm8450: Move PLL & clk configuration to " Jagadeesh Kona
2025-03-11 9:54 ` Bryan O'Donoghue [this message]
2025-03-06 8:55 ` [PATCH v2 5/8] clk: qcom: videocc-sm8550: " Jagadeesh Kona
2025-03-06 8:55 ` [PATCH v2 6/8] arm64: dts: qcom: Add MXC power domain to videocc node on SM8450 Jagadeesh Kona
2025-03-06 8:55 ` [PATCH v2 7/8] arm64: dts: qcom: Add MXC power domain to videocc node on SM8550 Jagadeesh Kona
2025-03-06 8:55 ` [PATCH v2 8/8] arm64: dts: qcom: Add MXC power domain to videocc node on SM8650 Jagadeesh Kona
2025-03-11 9:52 ` [PATCH v2 0/8] clk: qcom: Add support to attach multiple power domains in cc probe Bryan O'Donoghue
2025-03-11 10:12 ` Vladimir Zapolskiy
2025-03-11 12:10 ` Bryan O'Donoghue
2025-03-11 17:55 ` Vladimir Zapolskiy
2025-03-11 18:11 ` Bryan O'Donoghue
2025-03-12 7:11 ` Jagadeesh Kona
2025-03-12 7:13 ` Jagadeesh Kona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a5518ad-b470-4c5b-99f0-9b4952d332ba@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_skakitap@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®