Re: [PATCH v4 3/6] x86/resctrl: Rename prev_msr to prev_mon_val

["Chen, Yu C" <yu.c.chen@intel.com>]

Hi Reinette,

On 6/24/2026 12:47 AM, Reinette Chatre wrote:
> Hi Chenyu,
> 
> On 6/23/26 12:48 AM, Chen, Yu C wrote:
>> On 6/23/2026 5:29 AM, Reinette Chatre wrote:
>> Would the following be appropriate?
>>
>> x86/resctrl: Replace "msr" in monitoring data identifiers
>>
>> Monitoring counter values are currently obtained via MSR and many
>> identifiers involved in processing these values contain "msr"
>> as part of their names, for example "prev_msr" and "msr_val".
>>
>> The ERDT ACPI table describes MMIO registers for monitoring access.
>> A subsequent patch adds MMIO-based L3 occupancy reads. Rename "msr"
> 
> Please drop the "A subsequent patch ...". Apart from it resembling the
> dreaded "this patch", once it is merged the intended meaning is lost. As an
> alternative the second paragraph can be:
> 	The ERDT ACPI table describes MMIO registers for monitoring data
> 	access. Rename "msr"-based identifiers to be interface-agnostic
> 	to support their upcoming use for MMIO-read values.
> 
> 	No functional change.
> 
>> based identifiers to interface-agnostic names so they remain accurate
>> as monitoring values may no longer originate exclusively from MSR.
>>
>> No functional change.

OK, will do.

thanks,
Chenyu