From: "Huang, Kai" <kai.huang@intel.com>
To: "dyoung@redhat.com" <dyoung@redhat.com>, "bp@alien8.de" <bp@alien8.de>
Cc: "Gao, Chao" <chao.gao@intel.com>,
"luto@kernel.org" <luto@kernel.org>,
"Hansen, Dave" <dave.hansen@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"bhe@redhat.com" <bhe@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"nik.borisov@suse.com" <nik.borisov@suse.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [PATCH 1/4] x86/coco: Add a new CC attribute to unify cache flush during kexec
Date: Wed, 28 Feb 2024 09:21:00 +0000 [thread overview]
Message-ID: <8c3e3e8c32b50cf488413d965ac6730ce8814214.camel@intel.com> (raw)
In-Reply-To: <CALu+AoSZkq1kz-xjvHkkuJ3C71d0SM5ibEJurdgmkZqZvNp2dQ@mail.gmail.com>
On Wed, 2024-02-28 at 10:54 +0800, Dave Young wrote:
> On Fri, 23 Feb 2024 at 18:41, Dave Young <dyoung@redhat.com> wrote:
> >
> > On Wed, 21 Feb 2024 at 17:33, Borislav Petkov <bp@alien8.de> wrote:
> > >
> > > On Tue, Feb 20, 2024 at 04:30:13PM -0600, Tom Lendacky wrote:
> > > > I believe the issues were that different Intel systems would hang or reset
> > > > and it was bisected to that commit that added the WBINVD. It was a while
> > > > ago, but I remember that they were similar to what the 1f5e7eb7868e commit
> > > > ended up fixing, which was debugged because sometimes the WBINVD was still
> > > > occasionally issued resulting in the following patch
> > > >
> > > > 9b040453d444 ("x86/smp: Dont access non-existing CPUID leaf")
> > > >
> > > > It just means that if we go to an unconditional WBINVD, then we need to be
> > > > careful.
> > >
> > > Let's try it.
> > >
> > > Dave, do you remember what issues
> > >
> > > f23d74f6c66c ("x86/mm: Rework wbinvd, hlt operation in stop_this_cpu()")
> > >
> > > fixed?
> >
> > It should be a kexec reboot failure describe in below thread:
> > https://lore.kernel.org/lkml/20180117072123.GA1866@dhcp-128-65.nay.redhat.com/
> >
> > >
> > > If so, can you try the below diff ontop of latest tip/master to see if
> > > those issues would reappear?
> >
> > It was reproduced on an old laptop (Thinkpad t440s or t480s, I can not
> > remember), but I have replaced them with a new different one. I tried
> > the latest tip-master with the if condition commented out, kexec
> > reboot works fine.
> >
> > Let me try to find an old laptop to see if I can do more tests, will
> > get back later next week.
>
> Update: tested on an old laptop as well, I did not find any problems
> with unconditional native_wbinvd(), kexec and kdump works fine.
>
>
Hi DaveY,
Thanks for getting back and I appreciate your help.
Hi Boris/DaveH,
Based on this I'll change to do unconditional WBINVD during kexec() for in
stop_this_cpu() and relocate_kernel(). Please let me know if you have any
comments.
Thanks all!
next prev parent reply other threads:[~2024-02-28 9:21 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 11:31 [PATCH 0/4] TDX host: kexec() support Huang, Kai
2024-01-31 11:31 ` [PATCH 1/4] x86/coco: Add a new CC attribute to unify cache flush during kexec Huang, Kai
2024-02-19 16:16 ` Borislav Petkov
2024-02-19 19:45 ` Tom Lendacky
2024-02-19 20:32 ` Borislav Petkov
2024-02-19 22:09 ` Tom Lendacky
2024-02-20 2:57 ` Huang, Kai
2024-02-20 14:40 ` Tom Lendacky
2024-02-20 14:28 ` Borislav Petkov
2024-02-20 14:47 ` Tom Lendacky
2024-02-20 20:07 ` Huang, Kai
2024-02-20 22:30 ` Tom Lendacky
2024-02-21 1:38 ` Huang, Kai
2024-02-21 9:28 ` Borislav Petkov
2024-02-22 11:49 ` Huang, Kai
2024-02-23 3:13 ` Dave Young
2024-02-23 10:41 ` Dave Young
2024-02-28 2:54 ` Dave Young
2024-02-28 9:21 ` Huang, Kai [this message]
2024-02-28 11:02 ` Borislav Petkov
2024-02-28 22:21 ` Huang, Kai
2024-02-28 10:44 ` Borislav Petkov
2024-02-20 3:12 ` Huang, Kai
2024-01-31 11:31 ` [PATCH 2/4] x86/virt/tdx: Advertise the CC_ATTR_HOST_MEM_INCOHERENT for TDX host Huang, Kai
2024-01-31 17:11 ` Dave Hansen
2024-02-01 14:42 ` Huang, Kai
2024-01-31 11:31 ` [PATCH 3/4] x86/kexec(): Reset TDX private memory on platforms with TDX erratum Huang, Kai
2024-01-31 21:21 ` Dave Hansen
2024-01-31 22:03 ` Kirill A. Shutemov
2024-02-01 14:22 ` Huang, Kai
2024-02-01 14:39 ` Kirill A. Shutemov
2024-02-01 14:47 ` Huang, Kai
2024-02-01 16:57 ` Dave Hansen
2024-02-05 6:49 ` Huang, Kai
2024-02-01 14:35 ` Huang, Kai
2024-02-02 0:54 ` Edgecombe, Rick P
2024-02-05 6:44 ` Huang, Kai
2024-01-31 11:31 ` [PATCH 4/4] x86/virt/tdx: Remove the !KEXEC_CORE dependency Huang, Kai
2024-02-01 18:28 ` [PATCH 0/4] TDX host: kexec() support Tom Lendacky
2024-02-05 6:50 ` Huang, Kai
2024-02-06 18:56 ` Kalra, Ashish
2024-02-07 1:43 ` Huang, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c3e3e8c32b50cf488413d965ac6730ce8814214.camel@intel.com \
--to=kai.huang@intel.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=chao.gao@intel.com \
--cc=dave.hansen@intel.com \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®