From: Jaakko Koivisto <jmatko@utu.fi>
To: Joshua Crofts <joshua.crofts1@gmail.com>,
Jaakko Koivisto <jmatko@utu.fi>
Cc: "Andreas Klinger" <ak@it-klinger.de>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] iio: chemical: sgp40: Replace manual locking with guard()
Date: Mon, 16 Nov 2026 10:49:51 +0200 [thread overview]
Message-ID: <DMWI8DZPNBKM.2GHPISPEOA7G5@utu.fi> (raw)
In-Reply-To: <20261102111020.00000194@gmail.com>
On Mon Nov 2, 2026 at 12:10 PM EET, Joshua Crofts wrote:
> On Mon, 2 Nov 2026 11:12:55 +0200
> Jaakko Koivisto <jmatko@utu.fi> wrote:
>
>> Replace manual mutex_lock() and mutex_unlock() with RAII-style
>> guard(mutex)().
>>
>> Extend the lock in sgp40_measure_resistance_raw() to cover the
>> I2C send and receive cycle, preventing I/O-errors if the device
>> is currently running a command, or clobbering the output of a previous
>> command if a new command is issued during the sleep-period between
>> i2c_master_send() and i2c_master_recv().
>>
>> Signed-off-by: Jaakko Koivisto <jmatko@utu.fi>
>> ---
>> drivers/iio/chemical/sgp40.c | 33 +++++++++++++--------------------
>> 1 file changed, 13 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/iio/chemical/sgp40.c b/drivers/iio/chemical/sgp40.c
>> index 3a239fb6847f..080d51f9f53c 100644
>> --- a/drivers/iio/chemical/sgp40.c
>> +++ b/drivers/iio/chemical/sgp40.c
>> @@ -148,9 +148,8 @@ static int sgp40_calc_voc(struct sgp40_data *data, u16 resistance_raw, int *voc)
>> u32 exp = 0;
>
> + #include <linux/cleanup.h>
>
>> /* we calculate as a multiple of 16384 (2^14) */
>> - mutex_lock(&data->lock);
>> + guard(mutex)(&data->lock);
>
> Blank lines around any guard() statement. You want to emphasize the fact
> that guard is being utilized.
>
Should this be applied also for guard() inside switch-case -blocks?
The extra blank lines makes them look strange.
>> x = ((int)resistance_raw - data->res_calibbias) * 106;
>> - mutex_unlock(&data->lock);
>
> If only a segment of the code has to hold a lock it's better to use
> scoped_guard() instead of regular guard().
>
Will fix for v3.
>>
>> /* voc = 500 / (1 + e^x) */
>> exp = sgp40_exp(x, SGP40_CALC_POWER, 18);
>> @@ -172,7 +171,7 @@ static int sgp40_measure_resistance_raw(struct sgp40_data *data, u16 *resistance
>> struct sgp40_tg_measure tg = {.command = {0x26, 0x0F}};
>> struct sgp40_tg_result tgres;
>>
next prev parent reply other threads:[~2026-11-16 8:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 9:12 [PATCH v2 0/5] iio: chemical: sgp40: add funtions for serial number readback, self-test, and heater control Jaakko Koivisto
2026-11-02 9:12 ` [PATCH v2 1/5] iio: chemical: sgp40: Do not convert I2C errors to EIO Jaakko Koivisto
2026-11-02 9:54 ` Joshua Crofts
2026-11-02 9:12 ` [PATCH v2 2/5] iio: chemical: sgp40: Replace manual locking with guard() Jaakko Koivisto
2026-11-02 10:10 ` Joshua Crofts
2026-11-16 8:49 ` Jaakko Koivisto [this message]
2026-11-16 9:07 ` Andy Shevchenko
2026-11-03 10:01 ` Andy Shevchenko
2026-11-02 9:12 ` [PATCH v2 3/5] iio: chemical: sgp40: Implement get_serial_number-command Jaakko Koivisto
2026-11-02 10:20 ` Joshua Crofts
2026-11-16 8:39 ` Jaakko Koivisto
2026-11-02 9:12 ` [PATCH v2 4/5] iio: chemical: sgp40: Implement execute_self_test-command Jaakko Koivisto
2026-11-02 10:21 ` Joshua Crofts
2026-11-08 1:02 ` Jonathan Cameron
2026-11-02 9:56 ` [PATCH v2 5/5] iio: chemical: sgp40: Implement turn_heater_off-command Jaakko Koivisto
2026-11-02 10:24 ` Joshua Crofts
2026-11-08 1:05 ` Jonathan Cameron
2026-11-16 9:23 ` Jaakko Koivisto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMWI8DZPNBKM.2GHPISPEOA7G5@utu.fi \
--to=jmatko@utu.fi \
--cc=ak@it-klinger.de \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®