mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jaakko Koivisto <jmatko@utu.fi>
Cc: "Joshua Crofts" <joshua.crofts1@gmail.com>,
	"Andreas Klinger" <ak@it-klinger.de>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] iio: chemical: sgp40: Replace manual locking with guard()
Date: Mon, 16 Nov 2026 11:07:35 +0200	[thread overview]
Message-ID: <avrH16ORPweOpbgP@ashevche-desk.local> (raw)
In-Reply-To: <DMWI8DZPNBKM.2GHPISPEOA7G5@utu.fi>

On Mon, Nov 16, 2026 at 10:49:51AM +0200, Jaakko Koivisto wrote:
> On Mon Nov 2, 2026 at 12:10 PM EET, Joshua Crofts wrote:
> > On Mon, 2 Nov 2026 11:12:55 +0200
> > Jaakko Koivisto <jmatko@utu.fi> wrote:

...

> >>  	/* we calculate as a multiple of 16384 (2^14) */

And this comment should be placed not for guard()() obviously.

> >> -	mutex_lock(&data->lock);
> >> +	guard(mutex)(&data->lock);
> >
> > Blank lines around any guard() statement. You want to emphasize the fact
> > that guard is being utilized.
> 
> Should this be applied also for guard() inside switch-case -blocks?
> The extra blank lines makes them look strange.

In scoped cases the blank line is needed only after the guard()() assuming it's
the first operator after the scope is opened.

> >>  	x = ((int)resistance_raw - data->res_calibbias) * 106;
> >> -	mutex_unlock(&data->lock);

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-11-16  9:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02  9:12 [PATCH v2 0/5] iio: chemical: sgp40: add funtions for serial number readback, self-test, and heater control Jaakko Koivisto
2026-11-02  9:12 ` [PATCH v2 1/5] iio: chemical: sgp40: Do not convert I2C errors to EIO Jaakko Koivisto
2026-11-02  9:54   ` Joshua Crofts
2026-11-02  9:12 ` [PATCH v2 2/5] iio: chemical: sgp40: Replace manual locking with guard() Jaakko Koivisto
2026-11-02 10:10   ` Joshua Crofts
2026-11-16  8:49     ` Jaakko Koivisto
2026-11-16  9:07       ` Andy Shevchenko [this message]
2026-11-03 10:01   ` Andy Shevchenko
2026-11-02  9:12 ` [PATCH v2 3/5] iio: chemical: sgp40: Implement get_serial_number-command Jaakko Koivisto
2026-11-02 10:20   ` Joshua Crofts
2026-11-16  8:39     ` Jaakko Koivisto
2026-11-02  9:12 ` [PATCH v2 4/5] iio: chemical: sgp40: Implement execute_self_test-command Jaakko Koivisto
2026-11-02 10:21   ` Joshua Crofts
2026-11-08  1:02   ` Jonathan Cameron
2026-11-02  9:56 ` [PATCH v2 5/5] iio: chemical: sgp40: Implement turn_heater_off-command Jaakko Koivisto
2026-11-02 10:24   ` Joshua Crofts
2026-11-08  1:05   ` Jonathan Cameron
2026-11-16  9:23     ` Jaakko Koivisto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avrH16ORPweOpbgP@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=ak@it-klinger.de \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=jmatko@utu.fi \
    --cc=joshua.crofts1@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®