RE: [PATCH v6 3/5] thermal: renesas: rzg3e: Add thermal driver for the Renesas RZ/G3E SoC

[John Madieu <john.madieu.xa@bp.renesas.com>]

Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: Tuesday, August 5, 2025 11:35 AM
> To: John Madieu <john.madieu.xa@bp.renesas.com>
> Subject: Re: [PATCH v6 3/5] thermal: renesas: rzg3e: Add thermal driver for
> the Renesas RZ/G3E SoC
> 
> Hi John,
> 
> On Tue, 5 Aug 2025 at 11:22, John Madieu <john.madieu.xa@bp.renesas.com>
> wrote:
> > > From: Geert Uytterhoeven <geert@linux-m68k.org> On Tue, 5 Aug 2025
> > > at 10:27, John Madieu <john.madieu.xa@bp.renesas.com>
> > > wrote:
> > > > > From: Geert Uytterhoeven <geert@linux-m68k.org> On Thu, 22 May
> > > > > 2025 at 20:23, John Madieu <john.madieu.xa@bp.renesas.com>
> > > > > wrote:
> > > > > > The RZ/G3E SoC integrates a Temperature Sensor Unit (TSU)
> > > > > > block designed to monitor the chip's junction temperature.
> > > > > > This sensor is connected to channel 1 of the APB port
> > > > > > clock/reset and provides
> > > > > temperature measurements.
> >
> > /* or */
> >
> > renesas,tsu-channel-map = <&sysc off1 off2>;
> >
> > I would go for the first option to make it easier for V2H (while
> > adding support for it later) so it can choose using either, or both,
> > regardless of the index.
> >
> > What do you think ?
> 
> As the property would be part of the TSU node, it would always refer to
> that specific channel/instance, so e.g.
> 
>     renesas,tsu-trim = <&sysc 0x320>;
> 
> for the first TSU instance, and
> 
>     renesas,tsu-trim = <&sysc 0x330>;
> 
> for the second instance.

Will go for this, with both naming and phandle/offset.

> 
> P.S. Please don't write "V2H" on its own, as both R-Car V2H and RZ/V2H
>      exist in the Renesas SoC portfolio ;-)

My bad. Will take care of this next times.

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds

Regards,
John