* [PATCH 01/13] iio: accel: Remove redundant dev_err()/dev_err_probe()
2026-07-17 9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
@ 2026-07-17 9:42 ` Pan Chuang
2026-07-17 23:21 ` Jonathan Cameron
2026-07-17 9:42 ` [PATCH 02/13] iio: addac: Remove redundant dev_err_probe() Pan Chuang
` (12 subsequent siblings)
13 siblings, 1 reply; 19+ messages in thread
From: Pan Chuang @ 2026-07-17 9:42 UTC (permalink / raw)
To: Puranjay Mohan, Nuno Sá,
Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, Marcelo Schmitt, Petre Rodan, Dan Robertson,
Matti Vaittinen, Uwe Kleine-König (The Capable Hub),
Takashi Sakamoto, Danilo Krummrich, Pan Chuang,
Sebastian Andrzej Siewior, Siratul Islam, Bjorn Helgaas,
Xichao Zhao, Waqar Hameed, Sakari Ailus, Dixit Parmar, Miao Li,
open list:ADXL355 THREE-AXIS DIGITAL ACCELEROMETER DRIVER,
open list:ANALOG DEVICES INC IIO DRIVERS, open list
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"),
devm_request_irq() and devm_request_threaded_irq() automatically log
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/iio/accel/adxl355_core.c | 3 +--
drivers/iio/accel/adxl367.c | 2 +-
drivers/iio/accel/bma180.c | 4 +---
drivers/iio/accel/bma220_core.c | 3 +--
drivers/iio/accel/bma400_core.c | 3 +--
drivers/iio/accel/kionix-kx022a.c | 2 +-
drivers/iio/accel/mma9551.c | 4 +---
drivers/iio/accel/mma9553.c | 5 +----
drivers/iio/accel/msa311.c | 2 +-
drivers/iio/accel/mxc4005.c | 5 +----
drivers/iio/accel/stk8312.c | 5 +----
drivers/iio/accel/stk8ba50.c | 5 +----
12 files changed, 12 insertions(+), 31 deletions(-)
diff --git a/drivers/iio/accel/adxl355_core.c b/drivers/iio/accel/adxl355_core.c
index 68cb2557f390..080c9f6f9a11 100644
--- a/drivers/iio/accel/adxl355_core.c
+++ b/drivers/iio/accel/adxl355_core.c
@@ -768,8 +768,7 @@ static int adxl355_probe_trigger(struct iio_dev *indio_dev, int irq)
ret = devm_request_irq(data->dev, irq, &iio_trigger_generic_data_rdy_poll,
IRQF_NO_THREAD, "adxl355_irq", data->dready_trig);
if (ret)
- return dev_err_probe(data->dev, ret, "request irq %d failed\n",
- irq);
+ return ret;
ret = devm_iio_trigger_register(data->dev, data->dready_trig);
if (ret)
diff --git a/drivers/iio/accel/adxl367.c b/drivers/iio/accel/adxl367.c
index 8c3de11a10a3..4ff1c7a0988b 100644
--- a/drivers/iio/accel/adxl367.c
+++ b/drivers/iio/accel/adxl367.c
@@ -1486,7 +1486,7 @@ int adxl367_probe(struct device *dev, const struct adxl367_ops *ops,
adxl367_irq_handler, IRQF_ONESHOT,
indio_dev->name, indio_dev);
if (ret)
- return dev_err_probe(st->dev, ret, "Failed to request irq\n");
+ return ret;
return devm_iio_device_register(dev, indio_dev);
}
diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
index 62bda8d76691..e7dbbd4766dd 100644
--- a/drivers/iio/accel/bma180.c
+++ b/drivers/iio/accel/bma180.c
@@ -988,10 +988,8 @@ static int bma180_probe(struct i2c_client *client)
iio_trigger_generic_data_rdy_poll,
IRQF_TRIGGER_RISING | IRQF_NO_THREAD,
"bma180_event", data->trig);
- if (ret) {
- dev_err(dev, "unable to request IRQ\n");
+ if (ret)
goto err_trigger_free;
- }
data->trig->ops = &bma180_trigger_ops;
iio_trigger_set_drvdata(data->trig, indio_dev);
diff --git a/drivers/iio/accel/bma220_core.c b/drivers/iio/accel/bma220_core.c
index 269e2b720ddb..b83abfdd84fd 100644
--- a/drivers/iio/accel/bma220_core.c
+++ b/drivers/iio/accel/bma220_core.c
@@ -544,8 +544,7 @@ int bma220_common_probe(struct device *dev, struct regmap *regmap, int irq)
&bma220_irq_handler, IRQF_ONESHOT,
indio_dev->name, indio_dev);
if (ret)
- return dev_err_probe(dev, ret,
- "request irq %d failed\n", irq);
+ return ret;
}
ret = devm_add_action_or_reset(dev, bma220_deinit, data);
diff --git a/drivers/iio/accel/bma400_core.c b/drivers/iio/accel/bma400_core.c
index 05f72707f830..7e3cff4cca91 100644
--- a/drivers/iio/accel/bma400_core.c
+++ b/drivers/iio/accel/bma400_core.c
@@ -1789,8 +1789,7 @@ int bma400_probe(struct device *dev, struct regmap *regmap, int irq,
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
indio_dev->name, indio_dev);
if (ret)
- return dev_err_probe(data->dev, ret,
- "request irq %d failed\n", irq);
+ return ret;
}
ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL,
diff --git a/drivers/iio/accel/kionix-kx022a.c b/drivers/iio/accel/kionix-kx022a.c
index 39485572a76b..02dd1db7a646 100644
--- a/drivers/iio/accel/kionix-kx022a.c
+++ b/drivers/iio/accel/kionix-kx022a.c
@@ -1435,7 +1435,7 @@ int kx022a_probe_internal(struct device *dev, const struct kx022a_chip_info *chi
&kx022a_irq_thread_handler,
IRQF_ONESHOT, name, idev);
if (ret)
- return dev_err_probe(data->dev, ret, "Could not request IRQ\n");
+ return ret;
ret = devm_iio_trigger_register(dev, indio_trig);
if (ret)
diff --git a/drivers/iio/accel/mma9551.c b/drivers/iio/accel/mma9551.c
index 7d9cbfa01360..21e87c7b6f5d 100644
--- a/drivers/iio/accel/mma9551.c
+++ b/drivers/iio/accel/mma9551.c
@@ -420,10 +420,8 @@ static int mma9551_gpio_probe(struct iio_dev *indio_dev)
NULL, mma9551_event_handler,
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
"mma9551_event", indio_dev);
- if (ret < 0) {
- dev_err(dev, "request irq %d failed\n", data->irqs[i]);
+ if (ret < 0)
return ret;
- }
dev_dbg(dev, "gpio resource, no:%d irq:%d\n",
desc_to_gpio(gpio), data->irqs[i]);
diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c
index ab43b1e0ff04..5d6c2dc83016 100644
--- a/drivers/iio/accel/mma9553.c
+++ b/drivers/iio/accel/mma9553.c
@@ -1099,11 +1099,8 @@ static int mma9553_probe(struct i2c_client *client)
mma9553_event_handler,
IRQF_TRIGGER_RISING,
"mma9553_event", indio_dev);
- if (ret < 0) {
- dev_err(&client->dev, "request irq %d failed\n",
- client->irq);
+ if (ret < 0)
goto out_poweroff;
- }
}
ret = pm_runtime_set_active(&client->dev);
diff --git a/drivers/iio/accel/msa311.c b/drivers/iio/accel/msa311.c
index e0e73b87cba8..caf9b1b6397f 100644
--- a/drivers/iio/accel/msa311.c
+++ b/drivers/iio/accel/msa311.c
@@ -1059,7 +1059,7 @@ static int msa311_setup_interrupts(struct msa311_priv *msa311)
msa311_irq_thread, IRQF_ONESHOT,
msa311->chip_name, indio_dev);
if (err)
- return dev_err_probe(dev, err, "failed to request IRQ\n");
+ return err;
trig = devm_iio_trigger_alloc(dev, "%s-new-data", msa311->chip_name);
if (!trig)
diff --git a/drivers/iio/accel/mxc4005.c b/drivers/iio/accel/mxc4005.c
index 2034fe92bae3..a66fee828ec1 100644
--- a/drivers/iio/accel/mxc4005.c
+++ b/drivers/iio/accel/mxc4005.c
@@ -489,11 +489,8 @@ static int mxc4005_probe(struct i2c_client *client)
iio_trigger_generic_data_rdy_poll,
IRQF_TRIGGER_FALLING | IRQF_NO_THREAD,
"mxc4005_event", data->dready_trig);
- if (ret) {
- dev_err(&client->dev,
- "failed to init threaded irq\n");
+ if (ret)
return ret;
- }
data->dready_trig->ops = &mxc4005_trigger_ops;
iio_trigger_set_drvdata(data->dready_trig, indio_dev);
diff --git a/drivers/iio/accel/stk8312.c b/drivers/iio/accel/stk8312.c
index ad4d11337f4b..77d8178ffa25 100644
--- a/drivers/iio/accel/stk8312.c
+++ b/drivers/iio/accel/stk8312.c
@@ -550,11 +550,8 @@ static int stk8312_probe(struct i2c_client *client)
IRQF_ONESHOT,
"stk8312_event",
indio_dev);
- if (ret < 0) {
- dev_err(&client->dev, "request irq %d failed\n",
- client->irq);
+ if (ret < 0)
goto err_power_off;
- }
data->dready_trig = devm_iio_trigger_alloc(&client->dev,
"%s-dev%d",
diff --git a/drivers/iio/accel/stk8ba50.c b/drivers/iio/accel/stk8ba50.c
index 54638cd75ea7..643fac8aaf70 100644
--- a/drivers/iio/accel/stk8ba50.c
+++ b/drivers/iio/accel/stk8ba50.c
@@ -438,11 +438,8 @@ static int stk8ba50_probe(struct i2c_client *client)
stk8ba50_data_rdy_trig_poll,
IRQF_TRIGGER_RISING | IRQF_NO_THREAD,
"stk8ba50_event", indio_dev);
- if (ret < 0) {
- dev_err(&client->dev, "request irq %d failed\n",
- client->irq);
+ if (ret < 0)
goto err_power_off;
- }
data->dready_trig = devm_iio_trigger_alloc(&client->dev,
"%s-dev%d",
--
2.34.1
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 01/13] iio: accel: Remove redundant dev_err()/dev_err_probe()
2026-07-17 9:42 ` [PATCH 01/13] iio: accel: Remove redundant dev_err()/dev_err_probe() Pan Chuang
@ 2026-07-17 23:21 ` Jonathan Cameron
0 siblings, 0 replies; 19+ messages in thread
From: Jonathan Cameron @ 2026-07-17 23:21 UTC (permalink / raw)
To: Pan Chuang
Cc: Puranjay Mohan, Nuno Sá,
Michael Hennerich, David Lechner, Andy Shevchenko,
Marcelo Schmitt, Petre Rodan, Dan Robertson, Matti Vaittinen,
Uwe Kleine-König (The Capable Hub),
Takashi Sakamoto, Danilo Krummrich, Sebastian Andrzej Siewior,
Siratul Islam, Bjorn Helgaas, Xichao Zhao, Waqar Hameed,
Sakari Ailus, Dixit Parmar, Miao Li,
open list:ADXL355 THREE-AXIS DIGITAL ACCELEROMETER DRIVER,
open list:ANALOG DEVICES INC IIO DRIVERS, open list
On Fri, 17 Jul 2026 17:42:24 +0800
Pan Chuang <panchuang@vivo.com> wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"),
Please rewrap in a fashion that keeps the commit description on one line.
One option would be:
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
Idea being to make it easy to grep for.
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 02/13] iio: addac: Remove redundant dev_err_probe()
2026-07-17 9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17 9:42 ` [PATCH 01/13] iio: accel: Remove redundant dev_err()/dev_err_probe() Pan Chuang
@ 2026-07-17 9:42 ` Pan Chuang
2026-07-17 9:42 ` [PATCH 03/13] iio: chemical: Remove redundant dev_err()/dev_err_probe() Pan Chuang
` (11 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: Pan Chuang @ 2026-07-17 9:42 UTC (permalink / raw)
To: Marcelo Schmitt, Nuno Sá,
Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, open list:ANALOG DEVICES INC AD74413R DRIVER,
open list:ANALOG DEVICES INC IIO DRIVERS, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/iio/addac/ad74413r.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c
index 43bd2079cf6d..2e5a58e48a89 100644
--- a/drivers/iio/addac/ad74413r.c
+++ b/drivers/iio/addac/ad74413r.c
@@ -1457,7 +1457,7 @@ static int ad74413r_probe(struct spi_device *spi)
ret = devm_request_irq(st->dev, spi->irq, ad74413r_adc_data_interrupt,
0, st->chip_info->name, indio_dev);
if (ret)
- return dev_err_probe(st->dev, ret, "Failed to request irq\n");
+ return ret;
ret = devm_iio_triggered_buffer_setup(st->dev, indio_dev,
&iio_pollfunc_store_time,
--
2.34.1
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 03/13] iio: chemical: Remove redundant dev_err()/dev_err_probe()
2026-07-17 9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17 9:42 ` [PATCH 01/13] iio: accel: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 9:42 ` [PATCH 02/13] iio: addac: Remove redundant dev_err_probe() Pan Chuang
@ 2026-07-17 9:42 ` Pan Chuang
2026-07-17 22:05 ` Maxwell Doose
2026-07-17 9:42 ` [PATCH 04/13] iio: common: Remove redundant dev_err() Pan Chuang
` (10 subsequent siblings)
13 siblings, 1 reply; 19+ messages in thread
From: Pan Chuang @ 2026-07-17 9:42 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Gustavo Silva, Maxwell Doose, Tomasz Duszynski,
Matti Vaittinen, Siratul Islam, Pan Chuang,
Uwe Kleine-König (The Capable Hub),
open list:IIO SUBSYSTEM AND DRIVERS, open list
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"),
devm_request_irq() and devm_request_threaded_irq() automatically log
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/iio/chemical/ccs811.c | 4 +---
drivers/iio/chemical/ens160_core.c | 2 +-
drivers/iio/chemical/scd30_core.c | 2 +-
3 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/iio/chemical/ccs811.c b/drivers/iio/chemical/ccs811.c
index ce7187ccd706..d126ee12ffe5 100644
--- a/drivers/iio/chemical/ccs811.c
+++ b/drivers/iio/chemical/ccs811.c
@@ -484,10 +484,8 @@ static int ccs811_probe(struct i2c_client *client)
IRQF_TRIGGER_FALLING |
IRQF_ONESHOT,
"ccs811_irq", indio_dev);
- if (ret) {
- dev_err(&client->dev, "irq request error %d\n", -ret);
+ if (ret)
goto err_poweroff;
- }
data->drdy_trig = devm_iio_trigger_alloc(&client->dev,
"%s-dev%d",
diff --git a/drivers/iio/chemical/ens160_core.c b/drivers/iio/chemical/ens160_core.c
index bbc96c4c6283..7c1ffda38b99 100644
--- a/drivers/iio/chemical/ens160_core.c
+++ b/drivers/iio/chemical/ens160_core.c
@@ -320,7 +320,7 @@ static int ens160_setup_trigger(struct iio_dev *indio_dev, int irq)
IRQF_NO_THREAD, indio_dev->name,
indio_dev->trig);
if (ret)
- return dev_err_probe(dev, ret, "failed to request irq\n");
+ return ret;
return 0;
}
diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30_core.c
index f85cdd8bd84f..770571c21521 100644
--- a/drivers/iio/chemical/scd30_core.c
+++ b/drivers/iio/chemical/scd30_core.c
@@ -686,7 +686,7 @@ static int scd30_setup_trigger(struct iio_dev *indio_dev)
IRQF_NO_AUTOEN,
indio_dev->name, indio_dev);
if (ret)
- return dev_err_probe(dev, ret, "failed to request irq\n");
+ return ret;
return 0;
}
--
2.34.1
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 03/13] iio: chemical: Remove redundant dev_err()/dev_err_probe()
2026-07-17 9:42 ` [PATCH 03/13] iio: chemical: Remove redundant dev_err()/dev_err_probe() Pan Chuang
@ 2026-07-17 22:05 ` Maxwell Doose
2026-07-17 23:24 ` Jonathan Cameron
0 siblings, 1 reply; 19+ messages in thread
From: Maxwell Doose @ 2026-07-17 22:05 UTC (permalink / raw)
To: Pan Chuang, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Gustavo Silva, Maxwell Doose, Tomasz Duszynski,
Matti Vaittinen, Siratul Islam,
Uwe Kleine-König (The Capable Hub),
linux-iio, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]
Hi Pan,
On Fri Jul 17, 2026 at 4:42 AM CDT
Pan Chuang <panchuang@vivo.com> wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"),
> devm_request_irq() and devm_request_threaded_irq() automatically log
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() and dev_err_probe() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
> drivers/iio/chemical/ccs811.c | 4 +---
> drivers/iio/chemical/ens160_core.c | 2 +-
> drivers/iio/chemical/scd30_core.c | 2 +-
> 3 files changed, 3 insertions(+), 5 deletions(-)
>
...
>
> diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30_core.c
> index f85cdd8bd84f..770571c21521 100644
> --- a/drivers/iio/chemical/scd30_core.c
> +++ b/drivers/iio/chemical/scd30_core.c
> @@ -686,7 +686,7 @@ static int scd30_setup_trigger(struct iio_dev *indio_dev)
> IRQF_NO_AUTOEN,
> indio_dev->name, indio_dev);
> if (ret)
> - return dev_err_probe(dev, ret, "failed to request irq\n");
> + return ret;
>
> return 0;
> }
Please split per driver and resubmit and feel free to add
Reviewed-by: Maxwell Doose <maxwell@maxwelld.cc>
once you do that.
--
best regards,
max
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 03/13] iio: chemical: Remove redundant dev_err()/dev_err_probe()
2026-07-17 22:05 ` Maxwell Doose
@ 2026-07-17 23:24 ` Jonathan Cameron
0 siblings, 0 replies; 19+ messages in thread
From: Jonathan Cameron @ 2026-07-17 23:24 UTC (permalink / raw)
To: Maxwell Doose
Cc: Pan Chuang, David Lechner, Nuno Sá,
Andy Shevchenko, Gustavo Silva, Maxwell Doose, Tomasz Duszynski,
Matti Vaittinen, Siratul Islam,
Uwe Kleine-König (The Capable Hub),
linux-iio, linux-kernel
On Fri, 17 Jul 2026 17:05:22 -0500
"Maxwell Doose" <maxwell@maxwelld.cc> wrote:
> Hi Pan,
>
> On Fri Jul 17, 2026 at 4:42 AM CDT
> Pan Chuang <panchuang@vivo.com> wrote:
>
> > Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> > devm_request_*_irq()"),
> > devm_request_irq() and devm_request_threaded_irq() automatically log
> > detailed error messages on failure. Remove the now-redundant
> > driver-specific dev_err() and dev_err_probe() calls.
> >
> > Signed-off-by: Pan Chuang <panchuang@vivo.com>
> > ---
> > drivers/iio/chemical/ccs811.c | 4 +---
> > drivers/iio/chemical/ens160_core.c | 2 +-
> > drivers/iio/chemical/scd30_core.c | 2 +-
> > 3 files changed, 3 insertions(+), 5 deletions(-)
> >
> ...
> >
> > diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30_core.c
> > index f85cdd8bd84f..770571c21521 100644
> > --- a/drivers/iio/chemical/scd30_core.c
> > +++ b/drivers/iio/chemical/scd30_core.c
> > @@ -686,7 +686,7 @@ static int scd30_setup_trigger(struct iio_dev *indio_dev)
> > IRQF_NO_AUTOEN,
> > indio_dev->name, indio_dev);
> > if (ret)
> > - return dev_err_probe(dev, ret, "failed to request irq\n");
> > + return ret;
> >
> > return 0;
> > }
>
> Please split per driver and resubmit and feel free to add
For large and simple repeat actions like this it's a trade off between
the noise of a lot of patches vs easy handling of any future conflicts in
backports. Given there are 60ish patches if this is broken up, it is a
bit marginal for which approach is preferable.
For more complex changes I would entirely agree that one patch per driver.
So I think I'm fine either way for this particular series. One patch
per directory, or one patch per driver.
Jonathan
>
> Reviewed-by: Maxwell Doose <maxwell@maxwelld.cc>
>
> once you do that.
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 04/13] iio: common: Remove redundant dev_err()
2026-07-17 9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
` (2 preceding siblings ...)
2026-07-17 9:42 ` [PATCH 03/13] iio: chemical: Remove redundant dev_err()/dev_err_probe() Pan Chuang
@ 2026-07-17 9:42 ` Pan Chuang
2026-07-17 23:26 ` Jonathan Cameron
2026-07-17 9:42 ` [PATCH 05/13] iio: gyro: Remove redundant dev_err_probe() Pan Chuang
` (9 subsequent siblings)
13 siblings, 1 reply; 19+ messages in thread
From: Pan Chuang @ 2026-07-17 9:42 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Pan Chuang, open list:IIO SUBSYSTEM AND DRIVERS,
open list
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/iio/common/st_sensors/st_sensors_trigger.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/common/st_sensors/st_sensors_trigger.c b/drivers/iio/common/st_sensors/st_sensors_trigger.c
index 8a8ab688d798..7b3e9732cc3e 100644
--- a/drivers/iio/common/st_sensors/st_sensors_trigger.c
+++ b/drivers/iio/common/st_sensors/st_sensors_trigger.c
@@ -211,10 +211,8 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev,
irq_trig,
sdata->trig->name,
sdata->trig);
- if (err) {
- dev_err(parent, "failed to request trigger IRQ.\n");
+ if (err)
return err;
- }
err = devm_iio_trigger_register(parent, sdata->trig);
if (err < 0) {
--
2.34.1
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 04/13] iio: common: Remove redundant dev_err()
2026-07-17 9:42 ` [PATCH 04/13] iio: common: Remove redundant dev_err() Pan Chuang
@ 2026-07-17 23:26 ` Jonathan Cameron
0 siblings, 0 replies; 19+ messages in thread
From: Jonathan Cameron @ 2026-07-17 23:26 UTC (permalink / raw)
To: Pan Chuang
Cc: David Lechner, Nuno Sá,
Andy Shevchenko, open list:IIO SUBSYSTEM AND DRIVERS, open list
On Fri, 17 Jul 2026 17:42:27 +0800
Pan Chuang <panchuang@vivo.com> wrote:
Hi,
Where there is only one driver affected, please name that driver
in the commit message. Let's anyone who cares about other drivers
in that directory know they can ignore it!
Thanks,
Jonathan
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
> drivers/iio/common/st_sensors/st_sensors_trigger.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/common/st_sensors/st_sensors_trigger.c b/drivers/iio/common/st_sensors/st_sensors_trigger.c
> index 8a8ab688d798..7b3e9732cc3e 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_trigger.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_trigger.c
> @@ -211,10 +211,8 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev,
> irq_trig,
> sdata->trig->name,
> sdata->trig);
> - if (err) {
> - dev_err(parent, "failed to request trigger IRQ.\n");
> + if (err)
> return err;
> - }
>
> err = devm_iio_trigger_register(parent, sdata->trig);
> if (err < 0) {
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 05/13] iio: gyro: Remove redundant dev_err_probe()
2026-07-17 9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
` (3 preceding siblings ...)
2026-07-17 9:42 ` [PATCH 04/13] iio: common: Remove redundant dev_err() Pan Chuang
@ 2026-07-17 9:42 ` Pan Chuang
2026-07-17 9:42 ` [PATCH 06/13] iio: health: Remove redundant dev_err() Pan Chuang
` (8 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: Pan Chuang @ 2026-07-17 9:42 UTC (permalink / raw)
To: Nishant Malpani, Nuno Sá,
Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, open list:ANALOG DEVICES INC ADXRS290 DRIVER,
open list:ANALOG DEVICES INC IIO DRIVERS, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/iio/gyro/adxrs290.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iio/gyro/adxrs290.c b/drivers/iio/gyro/adxrs290.c
index 35928383d4f2..61956e4fe8a9 100644
--- a/drivers/iio/gyro/adxrs290.c
+++ b/drivers/iio/gyro/adxrs290.c
@@ -586,8 +586,7 @@ static int adxrs290_probe_trigger(struct iio_dev *indio_dev)
&iio_trigger_generic_data_rdy_poll,
IRQF_NO_THREAD, "adxrs290_irq", st->dready_trig);
if (ret < 0)
- return dev_err_probe(&st->spi->dev, ret,
- "request irq %d failed\n", st->spi->irq);
+ return ret;
ret = devm_iio_trigger_register(&st->spi->dev, st->dready_trig);
if (ret) {
--
2.34.1
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 06/13] iio: health: Remove redundant dev_err()
2026-07-17 9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
` (4 preceding siblings ...)
2026-07-17 9:42 ` [PATCH 05/13] iio: gyro: Remove redundant dev_err_probe() Pan Chuang
@ 2026-07-17 9:42 ` Pan Chuang
2026-07-17 9:42 ` [PATCH 07/13] iio: humidity: Remove redundant dev_err()/dev_err_probe() Pan Chuang
` (7 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: Pan Chuang @ 2026-07-17 9:42 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Marcus Folkesson, Andrew Davis,
Uwe Kleine-König (The Capable Hub),
Sebastian Andrzej Siewior, Pan Chuang, Dixit Parmar, Kurt Borja,
Shrikant Raskar, open list:IIO SUBSYSTEM AND DRIVERS, open list
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() and devm_request_threaded_irq()
automatically log detailed error messages on failure. Remove the
now-redundant driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/iio/health/afe4403.c | 4 +---
drivers/iio/health/afe4404.c | 4 +---
drivers/iio/health/max30100.c | 4 +---
drivers/iio/health/max30102.c | 4 +---
4 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/iio/health/afe4403.c b/drivers/iio/health/afe4403.c
index 27e32707f089..2a648532242a 100644
--- a/drivers/iio/health/afe4403.c
+++ b/drivers/iio/health/afe4403.c
@@ -544,10 +544,8 @@ static int afe4403_probe(struct spi_device *spi)
iio_trigger_generic_data_rdy_poll,
IRQF_NO_THREAD, AFE4403_DRIVER_NAME,
afe->trig);
- if (ret) {
- dev_err(dev, "Unable to request IRQ\n");
+ if (ret)
return ret;
- }
}
ret = devm_iio_triggered_buffer_setup(dev, indio_dev,
diff --git a/drivers/iio/health/afe4404.c b/drivers/iio/health/afe4404.c
index 2357e2dd7017..22cd46eca217 100644
--- a/drivers/iio/health/afe4404.c
+++ b/drivers/iio/health/afe4404.c
@@ -551,10 +551,8 @@ static int afe4404_probe(struct i2c_client *client)
iio_trigger_generic_data_rdy_poll,
IRQF_NO_THREAD, AFE4404_DRIVER_NAME,
afe->trig);
- if (ret) {
- dev_err(dev, "Unable to request IRQ\n");
+ if (ret)
return ret;
- }
}
ret = devm_iio_triggered_buffer_setup(dev, indio_dev,
diff --git a/drivers/iio/health/max30100.c b/drivers/iio/health/max30100.c
index 97352485f5e2..191540e10c20 100644
--- a/drivers/iio/health/max30100.c
+++ b/drivers/iio/health/max30100.c
@@ -489,10 +489,8 @@ static int max30100_probe(struct i2c_client *client)
NULL, max30100_interrupt_handler,
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
"max30100_irq", indio_dev);
- if (ret) {
- dev_err(&client->dev, "request irq (%d) failed\n", client->irq);
+ if (ret)
return ret;
- }
return iio_device_register(indio_dev);
}
diff --git a/drivers/iio/health/max30102.c b/drivers/iio/health/max30102.c
index 0eeaa378b10d..c37316c86f14 100644
--- a/drivers/iio/health/max30102.c
+++ b/drivers/iio/health/max30102.c
@@ -577,10 +577,8 @@ static int max30102_probe(struct i2c_client *client)
NULL, max30102_interrupt_handler,
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
"max30102_irq", indio_dev);
- if (ret) {
- dev_err(&client->dev, "request irq (%d) failed\n", client->irq);
+ if (ret)
return ret;
- }
return iio_device_register(indio_dev);
}
--
2.34.1
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 07/13] iio: humidity: Remove redundant dev_err()/dev_err_probe()
2026-07-17 9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
` (5 preceding siblings ...)
2026-07-17 9:42 ` [PATCH 06/13] iio: health: Remove redundant dev_err() Pan Chuang
@ 2026-07-17 9:42 ` Pan Chuang
2026-07-17 9:42 ` [PATCH 08/13] iio: imu: " Pan Chuang
` (6 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: Pan Chuang @ 2026-07-17 9:42 UTC (permalink / raw)
To: Javier Carrasco, Li peiyu, Jonathan Cameron, David Lechner,
Nuno Sá,
Andy Shevchenko, Lorenzo Bianconi,
open list:TI HDC302X HUMIDITY DRIVER, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/iio/humidity/hdc3020.c | 3 +--
drivers/iio/humidity/hts221_buffer.c | 5 +----
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/humidity/hdc3020.c b/drivers/iio/humidity/hdc3020.c
index 1ae8702ada54..75971c19624a 100644
--- a/drivers/iio/humidity/hdc3020.c
+++ b/drivers/iio/humidity/hdc3020.c
@@ -843,8 +843,7 @@ static int hdc3020_probe(struct i2c_client *client)
IRQF_ONESHOT, "hdc3020",
indio_dev);
if (ret)
- return dev_err_probe(&client->dev, ret,
- "Failed to request IRQ\n");
+ return ret;
}
ret = devm_iio_device_register(&data->client->dev, indio_dev);
diff --git a/drivers/iio/humidity/hts221_buffer.c b/drivers/iio/humidity/hts221_buffer.c
index 4d03db19063e..df12c7a25b2e 100644
--- a/drivers/iio/humidity/hts221_buffer.c
+++ b/drivers/iio/humidity/hts221_buffer.c
@@ -122,11 +122,8 @@ int hts221_allocate_trigger(struct iio_dev *iio_dev)
hts221_trigger_handler_thread,
irq_type | IRQF_ONESHOT,
hw->name, hw);
- if (err) {
- dev_err(hw->dev, "failed to request trigger irq %d\n",
- hw->irq);
+ if (err)
return err;
- }
hw->trig = devm_iio_trigger_alloc(hw->dev, "%s-trigger",
iio_dev->name);
--
2.34.1
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 08/13] iio: imu: Remove redundant dev_err()/dev_err_probe()
2026-07-17 9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
` (6 preceding siblings ...)
2026-07-17 9:42 ` [PATCH 07/13] iio: humidity: Remove redundant dev_err()/dev_err_probe() Pan Chuang
@ 2026-07-17 9:42 ` Pan Chuang
2026-07-17 9:42 ` [PATCH 09/13] iio: magnetometer: Remove redundant dev_err() Pan Chuang
` (5 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: Pan Chuang @ 2026-07-17 9:42 UTC (permalink / raw)
To: Alex Lanzano, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Jagath Jog J, Lorenzo Bianconi,
open list:BOSCH SENSORTEC BMI270 IMU IIO DRIVER, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/iio/imu/bmi270/bmi270_core.c | 2 +-
drivers/iio/imu/bmi323/bmi323_core.c | 2 +-
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 5 +----
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/imu/bmi270/bmi270_core.c b/drivers/iio/imu/bmi270/bmi270_core.c
index 2ad230788532..fbcf6bb87acc 100644
--- a/drivers/iio/imu/bmi270/bmi270_core.c
+++ b/drivers/iio/imu/bmi270/bmi270_core.c
@@ -1434,7 +1434,7 @@ static int bmi270_trigger_probe(struct bmi270_data *data,
bmi270_irq_thread_handler,
IRQF_ONESHOT, "bmi270-int", indio_dev);
if (ret)
- return dev_err_probe(data->dev, ret, "Failed to request IRQ\n");
+ return ret;
ret = devm_iio_trigger_register(data->dev, data->trig);
if (ret)
diff --git a/drivers/iio/imu/bmi323/bmi323_core.c b/drivers/iio/imu/bmi323/bmi323_core.c
index 72955a697a93..ebeb1b10c38c 100644
--- a/drivers/iio/imu/bmi323/bmi323_core.c
+++ b/drivers/iio/imu/bmi323/bmi323_core.c
@@ -1946,7 +1946,7 @@ static int bmi323_trigger_probe(struct bmi323_data *data,
bmi323_irq_thread_handler,
IRQF_ONESHOT, "bmi323-int", indio_dev);
if (ret)
- return dev_err_probe(data->dev, ret, "Failed to request IRQ\n");
+ return ret;
ret = devm_iio_trigger_register(data->dev, data->trig);
if (ret)
diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
index f4edcb73ec8c..360f1365f892 100644
--- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
+++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
@@ -2852,11 +2852,8 @@ static int st_lsm6dsx_irq_setup(struct st_lsm6dsx_hw *hw)
st_lsm6dsx_handler_thread,
irq_type | IRQF_ONESHOT,
"lsm6dsx", hw);
- if (err) {
- dev_err(hw->dev, "failed to request trigger irq %d\n",
- hw->irq);
+ if (err)
return err;
- }
return 0;
}
--
2.34.1
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 09/13] iio: magnetometer: Remove redundant dev_err()
2026-07-17 9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
` (7 preceding siblings ...)
2026-07-17 9:42 ` [PATCH 08/13] iio: imu: " Pan Chuang
@ 2026-07-17 9:42 ` Pan Chuang
2026-07-17 9:42 ` [PATCH 10/13] iio: pressure: Remove redundant dev_err()/dev_err_probe() Pan Chuang
` (4 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: Pan Chuang @ 2026-07-17 9:42 UTC (permalink / raw)
To: Linus Walleij, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Song Qiang, open list:ASAHI KASEI AK8974 DRIVER,
open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/iio/magnetometer/ak8974.c | 5 +----
drivers/iio/magnetometer/rm3100-core.c | 4 +---
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/iio/magnetometer/ak8974.c b/drivers/iio/magnetometer/ak8974.c
index c7fdb7c2f543..28d6cadfd9f8 100644
--- a/drivers/iio/magnetometer/ak8974.c
+++ b/drivers/iio/magnetometer/ak8974.c
@@ -926,11 +926,8 @@ static int ak8974_probe(struct i2c_client *i2c)
irq_trig,
ak8974->name,
ak8974);
- if (ret) {
- dev_err(&i2c->dev, "unable to request DRDY IRQ "
- "- proceeding without IRQ\n");
+ if (ret)
goto no_irq;
- }
ak8974->drdy_irq = true;
}
diff --git a/drivers/iio/magnetometer/rm3100-core.c b/drivers/iio/magnetometer/rm3100-core.c
index ac3f9f7fc808..54efb694748e 100644
--- a/drivers/iio/magnetometer/rm3100-core.c
+++ b/drivers/iio/magnetometer/rm3100-core.c
@@ -568,10 +568,8 @@ int rm3100_common_probe(struct device *dev, struct regmap *regmap, int irq)
IRQF_ONESHOT,
indio_dev->name,
indio_dev);
- if (ret < 0) {
- dev_err(dev, "request irq line failed.\n");
+ if (ret < 0)
return ret;
- }
data->drdy_trig = devm_iio_trigger_alloc(dev, "%s-drdy%d",
indio_dev->name,
--
2.34.1
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 10/13] iio: pressure: Remove redundant dev_err()/dev_err_probe()
2026-07-17 9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
` (8 preceding siblings ...)
2026-07-17 9:42 ` [PATCH 09/13] iio: magnetometer: Remove redundant dev_err() Pan Chuang
@ 2026-07-17 9:42 ` Pan Chuang
2026-07-17 9:42 ` [PATCH 11/13] iio: proximity: " Pan Chuang
` (3 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: Pan Chuang @ 2026-07-17 9:42 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Matti Vaittinen, Salah Triki, Yury Norov,
Pan Chuang, Achim Gratz, Yash Suthar, Greg Kroah-Hartman,
Sakari Ailus, Sebastian Andrzej Siewior, Dixit Parmar,
Uwe Kleine-König (The Capable Hub),
Shi Hao, open list:IIO SUBSYSTEM AND DRIVERS, open list
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"),
devm_request_irq() and devm_request_threaded_irq() automatically log
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/iio/pressure/bmp280-core.c | 3 +--
drivers/iio/pressure/dlhl60d.c | 4 +---
drivers/iio/pressure/rohm-bm1390.c | 2 +-
drivers/iio/pressure/zpa2326.c | 5 +----
4 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
index c89153dcc323..6270309db5bb 100644
--- a/drivers/iio/pressure/bmp280-core.c
+++ b/drivers/iio/pressure/bmp280-core.c
@@ -1339,7 +1339,7 @@ static int __bmp280_trigger_probe(struct iio_dev *indio_dev,
irq_thread_handler, IRQF_ONESHOT,
indio_dev->name, indio_dev);
if (ret)
- return dev_err_probe(dev, ret, "request IRQ failed.\n");
+ return ret;
ret = devm_iio_trigger_register(data->dev, data->trig);
if (ret)
@@ -3070,7 +3070,6 @@ static int bmp085_trigger_probe(struct iio_dev *indio_dev)
indio_dev->name, data);
if (ret) {
/* Bail out without IRQ but keep the driver in place */
- dev_err(dev, "unable to request DRDY IRQ\n");
return 0;
}
diff --git a/drivers/iio/pressure/dlhl60d.c b/drivers/iio/pressure/dlhl60d.c
index 01a873165923..961888fd03a7 100644
--- a/drivers/iio/pressure/dlhl60d.c
+++ b/drivers/iio/pressure/dlhl60d.c
@@ -309,10 +309,8 @@ static int dlh_probe(struct i2c_client *client)
ret = devm_request_irq(&client->dev, client->irq, dlh_interrupt,
IRQF_TRIGGER_RISING | IRQF_NO_THREAD,
st->info->name, indio_dev);
- if (ret) {
- dev_err(&client->dev, "failed to allocate threaded irq");
+ if (ret)
return ret;
- }
st->use_interrupt = true;
init_completion(&st->completion);
diff --git a/drivers/iio/pressure/rohm-bm1390.c b/drivers/iio/pressure/rohm-bm1390.c
index 9d72ae64126c..57941fb4a535 100644
--- a/drivers/iio/pressure/rohm-bm1390.c
+++ b/drivers/iio/pressure/rohm-bm1390.c
@@ -805,7 +805,7 @@ static int bm1390_setup_trigger(struct bm1390_data *data, struct iio_dev *idev,
&bm1390_irq_thread_handler,
IRQF_ONESHOT, name, idev);
if (ret)
- return dev_err_probe(data->dev, ret, "Could not request IRQ\n");
+ return ret;
ret = devm_iio_trigger_register(data->dev, itrig);
diff --git a/drivers/iio/pressure/zpa2326.c b/drivers/iio/pressure/zpa2326.c
index 2c68fdf2744e..b38493ff3b8b 100644
--- a/drivers/iio/pressure/zpa2326.c
+++ b/drivers/iio/pressure/zpa2326.c
@@ -911,11 +911,8 @@ static int zpa2326_init_managed_irq(struct device *parent,
zpa2326_handle_threaded_irq,
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
dev_name(parent), indio_dev);
- if (err) {
- dev_err(parent, "failed to request interrupt %d (%d)", irq,
- err);
+ if (err)
return err;
- }
dev_info(parent, "using interrupt %d", irq);
--
2.34.1
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 11/13] iio: proximity: Remove redundant dev_err()/dev_err_probe()
2026-07-17 9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
` (9 preceding siblings ...)
2026-07-17 9:42 ` [PATCH 10/13] iio: pressure: Remove redundant dev_err()/dev_err_probe() Pan Chuang
@ 2026-07-17 9:42 ` Pan Chuang
2026-07-17 9:42 ` [PATCH 12/13] iio: light: " Pan Chuang
` (2 subsequent siblings)
13 siblings, 0 replies; 19+ messages in thread
From: Pan Chuang @ 2026-07-17 9:42 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Andreas Klinger, Song Qiang,
Uwe Kleine-König (The Capable Hub),
Danilo Krummrich, Takashi Sakamoto, Bjorn Helgaas, Pan Chuang,
Xichao Zhao, Yasin Lee, open list:IIO SUBSYSTEM AND DRIVERS,
open list
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() and devm_request_threaded_irq()
automatically log detailed error messages on failure. Remove the
now-redundant driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/iio/proximity/as3935.c | 4 +---
drivers/iio/proximity/d3323aa.c | 2 +-
drivers/iio/proximity/hx9023s.c | 2 +-
drivers/iio/proximity/irsd200.c | 2 +-
drivers/iio/proximity/mb1232.c | 4 +---
drivers/iio/proximity/srf04.c | 4 +---
drivers/iio/proximity/sx_common.c | 2 +-
drivers/iio/proximity/vcnl3020.c | 6 +-----
drivers/iio/proximity/vl53l0x-i2c.c | 4 +---
9 files changed, 9 insertions(+), 21 deletions(-)
diff --git a/drivers/iio/proximity/as3935.c b/drivers/iio/proximity/as3935.c
index 93833037bc94..d7f43c3af165 100644
--- a/drivers/iio/proximity/as3935.c
+++ b/drivers/iio/proximity/as3935.c
@@ -428,10 +428,8 @@ static int as3935_probe(struct spi_device *spi)
dev_name(dev),
indio_dev);
- if (ret) {
- dev_err(dev, "unable to request irq\n");
+ if (ret)
return ret;
- }
ret = devm_iio_device_register(dev, indio_dev);
if (ret < 0) {
diff --git a/drivers/iio/proximity/d3323aa.c b/drivers/iio/proximity/d3323aa.c
index d40e3dff9eb1..1f43c1fed342 100644
--- a/drivers/iio/proximity/d3323aa.c
+++ b/drivers/iio/proximity/d3323aa.c
@@ -771,7 +771,7 @@ static int d3323aa_probe(struct platform_device *pdev)
IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
dev_name(dev), indio_dev);
if (ret)
- return dev_err_probe(dev, ret, "Could not request IRQ\n");
+ return ret;
ret = d3323aa_setup(indio_dev, D3323AA_LP_FILTER_FREQ_DEFAULT_IDX,
D3323AA_FILTER_GAIN_DEFAULT_IDX,
diff --git a/drivers/iio/proximity/hx9023s.c b/drivers/iio/proximity/hx9023s.c
index a6ff7cbe9e65..0199a6351a46 100644
--- a/drivers/iio/proximity/hx9023s.c
+++ b/drivers/iio/proximity/hx9023s.c
@@ -1139,7 +1139,7 @@ static int hx9023s_probe(struct i2c_client *client)
IRQF_ONESHOT,
"hx9023s_event", indio_dev);
if (ret)
- return dev_err_probe(dev, ret, "irq request failed\n");
+ return ret;
data->trig = devm_iio_trigger_alloc(dev, "%s-dev%d",
indio_dev->name,
diff --git a/drivers/iio/proximity/irsd200.c b/drivers/iio/proximity/irsd200.c
index 65af31d43453..b3db7f3a49f6 100644
--- a/drivers/iio/proximity/irsd200.c
+++ b/drivers/iio/proximity/irsd200.c
@@ -910,7 +910,7 @@ static int irsd200_probe(struct i2c_client *client)
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
NULL, indio_dev);
if (ret)
- return dev_err_probe(data->dev, ret, "Could not request irq\n");
+ return ret;
trigger = devm_iio_trigger_alloc(data->dev, "%s-dev%d", indio_dev->name,
iio_device_id(indio_dev));
diff --git a/drivers/iio/proximity/mb1232.c b/drivers/iio/proximity/mb1232.c
index eab881b0cdc7..8b6cfe59508e 100644
--- a/drivers/iio/proximity/mb1232.c
+++ b/drivers/iio/proximity/mb1232.c
@@ -213,10 +213,8 @@ static int mb1232_probe(struct i2c_client *client)
if (data->irqnr > 0) {
ret = devm_request_irq(dev, data->irqnr, mb1232_handle_irq,
IRQF_TRIGGER_FALLING, id->name, indio_dev);
- if (ret < 0) {
- dev_err(dev, "request_irq: %d\n", ret);
+ if (ret < 0)
return ret;
- }
}
ret = devm_iio_triggered_buffer_setup(dev, indio_dev,
diff --git a/drivers/iio/proximity/srf04.c b/drivers/iio/proximity/srf04.c
index 7be50bdebfcb..395185d770bf 100644
--- a/drivers/iio/proximity/srf04.c
+++ b/drivers/iio/proximity/srf04.c
@@ -303,10 +303,8 @@ static int srf04_probe(struct platform_device *pdev)
ret = devm_request_irq(dev, data->irqnr, srf04_handle_irq,
IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
pdev->name, indio_dev);
- if (ret < 0) {
- dev_err(data->dev, "request_irq: %d\n", ret);
+ if (ret < 0)
return ret;
- }
platform_set_drvdata(pdev, indio_dev);
diff --git a/drivers/iio/proximity/sx_common.c b/drivers/iio/proximity/sx_common.c
index 59b35e40739b..4d4937395d9a 100644
--- a/drivers/iio/proximity/sx_common.c
+++ b/drivers/iio/proximity/sx_common.c
@@ -517,7 +517,7 @@ int sx_common_probe(struct i2c_client *client,
IRQF_ONESHOT,
"sx_event", indio_dev);
if (ret)
- return dev_err_probe(dev, ret, "No IRQ\n");
+ return ret;
data->trig = devm_iio_trigger_alloc(dev, "%s-dev%d",
indio_dev->name,
diff --git a/drivers/iio/proximity/vcnl3020.c b/drivers/iio/proximity/vcnl3020.c
index 7f417372566a..6b0d7a9038d9 100644
--- a/drivers/iio/proximity/vcnl3020.c
+++ b/drivers/iio/proximity/vcnl3020.c
@@ -638,12 +638,8 @@ static int vcnl3020_probe(struct i2c_client *client)
NULL, vcnl3020_handle_irq_thread,
IRQF_ONESHOT, indio_dev->name,
indio_dev);
- if (rc) {
- dev_err(&client->dev,
- "Error (%d) irq request failed (%u)\n", rc,
- client->irq);
+ if (rc)
return rc;
- }
}
return devm_iio_device_register(&client->dev, indio_dev);
diff --git a/drivers/iio/proximity/vl53l0x-i2c.c b/drivers/iio/proximity/vl53l0x-i2c.c
index b7127c3c52d2..9fe14ceb8be7 100644
--- a/drivers/iio/proximity/vl53l0x-i2c.c
+++ b/drivers/iio/proximity/vl53l0x-i2c.c
@@ -127,10 +127,8 @@ static int vl53l0x_configure_irq(struct i2c_client *client,
ret = devm_request_threaded_irq(&client->dev, client->irq,
NULL, vl53l0x_threaded_irq,
irq_flags | IRQF_ONESHOT, indio_dev->name, indio_dev);
- if (ret) {
- dev_err(&client->dev, "devm_request_irq error: %d\n", ret);
+ if (ret)
return ret;
- }
ret = i2c_smbus_write_byte_data(data->client,
VL_REG_SYSTEM_INTERRUPT_CONFIG_GPIO,
--
2.34.1
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 12/13] iio: light: Remove redundant dev_err()/dev_err_probe()
2026-07-17 9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
` (10 preceding siblings ...)
2026-07-17 9:42 ` [PATCH 11/13] iio: proximity: " Pan Chuang
@ 2026-07-17 9:42 ` Pan Chuang
2026-07-17 9:42 ` [PATCH 13/13] iio: temperature: " Pan Chuang
2026-07-17 10:30 ` [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Andy Shevchenko
13 siblings, 0 replies; 19+ messages in thread
From: Pan Chuang @ 2026-07-17 9:42 UTC (permalink / raw)
To: Nuno Sá,
Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko, Mikael Gonella-Bolduc, Subhajit Ghosh,
Mudit Sharma, Kevin Tsai, Linus Walleij, Anshul Dalal,
Javier Carrasco, Siratul Islam,
Uwe Kleine-König (The Capable Hub),
Pan Chuang, Matti Vaittinen, Sakari Ailus, Chu Guangqing,
Takashi Sakamoto, Antoniu Miclaus, Kurt Borja, Xichao Zhao,
Sebastian Andrzej Siewior, Joshua Crofts, Miao Li,
Rafael G. Dias, Felipe Khoury Dayoub, Dixit Parmar,
Danilo Krummrich, Bjorn Helgaas, Shi Hao, Svyatoslav Ryhel,
Colin Ian King, open list:ANALOG DEVICES INC IIO DRIVERS,
open list:IIO SUBSYSTEM AND DRIVERS, open list
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() and devm_request_threaded_irq()
automatically log detailed error messages on failure. Remove the
now-redundant driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/iio/light/adux1020.c | 4 +---
drivers/iio/light/apds9160.c | 7 ++-----
drivers/iio/light/apds9300.c | 4 +---
drivers/iio/light/apds9306.c | 3 +--
drivers/iio/light/apds9960.c | 4 +---
drivers/iio/light/bh1745.c | 3 +--
drivers/iio/light/cm3605.c | 4 +---
drivers/iio/light/gp2ap002.c | 4 +---
drivers/iio/light/ltr390.c | 3 +--
drivers/iio/light/ltr501.c | 5 +----
drivers/iio/light/opt4060.c | 2 +-
drivers/iio/light/rpr0521.c | 5 +----
drivers/iio/light/si1145.c | 4 +---
drivers/iio/light/st_uvis25_core.c | 5 +----
drivers/iio/light/stk3310.c | 5 +----
drivers/iio/light/tsl2563.c | 2 +-
drivers/iio/light/tsl2772.c | 5 +----
drivers/iio/light/vcnl4035.c | 3 ---
drivers/iio/light/veml6030.c | 4 +---
drivers/iio/light/vl6180.c | 2 +-
20 files changed, 20 insertions(+), 58 deletions(-)
diff --git a/drivers/iio/light/adux1020.c b/drivers/iio/light/adux1020.c
index 633a105fd7f0..0ea282ecc99a 100644
--- a/drivers/iio/light/adux1020.c
+++ b/drivers/iio/light/adux1020.c
@@ -808,10 +808,8 @@ static int adux1020_probe(struct i2c_client *client)
NULL, adux1020_interrupt_handler,
IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
ADUX1020_DRV_NAME, indio_dev);
- if (ret) {
- dev_err(&client->dev, "irq request error %d\n", -ret);
+ if (ret)
return ret;
- }
}
return devm_iio_device_register(&client->dev, indio_dev);
diff --git a/drivers/iio/light/apds9160.c b/drivers/iio/light/apds9160.c
index 8dacb1730429..d7e0924b8106 100644
--- a/drivers/iio/light/apds9160.c
+++ b/drivers/iio/light/apds9160.c
@@ -1545,11 +1545,8 @@ static int apds9160_probe(struct i2c_client *client)
apds9160_irq_handler,
IRQF_ONESHOT, "apds9160_event",
indio_dev);
- if (ret) {
- return dev_err_probe(dev, ret,
- "request irq (%d) failed\n",
- client->irq);
- }
+ if (ret)
+ return ret;
} else {
indio_dev->info = &apds9160_info_no_events;
indio_dev->channels = apds9160_channels_without_events;
diff --git a/drivers/iio/light/apds9300.c b/drivers/iio/light/apds9300.c
index d60ade1209f3..f0abbc4a862a 100644
--- a/drivers/iio/light/apds9300.c
+++ b/drivers/iio/light/apds9300.c
@@ -432,10 +432,8 @@ static int apds9300_probe(struct i2c_client *client)
NULL, apds9300_interrupt_handler,
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
"apds9300_event", indio_dev);
- if (ret) {
- dev_err(&client->dev, "irq request error %d\n", -ret);
+ if (ret)
goto err;
- }
}
ret = iio_device_register(indio_dev);
diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c
index 5ca4c87524fe..697cb36b975b 100644
--- a/drivers/iio/light/apds9306.c
+++ b/drivers/iio/light/apds9306.c
@@ -1286,8 +1286,7 @@ static int apds9306_probe(struct i2c_client *client)
apds9306_irq_handler, IRQF_ONESHOT,
"apds9306_event", indio_dev);
if (ret)
- return dev_err_probe(dev, ret,
- "failed to assign interrupt.\n");
+ return ret;
} else {
indio_dev->info = &apds9306_info_no_events;
indio_dev->channels = apds9306_channels_without_events;
diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
index 2686c3b0c03b..afe520de60e2 100644
--- a/drivers/iio/light/apds9960.c
+++ b/drivers/iio/light/apds9960.c
@@ -1098,10 +1098,8 @@ static int apds9960_probe(struct i2c_client *client)
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
"apds9960_event",
indio_dev);
- if (ret) {
- dev_err(&client->dev, "request irq (%d) failed\n", client->irq);
+ if (ret)
goto error_power_down;
- }
ret = iio_device_register(indio_dev);
if (ret)
diff --git a/drivers/iio/light/bh1745.c b/drivers/iio/light/bh1745.c
index 0aa8e5cc6c56..2b8ff36071b8 100644
--- a/drivers/iio/light/bh1745.c
+++ b/drivers/iio/light/bh1745.c
@@ -784,8 +784,7 @@ static int bh1745_setup_triggered_buffer(struct iio_dev *indio_dev,
IRQF_ONESHOT,
"bh1745_interrupt", indio_dev);
if (ret)
- return dev_err_probe(dev, ret,
- "Request for IRQ failed\n");
+ return ret;
}
return 0;
diff --git a/drivers/iio/light/cm3605.c b/drivers/iio/light/cm3605.c
index 9f799041edf9..34c127593947 100644
--- a/drivers/iio/light/cm3605.c
+++ b/drivers/iio/light/cm3605.c
@@ -232,10 +232,8 @@ static int cm3605_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(dev, irq, cm3605_prox_irq,
NULL, 0, "cm3605", indio_dev);
- if (ret) {
- dev_err(dev, "unable to request IRQ\n");
+ if (ret)
goto out_disable_aset;
- }
/* Just name the trigger the same as the driver */
led_trigger_register_simple("cm3605", &cm3605->led);
diff --git a/drivers/iio/light/gp2ap002.c b/drivers/iio/light/gp2ap002.c
index 02818e2aed68..0f51cea28c09 100644
--- a/drivers/iio/light/gp2ap002.c
+++ b/drivers/iio/light/gp2ap002.c
@@ -573,10 +573,8 @@ static int gp2ap002_probe(struct i2c_client *client)
ret = devm_request_threaded_irq(dev, client->irq, NULL,
gp2ap002_prox_irq, IRQF_ONESHOT,
"gp2ap002", indio_dev);
- if (ret) {
- dev_err(dev, "unable to request IRQ\n");
+ if (ret)
goto out_put_pm;
- }
gp2ap002->irq = client->irq;
/*
diff --git a/drivers/iio/light/ltr390.c b/drivers/iio/light/ltr390.c
index bdc74b8226c8..bc031f2c3141 100644
--- a/drivers/iio/light/ltr390.c
+++ b/drivers/iio/light/ltr390.c
@@ -838,8 +838,7 @@ static int ltr390_probe(struct i2c_client *client)
"ltr390_thresh_event",
indio_dev);
if (ret)
- return dev_err_probe(dev, ret,
- "request irq (%d) failed\n", client->irq);
+ return ret;
}
ret = ltr390_pm_init(data);
diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c
index 7d045be78c6d..fa0d16890c8b 100644
--- a/drivers/iio/light/ltr501.c
+++ b/drivers/iio/light/ltr501.c
@@ -1537,11 +1537,8 @@ static int ltr501_probe(struct i2c_client *client)
IRQF_ONESHOT,
"ltr501_thresh_event",
indio_dev);
- if (ret) {
- dev_err(&client->dev, "request irq (%d) failed\n",
- client->irq);
+ if (ret)
return ret;
- }
} else {
indio_dev->info = data->chip_info->info_no_irq;
}
diff --git a/drivers/iio/light/opt4060.c b/drivers/iio/light/opt4060.c
index c391ad3271c6..98e644192ce3 100644
--- a/drivers/iio/light/opt4060.c
+++ b/drivers/iio/light/opt4060.c
@@ -1200,7 +1200,7 @@ static int opt4060_setup_trigger(struct opt4060_chip *chip, struct iio_dev *idev
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
name, idev);
if (ret)
- return dev_err_probe(chip->dev, ret, "Could not request IRQ\n");
+ return ret;
init_completion(&chip->completion);
diff --git a/drivers/iio/light/rpr0521.c b/drivers/iio/light/rpr0521.c
index f961973892f2..aa5faa528b88 100644
--- a/drivers/iio/light/rpr0521.c
+++ b/drivers/iio/light/rpr0521.c
@@ -987,11 +987,8 @@ static int rpr0521_probe(struct i2c_client *client)
rpr0521_drdy_irq_handler, rpr0521_drdy_irq_thread,
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
"rpr0521_event", indio_dev);
- if (ret < 0) {
- dev_err(&client->dev, "request irq %d for trigger0 failed\n",
- client->irq);
+ if (ret < 0)
goto err_pm_disable;
- }
ret = devm_iio_trigger_register(indio_dev->dev.parent,
data->drdy_trigger0);
diff --git a/drivers/iio/light/si1145.c b/drivers/iio/light/si1145.c
index 4601ae5d2009..910a5a191cdc 100644
--- a/drivers/iio/light/si1145.c
+++ b/drivers/iio/light/si1145.c
@@ -1251,10 +1251,8 @@ static int si1145_probe_trigger(struct iio_dev *indio_dev)
IRQF_TRIGGER_FALLING | IRQF_NO_THREAD,
"si1145_irq",
trig);
- if (ret < 0) {
- dev_err(&client->dev, "irq request failed\n");
+ if (ret < 0)
return ret;
- }
ret = devm_iio_trigger_register(&client->dev, trig);
if (ret)
diff --git a/drivers/iio/light/st_uvis25_core.c b/drivers/iio/light/st_uvis25_core.c
index bcd729a9924e..94d5261b2663 100644
--- a/drivers/iio/light/st_uvis25_core.c
+++ b/drivers/iio/light/st_uvis25_core.c
@@ -196,11 +196,8 @@ static int st_uvis25_allocate_trigger(struct iio_dev *iio_dev)
st_uvis25_trigger_handler_thread,
irq_type | IRQF_ONESHOT,
iio_dev->name, hw);
- if (err) {
- dev_err(dev, "failed to request trigger irq %d\n",
- hw->irq);
+ if (err)
return err;
- }
hw->trig = devm_iio_trigger_alloc(dev, "%s-trigger",
iio_dev->name);
diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c
index e7ce6f32592b..4cd705d98ee0 100644
--- a/drivers/iio/light/stk3310.c
+++ b/drivers/iio/light/stk3310.c
@@ -673,11 +673,8 @@ static int stk3310_probe(struct i2c_client *client)
IRQF_TRIGGER_FALLING |
IRQF_ONESHOT,
"stk3310_event", indio_dev);
- if (ret < 0) {
- dev_err(&client->dev, "request irq %d failed\n",
- client->irq);
+ if (ret < 0)
goto err_standby;
- }
}
ret = iio_device_register(indio_dev);
diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c
index 45f3513d931e..7bef0c3118c2 100644
--- a/drivers/iio/light/tsl2563.c
+++ b/drivers/iio/light/tsl2563.c
@@ -754,7 +754,7 @@ static int tsl2563_probe(struct i2c_client *client)
"tsl2563_event",
indio_dev);
if (err)
- return dev_err_probe(dev, err, "irq request error\n");
+ return err;
}
err = tsl2563_configure(chip);
diff --git a/drivers/iio/light/tsl2772.c b/drivers/iio/light/tsl2772.c
index 244f44379c36..83ef7c665146 100644
--- a/drivers/iio/light/tsl2772.c
+++ b/drivers/iio/light/tsl2772.c
@@ -1849,11 +1849,8 @@ static int tsl2772_probe(struct i2c_client *clientp)
IRQF_ONESHOT,
"TSL2772_event",
indio_dev);
- if (ret) {
- dev_err(&clientp->dev,
- "%s: irq request failed\n", __func__);
+ if (ret)
return ret;
- }
} else {
indio_dev->channels = chip->chip_info->channel_without_events;
}
diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
index bf3a49b4351d..8ed347a2dce4 100644
--- a/drivers/iio/light/vcnl4035.c
+++ b/drivers/iio/light/vcnl4035.c
@@ -545,9 +545,6 @@ static int vcnl4035_probe_trigger(struct iio_dev *indio_dev)
NULL, vcnl4035_drdy_irq_thread,
IRQF_TRIGGER_LOW | IRQF_ONESHOT,
"vcnl4035_event", indio_dev);
- if (ret < 0)
- dev_err(&data->client->dev, "request irq %d for trigger0 failed\n",
- data->client->irq);
return ret;
}
diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c
index 7c837d60dad8..ec9c127e7d8a 100644
--- a/drivers/iio/light/veml6030.c
+++ b/drivers/iio/light/veml6030.c
@@ -921,9 +921,7 @@ static int veml6030_set_info(struct iio_dev *indio_dev)
IRQF_TRIGGER_LOW | IRQF_ONESHOT,
indio_dev->name, indio_dev);
if (ret < 0)
- return dev_err_probe(&client->dev, ret,
- "irq %d request failed\n",
- client->irq);
+ return ret;
indio_dev->info = &veml6030_info;
} else {
diff --git a/drivers/iio/light/vl6180.c b/drivers/iio/light/vl6180.c
index 4f270f405b21..aef8a5333442 100644
--- a/drivers/iio/light/vl6180.c
+++ b/drivers/iio/light/vl6180.c
@@ -721,7 +721,7 @@ static int vl6180_probe(struct i2c_client *client)
IRQF_ONESHOT,
indio_dev->name, indio_dev);
if (ret)
- return dev_err_probe(&client->dev, ret, "devm_request_irq error\n");
+ return ret;
init_completion(&data->completion);
--
2.34.1
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 13/13] iio: temperature: Remove redundant dev_err()/dev_err_probe()
2026-07-17 9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
` (11 preceding siblings ...)
2026-07-17 9:42 ` [PATCH 12/13] iio: light: " Pan Chuang
@ 2026-07-17 9:42 ` Pan Chuang
2026-07-17 10:30 ` [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Andy Shevchenko
13 siblings, 0 replies; 19+ messages in thread
From: Pan Chuang @ 2026-07-17 9:42 UTC (permalink / raw)
To: Nuno Sá,
Jonathan Cameron, David Lechner, Andy Shevchenko,
Uwe Kleine-König (The Capable Hub),
Bjorn Helgaas, Pan Chuang, Takashi Sakamoto,
open list:LTC2983 IIO TEMPERATURE DRIVER, open list
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() and devm_request_threaded_irq()
automatically log detailed error messages on failure. Remove the
now-redundant driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/iio/temperature/ltc2983.c | 2 +-
drivers/iio/temperature/tmp007.c | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/temperature/ltc2983.c b/drivers/iio/temperature/ltc2983.c
index a9d38ed45da6..6efb5252a773 100644
--- a/drivers/iio/temperature/ltc2983.c
+++ b/drivers/iio/temperature/ltc2983.c
@@ -1994,7 +1994,7 @@ static int ltc2983_probe(struct spi_device *spi)
ret = devm_request_irq(dev, spi->irq, ltc2983_irq_handler,
IRQF_TRIGGER_RISING, st->info->name, st);
if (ret)
- return dev_err_probe(dev, ret, "failed to request an irq\n");
+ return ret;
if (st->info->has_eeprom) {
ret = ltc2983_eeprom_cmd(st, LTC2983_EEPROM_WRITE_CMD,
diff --git a/drivers/iio/temperature/tmp007.c b/drivers/iio/temperature/tmp007.c
index 2f6ff87d2a37..4e743424f88e 100644
--- a/drivers/iio/temperature/tmp007.c
+++ b/drivers/iio/temperature/tmp007.c
@@ -527,10 +527,8 @@ static int tmp007_probe(struct i2c_client *client)
NULL, tmp007_interrupt_handler,
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
tmp007_id->name, indio_dev);
- if (ret) {
- dev_err(&client->dev, "irq request error %d\n", -ret);
+ if (ret)
return ret;
- }
}
return devm_iio_device_register(&client->dev, indio_dev);
--
2.34.1
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure
2026-07-17 9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
` (12 preceding siblings ...)
2026-07-17 9:42 ` [PATCH 13/13] iio: temperature: " Pan Chuang
@ 2026-07-17 10:30 ` Andy Shevchenko
13 siblings, 0 replies; 19+ messages in thread
From: Andy Shevchenko @ 2026-07-17 10:30 UTC (permalink / raw)
To: Pan Chuang
Cc: Nuno Sá,
Michael Hennerich, Puranjay Mohan, Jonathan Cameron,
David Lechner, Andy Shevchenko, Marcelo Schmitt, Petre Rodan,
Dan Robertson, Matti Vaittinen, Gustavo Silva, Maxwell Doose,
Tomasz Duszynski, Nishant Malpani, Javier Carrasco, Li peiyu,
Lorenzo Bianconi, Alex Lanzano, Jagath Jog J,
Mikael Gonella-Bolduc, Subhajit Ghosh, Mudit Sharma, Kevin Tsai,
Linus Walleij, Anshul Dalal, Song Qiang, Andreas Klinger,
Uwe Kleine-König (The Capable Hub),
Siratul Islam, Sebastian Andrzej Siewior, Danilo Krummrich,
Takashi Sakamoto, Bjorn Helgaas, Xichao Zhao, Waqar Hameed,
Sakari Ailus, Marcus Folkesson, Dixit Parmar, Miao Li,
Andrew Davis, Kurt Borja, Shrikant Raskar, Chu Guangqing,
Antoniu Miclaus, Joshua Crofts, Felipe Khoury Dayoub,
Rafael G. Dias, Svyatoslav Ryhel, Shi Hao, Colin Ian King,
Salah Triki, David Carlier, Greg Kroah-Hartman, Yash Suthar,
Achim Gratz, Yasin Lee, open list:ANALOG DEVICES INC IIO DRIVERS,
open list:ADXL355 THREE-AXIS DIGITAL ACCELEROMETER DRIVER,
open list
On Fri, Jul 17, 2026 at 05:42:23PM +0800, Pan Chuang wrote:
> Commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()") added automatic error logging to
> devm_request_threaded_irq() and devm_request_any_context_irq()
> via the new devm_request_result() helper, which prints device
> name, IRQ number, handler functions, and error code on failure.
>
> Since devm_request_irq() is a static inline wrapper around
> devm_request_threaded_irq(), it also benefits from this
> automatic logging.
>
> Remove the now-redundant dev_err() and dev_err_probe() calls
> in iio drivers that follow these devm_request_*_irq()
> functions, as the core now provides more detailed diagnostic
> information on failure.
Same comment as per your other series.
While at it drop all these ' != 0' and ' < 0' noise in the conditionals.
With that being done, feel free to add my
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 19+ messages in thread