mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kayra Cizmeci <kayracizmeci@gmail.com>
To: albin_yang@163.com
Cc: peterz@infradead.org, kprateek.nayak@amd.com,
	albinwyang@tencent.com,  bsegall@google.com, chen.yu@linux.dev,
	dietmar.eggemann@arm.com, jstultz@google.com,
	 juri.lelli@redhat.com, linux-kernel@vger.kernel.org,
	mgorman@suse.de, mingo@redhat.com,  rostedt@goodmis.org,
	vincent.guittot@linaro.org, vschneid@redhat.com
Subject: Re: [PATCH] sched/stats: Fix run_delay over-count for proxy-migrated blocked donors
Date: Sun, 1 Nov 2026 18:19:17 +0300	[thread overview]
Message-ID: <audUyrA8QYYHKYPz@scheduler.schedules> (raw)
In-Reply-To: <20261101143101.353033-1-albin_yang@163.com>

On Sun, Nov 01, 2026 at 10:31:01PM +0800, albin_yang@163.com wrote:
> On Wed, Oct 28, 2026 at 09:10:20AM +0530, K Prateek Nayak wrote:
> > Yup! on_cpu / task_current() gets dealt at sched_info_switch()
> > which will enqueue the signal if the task is preempted.
> 
> Prateek, Kayra, Peter -- thanks for the reviews and suggestions.
> 
> I tested the full diff below (comments stripped for brevity).

IDK if you added the comment Peter asked for, if you didn't please
add it in the final patch :-).

> One ask, about the split rather than the code: keep the DELAY_DEQUEUE
> fix as its own patch on se.sched_delayed. p->is_blocked arrived in
> 4c2a20413d7f and first appears in v7.2-rc1, while that over-count goes
> back to v6.12 (152e11f6df29) -- folded in, it cannot be built or
> backported for v6.12.y..v7.1.y. It already exists as v4, already
> reviewed and tested:
> 
>   https://lore.kernel.org/all/20261024042753.2276779-1-albin_yang@163.com/
> 
> Happy to be overruled.

It's up to Peter. Tho, makes sense to me if the other issue exists on older
versions.


Thanks,

Kayra

      reply	other threads:[~2026-11-01 15:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-25 13:07 albin_yang
2026-10-25 19:28 ` Kayra Cizmeci
2026-10-26 13:53   ` albin_yang
2026-10-26 14:48     ` Kayra Cizmeci
2026-10-26  5:46 ` K Prateek Nayak
2026-10-26 13:38   ` albin_yang
2026-10-27  4:11     ` K Prateek Nayak
2026-10-27  6:11       ` Kayra Cizmeci
2026-10-27  6:24         ` K Prateek Nayak
2026-10-27  6:52           ` Kayra Cizmeci
2026-10-27  9:45             ` K Prateek Nayak
2026-10-27  9:53               ` Kayra Cizmeci
2026-10-27  9:58                 ` K Prateek Nayak
2026-10-27 12:09               ` Peter Zijlstra
2026-10-27 12:13                 ` Kayra Cizmeci
2026-10-28  3:40                   ` K Prateek Nayak
2026-10-28  9:22                     ` Peter Zijlstra
2026-11-01 14:31                     ` albin_yang
2026-11-01 15:19                       ` Kayra Cizmeci [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=audUyrA8QYYHKYPz@scheduler.schedules \
    --to=kayracizmeci@gmail.com \
    --cc=albin_yang@163.com \
    --cc=albinwyang@tencent.com \
    --cc=bsegall@google.com \
    --cc=chen.yu@linux.dev \
    --cc=dietmar.eggemann@arm.com \
    --cc=jstultz@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®