Re: [PATCH 3/8] clk: ath79: move the ath79 clock driver to drivers/clk

[Brian Masney <masneyb@kernel.org>]

Hi Rosen,

On Tue, Nov 03, 2026 at 09:58:47PM -0800, Rosen Penev wrote:
> The ath79 PLL clock code only uses the clk API and its own PLL and SRIF
> registers now, so move it from arch/mips/ath79 to drivers/clk, like
> the Ralink clocks before it. Copy the register definitions it uses
> from asm/mach-ath79/ar71xx_regs.h into the driver, so it no longer
> needs the mach headers, and drop the unused ath79.h and common.h.
> 
> The driver stays a CLK_OF_DECLARE one, as the MIPS timer needs the CPU
> clock from plat_time_init(). COMMON_CLK_ATH79 defaults to ATH79.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

This patch itself looks straight forward, however looking at the
original driver it needs a lot of work to be cleaned up. To make it
easier to review, I suggest that you clean up the driver all in one go,
and post it as a brand new version to drivers/clk.

Also for the CLK_OF_DECLARE, we are trying to limit new drivers that use
this. Please have just the timer clock(s) declared with CLK_OF_DECLARE,
and have all of the others as a standard platform driver.

Brian