* [PATCH V1 1/3] dt-bindings: mmc: sdhci-msm: Add sm8750 compatible
2025-10-07 5:44 [PATCH V1 0/3] Add SD Card support for sm8750 SoC and boards Sarthak Garg
@ 2025-10-07 5:44 ` Sarthak Garg
2025-10-10 14:24 ` Rob Herring (Arm)
2025-10-17 13:30 ` Ulf Hansson
2025-10-07 5:44 ` [PATCH V1 2/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc Sarthak Garg
2025-10-07 5:44 ` [PATCH V1 3/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 mtp and qrd board Sarthak Garg
2 siblings, 2 replies; 10+ messages in thread
From: Sarthak Garg @ 2025-10-07 5:44 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio
Cc: linux-mmc, devicetree, linux-kernel, linux-arm-msm, quic_nguyenb,
quic_rampraka, quic_pragalla, quic_sayalil, quic_nitirawa,
quic_bhaskarv, kernel, Sarthak Garg
Document the compatible string for the SDHCI controller on the
sm8750 platform.
Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
---
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
index 594bd174ff21..027011223368 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
@@ -70,6 +70,7 @@ properties:
- qcom,sm8450-sdhci
- qcom,sm8550-sdhci
- qcom,sm8650-sdhci
+ - qcom,sm8750-sdhci
- qcom,x1e80100-sdhci
- const: qcom,sdhci-msm-v5 # for sdcc version 5.0
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH V1 1/3] dt-bindings: mmc: sdhci-msm: Add sm8750 compatible
2025-10-07 5:44 ` [PATCH V1 1/3] dt-bindings: mmc: sdhci-msm: Add sm8750 compatible Sarthak Garg
@ 2025-10-10 14:24 ` Rob Herring (Arm)
2025-10-17 13:30 ` Ulf Hansson
1 sibling, 0 replies; 10+ messages in thread
From: Rob Herring (Arm) @ 2025-10-10 14:24 UTC (permalink / raw)
To: Sarthak Garg
Cc: Bjorn Andersson, quic_nguyenb, quic_nitirawa, quic_bhaskarv,
linux-arm-msm, kernel, devicetree, linux-mmc, quic_sayalil,
Konrad Dybcio, Conor Dooley, Krzysztof Kozlowski, quic_rampraka,
Ulf Hansson, quic_pragalla, linux-kernel
On Tue, 07 Oct 2025 11:14:43 +0530, Sarthak Garg wrote:
> Document the compatible string for the SDHCI controller on the
> sm8750 platform.
>
> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V1 1/3] dt-bindings: mmc: sdhci-msm: Add sm8750 compatible
2025-10-07 5:44 ` [PATCH V1 1/3] dt-bindings: mmc: sdhci-msm: Add sm8750 compatible Sarthak Garg
2025-10-10 14:24 ` Rob Herring (Arm)
@ 2025-10-17 13:30 ` Ulf Hansson
1 sibling, 0 replies; 10+ messages in thread
From: Ulf Hansson @ 2025-10-17 13:30 UTC (permalink / raw)
To: Sarthak Garg
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, linux-mmc, devicetree, linux-kernel,
linux-arm-msm, quic_nguyenb, quic_rampraka, quic_pragalla,
quic_sayalil, quic_nitirawa, quic_bhaskarv, kernel
On Tue, 7 Oct 2025 at 07:45, Sarthak Garg <sarthak.garg@oss.qualcomm.com> wrote:
>
> Document the compatible string for the SDHCI controller on the
> sm8750 platform.
>
> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> index 594bd174ff21..027011223368 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> @@ -70,6 +70,7 @@ properties:
> - qcom,sm8450-sdhci
> - qcom,sm8550-sdhci
> - qcom,sm8650-sdhci
> + - qcom,sm8750-sdhci
> - qcom,x1e80100-sdhci
> - const: qcom,sdhci-msm-v5 # for sdcc version 5.0
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH V1 2/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc
2025-10-07 5:44 [PATCH V1 0/3] Add SD Card support for sm8750 SoC and boards Sarthak Garg
2025-10-07 5:44 ` [PATCH V1 1/3] dt-bindings: mmc: sdhci-msm: Add sm8750 compatible Sarthak Garg
@ 2025-10-07 5:44 ` Sarthak Garg
2025-10-08 12:17 ` Konrad Dybcio
2025-10-07 5:44 ` [PATCH V1 3/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 mtp and qrd board Sarthak Garg
2 siblings, 1 reply; 10+ messages in thread
From: Sarthak Garg @ 2025-10-07 5:44 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio
Cc: linux-mmc, devicetree, linux-kernel, linux-arm-msm, quic_nguyenb,
quic_rampraka, quic_pragalla, quic_sayalil, quic_nitirawa,
quic_bhaskarv, kernel, Sarthak Garg
Add SD Card host controller for sm8750 soc.
Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm8750.dtsi | 63 ++++++++++++++++++++++++++++
1 file changed, 63 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
index a82d9867c7cb..dce70443f719 100644
--- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
@@ -2060,6 +2060,55 @@ ice: crypto@1d88000 {
clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
};
+ sdhc_2: mmc@8804000 {
+ compatible = "qcom,sm8750-sdhci", "qcom,sdhci-msm-v5";
+ reg = <0 0x08804000 0 0x1000>;
+
+ interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 223 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "hc_irq", "pwr_irq";
+
+ clocks = <&gcc GCC_SDCC2_AHB_CLK>,
+ <&gcc GCC_SDCC2_APPS_CLK>,
+ <&rpmhcc RPMH_CXO_CLK>;
+ clock-names = "iface", "core", "xo";
+
+ interconnects = <&aggre2_noc MASTER_SDCC_2 QCOM_ICC_TAG_ALWAYS
+ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
+ <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
+ &config_noc SLAVE_SDCC_2 QCOM_ICC_TAG_ACTIVE_ONLY>;
+ interconnect-names = "sdhc-ddr", "cpu-sdhc";
+
+ power-domains = <&rpmhpd RPMHPD_CX>;
+ operating-points-v2 = <&sdhc2_opp_table>;
+
+ qcom,dll-config = <0x0007442c>;
+ qcom,ddr-config = <0x80040868>;
+
+ iommus = <&apps_smmu 0x540 0x0>;
+ dma-coherent;
+
+ bus-width = <4>;
+ max-sd-hs-hz = <37500000>;
+
+ resets = <&gcc GCC_SDCC2_BCR>;
+ status = "disabled";
+
+ sdhc2_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-100000000 {
+ opp-hz = /bits/ 64 <100000000>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ };
+
+ opp-202000000 {
+ opp-hz = /bits/ 64 <202000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+ };
+ };
+
cryptobam: dma-controller@1dc4000 {
compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
reg = <0x0 0x01dc4000 0x0 0x28000>;
@@ -3121,6 +3170,13 @@ data-pins {
drive-strength = <2>;
bias-pull-up;
};
+
+ card-detect-pins {
+ pins = "gpio55";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
};
sdc2_default: sdc2-default-state {
@@ -3141,6 +3197,13 @@ data-pins {
drive-strength = <10>;
bias-pull-up;
};
+
+ card-detect-pins {
+ pins = "gpio55";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
};
};
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH V1 2/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc
2025-10-07 5:44 ` [PATCH V1 2/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc Sarthak Garg
@ 2025-10-08 12:17 ` Konrad Dybcio
2025-10-23 10:18 ` Sarthak Garg
0 siblings, 1 reply; 10+ messages in thread
From: Konrad Dybcio @ 2025-10-08 12:17 UTC (permalink / raw)
To: Sarthak Garg, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio
Cc: linux-mmc, devicetree, linux-kernel, linux-arm-msm, quic_nguyenb,
quic_rampraka, quic_pragalla, quic_sayalil, quic_nitirawa,
quic_bhaskarv, kernel
On 10/7/25 7:44 AM, Sarthak Garg wrote:
> Add SD Card host controller for sm8750 soc.
>
> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
> ---
[...]
> + sdhc_2: mmc@8804000 {
> + compatible = "qcom,sm8750-sdhci", "qcom,sdhci-msm-v5";
> + reg = <0 0x08804000 0 0x1000>;
> +
> + interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 223 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "hc_irq", "pwr_irq";
One a line, please
> +
> + clocks = <&gcc GCC_SDCC2_AHB_CLK>,
> + <&gcc GCC_SDCC2_APPS_CLK>,
> + <&rpmhcc RPMH_CXO_CLK>;
Please align the '<'s
> + clock-names = "iface", "core", "xo";
One a line, please
> +
> + interconnects = <&aggre2_noc MASTER_SDCC_2 QCOM_ICC_TAG_ALWAYS
> + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
> + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
> + &config_noc SLAVE_SDCC_2 QCOM_ICC_TAG_ACTIVE_ONLY>;
> + interconnect-names = "sdhc-ddr", "cpu-sdhc";
and here
> +
> + power-domains = <&rpmhpd RPMHPD_CX>;
> + operating-points-v2 = <&sdhc2_opp_table>;
> +
> + qcom,dll-config = <0x0007442c>;
> + qcom,ddr-config = <0x80040868>;
> +
> + iommus = <&apps_smmu 0x540 0x0>;
> + dma-coherent;
> +
> + bus-width = <4>;
> + max-sd-hs-hz = <37500000>;
> +
> + resets = <&gcc GCC_SDCC2_BCR>;
> + status = "disabled";
A \n before 'status' is customary
> +
> + sdhc2_opp_table: opp-table {
> + compatible = "operating-points-v2";
> +
> + opp-100000000 {
> + opp-hz = /bits/ 64 <100000000>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> + };
> +
> + opp-202000000 {
> + opp-hz = /bits/ 64 <202000000>;
> + required-opps = <&rpmhpd_opp_nom>;
This can work at SVS_L1
Konrad
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH V1 2/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc
2025-10-08 12:17 ` Konrad Dybcio
@ 2025-10-23 10:18 ` Sarthak Garg
0 siblings, 0 replies; 10+ messages in thread
From: Sarthak Garg @ 2025-10-23 10:18 UTC (permalink / raw)
To: Konrad Dybcio, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio
Cc: linux-mmc, devicetree, linux-kernel, linux-arm-msm, quic_nguyenb,
quic_rampraka, quic_pragalla, quic_sayalil, quic_nitirawa,
quic_bhaskarv, kernel
On 10/8/2025 5:47 PM, Konrad Dybcio wrote:
> On 10/7/25 7:44 AM, Sarthak Garg wrote:
>> Add SD Card host controller for sm8750 soc.
>>
>> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
>> ---
> [...]
>
>> + sdhc_2: mmc@8804000 {
>> + compatible = "qcom,sm8750-sdhci", "qcom,sdhci-msm-v5";
>> + reg = <0 0x08804000 0 0x1000>;
>> +
>> + interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 223 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "hc_irq", "pwr_irq";
> One a line, please
Sure will update it in V2.
>> +
>> + clocks = <&gcc GCC_SDCC2_AHB_CLK>,
>> + <&gcc GCC_SDCC2_APPS_CLK>,
>> + <&rpmhcc RPMH_CXO_CLK>;
> Please align the '<'s
Sure will update it in V2.
>> + clock-names = "iface", "core", "xo";
> One a line, please
Sure will update it in V2.
>> +
>> + interconnects = <&aggre2_noc MASTER_SDCC_2 QCOM_ICC_TAG_ALWAYS
>> + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
>> + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
>> + &config_noc SLAVE_SDCC_2 QCOM_ICC_TAG_ACTIVE_ONLY>;
>> + interconnect-names = "sdhc-ddr", "cpu-sdhc";
> and here
Sure will update it in V2.
>
>> +
>> + power-domains = <&rpmhpd RPMHPD_CX>;
>> + operating-points-v2 = <&sdhc2_opp_table>;
>> +
>> + qcom,dll-config = <0x0007442c>;
>> + qcom,ddr-config = <0x80040868>;
>> +
>> + iommus = <&apps_smmu 0x540 0x0>;
>> + dma-coherent;
>> +
>> + bus-width = <4>;
>> + max-sd-hs-hz = <37500000>;
>> +
>> + resets = <&gcc GCC_SDCC2_BCR>;
>> + status = "disabled";
> A \n before 'status' is customary
Sure will update it in V2.
>
>> +
>> + sdhc2_opp_table: opp-table {
>> + compatible = "operating-points-v2";
>> +
>> + opp-100000000 {
>> + opp-hz = /bits/ 64 <100000000>;
>> + required-opps = <&rpmhpd_opp_low_svs>;
>> + };
>> +
>> + opp-202000000 {
>> + opp-hz = /bits/ 64 <202000000>;
>> + required-opps = <&rpmhpd_opp_nom>;
> This can work at SVS_L1
>
> Konrad
Sure will update to rpmhpd_opp_svs_l1 in V2.
Regards,
Sarthak
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH V1 3/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 mtp and qrd board
2025-10-07 5:44 [PATCH V1 0/3] Add SD Card support for sm8750 SoC and boards Sarthak Garg
2025-10-07 5:44 ` [PATCH V1 1/3] dt-bindings: mmc: sdhci-msm: Add sm8750 compatible Sarthak Garg
2025-10-07 5:44 ` [PATCH V1 2/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc Sarthak Garg
@ 2025-10-07 5:44 ` Sarthak Garg
2025-10-08 12:19 ` Konrad Dybcio
2 siblings, 1 reply; 10+ messages in thread
From: Sarthak Garg @ 2025-10-07 5:44 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio
Cc: linux-mmc, devicetree, linux-kernel, linux-arm-msm, quic_nguyenb,
quic_rampraka, quic_pragalla, quic_sayalil, quic_nitirawa,
quic_bhaskarv, kernel, Sarthak Garg
Enable SD Card host controller for sm8750 mtp and qrd board.
Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 15 +++++++++++++++
arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 16 ++++++++++++++++
2 files changed, 31 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
index 3bbb53b7c71f..26548191d95d 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
@@ -1030,6 +1030,21 @@ &remoteproc_mpss {
status = "fail";
};
+&sdhc_2 {
+ cd-gpios = <&tlmm 55 GPIO_ACTIVE_LOW>;
+ vmmc-supply = <&vreg_l9b_2p9>;
+ vqmmc-supply = <&vreg_l8b_1p8>;
+
+ no-sdio;
+ no-mmc;
+
+ pinctrl-0 = <&sdc2_default>;
+ pinctrl-1 = <&sdc2_sleep>;
+ pinctrl-names = "default", "sleep";
+
+ status = "okay";
+};
+
&swr0 {
status = "okay";
diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
index 13c7b9664c89..8d018eef44da 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
@@ -916,6 +916,22 @@ &remoteproc_mpss {
status = "okay";
};
+&sdhc_2 {
+ cd-gpios = <&tlmm 55 GPIO_ACTIVE_LOW>;
+
+ vmmc-supply = <&vreg_l9b_2p9>;
+ vqmmc-supply = <&vreg_l8b_1p8>;
+
+ no-sdio;
+ no-mmc;
+
+ pinctrl-0 = <&sdc2_default>;
+ pinctrl-1 = <&sdc2_sleep>;
+ pinctrl-names = "default", "sleep";
+
+ status = "okay";
+};
+
&swr0 {
status = "okay";
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH V1 3/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 mtp and qrd board
2025-10-07 5:44 ` [PATCH V1 3/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 mtp and qrd board Sarthak Garg
@ 2025-10-08 12:19 ` Konrad Dybcio
2025-10-23 11:01 ` Sarthak Garg
0 siblings, 1 reply; 10+ messages in thread
From: Konrad Dybcio @ 2025-10-08 12:19 UTC (permalink / raw)
To: Sarthak Garg, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio
Cc: linux-mmc, devicetree, linux-kernel, linux-arm-msm, quic_nguyenb,
quic_rampraka, quic_pragalla, quic_sayalil, quic_nitirawa,
quic_bhaskarv, kernel
On 10/7/25 7:44 AM, Sarthak Garg wrote:
> Enable SD Card host controller for sm8750 mtp and qrd board.
>
> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 15 +++++++++++++++
> arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 16 ++++++++++++++++
Normally this should be one commit per board, with e.g. "sm8750-mtp:"
in the title
> 2 files changed, 31 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> index 3bbb53b7c71f..26548191d95d 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> @@ -1030,6 +1030,21 @@ &remoteproc_mpss {
> status = "fail";
> };
>
> +&sdhc_2 {
> + cd-gpios = <&tlmm 55 GPIO_ACTIVE_LOW>;
> + vmmc-supply = <&vreg_l9b_2p9>;
> + vqmmc-supply = <&vreg_l8b_1p8>;
Any reason you didn't place a \n here..
> +
> + no-sdio;
> + no-mmc;
> +
> + pinctrl-0 = <&sdc2_default>;
> + pinctrl-1 = <&sdc2_sleep>;
> + pinctrl-names = "default", "sleep";
> +
> + status = "okay";
> +};
> +
> &swr0 {
> status = "okay";
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> index 13c7b9664c89..8d018eef44da 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> @@ -916,6 +916,22 @@ &remoteproc_mpss {
> status = "okay";
> };
>
> +&sdhc_2 {
> + cd-gpios = <&tlmm 55 GPIO_ACTIVE_LOW>;
> +
> + vmmc-supply = <&vreg_l9b_2p9>;
> + vqmmc-supply = <&vreg_l8b_1p8>;
..but added one here?
FWIW I like the 2nd one more
Konrad
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH V1 3/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 mtp and qrd board
2025-10-08 12:19 ` Konrad Dybcio
@ 2025-10-23 11:01 ` Sarthak Garg
0 siblings, 0 replies; 10+ messages in thread
From: Sarthak Garg @ 2025-10-23 11:01 UTC (permalink / raw)
To: Konrad Dybcio, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio
Cc: linux-mmc, devicetree, linux-kernel, linux-arm-msm, quic_nguyenb,
quic_rampraka, quic_pragalla, quic_sayalil, quic_nitirawa,
quic_bhaskarv, kernel
On 10/8/2025 5:49 PM, Konrad Dybcio wrote:
> On 10/7/25 7:44 AM, Sarthak Garg wrote:
>> Enable SD Card host controller for sm8750 mtp and qrd board.
>>
>> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
>> ---
>> arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 15 +++++++++++++++
>> arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 16 ++++++++++++++++
> Normally this should be one commit per board, with e.g. "sm8750-mtp:"
> in the title
>
Sure will split in separate commits per board.
>> 2 files changed, 31 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
>> index 3bbb53b7c71f..26548191d95d 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
>> @@ -1030,6 +1030,21 @@ &remoteproc_mpss {
>> status = "fail";
>> };
>>
>> +&sdhc_2 {
>> + cd-gpios = <&tlmm 55 GPIO_ACTIVE_LOW>;
>> + vmmc-supply = <&vreg_l9b_2p9>;
>> + vqmmc-supply = <&vreg_l8b_1p8>;
> Any reason you didn't place a \n here..
Missed it will place in next series.
Regards,
Sarthak
>> +
>> + no-sdio;
>> + no-mmc;
>> +
>> + pinctrl-0 = <&sdc2_default>;
>> + pinctrl-1 = <&sdc2_sleep>;
>> + pinctrl-names = "default", "sleep";
>> +
>> + status = "okay";
>> +};
>> +
>> &swr0 {
>> status = "okay";
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> index 13c7b9664c89..8d018eef44da 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
>> @@ -916,6 +916,22 @@ &remoteproc_mpss {
>> status = "okay";
>> };
>>
>> +&sdhc_2 {
>> + cd-gpios = <&tlmm 55 GPIO_ACTIVE_LOW>;
>> +
>> + vmmc-supply = <&vreg_l9b_2p9>;
>> + vqmmc-supply = <&vreg_l8b_1p8>;
> ..but added one here?
>
> FWIW I like the 2nd one more
>
> Konrad
^ permalink raw reply [flat|nested] 10+ messages in thread