mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Riesch <michael.riesch@collabora.com>
To: 楊智成 <jason98166@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Guochun Huang <hero.huang@rock-chips.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH v6 3/9] phy: rockchip-samsung-dcphy: Unwind power-on on PLL lock failure
Date: Tue, 17 Nov 2026 09:16:24 +0100	[thread overview]
Message-ID: <d3e91164-9da9-4f20-9165-5a586d9aa55b@collabora.com> (raw)
In-Reply-To: <CAPwA33LgQqQSnn3vUOQF2wTUiqP2QROKfUpsASJZqjJP6WDi7A@mail.gmail.com>

Hi Jason,

On 11/17/26 07:41, 楊智成 wrote:
> Hi Michael,
> 
> On 11/16/26 11:00, Michael Riesch wrote:
>> Still what we discussed makes sense, so let us do some refactoring in a
>> later series.
> 
> As discussed, I plan to add the tx_ prefix to the PLL helpers in 6/9.

Oh, seems I missed that. OK, carry on :-)

> I also noticed that struct samsung_mipi_phy holds phy and lanes, which
> TX and RX both use, but also the RX-only hs* fields added in 8/9, while
> the TX-only PLL state stays in struct samsung_mipi_dcphy.
> 
> I am thinking about the following:
> 
> 1) One struct per direction:
> 
> struct samsung_mipi_phy_tx {
>   struct phy *phy;
>   unsigned int lanes;
>   struct reset_control *m_phy_rst;
>   bool legacy_mismatch;
>   struct { ... } pll;
> };
> 
> struct samsung_mipi_phy_rx {
>   struct phy *phy;
>   unsigned int lanes;
>   struct reset_control *s_phy_rst;
>   unsigned long long hs_clk_rate;
>   u16 hsfreq_cfg;
> };
> 
> 2) Keep only phy and lanes in struct samsung_mipi_phy, and move the hs*
> fields to struct samsung_mipi_dcphy, next to the PLL state:
> 
> struct samsung_mipi_dcphy {
>   ...
>   struct samsung_mipi_phy tx;
>   struct samsung_mipi_phy rx;
>   ...
>   struct { ... } pll;
>   unsigned long long rx_hs_clk_rate;
>   u16 rx_hsfreq_cfg;
> };
> 
> Option 1 changes 6/9 to 8/9, option 2 only 8/9. Which one would be more
> convenient for your future work?

Thank you for asking. Option 1 seems a tad cleaner to me.

Please note that there could be a variation of option 1, something like

struct samsung_mipi_dcphy {
  ...
  struct samsung_mipi_phy tx;
  struct samsung_mipi_phy rx;
  ....
};

where

struct samsung_mipi_phy {
  struct phy *phy;
  unsigned int lanes;
  struct reset_control *phy_rst;
  union {
     struct {
       unsigned long long hs_clk_rate;
       u16 hsfreq_cfg;
     } rx_stuff;
     struct {
       bool legacy_mismatch;
       struct { ... } pll;
     } tx_stuff;
  };
};

Maybe this is an acceptable approach for you?

Best regards,
Michael


  reply	other threads:[~2026-11-17  8:16 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  8:18 [PATCH v6 0/9] phy: rockchip-samsung-dcphy: Add the MIPI D-PHY receiver Jason Yang
2026-11-10  8:18 ` [PATCH v6 1/9] dt-bindings: phy: Add PHY_DIRECTION_TX/RX definitions Jason Yang
2026-11-11 10:29   ` Michael Riesch
2026-11-10  8:18 ` [PATCH v6 2/9] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: Select TX or RX, add phy-type Jason Yang
2026-11-10 18:02   ` Rob Herring (Arm)
2026-11-11 10:33   ` Michael Riesch
2026-11-10  8:18 ` [PATCH v6 3/9] phy: rockchip-samsung-dcphy: Unwind power-on on PLL lock failure Jason Yang
2026-11-11 13:02   ` Michael Riesch
2026-11-16  3:01     ` 楊智成
2026-11-16 10:00       ` Michael Riesch
2026-11-17  6:41         ` 楊智成
2026-11-17  8:16           ` Michael Riesch [this message]
2026-11-10  8:18 ` [PATCH v6 4/9] phy: rockchip-samsung-dcphy: Always write the rate-dependent registers Jason Yang
2026-11-11 13:05   ` Michael Riesch
2026-11-10  8:18 ` [PATCH v6 5/9] phy: rockchip-samsung-dcphy: Move block-level setup to runtime resume Jason Yang
2026-11-11 13:14   ` Michael Riesch
2026-11-10  8:18 ` [PATCH v6 6/9] phy: rockchip-samsung-dcphy: Name the transmitter helpers and ops Jason Yang
2026-11-10  8:18 ` [PATCH v6 7/9] phy: rockchip-samsung-dcphy: Support the new phy-type and direction binding Jason Yang
2026-11-11 13:32   ` Michael Riesch
2026-11-10  8:18 ` [PATCH v6 8/9] phy: rockchip-samsung-dcphy: Add MIPI D-PHY receiver support Jason Yang
2026-11-11 15:22   ` Michael Riesch
2026-11-10  8:18 ` [PATCH v6 9/9] arm64: dts: rockchip: add the dcphy mipi csi-2 receiver nodes to rk3588 Jason Yang
2026-11-11 12:32   ` Michael Riesch
2026-11-13 11:08 ` [PATCH v6 0/9] phy: rockchip-samsung-dcphy: Add the MIPI D-PHY receiver Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3e91164-9da9-4f20-9165-5a586d9aa55b@collabora.com \
    --to=michael.riesch@collabora.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=hero.huang@rock-chips.com \
    --cc=jason98166@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mani@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=sashiko-bot@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®