From: Bryan O'Donoghue <bod@kernel.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Suresh Vankadara <svankada@qti.qualcomm.com>,
Vikram Sharma <vikram.sharma@oss.qualcomm.com>
Subject: Re: [PATCH 1/2] dt-bindings: media: qcom,glymur-camss: Use CSIPHY indices for ports
Date: Thu, 5 Nov 2026 15:54:11 +0000 [thread overview]
Message-ID: <ef332a20-1ac8-4d48-a959-46564b2bac42@kernel.org> (raw)
In-Reply-To: <4d656385-fd3b-426d-b326-b1d20ba1e2d7@linaro.org>
On 05/11/2026 15:39, Vladimir Zapolskiy wrote:
>> Today, the Glymur bindings define DT ports { 0, 1, 3 } to map to PHY
>> indices { 0, 1, 4 }. One could argue that this is already an
>> established convention, as it is documented in the bindings. However,
>> it is somewhat confusing.
>>
> I believe it should be fine to have incontiguous port indices, because
> there is no need to link unused phys to CAMSS on any particular board,
> therefore there will be unavoidable "holes", and this can be set right
> in the documentation of CSIPHY to CAMSS connection.
>
> --
> Best wishes,
> Vladimir
I mean the port numbers currently mean absolutely nothing with
standalone PHYs so in that sense I agree.
OTOH since the numbers mean nothing - they should probably be linear,
it's just confusing to have non-linear port numbering.
For legacy PHYs numbering ports after the PHYs is something we inherited
and worked with. For the new scheme it serves no purpose.
---
bod
next prev parent reply other threads:[~2026-11-05 15:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 8:50 [PATCH 0/2] media: qcom: camss: Use Glymur graph ports as CSIPHY IDs Nihal Kumar Gupta
2026-11-02 8:50 ` [PATCH 1/2] dt-bindings: media: qcom,glymur-camss: Use CSIPHY indices for ports Nihal Kumar Gupta
2026-11-04 13:52 ` Krzysztof Kozlowski
2026-11-04 16:00 ` Nihal Kumar Gupta
2026-11-04 16:12 ` Krzysztof Kozlowski
2026-11-05 5:32 ` Nihal Kumar Gupta
2026-11-05 7:33 ` Krzysztof Kozlowski
2026-11-05 9:18 ` Nihal Kumar Gupta
2026-11-05 9:23 ` Krzysztof Kozlowski
2026-11-05 9:53 ` Loic Poulain
2026-11-05 10:15 ` Bryan O'Donoghue
2026-11-05 10:45 ` Krzysztof Kozlowski
2026-11-05 11:03 ` Bryan O'Donoghue
2026-11-05 12:04 ` Loic Poulain
2026-11-05 13:21 ` Krzysztof Kozlowski
2026-11-05 14:01 ` Loic Poulain
2026-11-05 15:39 ` Vladimir Zapolskiy
2026-11-05 15:54 ` Bryan O'Donoghue [this message]
2026-11-05 15:46 ` Bryan O'Donoghue
2026-11-05 16:18 ` Loic Poulain
2026-11-02 8:50 ` [PATCH 2/2] media: qcom: camss: Add Glymur specific resources Nihal Kumar Gupta
2026-11-04 13:54 ` Krzysztof Kozlowski
2026-11-04 16:01 ` Nihal Kumar Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef332a20-1ac8-4d48-a959-46564b2bac42@kernel.org \
--to=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=nihal.gupta@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=svankada@qti.qualcomm.com \
--cc=vikram.sharma@oss.qualcomm.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®