mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chuyi Zhou" <zhouchuyi@bytedance.com>
To: "Peter Zijlstra" <peterz@infradead.org>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <luto@kernel.org>,
	 <paulmck@kernel.org>, <muchun.song@linux.dev>, <bp@alien8.de>,
	 <dave.hansen@linux.intel.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 05/11] smp: Enable preemption early in smp_call_function_many_cond
Date: Fri, 6 Feb 2026 19:45:14 +0800	[thread overview]
Message-ID: <fcea1d58-74c5-41ac-9880-48e4202f78af@bytedance.com> (raw)
In-Reply-To: <20260206094700.GR1282955@noisy.programming.kicks-ass.net>

Hello,

在 2026/2/6 17:47, Peter Zijlstra 写道:
> On Fri, Feb 06, 2026 at 04:43:48PM +0800, Chuyi Zhou wrote:
> 
>> However, 99% of callers have preemption disabled, some of them even
>> invoking it within spin_locks (for example, we might trigger a TLB flush
>> while holding pte spinlocks).
> 
> Then 99% of the callers don't benefit from this and won't see your
> latency reduction -- and will be broken on PREEMPT_RT, no?

Once we make the preemption logic self-contained within smp_call, the 
disabling of preemption by most callers becomes unnecessary and can 
therefore be removed. We can preserve the few instances where it is 
still meaningful or apply special optimizations to them, much like the 
subsequent patch does for arch_tlbbatch_flush/flush_tlb_mm_range.

Consequently, the vast majority of callers stand to benefit. For the RT 
kernel, this optimization provides additional benefits when smp_call is 
invoked within spinlocks, as it reduces the length of non-preemptible 
critical sections.

We can invoke alloc_cpumask_var only when CONFIG_CPUMASK_OFFSTACK is 
disabled, thereby avoiding broken on RT.

However, using cpus_read_lock requires us to absolutely guarantee that 
the current context is sleepable, which is difficult to ensure.

  reply	other threads:[~2026-02-06 11:45 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 11:23 [PATCH 00/11] Allow preemption during IPI completion waiting to improve real-time performance Chuyi Zhou
2026-02-03 11:23 ` [PATCH 01/11] smp: Disable preemption explicitly in __csd_lock_wait Chuyi Zhou
2026-02-05  6:05   ` Muchun Song
2026-02-03 11:23 ` [PATCH 02/11] smp: Enable preemption early in smp_call_function_single Chuyi Zhou
2026-02-05  3:55   ` Muchun Song
2026-02-05  9:34   ` Peter Zijlstra
2026-02-03 11:23 ` [PATCH 03/11] smp: Remove get_cpu from smp_call_function_any Chuyi Zhou
2026-02-05  6:03   ` Muchun Song
2026-02-05  9:42   ` Peter Zijlstra
2026-02-06  8:54     ` Chuyi Zhou
2026-02-03 11:23 ` [PATCH 04/11] smp: Use on-stack cpumask in smp_call_function_many_cond Chuyi Zhou
2026-02-05  9:44   ` Peter Zijlstra
2026-02-06  9:07     ` Chuyi Zhou
2026-02-05  9:51   ` Peter Zijlstra
2026-02-03 11:23 ` [PATCH 05/11] smp: Enable preemption early " Chuyi Zhou
2026-02-05  9:52   ` Peter Zijlstra
2026-02-05 10:57     ` Peter Zijlstra
2026-02-05 14:29       ` Chuyi Zhou
2026-02-05 14:59         ` Peter Zijlstra
2026-02-06  8:43           ` Chuyi Zhou
2026-02-06  9:47             ` Peter Zijlstra
2026-02-06 11:45               ` Chuyi Zhou [this message]
2026-02-09  7:56     ` Chuyi Zhou
2026-02-03 11:23 ` [PATCH 06/11] smp: Remove preempt_disable from smp_call_function Chuyi Zhou
2026-02-03 11:23 ` [PATCH 07/11] smp: Remove preempt_disable from on_each_cpu_cond_mask Chuyi Zhou
2026-02-03 11:23 ` [PATCH 08/11] scftorture: Remove preempt_disable in scftorture_invoke_one Chuyi Zhou
2026-02-03 11:23 ` [PATCH 09/11] x86/mm: Move flush_tlb_info back to the stack Chuyi Zhou
2026-02-03 11:24 ` [PATCH 10/11] x86/mm: Enable preemption during native_flush_tlb_multi Chuyi Zhou
2026-02-03 11:24 ` [PATCH 11/11] x86/mm: Enable preemption during flush_tlb_kernel_range Chuyi Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcea1d58-74c5-41ac-9880-48e4202f78af@bytedance.com \
    --to=zhouchuyi@bytedance.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=muchun.song@linux.dev \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®