From: Daniel Walker <dwalker@mvista.com>
To: eranian@hpl.hp.com
Cc: "Björn Steinbrink" <B.Steinbrink@gmx.de>,
ak@suse.de, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: nmi_watchdog=2 regression in 2.6.21
Date: Tue, 28 Aug 2007 13:26:42 -0700 [thread overview]
Message-ID: <1188332802.2435.332.camel@dhcp193.mvista.com> (raw)
In-Reply-To: <20070828194636.GB2814@frankl.hpl.hp.com>
Here's a simpler patch that fixes the boot hang ..
We have to call off the IPI looping regardless of the check_nmi_watchdog
outcome..
Signed-off-by: Daniel Walker <dwalker@mvista.com>
Index: linux-2.6.22/arch/i386/kernel/nmi.c
===================================================================
--- linux-2.6.22.orig/arch/i386/kernel/nmi.c 2007-08-15 00:51:12.000000000 +0000
+++ linux-2.6.22/arch/i386/kernel/nmi.c 2007-08-28 20:27:56.000000000 +0000
@@ -122,12 +122,12 @@ static int __init check_nmi_watchdog(voi
atomic_dec(&nmi_active);
}
}
+ endflag = 1;
if (!atomic_read(&nmi_active)) {
kfree(prev_nmi_count);
atomic_set(&nmi_active, -1);
return -1;
}
- endflag = 1;
printk("OK.\n");
/* now that we know it works we can reduce NMI frequency to
next prev parent reply other threads:[~2007-08-28 20:35 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 0:06 Daniel Walker
2007-08-08 14:20 ` Björn Steinbrink
2007-08-08 15:20 ` Daniel Walker
2007-08-20 16:44 ` Daniel Walker
2007-08-23 20:08 ` Michal Piotrowski
2007-08-23 21:22 ` Daniel Walker
2007-08-27 0:45 ` Who wants to maintain KR list for stable releases? (was Re: nmi_watchdog=2 regression in 2.6.21) Michal Piotrowski
2007-08-27 7:51 ` Andrew Morton
2007-08-27 9:41 ` Jeff Garzik
2007-08-27 11:35 ` Michal Piotrowski
2007-08-27 16:09 ` Adrian Bunk
2007-08-27 16:05 ` Daniel Walker
2007-08-27 11:38 ` Michal Piotrowski
2007-08-27 12:35 ` Rafael J. Wysocki
2007-08-27 15:02 ` Michal Piotrowski
2007-08-27 15:13 ` Daniel Walker
2007-08-27 15:26 ` Michal Piotrowski
2007-08-27 15:39 ` Daniel Walker
2007-08-27 17:02 ` Michal Piotrowski
2007-08-27 17:17 ` Daniel Walker
2007-08-27 19:12 ` David Rees
2007-08-29 7:42 ` Natalie Protasevich
2007-08-29 22:23 ` Adrian Bunk
2007-08-29 23:59 ` Natalie Protasevich
2007-08-30 8:51 ` Adrian Bunk
2007-08-30 15:24 ` Who wants to maintain KR list for stable releases? Stefan Richter
[not found] ` <32209efe0708300950r5787402l4d02cedd862314fd@mail.gmail.com>
2007-08-30 22:11 ` Al Boldi
2007-09-03 12:29 ` Adrian Bunk
2007-09-03 13:20 ` Stefan Richter
2007-08-30 15:54 ` Who wants to maintain KR list for stable releases? (was Re: nmi_watchdog=2 regression in 2.6.21) Bill Davidsen
2007-09-03 12:43 ` Adrian Bunk
2007-08-27 16:26 ` Daniel Walker
2007-08-27 16:44 ` Andrew Morton
2007-08-27 16:52 ` Adrian Bunk
2007-08-27 17:08 ` Daniel Walker
2007-08-27 18:26 ` Andrew Morton
2007-08-27 8:11 ` David Rees
2007-08-27 11:42 ` Michal Piotrowski
2007-08-27 14:39 ` Daniel Walker
2007-08-27 15:11 ` Michal Piotrowski
2007-08-27 17:54 ` nmi_watchdog=2 regression in 2.6.21 Stephane Eranian
2007-08-27 17:55 ` Daniel Walker
2007-08-27 22:55 ` Stephane Eranian
2007-08-27 23:07 ` Daniel Walker
2007-08-28 9:12 ` Stephane Eranian
2007-08-28 14:34 ` Daniel Walker
2007-08-28 17:05 ` Stephane Eranian
2007-08-28 18:30 ` Daniel Walker
2007-08-28 19:46 ` Stephane Eranian
2007-08-28 20:13 ` Daniel Walker
2007-08-29 21:24 ` Stephane Eranian
2007-08-30 1:21 ` Daniel Walker
2007-08-30 21:05 ` Stephane Eranian
2007-08-31 14:43 ` Daniel Walker
2007-08-31 16:21 ` Stephane Eranian
2007-08-31 16:35 ` Daniel Walker
2007-08-31 18:06 ` Björn Steinbrink
2007-09-01 0:24 ` Daniel Walker
2007-09-01 1:00 ` Björn Steinbrink
2007-09-01 1:36 ` Daniel Walker
2007-09-01 10:19 ` Andi Kleen
2007-09-01 19:51 ` Stephane Eranian
2007-09-01 20:32 ` Andi Kleen
2007-09-01 20:46 ` Daniel Walker
2007-09-01 9:12 ` Andi Kleen
2007-08-28 20:26 ` Daniel Walker [this message]
2007-08-28 20:21 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1188332802.2435.332.camel@dhcp193.mvista.com \
--to=dwalker@mvista.com \
--cc=B.Steinbrink@gmx.de \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=eranian@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®