* [PATCH] selftests: futex: fix compilation error
@ 2017-11-06 4:03 Lei Yang
2017-11-06 23:45 ` Shuah Khan
0 siblings, 1 reply; 8+ messages in thread
From: Lei Yang @ 2017-11-06 4:03 UTC (permalink / raw)
To: lei.yang, shuahkh, linux-kselftest, linux-kernel
I run into below error when building futext
/bin/sh: -c: line 5: syntax error: unexpected end of file
the closing ";" and "\" are necessary.
My OS is "Ubuntu 14.04.5 LTS"
Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
---
tools/testing/selftests/futex/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
index f0c0369..943f3a2 100644
--- a/tools/testing/selftests/futex/Makefile
+++ b/tools/testing/selftests/futex/Makefile
@@ -11,9 +11,9 @@ all:
BUILD_TARGET=$(OUTPUT)/$$DIR; \
mkdir $$BUILD_TARGET -p; \
make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
- if [ -e $$DIR/$(TEST_PROGS) ]; then
- rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
- fi
+ if [ -e $$DIR/$(TEST_PROGS) ]; then \
+ rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
+ fi \
done
override define RUN_TESTS
--
1.9.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] selftests: futex: fix compilation error
2017-11-06 4:03 [PATCH] selftests: futex: fix compilation error Lei Yang
@ 2017-11-06 23:45 ` Shuah Khan
2017-11-06 23:48 ` Shuah Khan
2017-11-07 1:17 ` lei yang
0 siblings, 2 replies; 8+ messages in thread
From: Shuah Khan @ 2017-11-06 23:45 UTC (permalink / raw)
To: Lei Yang; +Cc: linux-kselftest, linux-kernel, Shuah Khan, Shuah Khan
On 11/05/2017 09:03 PM, Lei Yang wrote:
> I run into below error when building futext
> /bin/sh: -c: line 5: syntax error: unexpected end of file
>
> the closing ";" and "\" are necessary.
> My OS is "Ubuntu 14.04.5 LTS"
>
> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
> ---
> tools/testing/selftests/futex/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index f0c0369..943f3a2 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -11,9 +11,9 @@ all:
> BUILD_TARGET=$(OUTPUT)/$$DIR; \
> mkdir $$BUILD_TARGET -p; \
> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> - if [ -e $$DIR/$(TEST_PROGS) ]; then
> - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
> - fi
> + if [ -e $$DIR/$(TEST_PROGS) ]; then \
> + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
> + fi \
> done
>
> override define RUN_TESTS
>
Hmm. I don't see this error on linux_4.14-rc8?
Can you give more details on the gcc version you are using?
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] selftests: futex: fix compilation error
2017-11-06 23:45 ` Shuah Khan
@ 2017-11-06 23:48 ` Shuah Khan
2017-11-07 1:18 ` lei yang
2017-11-07 1:17 ` lei yang
1 sibling, 1 reply; 8+ messages in thread
From: Shuah Khan @ 2017-11-06 23:48 UTC (permalink / raw)
To: Lei Yang; +Cc: linux-kselftest, linux-kernel, Shuah Khan, shuah Khan
On 11/06/2017 04:45 PM, Shuah Khan wrote:
> On 11/05/2017 09:03 PM, Lei Yang wrote:
>> I run into below error when building futext
>> /bin/sh: -c: line 5: syntax error: unexpected end of file
>>
>> the closing ";" and "\" are necessary.
>> My OS is "Ubuntu 14.04.5 LTS"
>>
>> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
>> ---
>> tools/testing/selftests/futex/Makefile | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
>> index f0c0369..943f3a2 100644
>> --- a/tools/testing/selftests/futex/Makefile
>> +++ b/tools/testing/selftests/futex/Makefile
>> @@ -11,9 +11,9 @@ all:
>> BUILD_TARGET=$(OUTPUT)/$$DIR; \
>> mkdir $$BUILD_TARGET -p; \
>> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>> - if [ -e $$DIR/$(TEST_PROGS) ]; then
>> - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
>> - fi
>> + if [ -e $$DIR/$(TEST_PROGS) ]; then \
>> + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
>> + fi \
>> done
>>
>> override define RUN_TESTS
>>
>
> Hmm. I don't see this error on linux_4.14-rc8?
>
> Can you give more details on the gcc version you are using?
I meant gnumake version? I am not seeing the failure with what I am
using
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] selftests: futex: fix compilation error
2017-11-06 23:48 ` Shuah Khan
@ 2017-11-07 1:18 ` lei yang
2017-11-07 22:57 ` Shuah Khan
0 siblings, 1 reply; 8+ messages in thread
From: lei yang @ 2017-11-07 1:18 UTC (permalink / raw)
To: Shuah Khan; +Cc: linux-kselftest, linux-kernel, Shuah Khan
On 2017年11月07日 07:48, Shuah Khan wrote:
> On 11/06/2017 04:45 PM, Shuah Khan wrote:
>> On 11/05/2017 09:03 PM, Lei Yang wrote:
>>> I run into below error when building futext
>>> /bin/sh: -c: line 5: syntax error: unexpected end of file
>>>
>>> the closing ";" and "\" are necessary.
>>> My OS is "Ubuntu 14.04.5 LTS"
>>>
>>> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
>>> ---
>>> tools/testing/selftests/futex/Makefile | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
>>> index f0c0369..943f3a2 100644
>>> --- a/tools/testing/selftests/futex/Makefile
>>> +++ b/tools/testing/selftests/futex/Makefile
>>> @@ -11,9 +11,9 @@ all:
>>> BUILD_TARGET=$(OUTPUT)/$$DIR; \
>>> mkdir $$BUILD_TARGET -p; \
>>> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>>> - if [ -e $$DIR/$(TEST_PROGS) ]; then
>>> - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
>>> - fi
>>> + if [ -e $$DIR/$(TEST_PROGS) ]; then \
>>> + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
>>> + fi \
>>> done
>>>
>>> override define RUN_TESTS
>>>
>> Hmm. I don't see this error on linux_4.14-rc8?
>>
>> Can you give more details on the gcc version you are using?
>
> I meant gnumake version? I am not seeing the failure with what I am
> using
$ make -v
GNU Make 3.81
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.
This program built for x86_64-pc-linux-gnu
Lei
> thanks,
> -- Shuah
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] selftests: futex: fix compilation error
2017-11-07 1:18 ` lei yang
@ 2017-11-07 22:57 ` Shuah Khan
2017-11-08 7:55 ` lei yang
0 siblings, 1 reply; 8+ messages in thread
From: Shuah Khan @ 2017-11-07 22:57 UTC (permalink / raw)
To: lei yang; +Cc: linux-kselftest, linux-kernel, Shuah Khan, Shuah Khan
On 11/06/2017 06:18 PM, lei yang wrote:
>
>
> On 2017年11月07日 07:48, Shuah Khan wrote:
>> On 11/06/2017 04:45 PM, Shuah Khan wrote:
>>> On 11/05/2017 09:03 PM, Lei Yang wrote:
>>>> I run into below error when building futext
>>>> /bin/sh: -c: line 5: syntax error: unexpected end of file
>>>>
>>>> the closing ";" and "\" are necessary.
>>>> My OS is "Ubuntu 14.04.5 LTS"
>>>>
>>>> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
>>>> ---
>>>> tools/testing/selftests/futex/Makefile | 6 +++---
>>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
>>>> index f0c0369..943f3a2 100644
>>>> --- a/tools/testing/selftests/futex/Makefile
>>>> +++ b/tools/testing/selftests/futex/Makefile
>>>> @@ -11,9 +11,9 @@ all:
>>>> BUILD_TARGET=$(OUTPUT)/$$DIR; \
>>>> mkdir $$BUILD_TARGET -p; \
>>>> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>>>> - if [ -e $$DIR/$(TEST_PROGS) ]; then
>>>> - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
>>>> - fi
>>>> + if [ -e $$DIR/$(TEST_PROGS) ]; then \
>>>> + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
>>>> + fi \
>>>> done
>>>> override define RUN_TESTS
>>>>
>>> Hmm. I don't see this error on linux_4.14-rc8?
>>>
>>> Can you give more details on the gcc version you are using?
>>
>> I meant gnumake version? I am not seeing the failure with what I am
>> using
>
> $ make -v
> GNU Make 3.81
> Copyright (C) 2006 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.
> There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
> PARTICULAR PURPOSE.
>
> This program built for x86_64-pc-linux-gnu
>
>
> Lei
>
I can't take patches that aren't tested on the latest kernel release.
3.16 is very old. I am not going reply to other patches you sent.
Please make sure the patches are based on the latest release and tested
on it as well.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] selftests: futex: fix compilation error
2017-11-07 22:57 ` Shuah Khan
@ 2017-11-08 7:55 ` lei yang
2017-11-08 15:31 ` Shuah Khan
0 siblings, 1 reply; 8+ messages in thread
From: lei yang @ 2017-11-08 7:55 UTC (permalink / raw)
To: Shuah Khan; +Cc: linux-kselftest, linux-kernel, Shuah Khan
On 2017年11月08日 06:57, Shuah Khan wrote:
> On 11/06/2017 06:18 PM, lei yang wrote:
>>
>> On 2017年11月07日 07:48, Shuah Khan wrote:
>>> On 11/06/2017 04:45 PM, Shuah Khan wrote:
>>>> On 11/05/2017 09:03 PM, Lei Yang wrote:
>>>>> I run into below error when building futext
>>>>> /bin/sh: -c: line 5: syntax error: unexpected end of file
>>>>>
>>>>> the closing ";" and "\" are necessary.
>>>>> My OS is "Ubuntu 14.04.5 LTS"
>>>>>
>>>>> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
>>>>> ---
>>>>> tools/testing/selftests/futex/Makefile | 6 +++---
>>>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>>>
>>>>> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
>>>>> index f0c0369..943f3a2 100644
>>>>> --- a/tools/testing/selftests/futex/Makefile
>>>>> +++ b/tools/testing/selftests/futex/Makefile
>>>>> @@ -11,9 +11,9 @@ all:
>>>>> BUILD_TARGET=$(OUTPUT)/$$DIR; \
>>>>> mkdir $$BUILD_TARGET -p; \
>>>>> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>>>>> - if [ -e $$DIR/$(TEST_PROGS) ]; then
>>>>> - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
>>>>> - fi
>>>>> + if [ -e $$DIR/$(TEST_PROGS) ]; then \
>>>>> + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
>>>>> + fi \
>>>>> done
>>>>> override define RUN_TESTS
>>>>>
>>>> Hmm. I don't see this error on linux_4.14-rc8?
>>>>
>>>> Can you give more details on the gcc version you are using?
>>> I meant gnumake version? I am not seeing the failure with what I am
>>> using
>> $ make -v
>> GNU Make 3.81
>> Copyright (C) 2006 Free Software Foundation, Inc.
>> This is free software; see the source for copying conditions.
>> There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
>> PARTICULAR PURPOSE.
>>
>> This program built for x86_64-pc-linux-gnu
>>
>>
>> Lei
>>
> I can't take patches that aren't tested on the latest kernel release.
> 3.16 is very old. I am not going reply to other patches you sent.
>
> Please make sure the patches are based on the latest release and tested
> on it as well.
this error only happens when use old version "make", it has nothing to
do with the new or old kernel.
so the question is do we need to be compatible with old "make" ?
Lei
>
> thanks,
> -- Shuah
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] selftests: futex: fix compilation error
2017-11-08 7:55 ` lei yang
@ 2017-11-08 15:31 ` Shuah Khan
0 siblings, 0 replies; 8+ messages in thread
From: Shuah Khan @ 2017-11-08 15:31 UTC (permalink / raw)
To: lei yang; +Cc: linux-kselftest, linux-kernel, Shuah Khan, Shuah Khan
On 11/08/2017 12:55 AM, lei yang wrote:
>
>
> On 2017年11月08日 06:57, Shuah Khan wrote:
>> On 11/06/2017 06:18 PM, lei yang wrote:
>>>
>>> On 2017年11月07日 07:48, Shuah Khan wrote:
>>>> On 11/06/2017 04:45 PM, Shuah Khan wrote:
>>>>> On 11/05/2017 09:03 PM, Lei Yang wrote:
>>>>>> I run into below error when building futext
>>>>>> /bin/sh: -c: line 5: syntax error: unexpected end of file
>>>>>>
>>>>>> the closing ";" and "\" are necessary.
>>>>>> My OS is "Ubuntu 14.04.5 LTS"
>>>>>>
>>>>>> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
>>>>>> ---
>>>>>> tools/testing/selftests/futex/Makefile | 6 +++---
>>>>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>>>>
>>>>>> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
>>>>>> index f0c0369..943f3a2 100644
>>>>>> --- a/tools/testing/selftests/futex/Makefile
>>>>>> +++ b/tools/testing/selftests/futex/Makefile
>>>>>> @@ -11,9 +11,9 @@ all:
>>>>>> BUILD_TARGET=$(OUTPUT)/$$DIR; \
>>>>>> mkdir $$BUILD_TARGET -p; \
>>>>>> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>>>>>> - if [ -e $$DIR/$(TEST_PROGS) ]; then
>>>>>> - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
>>>>>> - fi
>>>>>> + if [ -e $$DIR/$(TEST_PROGS) ]; then \
>>>>>> + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
>>>>>> + fi \
>>>>>> done
>>>>>> override define RUN_TESTS
>>>>>>
>>>>> Hmm. I don't see this error on linux_4.14-rc8?
>>>>>
>>>>> Can you give more details on the gcc version you are using?
>>>> I meant gnumake version? I am not seeing the failure with what I am
>>>> using
>>> $ make -v
>>> GNU Make 3.81
>>> Copyright (C) 2006 Free Software Foundation, Inc.
>>> This is free software; see the source for copying conditions.
>>> There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
>>> PARTICULAR PURPOSE.
>>>
>>> This program built for x86_64-pc-linux-gnu
>>>
>>>
>>> Lei
>>>
>> I can't take patches that aren't tested on the latest kernel release.
>> 3.16 is very old. I am not going reply to other patches you sent.
>>
>> Please make sure the patches are based on the latest release and tested
>> on it as well.
>
> this error only happens when use old version "make", it has nothing to do with the new or old kernel.
>
> so the question is do we need to be compatible with old "make" ?
>
> Lei
>
Like I said, Linux 3.16 kernel is very old and I won't take patches that
are tested on it.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] selftests: futex: fix compilation error
2017-11-06 23:45 ` Shuah Khan
2017-11-06 23:48 ` Shuah Khan
@ 2017-11-07 1:17 ` lei yang
1 sibling, 0 replies; 8+ messages in thread
From: lei yang @ 2017-11-07 1:17 UTC (permalink / raw)
To: Shuah Khan; +Cc: linux-kselftest, linux-kernel, Shuah Khan
On 2017年11月07日 07:45, Shuah Khan wrote:
> On 11/05/2017 09:03 PM, Lei Yang wrote:
>> I run into below error when building futext
>> /bin/sh: -c: line 5: syntax error: unexpected end of file
>>
>> the closing ";" and "\" are necessary.
>> My OS is "Ubuntu 14.04.5 LTS"
>>
>> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
>> ---
>> tools/testing/selftests/futex/Makefile | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
>> index f0c0369..943f3a2 100644
>> --- a/tools/testing/selftests/futex/Makefile
>> +++ b/tools/testing/selftests/futex/Makefile
>> @@ -11,9 +11,9 @@ all:
>> BUILD_TARGET=$(OUTPUT)/$$DIR; \
>> mkdir $$BUILD_TARGET -p; \
>> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>> - if [ -e $$DIR/$(TEST_PROGS) ]; then
>> - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
>> - fi
>> + if [ -e $$DIR/$(TEST_PROGS) ]; then \
>> + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
>> + fi \
>> done
>>
>> override define RUN_TESTS
>>
> Hmm. I don't see this error on linux_4.14-rc8?
>
> Can you give more details on the gcc version you are using?
$ cat /proc/version
Linux version 3.16.0-30-generic (buildd@kissel) (gcc version 4.8.2
(Ubuntu 4.8.2-19ubuntu1) ) #40~14.04.1-Ubuntu SMP Thu Jan 15 17:43:14
UTC 2015
$ uname -a
Linux pek-lyang0-d1 3.16.0-30-generic #40~14.04.1-Ubuntu SMP Thu Jan 15
17:43:14 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
I'm also surprised why nobody report this ? I thought it's because
ksefltest community is not active :-)
Lei
> thanks,
> -- Shuah
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-11-08 15:32 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-06 4:03 [PATCH] selftests: futex: fix compilation error Lei Yang
2017-11-06 23:45 ` Shuah Khan
2017-11-06 23:48 ` Shuah Khan
2017-11-07 1:18 ` lei yang
2017-11-07 22:57 ` Shuah Khan
2017-11-08 7:55 ` lei yang
2017-11-08 15:31 ` Shuah Khan
2017-11-07 1:17 ` lei yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®