Re: [PATCH v1 3/8] arm64: dts: qcom: shikra: Add gpr node

[Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>]

On 6/22/2026 7:14 PM, Krzysztof Kozlowski wrote:
> On 16/06/2026 22:13, Mohammad Rafi Shaik wrote:
>> Add GPR(Generic Pack router) node along with
> 
> Missing spaces before (.
> 
>> APM(Audio Process Manager) and PRM(Proxy resource
>> Manager) audio services.
> 
> 
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
> 

Thanks, I’ll fix the spacing and update the commit message to follow 
Linux coding style and wrapping guidelines.

> 
>> @@ -1851,6 +1854,42 @@ glink-edge {
>>   				mboxes = <&apcs_glb 12>;
>>   				qcom,remote-pid = <1>;
>>   				label = "mpss";
>> +
>> +				gpr: gpr {
>> +					compatible = "qcom,gpr";
>> +					qcom,glink-channels = "modem_apps";
>> +					qcom,domain = <GPR_DOMAIN_ID_MODEM>;
>> +					qcom,intents = <200 20>;
>> +					#address-cells = <1>;
>> +					#size-cells = <0>;
>> +
>> +					q6apm: service@1 {
>> +						compatible = "qcom,q6apm";
>> +						reg = <GPR_APM_MODULE_IID>;
>> +						#sound-dai-cells = <0>;
>> +
>> +						q6apmbedai: bedais {
>> +							compatible = "qcom,q6apm-lpass-dais";
>> +							#sound-dai-cells = <1>;
>> +						};
>> +
>> +						q6apmdai: dais {
>> +							compatible = "qcom,q6apm-dais";
>> +							qcom,vmid = <QCOM_SCM_VMID_LPASS
>> +								     QCOM_SCM_VMID_MSS_MSA>;
> 
> I don't understand what is happening here.
> 

Apologies for the confusion. I will update the commit description in the 
next revision to clearly explain the use of vmid,

> Other patch made a change like:
> 
> -qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>;
> 
> But even here you do not have it.
> 
> I don't understand what is happening here, but for now it looks that
> this patchset is incorrect and incomplete.
> 

I will also incorporate that change directly into this patchset to avoid 
confusion caused by multiple parallel threads, and ensure everything is 
consistent and complete here.

Thanks & Regards,
Rafi.

>> +						};
>> +					};
>> +
> 
> 
> Best regards,
> Krzysztof