From: "Xin Li (Intel)" <xin@zytor.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
peterz@infradead.org, andrew.cooper3@citrix.com,
seanjc@google.com
Subject: [PATCH v1 0/3] x86: Write FRED RSP0 on return to userspace
Date: Tue, 6 Aug 2024 22:47:19 -0700 [thread overview]
Message-ID: <20240807054722.682375-1-xin@zytor.com> (raw)
This patch set moves writing MSR_IA32_FRED_RSP0 to return to userspace
from context switch.
In the discussion of save/restore host/guest FRED RSP0 for KVM, Sean
proposed to have the kernel write MSR_IA32_FRED_RSP0 on return to
userspace, i.e., arch_exit_to_user_mode_prepare(), instead of on context
switch. [1]
hpa suggested to test ti_work for zero and then process individual bits
in arch_exit_to_user_mode_prepare. And a quick measurement shows that
in most cases, ti_work values passed to arch_exit_to_user_mode_prepare()
are zeros, e.g., 99% in kernel build tests. This zero test change was
then sent to Intel 0day tests, and no perf regression is reported.
Besides, per the discussion of how to write MSR_IA32_FRED_RSP0 with the
introduction of WRMSRNS [2], use the alternatives mechanism to choose
WRMSRNS when it's available, otherwise fallback to WRMSR.
[1] https://lore.kernel.org/lkml/ZpkfkSMPiXrS9r2K@google.com/
[2] https://lore.kernel.org/lkml/15f56e6a-6edd-43d0-8e83-bb6430096514@citrix.com/
Andrew Cooper (1):
x86/msr: Switch between WRMSRNS and WRMSR with the alternatives
mechanism
Xin Li (Intel) (2):
x86/entry: Test ti_work for zero before processing individual bits
x86/entry: Set FRED RSP0 on return to userspace instead of context
switch
arch/x86/include/asm/entry-common.h | 21 ++++++++++++++-------
arch/x86/include/asm/msr.h | 28 ++++++++++++++--------------
arch/x86/include/asm/switch_to.h | 3 +--
arch/x86/include/asm/thread_info.h | 2 ++
arch/x86/kernel/cpu/cpuid-deps.c | 1 -
5 files changed, 31 insertions(+), 24 deletions(-)
base-commit: 9ebdc7589cbb5c976e6c8807cbe13f263d70d32c
--
2.45.2
next reply other threads:[~2024-08-07 5:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 5:47 Xin Li (Intel) [this message]
2024-08-07 5:47 ` [PATCH v1 1/3] x86/entry: Test ti_work for zero before processing individual bits Xin Li (Intel)
2024-08-07 16:21 ` Brian Gerst
2024-08-07 23:03 ` Xin Li
2024-08-07 18:08 ` Thomas Gleixner
2024-08-07 18:21 ` Thomas Gleixner
2024-08-07 23:01 ` Xin Li
2024-08-07 5:47 ` [PATCH v1 2/3] x86/msr: Switch between WRMSRNS and WRMSR with the alternatives mechanism Xin Li (Intel)
2024-08-07 18:11 ` Thomas Gleixner
2024-08-09 23:07 ` Andrew Cooper
2024-08-10 0:01 ` H. Peter Anvin
2024-08-10 0:25 ` Andrew Cooper
2024-08-16 17:52 ` Xin Li
2024-08-16 18:40 ` Andrew Cooper
2024-08-16 19:18 ` H. Peter Anvin
2024-08-16 21:45 ` Andrew Cooper
2024-08-16 21:26 ` H. Peter Anvin
2024-08-16 22:27 ` Andrew Cooper
2024-08-16 22:34 ` Andrew Cooper
2024-08-16 23:03 ` H. Peter Anvin
2024-08-16 22:59 ` H. Peter Anvin
2024-08-17 23:51 ` H. Peter Anvin
2024-08-17 14:23 ` Borislav Petkov
2024-08-17 14:43 ` Borislav Petkov
2024-08-17 15:44 ` Xin Li
2024-08-17 19:22 ` H. Peter Anvin
2024-08-18 5:59 ` Borislav Petkov
2024-08-17 19:22 ` H. Peter Anvin
2024-08-18 5:49 ` Borislav Petkov
2024-08-18 6:16 ` H. Peter Anvin
2024-08-07 5:47 ` [PATCH v1 3/3] x86/entry: Set FRED RSP0 on return to userspace instead of context switch Xin Li (Intel)
2024-08-07 18:39 ` Thomas Gleixner
2024-08-07 21:55 ` Sean Christopherson
2024-08-07 23:04 ` Thomas Gleixner
2024-08-09 10:45 ` Nikolay Borisov
2024-08-09 17:37 ` Xin Li
2024-08-09 22:43 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807054722.682375-1-xin@zytor.com \
--to=xin@zytor.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®