From: "Xin Li (Intel)" <xin@zytor.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
peterz@infradead.org, andrew.cooper3@citrix.com,
seanjc@google.com
Subject: [PATCH v1 1/3] x86/entry: Test ti_work for zero before processing individual bits
Date: Tue, 6 Aug 2024 22:47:20 -0700 [thread overview]
Message-ID: <20240807054722.682375-2-xin@zytor.com> (raw)
In-Reply-To: <20240807054722.682375-1-xin@zytor.com>
In most cases, ti_work values passed to arch_exit_to_user_mode_prepare()
are zeros, e.g., 99% in kernel build tests. So an obvious optimization
is to test ti_work for zero before processing individual bits in it.
In addition, Intel 0day tests find no perf regression with this change.
Suggested-by: H. Peter Anvin (Intel) <hpa@zytor.com>
Signed-off-by: Xin Li (Intel) <xin@zytor.com>
---
arch/x86/include/asm/entry-common.h | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/arch/x86/include/asm/entry-common.h b/arch/x86/include/asm/entry-common.h
index fb2809b20b0a..4c78b99060b5 100644
--- a/arch/x86/include/asm/entry-common.h
+++ b/arch/x86/include/asm/entry-common.h
@@ -47,15 +47,17 @@ static __always_inline void arch_enter_from_user_mode(struct pt_regs *regs)
static inline void arch_exit_to_user_mode_prepare(struct pt_regs *regs,
unsigned long ti_work)
{
- if (ti_work & _TIF_USER_RETURN_NOTIFY)
- fire_user_return_notifiers();
+ if (unlikely(ti_work)) {
+ if (ti_work & _TIF_USER_RETURN_NOTIFY)
+ fire_user_return_notifiers();
- if (unlikely(ti_work & _TIF_IO_BITMAP))
- tss_update_io_bitmap();
+ if (unlikely(ti_work & _TIF_IO_BITMAP))
+ tss_update_io_bitmap();
- fpregs_assert_state_consistent();
- if (unlikely(ti_work & _TIF_NEED_FPU_LOAD))
- switch_fpu_return();
+ fpregs_assert_state_consistent();
+ if (unlikely(ti_work & _TIF_NEED_FPU_LOAD))
+ switch_fpu_return();
+ }
#ifdef CONFIG_COMPAT
/*
--
2.45.2
next prev parent reply other threads:[~2024-08-07 5:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 5:47 [PATCH v1 0/3] x86: Write FRED RSP0 on return to userspace Xin Li (Intel)
2024-08-07 5:47 ` Xin Li (Intel) [this message]
2024-08-07 16:21 ` [PATCH v1 1/3] x86/entry: Test ti_work for zero before processing individual bits Brian Gerst
2024-08-07 23:03 ` Xin Li
2024-08-07 18:08 ` Thomas Gleixner
2024-08-07 18:21 ` Thomas Gleixner
2024-08-07 23:01 ` Xin Li
2024-08-07 5:47 ` [PATCH v1 2/3] x86/msr: Switch between WRMSRNS and WRMSR with the alternatives mechanism Xin Li (Intel)
2024-08-07 18:11 ` Thomas Gleixner
2024-08-09 23:07 ` Andrew Cooper
2024-08-10 0:01 ` H. Peter Anvin
2024-08-10 0:25 ` Andrew Cooper
2024-08-16 17:52 ` Xin Li
2024-08-16 18:40 ` Andrew Cooper
2024-08-16 19:18 ` H. Peter Anvin
2024-08-16 21:45 ` Andrew Cooper
2024-08-16 21:26 ` H. Peter Anvin
2024-08-16 22:27 ` Andrew Cooper
2024-08-16 22:34 ` Andrew Cooper
2024-08-16 23:03 ` H. Peter Anvin
2024-08-16 22:59 ` H. Peter Anvin
2024-08-17 23:51 ` H. Peter Anvin
2024-08-17 14:23 ` Borislav Petkov
2024-08-17 14:43 ` Borislav Petkov
2024-08-17 15:44 ` Xin Li
2024-08-17 19:22 ` H. Peter Anvin
2024-08-18 5:59 ` Borislav Petkov
2024-08-17 19:22 ` H. Peter Anvin
2024-08-18 5:49 ` Borislav Petkov
2024-08-18 6:16 ` H. Peter Anvin
2024-08-07 5:47 ` [PATCH v1 3/3] x86/entry: Set FRED RSP0 on return to userspace instead of context switch Xin Li (Intel)
2024-08-07 18:39 ` Thomas Gleixner
2024-08-07 21:55 ` Sean Christopherson
2024-08-07 23:04 ` Thomas Gleixner
2024-08-09 10:45 ` Nikolay Borisov
2024-08-09 17:37 ` Xin Li
2024-08-09 22:43 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807054722.682375-2-xin@zytor.com \
--to=xin@zytor.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®