* [PATCH 1/4] arm64: dts: ti: k3-am62p5-sk: Disable MMC1 internal pulls on data lines
2026-02-12 18:42 [PATCH 0/4] Fix MMC pin pull configurations Judith Mendez
@ 2026-02-12 18:42 ` Judith Mendez
2026-02-12 18:42 ` [PATCH 2/4] arm64: dts: ti: k3-am62l-evm: Disable MMC0 internal pulls Judith Mendez
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Judith Mendez @ 2026-02-12 18:42 UTC (permalink / raw)
To: Judith Mendez, Nishanth Menon, Vignesh Raghavendra
Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, devicetree, linux-kernel, Moteen Shah,
Andrew Davis
AM62p SK has external pullups on DATA 1-3 pins [0]. Remove internal
pullups considering:
- having both internal and external pullups reduces the total pull-up
resistance < 10K resulting in unnecessary power consumption
- mismatched pullup resistace between D0 and D1-D3 may cause potential
issues for modes with tighter timing requirements. The different pull-up
values cause different rise/fall times on each data line.
Fixes: c00504ea42c0 ("arm64: dts: ti: k3-am62p5-sk: Updates for SK EVM")
[0] https://www.ti.com/lit/zip/SPRR487
Signed-off-by: Judith Mendez <jm@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
index 4f7f6f95b02ef..35baa777b9121 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
@@ -271,9 +271,9 @@ main_mmc1_pins_default: main-mmc1-default-pins {
AM62PX_IOPAD(0x023c, PIN_INPUT, 0) /* (H20) MMC1_CMD */
AM62PX_IOPAD(0x0234, PIN_OUTPUT, 0) /* (J24) MMC1_CLK */
AM62PX_IOPAD(0x0230, PIN_INPUT, 0) /* (H21) MMC1_DAT0 */
- AM62PX_IOPAD(0x022c, PIN_INPUT_PULLUP, 0) /* (H23) MMC1_DAT1 */
- AM62PX_IOPAD(0x0228, PIN_INPUT_PULLUP, 0) /* (H22) MMC1_DAT2 */
- AM62PX_IOPAD(0x0224, PIN_INPUT_PULLUP, 0) /* (H25) MMC1_DAT3 */
+ AM62PX_IOPAD(0x022c, PIN_INPUT, 0) /* (H23) MMC1_DAT1 */
+ AM62PX_IOPAD(0x0228, PIN_INPUT, 0) /* (H22) MMC1_DAT2 */
+ AM62PX_IOPAD(0x0224, PIN_INPUT, 0) /* (H25) MMC1_DAT3 */
AM62PX_IOPAD(0x0240, PIN_INPUT, 0) /* (D23) MMC1_SDCD */
>;
bootph-all;
--
2.52.0
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 2/4] arm64: dts: ti: k3-am62l-evm: Disable MMC0 internal pulls
2026-02-12 18:42 [PATCH 0/4] Fix MMC pin pull configurations Judith Mendez
2026-02-12 18:42 ` [PATCH 1/4] arm64: dts: ti: k3-am62p5-sk: Disable MMC1 internal pulls on data lines Judith Mendez
@ 2026-02-12 18:42 ` Judith Mendez
2026-02-20 8:57 ` Moteen Shah
2026-02-12 18:42 ` [PATCH 3/4] arm64: dts: ti: k3-am62l-evm: Disable MMC1 internal pulls on data pins Judith Mendez
` (2 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Judith Mendez @ 2026-02-12 18:42 UTC (permalink / raw)
To: Judith Mendez, Nishanth Menon, Vignesh Raghavendra
Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, devicetree, linux-kernel, Moteen Shah,
Andrew Davis
AM62L EVM has external pullups on MMC0 CMD and D0 pins [0]. Remove
internal pullups considering:
- having both internal and external pullups reduces the total pull-up
resistance < 47K resulting in a value below the spec recommended 50K ohms
- having both pullups results in unnecessary power consumption
Fixes: 00fb4c73b67d ("arm64: dts: ti: k3-am62l: add initial reference board file")
[0] https://www.ti.com/lit/zip/SPRCAL6
Signed-off-by: Judith Mendez <jm@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62l3-evm.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts b/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
index cae04cce33736..5085cd255fcd5 100644
--- a/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
@@ -253,9 +253,9 @@ AM62LX_IOPAD(0x01e0, PIN_INPUT_PULLUP, 0) /* (D8) I2C2_SDA */
mmc0_pins_default: mmc0-default-pins {
pinctrl-single,pins = <
- AM62LX_IOPAD(0x0214, PIN_INPUT_PULLUP, 0) /* (D2) MMC0_CMD */
+ AM62LX_IOPAD(0x0214, PIN_INPUT, 0) /* (D2) MMC0_CMD */
AM62LX_IOPAD(0x020c, PIN_OUTPUT, 0) /* (B2) MMC0_CLK */
- AM62LX_IOPAD(0x0208, PIN_INPUT_PULLUP, 0) /* (D3) MMC0_DAT0 */
+ AM62LX_IOPAD(0x0208, PIN_INPUT, 0) /* (D3) MMC0_DAT0 */
AM62LX_IOPAD(0x0204, PIN_INPUT_PULLUP, 0) /* (D4) MMC0_DAT1 */
AM62LX_IOPAD(0x0200, PIN_INPUT_PULLUP, 0) /* (C1) MMC0_DAT2 */
AM62LX_IOPAD(0x01fc, PIN_INPUT_PULLUP, 0) /* (C2) MMC0_DAT3 */
--
2.52.0
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2/4] arm64: dts: ti: k3-am62l-evm: Disable MMC0 internal pulls
2026-02-12 18:42 ` [PATCH 2/4] arm64: dts: ti: k3-am62l-evm: Disable MMC0 internal pulls Judith Mendez
@ 2026-02-20 8:57 ` Moteen Shah
2026-02-23 20:15 ` Judith Mendez
0 siblings, 1 reply; 9+ messages in thread
From: Moteen Shah @ 2026-02-20 8:57 UTC (permalink / raw)
To: Judith Mendez, Nishanth Menon, Vignesh Raghavendra
Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, devicetree, linux-kernel, Andrew Davis
Hey Judith,
On 13/02/26 00:12, Judith Mendez wrote:
> AM62L EVM has external pullups on MMC0 CMD and D0 pins [0]. Remove
> internal pullups considering:
> - having both internal and external pullups reduces the total pull-up
> resistance < 47K resulting in a value below the spec recommended 50K ohms
> - having both pullups results in unnecessary power consumption
>
> Fixes: 00fb4c73b67d ("arm64: dts: ti: k3-am62l: add initial reference board file")
> [0] https://www.ti.com/lit/zip/SPRCAL6
> Signed-off-by: Judith Mendez <jm@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62l3-evm.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts b/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
> index cae04cce33736..5085cd255fcd5 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
> @@ -253,9 +253,9 @@ AM62LX_IOPAD(0x01e0, PIN_INPUT_PULLUP, 0) /* (D8) I2C2_SDA */
>
> mmc0_pins_default: mmc0-default-pins {
> pinctrl-single,pins = <
> - AM62LX_IOPAD(0x0214, PIN_INPUT_PULLUP, 0) /* (D2) MMC0_CMD */
> + AM62LX_IOPAD(0x0214, PIN_INPUT, 0) /* (D2) MMC0_CMD */
> AM62LX_IOPAD(0x020c, PIN_OUTPUT, 0) /* (B2) MMC0_CLK */
> - AM62LX_IOPAD(0x0208, PIN_INPUT_PULLUP, 0) /* (D3) MMC0_DAT0 */
> + AM62LX_IOPAD(0x0208, PIN_INPUT, 0) /* (D3) MMC0_DAT0 */
> AM62LX_IOPAD(0x0204, PIN_INPUT_PULLUP, 0) /* (D4) MMC0_DAT1 */
> AM62LX_IOPAD(0x0200, PIN_INPUT_PULLUP, 0) /* (C1) MMC0_DAT2 */
> AM62LX_IOPAD(0x01fc, PIN_INPUT_PULLUP, 0) /* (C2) MMC0_DAT3 */
Wont the change result in mismatched pullup resistance and will the
mismatch between D0 and D1-D3 won't cause potential timing issues for
modes with tighter timing requirements?
Regards,
Moteen
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2/4] arm64: dts: ti: k3-am62l-evm: Disable MMC0 internal pulls
2026-02-20 8:57 ` Moteen Shah
@ 2026-02-23 20:15 ` Judith Mendez
0 siblings, 0 replies; 9+ messages in thread
From: Judith Mendez @ 2026-02-23 20:15 UTC (permalink / raw)
To: Moteen Shah, Nishanth Menon, Vignesh Raghavendra
Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, devicetree, linux-kernel, Andrew Davis
Hello Moteen,
On 2/20/26 2:57 AM, Moteen Shah wrote:
> Hey Judith,
>
> On 13/02/26 00:12, Judith Mendez wrote:
>> AM62L EVM has external pullups on MMC0 CMD and D0 pins [0]. Remove
>> internal pullups considering:
>> - having both internal and external pullups reduces the total pull-up
>> resistance < 47K resulting in a value below the spec recommended
>> 50K ohms
>> - having both pullups results in unnecessary power consumption
>>
>> Fixes: 00fb4c73b67d ("arm64: dts: ti: k3-am62l: add initial reference
>> board file")
>> [0] https://www.ti.com/lit/zip/SPRCAL6
>> Signed-off-by: Judith Mendez <jm@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am62l3-evm.dts | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts b/arch/arm64/
>> boot/dts/ti/k3-am62l3-evm.dts
>> index cae04cce33736..5085cd255fcd5 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
>> @@ -253,9 +253,9 @@ AM62LX_IOPAD(0x01e0, PIN_INPUT_PULLUP, 0) /* (D8)
>> I2C2_SDA */
>> mmc0_pins_default: mmc0-default-pins {
>> pinctrl-single,pins = <
>> - AM62LX_IOPAD(0x0214, PIN_INPUT_PULLUP, 0) /* (D2)
>> MMC0_CMD */
>> + AM62LX_IOPAD(0x0214, PIN_INPUT, 0) /* (D2) MMC0_CMD */
>> AM62LX_IOPAD(0x020c, PIN_OUTPUT, 0) /* (B2) MMC0_CLK */
>> - AM62LX_IOPAD(0x0208, PIN_INPUT_PULLUP, 0) /* (D3)
>> MMC0_DAT0 */
>> + AM62LX_IOPAD(0x0208, PIN_INPUT, 0) /* (D3) MMC0_DAT0 */
>> AM62LX_IOPAD(0x0204, PIN_INPUT_PULLUP, 0) /* (D4)
>> MMC0_DAT1 */
>> AM62LX_IOPAD(0x0200, PIN_INPUT_PULLUP, 0) /* (C1)
>> MMC0_DAT2 */
>> AM62LX_IOPAD(0x01fc, PIN_INPUT_PULLUP, 0) /* (C2)
>> MMC0_DAT3 */
>
>
> Wont the change result in mismatched pullup resistance and will the
> mismatch between D0 and D1-D3 won't cause potential timing issues for
> modes with tighter timing requirements?
If you leave the internal pullup on MMC0_DAT0, then you will have a
greater mismatch actually. But I noticed a wrong detail on the commit
description after reviewing the patches again. So will respin the
series, thanks for reviewing Moteen.
~ Judith
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/4] arm64: dts: ti: k3-am62l-evm: Disable MMC1 internal pulls on data pins
2026-02-12 18:42 [PATCH 0/4] Fix MMC pin pull configurations Judith Mendez
2026-02-12 18:42 ` [PATCH 1/4] arm64: dts: ti: k3-am62p5-sk: Disable MMC1 internal pulls on data lines Judith Mendez
2026-02-12 18:42 ` [PATCH 2/4] arm64: dts: ti: k3-am62l-evm: Disable MMC0 internal pulls Judith Mendez
@ 2026-02-12 18:42 ` Judith Mendez
2026-02-12 18:42 ` [PATCH 4/4] arm64: dts: ti: k3-am62-lp-sk: Enable internal pulls for MMC0 " Judith Mendez
2026-02-20 8:49 ` [PATCH 0/4] Fix MMC pin pull configurations Moteen Shah
4 siblings, 0 replies; 9+ messages in thread
From: Judith Mendez @ 2026-02-12 18:42 UTC (permalink / raw)
To: Judith Mendez, Nishanth Menon, Vignesh Raghavendra
Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, devicetree, linux-kernel, Moteen Shah,
Andrew Davis
AM62L EVM has external pullups on MMC1 D1-D3 pins [0]. Remove internal
pullups considering:
- having both internal and external pullups reduces the total pull-up
resistance < 47K resulting in unnecessary power consumption
- mismatched pullup resistace between D0 and D1-D3 may cause potential
issues for modes with tighter timing requirements. The different pull-up
values cause different rise/fall times on each data line.
Fixes: 00fb4c73b67d ("arm64: dts: ti: k3-am62l: add initial reference board file")
[0] https://www.ti.com/lit/zip/SPRCAL6
Signed-off-by: Judith Mendez <jm@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62l3-evm.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts b/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
index 5085cd255fcd5..98e58d3e7d752 100644
--- a/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
@@ -272,9 +272,9 @@ mmc1_pins_default: mmc1-default-pins {
AM62LX_IOPAD(0x0230, PIN_INPUT, 0) /* (Y3) MMC1_CMD */
AM62LX_IOPAD(0x0228, PIN_OUTPUT, 0) /* (Y2) MMC1_CLK */
AM62LX_IOPAD(0x0224, PIN_INPUT, 0) /* (AA1) MMC1_DAT0 */
- AM62LX_IOPAD(0x0220, PIN_INPUT_PULLUP, 0) /* (Y4) MMC1_DAT1 */
- AM62LX_IOPAD(0x021c, PIN_INPUT_PULLUP, 0) /* (AA2) MMC1_DAT2 */
- AM62LX_IOPAD(0x0218, PIN_INPUT_PULLUP, 0) /* (AB2) MMC1_DAT3 */
+ AM62LX_IOPAD(0x0220, PIN_INPUT, 0) /* (Y4) MMC1_DAT1 */
+ AM62LX_IOPAD(0x021c, PIN_INPUT, 0) /* (AA2) MMC1_DAT2 */
+ AM62LX_IOPAD(0x0218, PIN_INPUT, 0) /* (AB2) MMC1_DAT3 */
AM62LX_IOPAD(0x0234, PIN_INPUT, 0) /* (B6) MMC1_SDCD */
>;
bootph-all;
--
2.52.0
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 4/4] arm64: dts: ti: k3-am62-lp-sk: Enable internal pulls for MMC0 data pins
2026-02-12 18:42 [PATCH 0/4] Fix MMC pin pull configurations Judith Mendez
` (2 preceding siblings ...)
2026-02-12 18:42 ` [PATCH 3/4] arm64: dts: ti: k3-am62l-evm: Disable MMC1 internal pulls on data pins Judith Mendez
@ 2026-02-12 18:42 ` Judith Mendez
2026-02-20 9:00 ` Moteen Shah
2026-02-20 8:49 ` [PATCH 0/4] Fix MMC pin pull configurations Moteen Shah
4 siblings, 1 reply; 9+ messages in thread
From: Judith Mendez @ 2026-02-12 18:42 UTC (permalink / raw)
To: Judith Mendez, Nishanth Menon, Vignesh Raghavendra
Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, devicetree, linux-kernel, Moteen Shah,
Andrew Davis
AM62 LP SK board does not have external pullups on MMC0 D1-D7 pins [0],
enable internal pullups considering:
- floating lines violate JDEC spec recommendations
- mismatched pullup resistace between D0 and D1-D7 may cause potential
issues for modes with tighter timing requirements. The different pull-up
values cause different rise/fall times on each data line.
Fixes: a0b8da04153e ("arm64: dts: ti: k3-am62*: Move eMMC pinmux to top level board file")
[0] https://www.ti.com/lit/zip/SPRR471
Signed-off-by: Judith Mendez <jm@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
index 3e2d8f6695351..8a556fbbe08b7 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
@@ -88,13 +88,13 @@ main_mmc0_pins_default: main-mmc0-default-pins {
AM62X_IOPAD(0x220, PIN_INPUT, 0) /* (V3) MMC0_CMD */
AM62X_IOPAD(0x218, PIN_INPUT, 0) /* (Y1) MMC0_CLK */
AM62X_IOPAD(0x214, PIN_INPUT, 0) /* (V2) MMC0_DAT0 */
- AM62X_IOPAD(0x210, PIN_INPUT, 0) /* (V1) MMC0_DAT1 */
- AM62X_IOPAD(0x20c, PIN_INPUT, 0) /* (W2) MMC0_DAT2 */
- AM62X_IOPAD(0x208, PIN_INPUT, 0) /* (W1) MMC0_DAT3 */
- AM62X_IOPAD(0x204, PIN_INPUT, 0) /* (Y2) MMC0_DAT4 */
- AM62X_IOPAD(0x200, PIN_INPUT, 0) /* (W3) MMC0_DAT5 */
- AM62X_IOPAD(0x1fc, PIN_INPUT, 0) /* (W4) MMC0_DAT6 */
- AM62X_IOPAD(0x1f8, PIN_INPUT, 0) /* (V4) MMC0_DAT7 */
+ AM62X_IOPAD(0x210, PIN_INPUT_PULLUP, 0) /* (V1) MMC0_DAT1 */
+ AM62X_IOPAD(0x20c, PIN_INPUT_PULLUP, 0) /* (W2) MMC0_DAT2 */
+ AM62X_IOPAD(0x208, PIN_INPUT_PULLUP, 0) /* (W1) MMC0_DAT3 */
+ AM62X_IOPAD(0x204, PIN_INPUT_PULLUP, 0) /* (Y2) MMC0_DAT4 */
+ AM62X_IOPAD(0x200, PIN_INPUT_PULLUP, 0) /* (W3) MMC0_DAT5 */
+ AM62X_IOPAD(0x1fc, PIN_INPUT_PULLUP, 0) /* (W4) MMC0_DAT6 */
+ AM62X_IOPAD(0x1f8, PIN_INPUT_PULLUP, 0) /* (V4) MMC0_DAT7 */
>;
};
--
2.52.0
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 4/4] arm64: dts: ti: k3-am62-lp-sk: Enable internal pulls for MMC0 data pins
2026-02-12 18:42 ` [PATCH 4/4] arm64: dts: ti: k3-am62-lp-sk: Enable internal pulls for MMC0 " Judith Mendez
@ 2026-02-20 9:00 ` Moteen Shah
0 siblings, 0 replies; 9+ messages in thread
From: Moteen Shah @ 2026-02-20 9:00 UTC (permalink / raw)
To: Judith Mendez, Nishanth Menon, Vignesh Raghavendra
Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, devicetree, linux-kernel, Andrew Davis
On 13/02/26 00:12, Judith Mendez wrote:
> AM62 LP SK board does not have external pullups on MMC0 D1-D7 pins [0],
> enable internal pullups considering:
> - floating lines violate JDEC spec recommendations
> - mismatched pullup resistace between D0 and D1-D7 may cause potential
> issues for modes with tighter timing requirements. The different pull-up
> values cause different rise/fall times on each data line.
>
> Fixes: a0b8da04153e ("arm64: dts: ti: k3-am62*: Move eMMC pinmux to top level board file")
> [0] https://www.ti.com/lit/zip/SPRR471
> Signed-off-by: Judith Mendez <jm@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> index 3e2d8f6695351..8a556fbbe08b7 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> @@ -88,13 +88,13 @@ main_mmc0_pins_default: main-mmc0-default-pins {
> AM62X_IOPAD(0x220, PIN_INPUT, 0) /* (V3) MMC0_CMD */
> AM62X_IOPAD(0x218, PIN_INPUT, 0) /* (Y1) MMC0_CLK */
> AM62X_IOPAD(0x214, PIN_INPUT, 0) /* (V2) MMC0_DAT0 */
> - AM62X_IOPAD(0x210, PIN_INPUT, 0) /* (V1) MMC0_DAT1 */
> - AM62X_IOPAD(0x20c, PIN_INPUT, 0) /* (W2) MMC0_DAT2 */
> - AM62X_IOPAD(0x208, PIN_INPUT, 0) /* (W1) MMC0_DAT3 */
> - AM62X_IOPAD(0x204, PIN_INPUT, 0) /* (Y2) MMC0_DAT4 */
> - AM62X_IOPAD(0x200, PIN_INPUT, 0) /* (W3) MMC0_DAT5 */
> - AM62X_IOPAD(0x1fc, PIN_INPUT, 0) /* (W4) MMC0_DAT6 */
> - AM62X_IOPAD(0x1f8, PIN_INPUT, 0) /* (V4) MMC0_DAT7 */
> + AM62X_IOPAD(0x210, PIN_INPUT_PULLUP, 0) /* (V1) MMC0_DAT1 */
> + AM62X_IOPAD(0x20c, PIN_INPUT_PULLUP, 0) /* (W2) MMC0_DAT2 */
> + AM62X_IOPAD(0x208, PIN_INPUT_PULLUP, 0) /* (W1) MMC0_DAT3 */
> + AM62X_IOPAD(0x204, PIN_INPUT_PULLUP, 0) /* (Y2) MMC0_DAT4 */
> + AM62X_IOPAD(0x200, PIN_INPUT_PULLUP, 0) /* (W3) MMC0_DAT5 */
> + AM62X_IOPAD(0x1fc, PIN_INPUT_PULLUP, 0) /* (W4) MMC0_DAT6 */
> + AM62X_IOPAD(0x1f8, PIN_INPUT_PULLUP, 0) /* (V4) MMC0_DAT7 */
> >;
> };
>
Same question as of the other patch, won't the mismatch in resistance
between D0 and other data lines will cause an issue here.
Regards,
Moteen
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/4] Fix MMC pin pull configurations
2026-02-12 18:42 [PATCH 0/4] Fix MMC pin pull configurations Judith Mendez
` (3 preceding siblings ...)
2026-02-12 18:42 ` [PATCH 4/4] arm64: dts: ti: k3-am62-lp-sk: Enable internal pulls for MMC0 " Judith Mendez
@ 2026-02-20 8:49 ` Moteen Shah
4 siblings, 0 replies; 9+ messages in thread
From: Moteen Shah @ 2026-02-20 8:49 UTC (permalink / raw)
To: Judith Mendez, Nishanth Menon, Vignesh Raghavendra
Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, devicetree, linux-kernel, Andrew Davis
On 13/02/26 00:12, Judith Mendez wrote:
> This series corrects MMC pin pull-up/pull-down configurations across
> TI AM62L EVM, AM62P SK, & AM62 LP SK boards to properly match their
> hardware design.
>
> Most boards have external pull-ups on MMC pins, but DT configuration
> was also enabling internal pulls. Having both internal and external
> pulls active causes several issues:
> - Unnecessary power consumption due to reduced total resistance
> - Potential timing issues with higher speed modes due to mismatched
> rise/fall times across data lines
>
> One board (AM62 LP SK) lacks external pulls on eMMC data pins and
> requires internal pulls to be explicitly enabled to prevent floating
> lines.
>
> All changes are based on the respective board schematics referenced
> in each patch.
For the series
Reviewed-by: Moteen Shah <m-shah@ti.com>
Regards,
Moteen
> Judith Mendez (4):
> arm64: dts: ti: k3-am62p5-sk: Disable MMC1 internal pulls on data
> lines
> arm64: dts: ti: k3-am62l-evm: Disable MMC0 internal pulls
> arm64: dts: ti: k3-am62l-evm: Disable MMC1 internal pulls on data pins
> arm64: dts: ti: k3-am62-lp-sk: Enable internal pulls for MMC0 data
> pins
>
> arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts | 14 +++++++-------
> arch/arm64/boot/dts/ti/k3-am62l3-evm.dts | 10 +++++-----
> arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 6 +++---
> 3 files changed, 15 insertions(+), 15 deletions(-)
>
^ permalink raw reply [flat|nested] 9+ messages in thread