[PATCH v2 0/3] iio: light: vcnl4000: add regulator support

[PATCH v2 0/3] iio: light: vcnl4000: add regulator support

[Erikas Bitovtas]

This patch series introduces support for voltage supply, I2C and cathode
regulators. This fixes an issue where if a regulator is shared between
the proximity sensor and some other device, and the other device is
powered off, the proximity sensor would be powered off as well.

One of the commits includes a Reported-by: tag without a Closes: tag -
the report was done outside of LKML.

Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
---
Changes in v2:
- Removed double quotes in includes.
- Reordered includes alphabetically.
- Enabled regulators before the mutex is initialized.
- Replaced direct usage of &client->dev with a variable.
- Link to v1: https://lore.kernel.org/r/20260311-vcnl4000-regulators-v1-0-66b6038ce563@gmail.com

---
Erikas Bitovtas (3):
      dt-bindings: iio: light: vcnl4000: add regulators
      iio: light: vcnl4000: add support for regulators
      iio: light: vcnl4000: move client->dev in probe into a variable

 .../bindings/iio/light/vishay,vcnl4000.yaml        |  7 ++++
 drivers/iio/light/vcnl4000.c                       | 41 +++++++++++++---------
 2 files changed, 32 insertions(+), 16 deletions(-)
---
base-commit: f90aadf1c67c8b4969d1e5e6d4fd7227adb6e4d7
change-id: 20260310-vcnl4000-regulators-bcf1b8a01ce6

Best regards,
-- 
Erikas Bitovtas <xerikasxx@gmail.com>

[PATCH v2 1/3] dt-bindings: iio: light: vcnl4000: add regulators

[Erikas Bitovtas]

This commit adds regulator properties for vcnl4000 ambient light and
proximity sensors.

Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
---
 Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
index 2ba4d5de4ec4..a1b4c02db246 100644
--- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
+++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
@@ -33,6 +33,10 @@ properties:
   interrupts:
     maxItems: 1
 
+  vdd-supply: true
+  vddio-supply: true
+  vled-supply: true
+
   reg:
     maxItems: 1
 
@@ -54,6 +58,9 @@ examples:
             compatible = "vishay,vcnl4200";
             reg = <0x51>;
             proximity-near-level = <220>;
+            vdd-supply = <&reg_vdd>;
+            vddio-supply = <&reg_vddio>;
+            vled-supply = <&reg_vled>;
         };
     };
 ...

-- 
2.53.0

[PATCH v2 2/3] iio: light: vcnl4000: add support for regulators

[Erikas Bitovtas]

Add supply, I2C and cathode voltage regulators to the sensor and enable
them. This keeps the sensor powered on even after its only supply shared
by another device shuts down.
This bug was reported outside of LKML, so no Closes: tag can be
attached.

Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
Reported-by: Raymond Hackley <raymondhackley@protonmail.com>
---
 drivers/iio/light/vcnl4000.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
index 5e03c3d8874b..04bde498aec4 100644
--- a/drivers/iio/light/vcnl4000.c
+++ b/drivers/iio/light/vcnl4000.c
@@ -18,12 +18,13 @@
  */
 
 #include <linux/bitfield.h>
-#include <linux/module.h>
-#include <linux/i2c.h>
-#include <linux/err.h>
 #include <linux/delay.h>
-#include <linux/pm_runtime.h>
+#include <linux/err.h>
+#include <linux/i2c.h>
 #include <linux/interrupt.h>
+#include <linux/module.h>
+#include <linux/pm_runtime.h>
+#include <linux/regulator/consumer.h>
 #include <linux/units.h>
 
 #include <linux/iio/buffer.h>
@@ -1983,6 +1984,7 @@ static int vcnl4010_probe_trigger(struct iio_dev *indio_dev)
 static int vcnl4000_probe(struct i2c_client *client)
 {
 	const struct i2c_device_id *id = i2c_client_get_device_id(client);
+	const char * const regulator_names[] = { "vdd", "vddio", "vled" };
 	struct vcnl4000_data *data;
 	struct iio_dev *indio_dev;
 	int ret;
@@ -1997,6 +1999,12 @@ static int vcnl4000_probe(struct i2c_client *client)
 	data->id = id->driver_data;
 	data->chip_spec = &vcnl4000_chip_spec_cfg[data->id];
 
+	ret = devm_regulator_bulk_get_enable(&client->dev,
+				      ARRAY_SIZE(regulator_names),
+				      regulator_names);
+	if (ret < 0)
+		return ret;
+
 	mutex_init(&data->vcnl4000_lock);
 
 	ret = data->chip_spec->init(data);

-- 
2.53.0

[PATCH v2 3/3] iio: light: vcnl4000: move client->dev in probe into a variable

[Erikas Bitovtas]

Move client->dev into a variable of its own and replace all instances of
client->dev being used by it.

Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
---
 drivers/iio/light/vcnl4000.c | 27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
index 04bde498aec4..36a3d8075eb3 100644
--- a/drivers/iio/light/vcnl4000.c
+++ b/drivers/iio/light/vcnl4000.c
@@ -1987,9 +1987,10 @@ static int vcnl4000_probe(struct i2c_client *client)
 	const char * const regulator_names[] = { "vdd", "vddio", "vled" };
 	struct vcnl4000_data *data;
 	struct iio_dev *indio_dev;
+	struct device *dev = &client->dev;
 	int ret;
 
-	indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data));
+	indio_dev = devm_iio_device_alloc(dev, sizeof(*data));
 	if (!indio_dev)
 		return -ENOMEM;
 
@@ -1999,7 +2000,7 @@ static int vcnl4000_probe(struct i2c_client *client)
 	data->id = id->driver_data;
 	data->chip_spec = &vcnl4000_chip_spec_cfg[data->id];
 
-	ret = devm_regulator_bulk_get_enable(&client->dev,
+	ret = devm_regulator_bulk_get_enable(dev,
 				      ARRAY_SIZE(regulator_names),
 				      regulator_names);
 	if (ret < 0)
@@ -2011,10 +2012,10 @@ static int vcnl4000_probe(struct i2c_client *client)
 	if (ret < 0)
 		return ret;
 
-	dev_dbg(&client->dev, "%s Ambient light/proximity sensor, Rev: %02x\n",
+	dev_dbg(dev, "%s Ambient light/proximity sensor, Rev: %02x\n",
 		data->chip_spec->prod, data->rev);
 
-	if (device_property_read_u32(&client->dev, "proximity-near-level",
+	if (device_property_read_u32(dev, "proximity-near-level",
 				     &data->near_level))
 		data->near_level = 0;
 
@@ -2026,26 +2027,26 @@ static int vcnl4000_probe(struct i2c_client *client)
 
 	if (data->chip_spec->trig_buffer_func &&
 	    data->chip_spec->buffer_setup_ops) {
-		ret = devm_iio_triggered_buffer_setup(&client->dev, indio_dev,
+		ret = devm_iio_triggered_buffer_setup(dev, indio_dev,
 						      NULL,
 						      data->chip_spec->trig_buffer_func,
 						      data->chip_spec->buffer_setup_ops);
 		if (ret < 0) {
-			dev_err(&client->dev,
+			dev_err(dev,
 				"unable to setup iio triggered buffer\n");
 			return ret;
 		}
 	}
 
 	if (client->irq && data->chip_spec->irq_thread) {
-		ret = devm_request_threaded_irq(&client->dev, client->irq,
-						NULL, data->chip_spec->irq_thread,
+		ret = devm_request_threaded_irq(dev, client->irq, NULL,
+						data->chip_spec->irq_thread,
 						IRQF_TRIGGER_FALLING |
 						IRQF_ONESHOT,
 						"vcnl4000_irq",
 						indio_dev);
 		if (ret < 0) {
-			dev_err(&client->dev, "irq request failed\n");
+			dev_err(dev, "irq request failed\n");
 			return ret;
 		}
 
@@ -2054,7 +2055,7 @@ static int vcnl4000_probe(struct i2c_client *client)
 			return ret;
 	}
 
-	ret = pm_runtime_set_active(&client->dev);
+	ret = pm_runtime_set_active(dev);
 	if (ret < 0)
 		goto fail_poweroff;
 
@@ -2062,9 +2063,9 @@ static int vcnl4000_probe(struct i2c_client *client)
 	if (ret < 0)
 		goto fail_poweroff;
 
-	pm_runtime_enable(&client->dev);
-	pm_runtime_set_autosuspend_delay(&client->dev, VCNL4000_SLEEP_DELAY_MS);
-	pm_runtime_use_autosuspend(&client->dev);
+	pm_runtime_enable(dev);
+	pm_runtime_set_autosuspend_delay(dev, VCNL4000_SLEEP_DELAY_MS);
+	pm_runtime_use_autosuspend(dev);
 
 	return 0;
 fail_poweroff:

-- 
2.53.0

Re: [PATCH v2 2/3] iio: light: vcnl4000: add support for regulators

[Andy Shevchenko]

On Thu, Mar 12, 2026 at 01:53:13PM +0200, Erikas Bitovtas wrote:
> Add supply, I2C and cathode voltage regulators to the sensor and enable
> them. This keeps the sensor powered on even after its only supply shared
> by another device shuts down.

> This bug was reported outside of LKML, so no Closes: tag can be
> attached.

This paragraph should not be part of the commit message. There is a
comment/changelog block for that.

...

>  #include <linux/bitfield.h>
> -#include <linux/module.h>
> -#include <linux/i2c.h>
> -#include <linux/err.h>
>  #include <linux/delay.h>
> -#include <linux/pm_runtime.h>
> +#include <linux/err.h>
> +#include <linux/i2c.h>
>  #include <linux/interrupt.h>
> +#include <linux/module.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/regulator/consumer.h>
>  #include <linux/units.h>

Sorting headers should be a separate prerequisite change.

...

> +	ret = devm_regulator_bulk_get_enable(&client->dev,
> +				      ARRAY_SIZE(regulator_names),
> +				      regulator_names);
> +	if (ret < 0)
> +		return ret;

>  	mutex_init(&data->vcnl4000_lock);

I would rather expect another prerequisite patch that moves to
devm_mutex_init().

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 3/3] iio: light: vcnl4000: move client->dev in probe into a variable

[Andy Shevchenko]

On Thu, Mar 12, 2026 at 01:53:14PM +0200, Erikas Bitovtas wrote:
> Move client->dev into a variable of its own and replace all instances of
> client->dev being used by it.

...

> +	struct device *dev = &client->dev;

This should be done in the previous patch to reduce churn...


> -	ret = devm_regulator_bulk_get_enable(&client->dev,
> +	ret = devm_regulator_bulk_get_enable(dev,

...like this one.

>  				      ARRAY_SIZE(regulator_names),
>  				      regulator_names);

...

> +		ret = devm_request_threaded_irq(dev, client->irq, NULL,
> +						data->chip_spec->irq_thread,
>  						IRQF_TRIGGER_FALLING |
>  						IRQF_ONESHOT,
>  						"vcnl4000_irq",
>  						indio_dev);

>  		if (ret < 0) {
> -			dev_err(&client->dev, "irq request failed\n");
> +			dev_err(dev, "irq request failed\n");
>  			return ret;
>  		}

This should be another patch to remove the dup message completely before doing
struct device conversion.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/3] iio: light: vcnl4000: add regulator support

[Andy Shevchenko]

On Thu, Mar 12, 2026 at 01:53:11PM +0200, Erikas Bitovtas wrote:
> This patch series introduces support for voltage supply, I2C and cathode
> regulators. This fixes an issue where if a regulator is shared between
> the proximity sensor and some other device, and the other device is
> powered off, the proximity sensor would be powered off as well.
> 
> One of the commits includes a Reported-by: tag without a Closes: tag -
> the report was done outside of LKML.

...

> - Removed double quotes in includes.

> - Reordered includes alphabetically.

Yes, but should be done in a separate change.


> - Enabled regulators before the mutex is initialized.

Why?

> - Replaced direct usage of &client->dev with a variable.

...

TL;DR: this has to be series out of 6 patches.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 1/3] dt-bindings: iio: light: vcnl4000: add regulators

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1339 bytes --]

On Thu, Mar 12, 2026 at 01:53:12PM +0200, Erikas Bitovtas wrote:
> This commit adds regulator properties for vcnl4000 ambient light and
> proximity sensors.

This we can see. Your commit message should say why.

Do all devices in the binding have all of these supplies?

> 
> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> ---
>  Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> index 2ba4d5de4ec4..a1b4c02db246 100644
> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> @@ -33,6 +33,10 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  vdd-supply: true
> +  vddio-supply: true
> +  vled-supply: true
> +
>    reg:
>      maxItems: 1
>  
> @@ -54,6 +58,9 @@ examples:
>              compatible = "vishay,vcnl4200";
>              reg = <0x51>;
>              proximity-near-level = <220>;
> +            vdd-supply = <&reg_vdd>;
> +            vddio-supply = <&reg_vddio>;
> +            vled-supply = <&reg_vled>;
>          };
>      };
>  ...
> 
> -- 
> 2.53.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 1/3] dt-bindings: iio: light: vcnl4000: add regulators

[Erikas Bitovtas]

On 3/12/26 7:39 PM, Conor Dooley wrote:
> On Thu, Mar 12, 2026 at 01:53:12PM +0200, Erikas Bitovtas wrote:
>> This commit adds regulator properties for vcnl4000 ambient light and
>> proximity sensors.
> 
> This we can see. Your commit message should say why.
> 
> Do all devices in the binding have all of these supplies?
> 

If we look at the datasheet for vcnl4040,
https://www.vishay.com/docs/84274/vcnl4040.pdf, in figure 11 we can see
that there can be 3 supplies: sensor supply Vdd (vdd), I2C supply for
the bus Vpull_up (vddio) and IR LED anode Vdd_led (vled).
The other datasheets refer to three supplies as well - one for the
sensor, one for anode and one for the bus:
https://www.vishay.com/docs/83372/vcnl4000.pdf
https://www.vishay.com/docs/84138/designingvcnl4010.pdf
https://www.vishay.com/docs/84327/designingvcnl4200.pdf

>>
>> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
>> ---
>>  Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
>> index 2ba4d5de4ec4..a1b4c02db246 100644
>> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
>> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
>> @@ -33,6 +33,10 @@ properties:
>>    interrupts:
>>      maxItems: 1
>>  
>> +  vdd-supply: true
>> +  vddio-supply: true
>> +  vled-supply: true
>> +
>>    reg:
>>      maxItems: 1
>>  
>> @@ -54,6 +58,9 @@ examples:
>>              compatible = "vishay,vcnl4200";
>>              reg = <0x51>;
>>              proximity-near-level = <220>;
>> +            vdd-supply = <&reg_vdd>;
>> +            vddio-supply = <&reg_vddio>;
>> +            vled-supply = <&reg_vled>;
>>          };
>>      };
>>  ...
>>
>> -- 
>> 2.53.0
>>

Re: [PATCH v2 1/3] dt-bindings: iio: light: vcnl4000: add regulators

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2249 bytes --]

On Fri, Mar 13, 2026 at 06:39:25PM +0200, Erikas Bitovtas wrote:
> 
> 
> On 3/12/26 7:39 PM, Conor Dooley wrote:
> > On Thu, Mar 12, 2026 at 01:53:12PM +0200, Erikas Bitovtas wrote:
> >> This commit adds regulator properties for vcnl4000 ambient light and
> >> proximity sensors.
> > 
> > This we can see. Your commit message should say why.
> > 
> > Do all devices in the binding have all of these supplies?
> > 
> 
> If we look at the datasheet for vcnl4040,
> https://www.vishay.com/docs/84274/vcnl4040.pdf, in figure 11 we can see
> that there can be 3 supplies: sensor supply Vdd (vdd), I2C supply for
> the bus Vpull_up (vddio) and IR LED anode Vdd_led (vled).
> The other datasheets refer to three supplies as well - one for the
> sensor, one for anode and one for the bus:
> https://www.vishay.com/docs/83372/vcnl4000.pdf
> https://www.vishay.com/docs/84138/designingvcnl4010.pdf
> https://www.vishay.com/docs/84327/designingvcnl4200.pdf

Please provide this information in the commit message in v2.

Thanks,
Conor.
pw-bot: changes-requested

> 
> >>
> >> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> >> ---
> >>  Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++++
> >>  1 file changed, 7 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> >> index 2ba4d5de4ec4..a1b4c02db246 100644
> >> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> >> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> >> @@ -33,6 +33,10 @@ properties:
> >>    interrupts:
> >>      maxItems: 1
> >>  
> >> +  vdd-supply: true
> >> +  vddio-supply: true
> >> +  vled-supply: true
> >> +
> >>    reg:
> >>      maxItems: 1
> >>  
> >> @@ -54,6 +58,9 @@ examples:
> >>              compatible = "vishay,vcnl4200";
> >>              reg = <0x51>;
> >>              proximity-near-level = <220>;
> >> +            vdd-supply = <&reg_vdd>;
> >> +            vddio-supply = <&reg_vddio>;
> >> +            vled-supply = <&reg_vled>;
> >>          };
> >>      };
> >>  ...
> >>
> >> -- 
> >> 2.53.0
> >>
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]