mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: albin_yang@163.com
To: kayracizmeci@gmail.com, peterz@infradead.org, kprateek.nayak@amd.com
Cc: albin_yang@163.com, albinwyang@tencent.com, bsegall@google.com,
	chen.yu@linux.dev, dietmar.eggemann@arm.com, jstultz@google.com,
	juri.lelli@redhat.com, linux-kernel@vger.kernel.org,
	mgorman@suse.de, mingo@redhat.com, rostedt@goodmis.org,
	vincent.guittot@linaro.org, vschneid@redhat.com
Subject: Re: [PATCH] sched/stats: Fix run_delay over-count for proxy-migrated blocked donors
Date: Mon,  2 Nov 2026 21:15:25 +0800	[thread overview]
Message-ID: <20261102131525.1099362-1-albin_yang@163.com> (raw)
In-Reply-To: <audUyrA8QYYHKYPz@scheduler.schedules>

On Sun, Nov 01, 2026, Kayra Cizmeci wrote:
> IDK if you added the comment Peter asked for, if you didn't please
> add it in the final patch :-).

Yes -- I stripped them only for the email; the final patch keeps comments.

> It's up to Peter. Tho, makes sense to me if the other issue exists on
> older versions.

It does -- I booted a v6.12.115 kernel and ran the same reproducer
there, with and without the v4 patch already on the list:

    kernel                          run_delay delta    hit rate
    -----------------------------   -----------------  --------
    6.12.115, unpatched             147.98 - 147.99 ms  8/20
    6.12.115, + v4 (sched_delayed)    0.00 ms           0/100
    v7.3+ master, unpatched         147.94 - 147.99 ms  5/20
    v7.3+ master, + the diff          0.00 ms           0/100

Same setup in all four: DELAY_DEQUEUE on, two CPUs used -- worker and a
competitor on CPU0, main on CPU1 -- and main migrates the sleeping worker
with sched_setaffinity(). run_delay is schedstat field 2. The unpatched
delta matches the worker's own t_wake - t_migrate (147.99 vs 148.00 ms)
-- the whole sleep is charged. The reproducer self-checks (must reproduce
unpatched) and run_delay still grows ~40 ms per round, so the counter is
alive, not switched off.

None of this needs proxy exec -- v6.12 does not have it at all, so the
delayed dequeue over-count is fully independent of the proxy one. And
p->is_blocked only exists from v7.2: the is_blocked version cannot even
be built on 6.12, so with both folded into a single patch, v6.12.y to
v7.1.y has no fix at all.

The reproducer is plain userspace (no module); I can provide it if
needed.

Thanks,
Wei Yang


      reply	other threads:[~2026-11-02 13:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-25 13:07 albin_yang
2026-10-25 19:28 ` Kayra Cizmeci
2026-10-26 13:53   ` albin_yang
2026-10-26 14:48     ` Kayra Cizmeci
2026-10-26  5:46 ` K Prateek Nayak
2026-10-26 13:38   ` albin_yang
2026-10-27  4:11     ` K Prateek Nayak
2026-10-27  6:11       ` Kayra Cizmeci
2026-10-27  6:24         ` K Prateek Nayak
2026-10-27  6:52           ` Kayra Cizmeci
2026-10-27  9:45             ` K Prateek Nayak
2026-10-27  9:53               ` Kayra Cizmeci
2026-10-27  9:58                 ` K Prateek Nayak
2026-10-27 12:09               ` Peter Zijlstra
2026-10-27 12:13                 ` Kayra Cizmeci
2026-10-28  3:40                   ` K Prateek Nayak
2026-10-28  9:22                     ` Peter Zijlstra
2026-11-01 14:31                     ` albin_yang
2026-11-01 15:19                       ` Kayra Cizmeci
2026-11-02 13:15                         ` albin_yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261102131525.1099362-1-albin_yang@163.com \
    --to=albin_yang@163.com \
    --cc=albinwyang@tencent.com \
    --cc=bsegall@google.com \
    --cc=chen.yu@linux.dev \
    --cc=dietmar.eggemann@arm.com \
    --cc=jstultz@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=kayracizmeci@gmail.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®