Re: [PATCH net-next 02/10] ice: dpll: serialize changes of the SyncE CGU registers

[Ivan Vecera <ivecera@redhat.com>]

On 11/10/26 18:53, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found more severe
> issue(s) in other patches of this series. This mail is only an FYI, in case
> you want to address the nit picks below when you respin.
> 
> Low priority / nit picks for your consideration:
> 
> - [Low] The commit fixes a race that already exists in the tree, but it
>    has no Fixes: tag and no stable Cc.
> 
> --
> 
> ice: dpll: serialize changes of the SyncE CGU registers
> 
> This patch adds a cgu_synce_lock mutex to struct ice_adapter, which all
> E825C PFs share. It holds that lock around the CGU R10/R11
> read-modify-write sequences in ice_dpll_synce_update_e825c(), and around
> the ice_tspll_cfg_synce_ethdiv_e825c() call in ice_ptp_link_change().
> 
>> ice_ptp_link_change() does not hold dpll_lock, so it can already overwrite
>> an update of another PF. RCLK callbacks are serialized by dpll_lock, but
>> the DPLL core is going to serialize callbacks per (module, clock_id), and
>> each complex has its own DSN and so its own clock_id. With that change, a
>> test toggling RCLK pins of both complexes lost an update.
> 
> [ ... ]
> 
>> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> 
> [Severity: Low]
> Should this patch have a Fixes: tag?

[...]

> Another option is to split this patch out of the series and send it to
> net.
Done, the patch went to net with this tag:

https://lore.kernel.org/netdev/20261110094350.184185-1-ivecera@redhat.com/

v2 of this series drops it.

Thanks,
Ivan