mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Riley <d.riley@proxmox.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	jon@nutanix.com, chao.gao@intel.com
Subject: Re: [PATCH v6 00/28] KVM: combined patchset for MBEC/GMET support
Date: Tue, 19 May 2026 10:02:46 +0200	[thread overview]
Message-ID: <78b03260-856a-4cce-a178-493e248dcbc9@proxmox.com> (raw)
In-Reply-To: <agdmi9wv8yOpgTpb@google.com>

Hi Sean,
thanks for the input.

On 5/15/26 8:31 PM, Sean Christopherson wrote:
> [...]
> Hmm, this probably confirms its the hrtimer issue?  When using the VMX preemption
> timer, KVM (on Intel) doesn't use an hrtimer to emulate L1's APIC timer.  I _think_
> forcing KVM to use an hrtimer would cause result in hrtimers being reprogrammed
> in response to KVM's usage, and thus mask the deferred reprogramming bug?  That
> sounds plausible-ish?
> [...]
> Can you try Peter's fixes?  AIUI, the reporter's hack-a-fix was very far from a
> complete fix.  Note, there's a v3 of patch 1 (b4 should take care of that for you,
> if you're using b4).
>
> https://lore.kernel.org/all/20260423155611.216805954@infradead.org

I tested it again with the v3 hrtimer patches [0] applied on top of the v6
MBEC/GMET series.

Setup:
* Host CPU: Intel(R) Core(TM) Ultra 7 265K (Arrow Lake)
* Host OS: Proxmox VE (based on Debian Trixie)
* Host Kernel: mainline kernel 7.1.0-rc4 with v6 MBEC/GMET and v3 
hrtimer [0]
* QEMU: 11.0.0 (downstream build)
* Guest OS: Windows Server 2026 (24H2, Build 26100.1742) with VBS/Hyper-V
    enabled.

Using:
* QEMU CPU Options: -cpu host,level=30,+vmx-mbec,-cet-ss,-cet-ibt

The CPU lockups did not occur anymore and I was able to boot the Guest. 
Keep
in mind that in this case I have the cet-ss and cet-ibt not passed along 
to the
guest.

If I launch the same Virtual Guest using
* QEMU CPU Options: -cpu host,level=30,+vmx-mbec,+cet-ss,+cet-ibt

The issue of the VM being stuck on boot persists even with the hrtimer 
patches
applied, but now there are no hard/soft lockups of the CPU anymore.

I get this trace using: trace-cmd record -e kvm

        CPU 0/KVM-11837 [001] d..2.  1363.314703: kvm_apic_accept_irq:  
apicid 0 vec 209 (Fixed|edge)
        CPU 0/KVM-11837 [001] d..2.  1363.314703: kvm_apicv_accept_irq: 
apicid 0 vec 209 (Fixed|edge)
        CPU 0/KVM-11837 [001] d..3.  1363.314703: kvm_hv_timer_state:  
  vcpu_id 0 hv_timer 1
        CPU 0/KVM-11837 [001] d..1.  1363.314703: kvm_entry:      vcpu 0 
rip 0xfffff801a59020f7
        CPU 0/KVM-11837 [001] d..1.  1363.314703: kvm_wait_lapic_expire: 
vcpu 0: delta -590 (late)
        CPU 0/KVM-11837 [001] d..1.  1363.314993: kvm_exit:      reason 
EXTERNAL_INTERRUPT rip 0xfffff801a59020ec info 0 0
        CPU 0/KVM-11837 [001] d..1.  1363.314994: kvm_entry:      vcpu 0 
rip 0xfffff801a59020ec
        CPU 0/KVM-11837 [001] d..1.  1363.315993: kvm_exit:      reason 
EXTERNAL_INTERRUPT rip 0xfffff801a59020ec info 0 0
        CPU 0/KVM-11837 [001] d..1.  1363.315993: kvm_entry:      vcpu 0 
rip 0xfffff801a59020ec
        CPU 0/KVM-11837 [001] d..1.  1363.316993: kvm_exit:      reason 
EXTERNAL_INTERRUPT rip 0xfffff801a59020ec info 0 0
        CPU 0/KVM-11837 [001] d..1.  1363.316994: kvm_entry:      vcpu 0 
rip 0xfffff801a59020ec
        CPU 0/KVM-11837 [001] d..1.  1363.317992: kvm_exit:      reason 
EXTERNAL_INTERRUPT rip 0xfffff801a59020ec info 0 0
        CPU 0/KVM-11837 [001] d..1.  1363.317993: kvm_entry:      vcpu 0 
rip 0xfffff801a59020ec
        CPU 0/KVM-11837 [001] d..1.  1363.318992: kvm_exit:      reason 
EXTERNAL_INTERRUPT rip 0xfffff801a59020ec info 0 0
        CPU 0/KVM-11837 [001] d..1.  1363.319269: kvm_entry:      vcpu 0 
rip 0xfffff801a59020ec
        CPU 0/KVM-11837 [001] d..1.  1363.319992: kvm_exit:      reason 
EXTERNAL_INTERRUPT rip 0xfffff801a59020ec info 0 0
        CPU 0/KVM-11837 [001] d..1.  1363.319994: kvm_entry:      vcpu 0 
rip 0xfffff801a59020ec

I did not spot anything useful in the dmesg/journalctl output.

I also did the same tests with mainline kernel
7.1.0-rc3 with v6 MBEC/GMET (patches 1-22 of 28) and v3 hrtimer [0]
and got the same results.

Best regards,
David

[0] https://lore.kernel.org/all/20260423155611.216805954@infradead.org




  reply	other threads:[~2026-05-19  8:02 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-05 19:51 Paolo Bonzini
2026-05-05 19:51 ` [PATCH 01/28] KVM: TDX/VMX: rework EPT_VIOLATION_EXEC_FOR_RING3_LIN into PROT_MASK Paolo Bonzini
2026-06-02 14:19   ` mlevitsk
2026-05-05 19:52 ` [PATCH 02/28] KVM: x86/mmu: remove SPTE_PERM_MASK Paolo Bonzini
2026-06-02 14:20   ` mlevitsk
2026-05-05 19:52 ` [PATCH 03/28] KVM: x86/mmu: free up bit 10 of PTEs in preparation for MBEC Paolo Bonzini
2026-06-02 14:20   ` mlevitsk
2026-05-05 19:52 ` [PATCH 04/28] KVM: x86/mmu: shuffle high bits of SPTEs " Paolo Bonzini
2026-06-02 14:20   ` mlevitsk
2026-05-05 19:52 ` [PATCH 05/28] KVM: x86/mmu: remove SPTE_EPT_* Paolo Bonzini
2026-06-02 14:21   ` mlevitsk
2026-05-05 19:52 ` [PATCH 06/28] KVM: x86/mmu: merge make_spte_{non,}executable Paolo Bonzini
2026-06-02 14:22   ` mlevitsk
2026-05-05 19:52 ` [PATCH 07/28] KVM: x86/mmu: rename and clarify BYTE_MASK Paolo Bonzini
2026-06-02 14:22   ` mlevitsk
2026-05-05 19:52 ` [PATCH 08/28] KVM: x86/mmu: separate more EPT/non-EPT permission_fault() Paolo Bonzini
2026-05-07 14:35   ` Sean Christopherson
2026-06-02 14:22   ` mlevitsk
2026-05-05 19:52 ` [PATCH 09/28] KVM: x86/mmu: introduce ACC_READ_MASK Paolo Bonzini
2026-06-02 14:23   ` mlevitsk
2026-05-05 19:52 ` [PATCH 10/28] KVM: x86/mmu: pass PFERR_GUEST_PAGE/FINAL_MASK to kvm_translate_gpa Paolo Bonzini
2026-06-02 14:23   ` mlevitsk
2026-05-05 19:52 ` [PATCH 11/28] KVM: x86/mmu: pass pte_access for final nGPA->GPA walk Paolo Bonzini
2026-06-02 14:24   ` mlevitsk
2026-05-05 19:52 ` [PATCH 12/28] KVM: x86: make translate_nested_gpa vendor-specific Paolo Bonzini
2026-06-02 14:24   ` mlevitsk
2026-05-05 19:52 ` [PATCH 13/28] KVM: x86/mmu: split XS/XU bits for EPT Paolo Bonzini
2026-06-02 14:24   ` mlevitsk
2026-05-05 19:52 ` [PATCH 14/28] KVM: x86/mmu: move cr4_smep to base role Paolo Bonzini
2026-06-02 14:25   ` mlevitsk
2026-05-05 19:52 ` [PATCH 15/28] KVM: VMX: enable use of MBEC Paolo Bonzini
2026-05-07 14:40   ` Sean Christopherson
2026-06-02 14:26   ` mlevitsk
2026-05-05 19:52 ` [PATCH 16/28] KVM: nVMX: pass advanced EPT violation vmexit info to guest Paolo Bonzini
2026-06-02 14:26   ` mlevitsk
2026-05-05 19:52 ` [PATCH 17/28] KVM: nVMX: pass PFERR_USER_MASK to MMU on EPT violations Paolo Bonzini
2026-06-02 14:27   ` mlevitsk
2026-05-05 19:52 ` [PATCH 18/28] KVM: x86/mmu: add support for MBEC to EPT page table walks Paolo Bonzini
2026-06-02 14:28   ` mlevitsk
2026-05-05 19:52 ` [PATCH 19/28] KVM: nVMX: advertise MBEC to nested guests Paolo Bonzini
2026-06-02 14:28   ` mlevitsk
2026-05-05 19:52 ` [PATCH 20/28] KVM: nVMX: allow MBEC with EVMCS Paolo Bonzini
2026-06-02 14:28   ` mlevitsk
2026-06-02 15:29     ` Vitaly Kuznetsov
2026-05-05 19:52 ` [PATCH 21/28] KVM: x86/mmu: propagate access mask from root pages down Paolo Bonzini
2026-06-02 14:29   ` mlevitsk
2026-05-05 19:52 ` [PATCH 22/28] KVM: x86/mmu: introduce cpu_role bit for availability of PFEC.I/D Paolo Bonzini
2026-06-02 14:29   ` mlevitsk
2026-05-05 19:52 ` [PATCH 23/28] KVM: SVM: add GMET bit definitions Paolo Bonzini
2026-06-02 14:30   ` mlevitsk
2026-05-05 19:52 ` [PATCH 24/28] KVM: x86/mmu: hard code more bits in kvm_init_shadow_npt_mmu Paolo Bonzini
2026-06-02 14:30   ` mlevitsk
2026-05-05 19:52 ` [PATCH 25/28] KVM: x86/mmu: add support for GMET to NPT page table walks Paolo Bonzini
2026-06-02 14:31   ` mlevitsk
2026-05-05 19:52 ` [PATCH 26/28] KVM: SVM: enable GMET and set it in MMU role Paolo Bonzini
2026-06-02 14:31   ` mlevitsk
2026-05-05 19:52 ` [PATCH 27/28] KVM: SVM: work around errata 1218 Paolo Bonzini
2026-06-02 14:31   ` mlevitsk
2026-05-05 19:52 ` [PATCH 28/28] KVM: nSVM: enable GMET for guests Paolo Bonzini
2026-06-02 14:32   ` mlevitsk
2026-05-07 14:44 ` [PATCH v6 00/28] KVM: combined patchset for MBEC/GMET support Sean Christopherson
2026-05-07 17:49   ` Paolo Bonzini
2026-05-11 10:53 ` David Riley
2026-05-11 10:55   ` Paolo Bonzini
2026-05-11 11:07     ` David Riley
2026-05-14  2:11       ` Chao Gao
2026-05-14 19:13         ` Sean Christopherson
2026-05-12 14:32   ` Paolo Bonzini
2026-05-12 16:34     ` Paolo Bonzini
2026-05-15 14:53     ` David Riley
2026-05-15 18:31       ` Sean Christopherson
2026-05-19  8:02         ` David Riley [this message]
2026-08-05 12:35 ` Jonas Theisen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78b03260-856a-4cce-a178-493e248dcbc9@proxmox.com \
    --to=d.riley@proxmox.com \
    --cc=chao.gao@intel.com \
    --cc=jon@nutanix.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®