mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baoquan He <baoquan.he@linux.dev>
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: "Nhat Pham" <nphamcs@gmail.com>,
	"Kairui Song" <kasong@tencent.com>,
	"Chris Li" <chrisl@kernel.org>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Michal Hocko" <mhocko@kernel.org>,
	"Roman Gushchin" <roman.gushchin@linux.dev>,
	"Yosry Ahmed" <yosry@kernel.org>,
	"David Hildenbrand" <david@kernel.org>,
	"Muchun Song" <muchun.song@linux.dev>,
	"Kemeng Shi" <shikemeng@huaweicloud.com>,
	"Barry Song" <baohua@kernel.org>,
	"YoungJun Park" <youngjun.park@lge.com>,
	"Chengming Zhou" <chengming.zhou@linux.dev>,
	"Lorenzo Stoakes (Oracle)" <ljs@kernel.org>,
	"Liam R. Howlett" <liam@infradead.org>,
	"Vlastimil Babka (SUSE)" <vbabka@kernel.org>,
	"Mike Rapoport" <rppt@kernel.org>,
	"Suren Baghdasaryan" <surenb@google.com>,
	"Qi Zheng" <qi.zheng@linux.dev>,
	"Axel Rasmussen" <axelrasmussen@google.com>,
	"Yuanchu Xie" <yuanchu@google.com>, "Wei Xu" <weixugc@google.com>,
	"Rik van Riel" <riel@surriel.com>,
	"Gregory Price" <gourry@gourry.net>,
	"Wenchao Hao" <haowenchao22@gmail.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Hugh Dickins" <hughd@google.com>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Tejun Heo" <tj@kernel.org>, "Michal Koutný" <mkoutny@suse.com>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Kunwu Chan" <kunwu.chan@linux.dev>,
	"Meta kernel team" <kernel-team@meta.com>,
	"Linux Memory Management List" <linux-mm@kvack.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-doc@vger.kernel.org,
	"open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)"
	<cgroups@vger.kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Kairui Song" <ryncsn@gmail.com>,
	"Joshua Hahn" <joshua.hahnjy@gmail.com>
Subject: Re: Path forward for Virtualized Swap?
Date: Tue, 15 Sep 2026 13:48:05 +0800	[thread overview]
Message-ID: <aqjcFb6MFNiA6n4V@fedora> (raw)
In-Reply-To: <aqQrPLPXHXiuKup0@linux.dev>

On 09/11/26 at 09:45am, Shakeel Butt wrote:
> On Fri, Sep 11, 2026 at 09:06:29PM +0800, Baoquan He wrote:
> > On 09/10/26 at 09:39am, Shakeel Butt wrote:
> > > On Thu, Sep 10, 2026 at 03:09:59PM +0800, Baoquan He wrote:
> > > > Hi Nhat,
> > > > 
> > > > On 09/04/26 at 02:14pm, Nhat Pham wrote:
> > > > .....snip...
> > > 
> > > [...]
> > > 
> > > > With VM_SPARSE, xswap's cluster access is exactly the plain-array line the
> > > > rest of swap already uses:
> > > > 
> > > >     return &si->cluster_info[offset / SWAPFILE_CLUSTER];
> > > > 
> > > > no branch, no RCU discipline, no tear-down state machine, and no NULL
> > > > return. So VM_SPARSE doesn't add complexity to close a gap; it lets the
> > > > cluster layer stay as simple as it already is, which is precisely the
> > > > part later work (writeback, rmap lookup, memcg charging, THP) has to sit
> > > > on.
> > > > 
> > > > I'm not going to claim xswap wins on throughput. I measured it:
> > > > on a 64G/64-thread swapout, xswap, vswap and plain swap+zswap are all
> > > > within ~2-3% of each other, effectively identical. 
> > > 
> > > So the claim is VM_SPARSE is simpler than xarray based approach. I feel like
> > > we are discussing implementation details before deciding the design and
> > > architecture. So, instead of VM_SPARSE vs xarray, let's discuss and decide the
> > > need for dynamic growth. Why we want dynamic growth upfront or can it be added
> > > later? Once we decide that then it will be very easy to pick an implementation
> > > that would take us there.
> > 
> > Hi Shakeel,
> > 
> > Thank you for joining the discussion and for taking the time to comment.
> 
> Hi Baoquan,
> 
> I am mainly trying to facilitate the discussion but your use of LLM is causing
> more confusion. LLM use is fine but please at least re-read before sending that
> the sentences flow and makes sense.

Sorry, my bad. I used LLM to find Nhat's words. But I did check it by
myself. I wrote most of them by myself. While at it ath the moment, my
logic could be unclear.

As said, how swap_cluster_info[] is built is the foundation. Whatever
you do, you have to make swap_cluster_info[] ready, then you can do
writeback, rmap lookup, thp support, etc, on top of it.
swap_cluster_info[] is the basement, then you continue building 2nd
floor, 3rd floor, till a high building is done with things added. Nobody
wants to claim he just need the high building, while no basement.

Now, the foundation has been built with the lazy vmalloc, it can grow on
demand. It keeps swap_cluster_info accessing as swap_cluster_info[],
a basic array semantics. And since we our target is to support a very
large swap device with an extendable logical space, grow on demand and
shrink becomes important. Now it is there.

That's my understanding, not sure if there's anything I can't get so
that writeback need be made first.

[I type each of above by hand.]
> 
> > 
> > Agreed on requirement first - but this one was already decided, and not by me. In
> > the July ghost swapfile thread Nhat rejected exactly the shape of "grow only, can
> > be added later":
> > 
> >     "Except for my virtual swap design, which does support dynamic growth AND
> >      shrinking of capacity on demand ;) If it cannot grow (and furthermore, if it
> >      requires userspace operation to trigger swapfile growth), why do we need this
> >      at all? Might as well create a new swapfile with swapon?"
> > 
> > To me what it converged on was "dynamic growth and shrink, no writeback yet".
> 
> I am not getting how out of context above paragraph shows the conclusion about
> dynamic growth/shrink and *no writeback*.
> 
> > So automatic growth *and* shrink is the requirement, and the simpler alternative
> > was already on the table.
> > 
> > And I keep mentioning it in the cover-letter of each version of my posting. I
> > only did the foundtation via lazy vmalloc. And Nhat will do the core
> > part including writabck, rmap lookup, memcg accounting, zero page fill,
> > etc.
> 
> I don't see any evidense of this decision. Actually this whole email thread
> shows that there is no such decision.
> 
> > 
> > What is still genuinely open, and I would like us to settle, is how large the
> > device's address space should be, because the metadata scales with it:
> 
> With dynamic growth/shrink, is this really a blocker?
> 
> Anyways, I will let Nhat and others discuss the technical details (unless I am
> asked for it). My main reason to join the conversation is to converge the
> discussion to a decision and resolution.

  reply	other threads:[~2026-09-15  5:48 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04 21:14 Nhat Pham
2026-09-07  5:51 ` Kairui Song
2026-09-08 16:36   ` Nhat Pham
2026-09-11 16:09     ` Kairui Song
2026-09-11 16:57       ` Nhat Pham
2026-09-11 18:14         ` Kairui Song
2026-09-11 19:03           ` Nhat Pham
2026-09-12  8:47             ` Kairui Song
2026-09-14 16:49               ` Nhat Pham
2026-09-08 18:30   ` Johannes Weiner
2026-09-09 16:41     ` Nhat Pham
2026-09-09 17:47       ` Nhat Pham
2026-09-12  9:00       ` Kairui Song
2026-09-12 11:51         ` Johannes Weiner
2026-09-14 16:10         ` Nhat Pham
2026-09-10 23:27   ` Nhat Pham
2026-09-07 11:30 ` David Hildenbrand (Arm)
2026-09-08 16:45   ` Nhat Pham
2026-09-10 10:56     ` David Hildenbrand (Arm)
2026-09-10 16:22       ` Nhat Pham
2026-09-10 17:57         ` David Hildenbrand (Arm)
2026-09-11 16:20         ` Kairui Song
2026-09-11 16:56           ` David Hildenbrand (Arm)
2026-09-14 15:00           ` Baoquan He
2026-09-10  7:09 ` Baoquan He
2026-09-10 16:39   ` Shakeel Butt
2026-09-11 13:06     ` Baoquan He
2026-09-11 16:45       ` Shakeel Butt
2026-09-15  5:48         ` Baoquan He [this message]
2026-09-15  6:44           ` Baoquan He
2026-09-10 17:03   ` Johannes Weiner
2026-09-11 12:27     ` Baoquan He
2026-09-11 16:21       ` Johannes Weiner
2026-09-10 17:16   ` Nhat Pham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqjcFb6MFNiA6n4V@fedora \
    --to=baoquan.he@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=cgroups@vger.kernel.org \
    --cc=chengming.zhou@linux.dev \
    --cc=chrisl@kernel.org \
    --cc=corbet@lwn.net \
    --cc=david@kernel.org \
    --cc=gourry@gourry.net \
    --cc=hannes@cmpxchg.org \
    --cc=haowenchao22@gmail.com \
    --cc=hughd@google.com \
    --cc=joshua.hahnjy@gmail.com \
    --cc=kasong@tencent.com \
    --cc=kernel-team@meta.com \
    --cc=kunwu.chan@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@kernel.org \
    --cc=mkoutny@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=nphamcs@gmail.com \
    --cc=qi.zheng@linux.dev \
    --cc=riel@surriel.com \
    --cc=roman.gushchin@linux.dev \
    --cc=rppt@kernel.org \
    --cc=ryncsn@gmail.com \
    --cc=shakeel.butt@linux.dev \
    --cc=shikemeng@huaweicloud.com \
    --cc=skhan@linuxfoundation.org \
    --cc=surenb@google.com \
    --cc=tj@kernel.org \
    --cc=vbabka@kernel.org \
    --cc=weixugc@google.com \
    --cc=yosry@kernel.org \
    --cc=youngjun.park@lge.com \
    --cc=yuanchu@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®