mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Robert Richter <rrichter@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Naveen N Rao (AMD)" <naveen@kernel.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Bharata B Rao <bharata@amd.com>,
	Manali Shukla <manali.shukla@amd.com>,
	Nikunj A Dadhania <nikunj@amd.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH RESEND v4 1/3] perf/amd/ibs: Limit the max EILVT register count for AMD family 0x10
Date: Mon, 21 Sep 2026 11:18:20 +0200	[thread overview]
Message-ID: <arD2XOBh5SQnKjof@rric.localdomain> (raw)
In-Reply-To: <20260919034035.GDaq4EM5Z41kzGVw1i@fat_crate.local>

On 18.09.26 20:40:35, Borislav Petkov wrote:
> On Thu, Sep 03, 2026 at 02:58:39PM +0530, Naveen N Rao (AMD) wrote:
> > For AMD family 0x10, EILVT offsets are not assigned by BIOS and is
> > instead assigned by picking the next available EILVT offset.  Use the
> > maximum EILVT count for family 0x10 (APIC_EILVT_NR_AMD_10H) rather than
> > an arbitrary maximum EILVT count when looking for the next available
> > EILVT offset.
> 
> Huh?
> 
> #define         APIC_EILVT_NR_MAX       APIC_EILVT_NR_AMD_10H

Right, found that too.

> 
> What is this "fixing"?

Nothing to do as long APIC_EILVT_NR_MAX does not change.

It shouldn't be sent as a standalone patch. Instead, embed it in a
broader change to keep it in that context.

-Robert

> 
> Also,
> 
> + Robert
> 
> who happens to know something about that code. Don't forget to use git
> annotate, do some git archeology and CC the relevant people on patches.
> 
> Leaving in the rest for him.
> 
> > Signed-off-by: Naveen N Rao (AMD) <naveen@kernel.org>
> > Tested-by: Manali Shukla <manali.shukla@amd.com>
> > ---
> >  arch/x86/events/amd/ibs.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)

  reply	other threads:[~2026-09-21  9:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03  9:28 [PATCH RESEND v4 0/3] x86/apic: Add support for additional AMD EILVT registers Naveen N Rao (AMD)
2026-09-03  9:28 ` [PATCH RESEND v4 1/3] perf/amd/ibs: Limit the max EILVT register count for AMD family 0x10 Naveen N Rao (AMD)
2026-09-19  3:40   ` Borislav Petkov
2026-09-21  9:18     ` Robert Richter [this message]
2026-09-22  5:26       ` Borislav Petkov
2026-09-03  9:28 ` [PATCH RESEND v4 2/3] x86/apic: Introduce a variable to track the number of EILVT registers Naveen N Rao (AMD)
2026-09-22  5:36   ` Borislav Petkov
2026-09-24 11:58     ` Naveen N Rao
2026-09-25  4:26       ` Borislav Petkov
2026-09-25 16:09         ` Naveen N Rao
2026-09-03  9:28 ` [PATCH RESEND v4 3/3] x86/apic: Drop APIC_EILVT_NR_MAX Naveen N Rao (AMD)
2026-09-07  5:16 ` [PATCH RESEND v4 0/3] x86/apic: Add support for additional AMD EILVT registers Bharata B Rao
2026-09-15  0:29 ` Borislav Petkov
2026-09-18  7:03   ` Ravi Bangoria
2026-09-19  1:46     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arD2XOBh5SQnKjof@rric.localdomain \
    --to=rrichter@amd.com \
    --cc=bharata@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manali.shukla@amd.com \
    --cc=mingo@redhat.com \
    --cc=naveen@kernel.org \
    --cc=nikunj@amd.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®