From: Reinette Chatre <reinette.chatre@intel.com>
To: Chen Yu <yu.c.chen@intel.com>
Cc: <tony.luck@intel.com>, <tglx@kernel.org>, <bp@alien8.de>,
<mingo@redhat.com>, <dave.hansen@linux.intel.com>,
<hpa@zytor.com>, <fenghuay@nvidia.com>, <babu.moger@amd.com>,
<hongyu.ning@intel.com>, <chen.yu@linux.dev>, <x86@kernel.org>,
<linux-kernel@vger.kernel.org>,
"Hongyu Ning" <hongyu.ning@linux.intel.com>
Subject: Re: [PATCH v9 12/12] x86/resctrl: Add MMIO-based LLC occupancy monitoring support
Date: Tue, 27 Oct 2026 09:21:56 -0700 [thread overview]
Message-ID: <d59c8bae-6429-4718-8653-117133462b49@intel.com> (raw)
In-Reply-To: <auCJh7ZOL8CSbgvv@chenyu-dev>
Hi Chenyu,
On 10/27/26 4:22 AM, Chen Yu wrote:
> Hi Reinette,
>
> On Fri, Oct 23, 2026 at 05:08:44PM -0700, Reinette Chatre wrote:
>> Hi Chenyu,
>>
>> On 10/13/26 8:01 PM, Chen Yu wrote:
>>> Add erdt_mon_read() to read LLC occupancy via MMIO and use it
>>> when the platform supports ERDT. Register the L3 occupancy event
>>> with ERDT enabled when available, falling back to the MSR-based
>>> path otherwise.
>>>
>>> Use the CMRC (Cache Monitoring Registers for CPU Agents Description)
>>> ACPI sub-table to read LLC occupancy counters for each RMID via MMIO
>>> when ERDT is enabled.
>>>
>>> Although the occupancy counters can now be read from any CPU via
>>> MMIO, keep the per-domain limbo handler. A global handler would
>>> still have to iterate over every domain and would save nr_domains - 1
>>
>> Please write what "nr_domains - 1" means in English since as it is written
>> it is not clear how this "does not justify maintaining two limbo handler
>> models."
>>
>
> OK, I'll rephrase it to a simpler version, how about this:
>
> Although the occupancy counters can now be read from any CPU via MMIO,
> keep the per domain limbo handler. A single global handler would still
> have to check the limbo RMIDs of every L3 domain, so it would do the same
> amount of work. The only saving would be running one limbo worker instead
> of one per L3 domain, which does not justify maintaining two limbo handler
> models.
ok. One nit, please let it start with "Keep the per domain limbo handler ...".
Thank you.
Reinette
next prev parent reply other threads:[~2026-10-27 16:22 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 2:56 [PATCH v9 00/12] Introduce MMIO-based CMT access for Enhanced RDT Chen Yu
2026-10-14 2:57 ` [PATCH v9 01/12] x86/topology: Export topo_lookup_cpuid() for resctrl use Chen Yu
2026-10-14 2:58 ` [PATCH v9 02/12] x86/resctrl: Require 64-bit x86 for resctrl support Chen Yu
2026-10-23 23:46 ` Reinette Chatre
2026-10-27 7:54 ` Chen Yu
2026-10-14 2:58 ` [PATCH v9 03/12] x86/resctrl: Parse ACPI ERDT table and save CACD cpumask per RMD Chen Yu
2026-10-23 23:50 ` Reinette Chatre
2026-10-27 8:14 ` Chen Yu
2026-10-14 2:58 ` [PATCH v9 04/12] x86/resctrl: Do not enable ERDT when Sub-NUMA Cluster is enabled Chen Yu
2026-10-23 23:54 ` Reinette Chatre
2026-10-27 8:54 ` Chen Yu
2026-10-27 16:16 ` Reinette Chatre
2026-10-28 2:44 ` Chen Yu
2026-10-14 2:58 ` [PATCH v9 05/12] x86/resctrl: Attach ACPI ERDT information to L3 mon domain on CPU online Chen Yu
2026-10-23 23:57 ` Reinette Chatre
2026-10-24 0:37 ` Reinette Chatre
2026-10-27 10:36 ` Chen Yu
2026-10-27 16:17 ` Reinette Chatre
2026-10-28 2:57 ` Chen Yu
2026-10-14 2:59 ` [PATCH v9 06/12] x86,fs/resctrl: Move resctrl_arch_round_mon_val() out of line Chen Yu
2026-10-23 23:59 ` Reinette Chatre
2026-10-27 10:39 ` Chen Yu
2026-10-14 2:59 ` [PATCH v9 07/12] x86/resctrl: Add a global ERDT monitor scale Chen Yu
2026-10-24 0:02 ` Reinette Chatre
2026-10-27 10:53 ` Chen Yu
2026-10-14 2:59 ` [PATCH v9 08/12] x86/resctrl: Parse ACPI CMRC table Chen Yu
2026-10-14 3:00 ` [PATCH v9 09/12] x86/resctrl: Refactor the monitor read function Chen Yu
2026-10-14 3:00 ` [PATCH v9 10/12] fs/resctrl: Do not invoke smp_processor_id() in preemptible context Chen Yu
2026-10-14 3:00 ` [PATCH v9 11/12] x86/resctrl: Introduce erdt_cpu_has() and erdt_support() Chen Yu
2026-10-14 3:01 ` [PATCH v9 12/12] x86/resctrl: Add MMIO-based LLC occupancy monitoring support Chen Yu
2026-10-24 0:08 ` Reinette Chatre
2026-10-27 11:22 ` Chen Yu
2026-10-27 16:21 ` Reinette Chatre [this message]
2026-10-28 2:59 ` Chen Yu
2026-10-19 12:45 ` [PATCH v9 00/12] Introduce MMIO-based CMT access for Enhanced RDT Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d59c8bae-6429-4718-8653-117133462b49@intel.com \
--to=reinette.chatre@intel.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=chen.yu@linux.dev \
--cc=dave.hansen@linux.intel.com \
--cc=fenghuay@nvidia.com \
--cc=hongyu.ning@intel.com \
--cc=hongyu.ning@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®