[PATCH v3] firmware: stratix10-svc: fix FCS SMC call kernel-doc

[PATCH v3] firmware: stratix10-svc: fix FCS SMC call kernel-doc

[genevieve.chan]

From: Genevieve Chan <genevieve.chan@altera.com>

Correct kernel-doc errors for two FCS SMC calls:

INTEL_SIP_SMC_FCS_SEND_CERTIFICATE:
- Describe as async to match STD_CALL_VAL usage
- Replace INTEL_SIP_SMC_FCS_REJECTED with INTEL_SIP_SMC_REJECTED

INTEL_SIP_SMC_FCS_GET_PROVISION_DATA:
- Replace FCS-specific status macros with standard status macros
  (INTEL_SIP_SMC_STATUS_ERROR and INTEL_SIP_SMC_STATUS_REJECTED)
- Restore return register documentation for a1 (mailbox error),
  a2 (physical address), and a3 (structure size)

Fixes: 4a4709d470e6 ("firmware: stratix10-svc: add new FCS commands")
Fixes: 4b0a32016347 ("firmware: stratix10-svc: change get provision data to async SMC call")
Cc: stable@vger.kernel.org # 6.0+
Signed-off-by: Genevieve Chan <genevieve.chan@altera.com>
---
Changes in v3:
- Use 12-character commit hashes in Fixes tags
- Remove 7.2+ stable Cc prerequisite line
- Use 6.0+ for stable Cc tag
- No changes in code
---
 include/linux/firmware/intel/stratix10-smc.h | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/include/linux/firmware/intel/stratix10-smc.h b/include/linux/firmware/intel/stratix10-smc.h
index 9116512169dc..2c603a24967f 100644
--- a/include/linux/firmware/intel/stratix10-smc.h
+++ b/include/linux/firmware/intel/stratix10-smc.h
@@ -606,7 +606,7 @@ INTEL_SIP_SMC_FAST_CALL_VAL(INTEL_SIP_SMC_FUNCID_FPGA_CONFIG_COMPLETED_WRITE)
 
 /**
  * Request INTEL_SIP_SMC_FUNCID_FCS_SEND_CERTIFICATE
- * Sync call to send a signed certificate
+ * Async call to send a signed certificate
  *
  * Call register usage:
  * a0 INTEL_SIP_SMC_FCS_SEND_CERTIFICATE
@@ -615,7 +615,7 @@ INTEL_SIP_SMC_FAST_CALL_VAL(INTEL_SIP_SMC_FUNCID_FPGA_CONFIG_COMPLETED_WRITE)
  * a3-a7 not used
  *
  * Return status:
- * a0 INTEL_SIP_SMC_STATUS_OK or INTEL_SIP_SMC_FCS_REJECTED
+ * a0 INTEL_SIP_SMC_STATUS_OK or INTEL_SIP_SMC_REJECTED
  * a1-a3 not used
  */
 #define INTEL_SIP_SMC_FUNCID_FCS_SEND_CERTIFICATE 93
@@ -631,9 +631,11 @@ INTEL_SIP_SMC_FAST_CALL_VAL(INTEL_SIP_SMC_FUNCID_FPGA_CONFIG_COMPLETED_WRITE)
  * a1-a7 not used
  *
  * Return status:
- * a0 INTEL_SIP_SMC_STATUS_OK, INTEL_SIP_SMC_FCS_ERROR or
- *      INTEL_SIP_SMC_FCS_REJECTED
- * a1-a3 not used
+ * a0 INTEL_SIP_SMC_STATUS_OK, INTEL_SIP_SMC_STATUS_ERROR or
+ *	INTEL_SIP_SMC_STATUS_REJECTED
+ * a1 mailbox error if a0 is INTEL_SIP_SMC_STATUS_ERROR
+ * a2 physical address for the structure of fuse and key hashes
+ * a3 the size of structure
  *
  */
 #define INTEL_SIP_SMC_FUNCID_FCS_GET_PROVISION_DATA 94
-- 
2.43.7

Re: [PATCH v3] firmware: stratix10-svc: fix FCS SMC call kernel-doc

[Dinh Nguyen]

On 7/6/26 00:55, genevieve.chan@altera.com wrote:
> From: Genevieve Chan <genevieve.chan@altera.com>
> 
> Correct kernel-doc errors for two FCS SMC calls:
> 
> INTEL_SIP_SMC_FCS_SEND_CERTIFICATE:
> - Describe as async to match STD_CALL_VAL usage
> - Replace INTEL_SIP_SMC_FCS_REJECTED with INTEL_SIP_SMC_REJECTED
> 
> INTEL_SIP_SMC_FCS_GET_PROVISION_DATA:
> - Replace FCS-specific status macros with standard status macros
>    (INTEL_SIP_SMC_STATUS_ERROR and INTEL_SIP_SMC_STATUS_REJECTED)
> - Restore return register documentation for a1 (mailbox error),
>    a2 (physical address), and a3 (structure size)
> 
> Fixes: 4a4709d470e6 ("firmware: stratix10-svc: add new FCS commands")
> Fixes: 4b0a32016347 ("firmware: stratix10-svc: change get provision data to async SMC call")

I see how this patch fixes 4a4709d470e6 but I don't see how this patch 
fixes 4b0a32016347. Can you justify how it fixes the second commit?

Thanks,
Dinh

Re: [PATCH v3] firmware: stratix10-svc: fix FCS SMC call kernel-doc

[Chan, Genevieve]

On 6/7/2026 9:56 pm, Dinh Nguyen wrote:
> 
> 
> On 7/6/26 00:55, genevieve.chan@altera.com wrote:
>> From: Genevieve Chan <genevieve.chan@altera.com>
>>
>> Correct kernel-doc errors for two FCS SMC calls:
>>
>> INTEL_SIP_SMC_FCS_SEND_CERTIFICATE:
>> - Describe as async to match STD_CALL_VAL usage
>> - Replace INTEL_SIP_SMC_FCS_REJECTED with INTEL_SIP_SMC_REJECTED
>>
>> INTEL_SIP_SMC_FCS_GET_PROVISION_DATA:
>> - Replace FCS-specific status macros with standard status macros
>>    (INTEL_SIP_SMC_STATUS_ERROR and INTEL_SIP_SMC_STATUS_REJECTED)
>> - Restore return register documentation for a1 (mailbox error),
>>    a2 (physical address), and a3 (structure size)
>>
>> Fixes: 4a4709d470e6 ("firmware: stratix10-svc: add new FCS commands")
>> Fixes: 4b0a32016347 ("firmware: stratix10-svc: change get provision data to async SMC call")
> 
> I see how this patch fixes 4a4709d470e6 but I don't see how this patch fixes 4b0a32016347. Can you justify how it fixes the second commit?

Hi Dinh,

The fixes for 4b0a32016347 includes modifying the original macro definition description section for register a1-a3 as well as the return status description of the INTEL_SIP_SMC_FCS_GET_PROVISION_DATA cmd.

Thanks,
Genevieve Chan

> 
> Thanks,
> Dinh

Re: [PATCH v3] firmware: stratix10-svc: fix FCS SMC call kernel-doc

[Dinh Nguyen]

On 7/7/26 00:02, Chan, Genevieve wrote:
> On 6/7/2026 9:56 pm, Dinh Nguyen wrote:
>>
>>
>> On 7/6/26 00:55, genevieve.chan@altera.com wrote:
>>> From: Genevieve Chan <genevieve.chan@altera.com>
>>>
>>> Correct kernel-doc errors for two FCS SMC calls:
>>>
>>> INTEL_SIP_SMC_FCS_SEND_CERTIFICATE:
>>> - Describe as async to match STD_CALL_VAL usage
>>> - Replace INTEL_SIP_SMC_FCS_REJECTED with INTEL_SIP_SMC_REJECTED
>>>
>>> INTEL_SIP_SMC_FCS_GET_PROVISION_DATA:
>>> - Replace FCS-specific status macros with standard status macros
>>>    (INTEL_SIP_SMC_STATUS_ERROR and INTEL_SIP_SMC_STATUS_REJECTED)
>>> - Restore return register documentation for a1 (mailbox error),
>>>    a2 (physical address), and a3 (structure size)
>>>
>>> Fixes: 4a4709d470e6 ("firmware: stratix10-svc: add new FCS commands")
>>> Fixes: 4b0a32016347 ("firmware: stratix10-svc: change get provision 
>>> data to async SMC call")
>>
>> I see how this patch fixes 4a4709d470e6 but I don't see how this patch 
>> fixes 4b0a32016347. Can you justify how it fixes the second commit?
> 
> Hi Dinh,
> 
> The fixes for 4b0a32016347 includes modifying the original macro 
> definition description section for register a1-a3 as well as the return 
> status description of the INTEL_SIP_SMC_FCS_GET_PROVISION_DATA cmd.
> 

Applied!

Thanks,
Dinh