[PATCH 0/7] ARM: dts: artpec: cleanup with the help of dt-check-style

[PATCH 0/7] ARM: dts: artpec: cleanup with the help of dt-check-style

[Henrik Grimler]

Fix most of the warnings that are reported by
scripts/dtc/dt-check-style, to make the files use the preferred
style. By doing so the files become easier to read and maintain.

Sorting of nodes have been left out from this patchset, as that
creates a huge, un-reviewable, patch. After the patches some warnings
remain when dt-check-style (with Krzysztof's recent fixes [1]) is run
in strict mode:

  axis/artpec6.dtsi:77: [child-name-order] child node 'psci' out of name order
  axis/artpec6.dtsi:80: [property-name] property name "psci_version" is using discouraged style
  axis/artpec6.dtsi:82: [property-name] property name "system_reset" is using discouraged style
  axis/artpec6.dtsi:91: [child-name-order] child node 'ext-clk' out of name order
  axis/artpec6.dtsi:97: [child-name-order] child node 'eth-phy-ref-clk' out of name order
  axis/artpec6.dtsi:103: [child-name-order] child node 'clkctrl' out of name order
  axis/artpec6.dtsi:127: [child-name-order] child node 'interrupt-controller' out of name order
  axis/artpec6.dtsi:134: [child-name-order] child node 'cache-controller' out of name order
  axis/artpec6.dtsi:163: [child-name-order] child node 'pcie' out of name order
  axis/artpec6.dtsi:233: [child-name-order] child node 'amba' out of name order
  axis/artpec6.dtsi:292: [child-address-order] child node @f8010000 out of address order
  axis/artpec6.dtsi:314: [property-name] property name "snps,wr_osr_lmt" is using discouraged style
  axis/artpec6.dtsi:315: [property-name] property name "snps,rd_osr_lmt" is using discouraged style
  axis/artpec6.dtsi:324: [child-name-order] child node 'rx-queues-config' out of name order

Fixing these are left for the future.

[1] https://github.com/krzk/linux/tree/b4/dts-style-checker-blank-lines

Signed-off-by: Henrik Grimler <henrik@grimler.se>
---
Henrik Grimler (7):
      ARM: dts: axis: artpec6: avoid _ in node names
      ARM: dts: axis: artpec6: align all continued lines
      ARM: dts: axis: artpec6: use multiple tuples in regs and ranges
      ARM: dts: axis: artpec6: sort all properties
      ARM: dts: axis: artpec6: add more blank lines
      ARM: dts: axis: artpec6: put inline comments on same line as entries
      ARM: dts: axis: artpec6: add empty lines before empty queue nodes

 arch/arm/boot/dts/axis/artpec6-devboard.dts |   9 +--
 arch/arm/boot/dts/axis/artpec6.dtsi         | 100 ++++++++++++++++------------
 2 files changed, 64 insertions(+), 45 deletions(-)
---
base-commit: f5f84daefcd92d7a630066635ecea1433ed5eac7
change-id: 20260928-b4-artpec6-cleanup-3dfb30a26b9d

Best regards,
--  
Henrik Grimler <henrik.grimler@axis.com>

[PATCH 1/7] ARM: dts: axis: artpec6: avoid _ in node names

[Henrik Grimler]

Node names should preferably not use _, use - instead. Fixes
dt-check-style strict mode warnings:

  axis/artpec6.dtsi:91: [node-name] node name "ext_clk" is using discouraged style
  axis/artpec6.dtsi:97: [node-name] node name "eth_phy_ref_clk" is using discouraged style
  axis/artpec6.dtsi:189: [node-name] node name "pcie_ep" is using discouraged style

Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
 arch/arm/boot/dts/axis/artpec6.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/axis/artpec6.dtsi b/arch/arm/boot/dts/axis/artpec6.dtsi
index 037157e6c5ee..ce642dcc754e 100644
--- a/arch/arm/boot/dts/axis/artpec6.dtsi
+++ b/arch/arm/boot/dts/axis/artpec6.dtsi
@@ -88,13 +88,13 @@ scu@faf00000 {
 	};
 
 	/* Main external clock driving CPU and peripherals */
-	ext_clk: ext_clk {
+	ext_clk: ext-clk {
 		#clock-cells = <0>;
 		compatible = "fixed-clock";
 		clock-frequency = <50000000>;
 	};
 
-	eth_phy_ref_clk: eth_phy_ref_clk {
+	eth_phy_ref_clk: eth-phy-ref-clk {
 		#clock-cells = <0>;
 		compatible = "fixed-clock";
 		clock-frequency = <125000000>;
@@ -186,7 +186,7 @@ pcie: pcie@f8050000 {
 		status = "disabled";
 	};
 
-	pcie_ep: pcie_ep@f8050000 {
+	pcie_ep: pcie-ep@f8050000 {
 		compatible = "axis,artpec6-pcie-ep", "snps,dw-pcie";
 		reg = <0xf8050000 0x2000
 		       0xf8051000 0x2000

-- 
2.43.0

[PATCH 2/7] ARM: dts: axis: artpec6: align all continued lines

[Henrik Grimler]

dt-check-style in strict mode reports that there are a bunch of
multiline properties that are not aligned, fix them to make the dts
easier to follow. Fixes dt-check-style warnings like:

  axis/artpec6.dtsi:290: [continuation-alignment] continuation should align to column 34 (to < or ")

Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
 arch/arm/boot/dts/axis/artpec6.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/axis/artpec6.dtsi b/arch/arm/boot/dts/axis/artpec6.dtsi
index ce642dcc754e..d6610f62ca25 100644
--- a/arch/arm/boot/dts/axis/artpec6.dtsi
+++ b/arch/arm/boot/dts/axis/artpec6.dtsi
@@ -151,7 +151,7 @@ pl310: cache-controller@faf10000 {
 	pmu {
 		compatible = "arm,cortex-a9-pmu";
 		interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
-			<GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
+			     <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-affinity = <&cpu0>, <&cpu1>;
 	};
 
@@ -287,7 +287,7 @@ dma1: dma@f8019400 {
 		ethernet: ethernet@f8010000 {
 			clock-names = "stmmaceth", "ptp_ref";
 			clocks = <&clkctrl ARTPEC6_CLK_ETH_ACLK>,
-				<&clkctrl ARTPEC6_CLK_PTP_REF>;
+				 <&clkctrl ARTPEC6_CLK_PTP_REF>;
 			compatible = "snps,dwmac-4.10a", "snps,dwmac";
 			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
@@ -333,7 +333,7 @@ uart0: serial@f8036000 {
 			reg = <0xf8036000 0x1000>;
 			interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clkctrl ARTPEC6_CLK_UART_REFCLK>,
-				<&clkctrl ARTPEC6_CLK_UART_PCLK>;
+				 <&clkctrl ARTPEC6_CLK_UART_PCLK>;
 			clock-names = "uart_clk", "apb_pclk";
 			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_uart0>;
@@ -347,7 +347,7 @@ uart1: serial@f8037000 {
 			reg = <0xf8037000 0x1000>;
 			interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clkctrl ARTPEC6_CLK_UART_REFCLK>,
-				<&clkctrl ARTPEC6_CLK_UART_PCLK>;
+				 <&clkctrl ARTPEC6_CLK_UART_PCLK>;
 			clock-names = "uart_clk", "apb_pclk";
 			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_uart1>;
@@ -361,7 +361,7 @@ uart2: serial@f8038000 {
 			reg = <0xf8038000 0x1000>;
 			interrupts = <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clkctrl ARTPEC6_CLK_UART_REFCLK>,
-				<&clkctrl ARTPEC6_CLK_UART_PCLK>;
+				 <&clkctrl ARTPEC6_CLK_UART_PCLK>;
 			clock-names = "uart_clk", "apb_pclk";
 			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_uart2>;
@@ -375,7 +375,7 @@ uart3: serial@f8039000 {
 			reg = <0xf8039000 0x1000>;
 			interrupts = <GIC_SPI 129 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clkctrl ARTPEC6_CLK_UART_REFCLK>,
-				<&clkctrl ARTPEC6_CLK_UART_PCLK>;
+				 <&clkctrl ARTPEC6_CLK_UART_PCLK>;
 			clock-names = "uart_clk", "apb_pclk";
 			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_uart3>;

-- 
2.43.0

[PATCH 3/7] ARM: dts: axis: artpec6: use multiple tuples in regs and ranges

[Henrik Grimler]

When #size-cells > 1 it is preferred to have each entry as its own
tuple, to make it easier to identify addresses and sizes. Update
artpec6.dtsi to use preferred style to increase readability.

Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
 arch/arm/boot/dts/axis/artpec6.dtsi | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/axis/artpec6.dtsi b/arch/arm/boot/dts/axis/artpec6.dtsi
index d6610f62ca25..49439058854d 100644
--- a/arch/arm/boot/dts/axis/artpec6.dtsi
+++ b/arch/arm/boot/dts/axis/artpec6.dtsi
@@ -161,17 +161,17 @@ pmu {
 	 */
 	pcie: pcie@f8050000 {
 		compatible = "axis,artpec6-pcie", "snps,dw-pcie";
-		reg = <0xf8050000 0x2000
-		       0xf8040000 0x1000
-		       0xc0000000 0x2000>;
+		reg = <0xf8050000 0x2000>,
+		      <0xf8040000 0x1000>,
+		      <0xc0000000 0x2000>;
 		reg-names = "dbi", "phy", "config";
 		#address-cells = <3>;
 		#size-cells = <2>;
 		device_type = "pci";
 			  /* downstream I/O */
-		ranges = <0x81000000 0 0 0xc0002000 0 0x00010000
+		ranges = <0x81000000 0 0 0xc0002000 0 0x00010000>,
 			  /* non-prefetchable memory */
-			  0x82000000 0 0xc0012000 0xc0012000 0 0x1ffee000>;
+			 <0x82000000 0 0xc0012000 0xc0012000 0 0x1ffee000>;
 		num-lanes = <2>;
 		bus-range = <0x00 0xff>;
 		interrupts = <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>;
@@ -188,10 +188,10 @@ pcie: pcie@f8050000 {
 
 	pcie_ep: pcie-ep@f8050000 {
 		compatible = "axis,artpec6-pcie-ep", "snps,dw-pcie";
-		reg = <0xf8050000 0x2000
-		       0xf8051000 0x2000
-		       0xf8040000 0x1000
-		       0xc0000000 0x20000000>;
+		reg = <0xf8050000 0x2000>,
+		      <0xf8051000 0x2000>,
+		      <0xf8040000 0x1000>,
+		      <0xc0000000 0x20000000>;
 		reg-names = "dbi", "dbi2", "phy", "addr_space";
 		num-ib-windows = <6>;
 		num-ob-windows = <2>;

-- 
2.43.0

[PATCH 4/7] ARM: dts: axis: artpec6: sort all properties

[Henrik Grimler]

To make as easy as possible to read devicetree nodes, the properties
should be alphabetical, with a few exceptions (compatible, reg,
status, ..). Update the artpec-6 dtses to use preferred style. Issues
are detected by dt-check-style when run in strict mode as:

  axis/artpec6.dtsi:93: [property-order] property 'compatible' out of canonical order (should sort before '#clock-cells')

Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
 arch/arm/boot/dts/axis/artpec6-devboard.dts |  8 +++---
 arch/arm/boot/dts/axis/artpec6.dtsi         | 40 ++++++++++++++---------------
 2 files changed, 24 insertions(+), 24 deletions(-)

diff --git a/arch/arm/boot/dts/axis/artpec6-devboard.dts b/arch/arm/boot/dts/axis/artpec6-devboard.dts
index 042a9cc920c6..9a91f9758442 100644
--- a/arch/arm/boot/dts/axis/artpec6-devboard.dts
+++ b/arch/arm/boot/dts/axis/artpec6-devboard.dts
@@ -46,18 +46,18 @@ &pcie {
 };
 
 &ethernet {
-	status = "okay";
-
 	phy-handle = <&phy1>;
 	phy-mode = "gmii";
 
+	status = "okay";
+
 	mdio {
+		compatible = "snps,dwmac-mdio";
 		#address-cells = <0x1>;
 		#size-cells = <0x0>;
-		compatible = "snps,dwmac-mdio";
 		phy1: phy@0 {
-			compatible = "ethernet-phy-ieee802.3-c22";
 			device_type = "ethernet-phy";
+			compatible = "ethernet-phy-ieee802.3-c22";
 			reg = <0x0>;
 		};
 	};
diff --git a/arch/arm/boot/dts/axis/artpec6.dtsi b/arch/arm/boot/dts/axis/artpec6.dtsi
index 49439058854d..d3079badcf21 100644
--- a/arch/arm/boot/dts/axis/artpec6.dtsi
+++ b/arch/arm/boot/dts/axis/artpec6.dtsi
@@ -45,9 +45,9 @@
 #include <dt-bindings/clock/axis,artpec6-clkctrl.h>
 
 / {
+	compatible = "axis,artpec6";
 	#address-cells = <1>;
 	#size-cells = <1>;
-	compatible = "axis,artpec6";
 	interrupt-parent = <&intc>;
 
 	cpus {
@@ -89,21 +89,21 @@ scu@faf00000 {
 
 	/* Main external clock driving CPU and peripherals */
 	ext_clk: ext-clk {
-		#clock-cells = <0>;
 		compatible = "fixed-clock";
+		#clock-cells = <0>;
 		clock-frequency = <50000000>;
 	};
 
 	eth_phy_ref_clk: eth-phy-ref-clk {
-		#clock-cells = <0>;
 		compatible = "fixed-clock";
+		#clock-cells = <0>;
 		clock-frequency = <125000000>;
 	};
 
 	clkctrl: clkctrl@f8000000 {
-		#clock-cells = <1>;
 		compatible = "axis,artpec6-clkctrl";
 		reg = <0xf8000000 0x48>;
+		#clock-cells = <1>;
 		clocks = <&ext_clk>;
 		clock-names = "sys_refclk";
 	};
@@ -124,26 +124,26 @@ timer@faf00600 {
 	};
 
 	intc: interrupt-controller@faf01000 {
-		interrupt-controller;
 		compatible = "arm,cortex-a9-gic";
+		reg = <0xfaf01000 0x1000>, <0xfaf00100 0x0100>;
+		interrupt-controller;
 		#interrupt-cells = <3>;
-		reg = < 0xfaf01000 0x1000 >, < 0xfaf00100 0x0100 >;
 	};
 
 	pl310: cache-controller@faf10000 {
 		compatible = "arm,pl310-cache";
+		reg = <0xfaf10000 0x1000>;
 		cache-unified;
 		cache-level = <2>;
-		reg = <0xfaf10000 0x1000>;
 		interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
+		prefetch-data = <1>;
+		prefetch-instr = <1>;
 		arm,data-latency = <1 1 1>;
 		arm,tag-latency = <1 1 1>;
 		arm,filter-ranges = <0x0 0x80000000>;
 		arm,double-linefill = <1>;
 		arm,double-linefill-incr = <0>;
 		arm,double-linefill-wrap = <0>;
-		prefetch-data = <1>;
-		prefetch-instr = <1>;
 		arm,prefetch-offset = <0>;
 		arm,prefetch-drop = <1>;
 	};
@@ -160,18 +160,18 @@ pmu {
 	 * leave the unwanted node as disabled.
 	 */
 	pcie: pcie@f8050000 {
+		device_type = "pci";
 		compatible = "axis,artpec6-pcie", "snps,dw-pcie";
 		reg = <0xf8050000 0x2000>,
 		      <0xf8040000 0x1000>,
 		      <0xc0000000 0x2000>;
 		reg-names = "dbi", "phy", "config";
-		#address-cells = <3>;
-		#size-cells = <2>;
-		device_type = "pci";
 			  /* downstream I/O */
 		ranges = <0x81000000 0 0 0xc0002000 0 0x00010000>,
 			  /* non-prefetchable memory */
 			 <0x82000000 0 0xc0012000 0xc0012000 0 0x1ffee000>;
+		#address-cells = <3>;
+		#size-cells = <2>;
 		num-lanes = <2>;
 		bus-range = <0x00 0xff>;
 		interrupts = <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>;
@@ -228,9 +228,9 @@ pinctrl_uart3: uart3grp {
 
 	amba@0 {
 		compatible = "simple-bus";
+		ranges;
 		#address-cells = <0x1>;
 		#size-cells = <0x1>;
-		ranges;
 		dma-ranges;
 
 		crypto@f4264000 {
@@ -285,14 +285,14 @@ dma1: dma@f8019400 {
 		};
 
 		ethernet: ethernet@f8010000 {
-			clock-names = "stmmaceth", "ptp_ref";
+			compatible = "snps,dwmac-4.10a", "snps,dwmac";
+			reg = <0xf8010000 0x4000>;
 			clocks = <&clkctrl ARTPEC6_CLK_ETH_ACLK>,
 				 <&clkctrl ARTPEC6_CLK_PTP_REF>;
-			compatible = "snps,dwmac-4.10a", "snps,dwmac";
+			clock-names = "stmmaceth", "ptp_ref";
 			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "macirq", "eth_lpi";
-			reg = <0xf8010000 0x4000>;
 
 			snps,axi-config = <&stmmac_axi_setup>;
 			snps,mtl-rx-config = <&mtl_rx_setup>;
@@ -335,8 +335,8 @@ uart0: serial@f8036000 {
 			clocks = <&clkctrl ARTPEC6_CLK_UART_REFCLK>,
 				 <&clkctrl ARTPEC6_CLK_UART_PCLK>;
 			clock-names = "uart_clk", "apb_pclk";
-			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_uart0>;
+			pinctrl-names = "default";
 			dmas = <&dma0 4 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>,
 			       <&dma0 5 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>;
 			dma-names = "rx", "tx";
@@ -349,8 +349,8 @@ uart1: serial@f8037000 {
 			clocks = <&clkctrl ARTPEC6_CLK_UART_REFCLK>,
 				 <&clkctrl ARTPEC6_CLK_UART_PCLK>;
 			clock-names = "uart_clk", "apb_pclk";
-			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_uart1>;
+			pinctrl-names = "default";
 			dmas = <&dma0 6 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>,
 			       <&dma0 7 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>;
 			dma-names = "rx", "tx";
@@ -363,8 +363,8 @@ uart2: serial@f8038000 {
 			clocks = <&clkctrl ARTPEC6_CLK_UART_REFCLK>,
 				 <&clkctrl ARTPEC6_CLK_UART_PCLK>;
 			clock-names = "uart_clk", "apb_pclk";
-			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_uart2>;
+			pinctrl-names = "default";
 			dmas = <&dma1 0 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>,
 			       <&dma1 1 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>;
 			dma-names = "rx", "tx";
@@ -377,8 +377,8 @@ uart3: serial@f8039000 {
 			clocks = <&clkctrl ARTPEC6_CLK_UART_REFCLK>,
 				 <&clkctrl ARTPEC6_CLK_UART_PCLK>;
 			clock-names = "uart_clk", "apb_pclk";
-			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_uart3>;
+			pinctrl-names = "default";
 			dmas = <&dma1 2 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>,
 			       <&dma1 3 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>;
 			dma-names = "rx", "tx";

-- 
2.43.0

[PATCH 5/7] ARM: dts: axis: artpec6: add more blank lines

[Henrik Grimler]

The status property, and each child node, should preferably have empty
lines before them to increase readability. dt-check-style in strict
mode reports this type of issue as:

  axis/artpec6.dtsi:186: [required-blank-lines] "status" must be preceded by a blank line

Fix all occurences.

Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
 arch/arm/boot/dts/axis/artpec6-devboard.dts |  1 +
 arch/arm/boot/dts/axis/artpec6.dtsi         | 14 ++++++++++++++
 2 files changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/axis/artpec6-devboard.dts b/arch/arm/boot/dts/axis/artpec6-devboard.dts
index 9a91f9758442..55fdd610d3ed 100644
--- a/arch/arm/boot/dts/axis/artpec6-devboard.dts
+++ b/arch/arm/boot/dts/axis/artpec6-devboard.dts
@@ -55,6 +55,7 @@ mdio {
 		compatible = "snps,dwmac-mdio";
 		#address-cells = <0x1>;
 		#size-cells = <0x0>;
+
 		phy1: phy@0 {
 			device_type = "ethernet-phy";
 			compatible = "ethernet-phy-ieee802.3-c22";
diff --git a/arch/arm/boot/dts/axis/artpec6.dtsi b/arch/arm/boot/dts/axis/artpec6.dtsi
index d3079badcf21..146a5fd98528 100644
--- a/arch/arm/boot/dts/axis/artpec6.dtsi
+++ b/arch/arm/boot/dts/axis/artpec6.dtsi
@@ -120,6 +120,7 @@ timer@faf00600 {
 		reg = <0xfaf00600 0x20>;
 		interrupts = <GIC_PPI 13 0xf04>;
 		clocks = <&clkctrl ARTPEC6_CLK_CPU_PERIPH>;
+
 		status = "disabled";
 	};
 
@@ -183,6 +184,7 @@ pcie: pcie@f8050000 {
 				<0 0 0 3 &intc GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>,
 				<0 0 0 4 &intc GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
 		axis,syscon-pcie = <&syscon>;
+
 		status = "disabled";
 	};
 
@@ -197,6 +199,7 @@ pcie_ep: pcie-ep@f8050000 {
 		num-ob-windows = <2>;
 		num-lanes = <2>;
 		axis,syscon-pcie = <&syscon>;
+
 		status = "disabled";
 	};
 
@@ -209,16 +212,19 @@ pinctrl_uart0: uart0grp {
 			groups = "uart0grp2";
 			bias-pull-up;
 		};
+
 		pinctrl_uart1: uart1grp {
 			function = "uart1";
 			groups = "uart1grp0";
 			bias-pull-up;
 		};
+
 		pinctrl_uart2: uart2grp {
 			function = "uart2";
 			groups = "uart2grp1";
 			bias-pull-up;
 		};
+
 		pinctrl_uart3: uart3grp {
 			function = "uart3";
 			groups = "uart3grp0";
@@ -261,6 +267,7 @@ dma0: dma@f8019000 {
 			dma-channels = <8>;
 			dma-requests = <8>;
 		};
+
 		dma1: dma@f8019400 {
 			compatible = "renesas,nbpfaxi64dmac8b16";
 			reg = <0xf8019400 0x400>;
@@ -340,8 +347,10 @@ uart0: serial@f8036000 {
 			dmas = <&dma0 4 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>,
 			       <&dma0 5 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>;
 			dma-names = "rx", "tx";
+
 			status = "disabled";
 		};
+
 		uart1: serial@f8037000 {
 			compatible = "arm,pl011", "arm,primecell";
 			reg = <0xf8037000 0x1000>;
@@ -354,8 +363,10 @@ uart1: serial@f8037000 {
 			dmas = <&dma0 6 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>,
 			       <&dma0 7 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>;
 			dma-names = "rx", "tx";
+
 			status = "disabled";
 		};
+
 		uart2: serial@f8038000 {
 			compatible = "arm,pl011", "arm,primecell";
 			reg = <0xf8038000 0x1000>;
@@ -368,8 +379,10 @@ uart2: serial@f8038000 {
 			dmas = <&dma1 0 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>,
 			       <&dma1 1 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>;
 			dma-names = "rx", "tx";
+
 			status = "disabled";
 		};
+
 		uart3: serial@f8039000 {
 			compatible = "arm,pl011", "arm,primecell";
 			reg = <0xf8039000 0x1000>;
@@ -382,6 +395,7 @@ uart3: serial@f8039000 {
 			dmas = <&dma1 2 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>,
 			       <&dma1 3 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>;
 			dma-names = "rx", "tx";
+
 			status = "disabled";
 		};
 	};

-- 
2.43.0

[PATCH 6/7] ARM: dts: axis: artpec6: put inline comments on same line as entries

[Henrik Grimler]

By having the comments next to the data they describe it is easier to
read the property. This fixes indent-consistent and
continuation-alignment warnings from dt-check-style in strict mode,
e.g. warnings like:

  axis/artpec6.dtsi:170: [indent-consistent] indent mismatch (expected depth 2 * '\t')
  axis/artpec6.dtsi:172: [continuation-alignment] continuation should align to column 26 (to < or ")

Also shorten one of the comments a bit so that the entire line fits
under 100 chars.

Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
 arch/arm/boot/dts/axis/artpec6.dtsi | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/axis/artpec6.dtsi b/arch/arm/boot/dts/axis/artpec6.dtsi
index 146a5fd98528..c9f671fd685a 100644
--- a/arch/arm/boot/dts/axis/artpec6.dtsi
+++ b/arch/arm/boot/dts/axis/artpec6.dtsi
@@ -167,10 +167,8 @@ pcie: pcie@f8050000 {
 		      <0xf8040000 0x1000>,
 		      <0xc0000000 0x2000>;
 		reg-names = "dbi", "phy", "config";
-			  /* downstream I/O */
-		ranges = <0x81000000 0 0 0xc0002000 0 0x00010000>,
-			  /* non-prefetchable memory */
-			 <0x82000000 0 0xc0012000 0xc0012000 0 0x1ffee000>;
+		ranges = <0x81000000 0 0 0xc0002000 0 0x00010000>,          /* downstream I/O */
+			 <0x82000000 0 0xc0012000 0xc0012000 0 0x1ffee000>; /* non-prefetchable */
 		#address-cells = <3>;
 		#size-cells = <2>;
 		num-lanes = <2>;

-- 
2.43.0

[PATCH 7/7] ARM: dts: axis: artpec6: add empty lines before empty queue nodes

[Henrik Grimler]

For better readability child nodes should be preceded by an empty
line, and closing braces should be on their own line. Both issues are
reported by dt-check-style in strict mode, e.g.

  axis/artpec6.dtsi:212: [required-blank-lines] child node must be preceded by a blank line
  axis/artpec6.dtsi:321: [node-close-alone] closing brace must be on its own line

Updated the dts to use preferred style.

Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
 arch/arm/boot/dts/axis/artpec6.dtsi | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/axis/artpec6.dtsi b/arch/arm/boot/dts/axis/artpec6.dtsi
index c9f671fd685a..6044a378c5b0 100644
--- a/arch/arm/boot/dts/axis/artpec6.dtsi
+++ b/arch/arm/boot/dts/axis/artpec6.dtsi
@@ -323,13 +323,19 @@ stmmac_axi_setup: stmmac-axi-config {
 
 			mtl_rx_setup: rx-queues-config {
 				snps,rx-queues-to-use = <1>;
-				queue0 {};
+
+				queue0 {
+				};
 			};
 
 			mtl_tx_setup: tx-queues-config {
 				snps,tx-queues-to-use = <2>;
-				queue0 {};
-				queue1 {};
+
+				queue0 {
+				};
+
+				queue1 {
+				};
 			};
 		};
 

-- 
2.43.0

Re: [PATCH 1/7] ARM: dts: axis: artpec6: avoid _ in node names

[Krzysztof Kozlowski]

On 28/09/2026 14:04, Henrik Grimler wrote:
> Node names should preferably not use _, use - instead. Fixes
> dt-check-style strict mode warnings:
> 
>   axis/artpec6.dtsi:91: [node-name] node name "ext_clk" is using discouraged style
>   axis/artpec6.dtsi:97: [node-name] node name "eth_phy_ref_clk" is using discouraged style
>   axis/artpec6.dtsi:189: [node-name] node name "pcie_ep" is using discouraged style
> 
> Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
> ---
>  arch/arm/boot/dts/axis/artpec6.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/axis/artpec6.dtsi b/arch/arm/boot/dts/axis/artpec6.dtsi
> index 037157e6c5ee..ce642dcc754e 100644
> --- a/arch/arm/boot/dts/axis/artpec6.dtsi
> +++ b/arch/arm/boot/dts/axis/artpec6.dtsi
> @@ -88,13 +88,13 @@ scu@faf00000 {
>  	};
>  
>  	/* Main external clock driving CPU and peripherals */
> -	ext_clk: ext_clk {
> +	ext_clk: ext-clk {

This will change the name of the clock. Did you verify that it is fine?

Best regards,
Krzysztof

Re: [PATCH 7/7] ARM: dts: axis: artpec6: add empty lines before empty queue nodes

[Krzysztof Kozlowski]

On 28/09/2026 14:04, Henrik Grimler wrote:
> For better readability child nodes should be preceded by an empty
> line, and closing braces should be on their own line. Both issues are
> reported by dt-check-style in strict mode, e.g.
> 
>   axis/artpec6.dtsi:212: [required-blank-lines] child node must be preceded by a blank line
>   axis/artpec6.dtsi:321: [node-close-alone] closing brace must be on its own line
> 
> Updated the dts to use preferred style.

These are false positives. Original code is readable.


Best regards,
Krzysztof

Re: [PATCH 6/7] ARM: dts: axis: artpec6: put inline comments on same line as entries

[Krzysztof Kozlowski]

On 28/09/2026 14:04, Henrik Grimler wrote:
> By having the comments next to the data they describe it is easier to
> read the property. This fixes indent-consistent and
> continuation-alignment warnings from dt-check-style in strict mode,
> e.g. warnings like:
> 
>   axis/artpec6.dtsi:170: [indent-consistent] indent mismatch (expected depth 2 * '\t')
>   axis/artpec6.dtsi:172: [continuation-alignment] continuation should align to column 26 (to < or ")
> 
> Also shorten one of the comments a bit so that the entire line fits
> under 100 chars.
> 
> Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
> ---
>  arch/arm/boot/dts/axis/artpec6.dtsi | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/axis/artpec6.dtsi b/arch/arm/boot/dts/axis/artpec6.dtsi
> index 146a5fd98528..c9f671fd685a 100644
> --- a/arch/arm/boot/dts/axis/artpec6.dtsi
> +++ b/arch/arm/boot/dts/axis/artpec6.dtsi
> @@ -167,10 +167,8 @@ pcie: pcie@f8050000 {
>  		      <0xf8040000 0x1000>,
>  		      <0xc0000000 0x2000>;
>  		reg-names = "dbi", "phy", "config";
> -			  /* downstream I/O */
> -		ranges = <0x81000000 0 0 0xc0002000 0 0x00010000>,
> -			  /* non-prefetchable memory */
> -			 <0x82000000 0 0xc0012000 0xc0012000 0 0x1ffee000>;
> +		ranges = <0x81000000 0 0 0xc0002000 0 0x00010000>,          /* downstream I/O */
> +			 <0x82000000 0 0xc0012000 0xc0012000 0 0x1ffee000>; /* non-prefetchable */

Squash with the #3 patch.

Best regards,
Krzysztof

Re: (subset) [PATCH 2/7] ARM: dts: axis: artpec6: align all continued lines

[Krzysztof Kozlowski]

On Mon, 28 Sep 2026 14:04:48 +0200, Henrik Grimler wrote:
> dt-check-style in strict mode reports that there are a bunch of
> multiline properties that are not aligned, fix them to make the dts
> easier to follow. Fixes dt-check-style warnings like:
> 
>   axis/artpec6.dtsi:290: [continuation-alignment] continuation should align to column 34 (to < or ")
> 
> 
> [...]

Applied, thanks!

[2/7] ARM: dts: axis: artpec6: align all continued lines
      https://git.kernel.org/krzk/linux/c/60c916de7b3bf0ff2a4d1d31753a29765941ab89

Best regards,
-- 
Krzysztof Kozlowski <krzk@kernel.org>

Re: (subset) [PATCH 2/7] ARM: dts: axis: artpec6: align all continued lines

[Krzysztof Kozlowski]

On 30/09/2026 07:30, Krzysztof Kozlowski wrote:
> 
> On Mon, 28 Sep 2026 14:04:48 +0200, Henrik Grimler wrote:
>> dt-check-style in strict mode reports that there are a bunch of
>> multiline properties that are not aligned, fix them to make the dts
>> easier to follow. Fixes dt-check-style warnings like:
>>
>>   axis/artpec6.dtsi:290: [continuation-alignment] continuation should align to column 34 (to < or ")
>>
>>
>> [...]
> 
> Applied, thanks!
> 
> [2/7] ARM: dts: axis: artpec6: align all continued lines
>       https://git.kernel.org/krzk/linux/c/60c916de7b3bf0ff2a4d1d31753a29765941ab89

... and dropped, that's not my subsystem. Why am I Cc-ed on this?

Best regards,
Krzysztof

Re: (subset) [PATCH 2/7] ARM: dts: axis: artpec6: align all continued lines

[Henrik Grimler]

Hi Krzysztof,

On Wed, Sep 30, 2026 at 07:44:54AM +0200, Krzysztof Kozlowski wrote:
> On 30/09/2026 07:30, Krzysztof Kozlowski wrote:
> > 
> > On Mon, 28 Sep 2026 14:04:48 +0200, Henrik Grimler wrote:
> >> dt-check-style in strict mode reports that there are a bunch of
> >> multiline properties that are not aligned, fix them to make the dts
> >> easier to follow. Fixes dt-check-style warnings like:
> >>
> >>   axis/artpec6.dtsi:290: [continuation-alignment] continuation should align to column 34 (to < or ")
> >>
> >>
> >> [...]
> > 
> > Applied, thanks!
> > 
> > [2/7] ARM: dts: axis: artpec6: align all continued lines
> >       https://git.kernel.org/krzk/linux/c/60c916de7b3bf0ff2a4d1d31753a29765941ab89
> 
> ... and dropped, that's not my subsystem. Why am I Cc-ed on this?

b4 / get_maintainer.pl picks you up:

  $ ./scripts/get_maintainer.pl arch/arm/boot/dts/axis/*
  ..
  Krzysztof Kozlowski <krzk+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
  ..

I believe ARTPEC-6 patches has gone through the ARM SOC tree in the
past, so maybe that makes the most sense now also. Will update the
cover letter in next version to suggest this.

Thanks for looking at the patches in any case, will fix your comments!

Best regards,
Henrik Grimler

> Best regards,
> Krzysztof

Re: (subset) [PATCH 2/7] ARM: dts: axis: artpec6: align all continued lines

[Krzysztof Kozlowski]

On 30/09/2026 08:22, Henrik Grimler wrote:
> Hi Krzysztof,
> 
> On Wed, Sep 30, 2026 at 07:44:54AM +0200, Krzysztof Kozlowski wrote:
>> On 30/09/2026 07:30, Krzysztof Kozlowski wrote:
>>>
>>> On Mon, 28 Sep 2026 14:04:48 +0200, Henrik Grimler wrote:
>>>> dt-check-style in strict mode reports that there are a bunch of
>>>> multiline properties that are not aligned, fix them to make the dts
>>>> easier to follow. Fixes dt-check-style warnings like:
>>>>
>>>>   axis/artpec6.dtsi:290: [continuation-alignment] continuation should align to column 34 (to < or ")
>>>>
>>>>
>>>> [...]
>>>
>>> Applied, thanks!
>>>
>>> [2/7] ARM: dts: axis: artpec6: align all continued lines
>>>       https://git.kernel.org/krzk/linux/c/60c916de7b3bf0ff2a4d1d31753a29765941ab89
>>
>> ... and dropped, that's not my subsystem. Why am I Cc-ed on this?
> 
> b4 / get_maintainer.pl picks you up:
> 
>   $ ./scripts/get_maintainer.pl arch/arm/boot/dts/axis/*
>   ..
>   Krzysztof Kozlowski <krzk+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)

Indeed, part of standard DTS catch-group.

Best regards,
Krzysztof