From: Pooventhiran G <pooventhiran.g@oss.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless-next v4 01/21] wifi: nl80211: define Seamless Mobility Domain (SMD) device capability
Date: Wed, 18 Nov 2026 19:24:42 +0530 [thread overview]
Message-ID: <204b3133-bbad-49cf-9290-9c334509297a@oss.qualcomm.com> (raw)
In-Reply-To: <61c6b777341edd1343ad1959abc9e2313a05ef25.camel@sipsolutions.net>
On 11/16/2026 04:10 pm, Johannes Berg wrote:
> On Fri, 2026-11-13 at 20:53 +0530, Pooventhiran G wrote:
>>
>> On 11/10/2026 07:56 pm, Johannes Berg wrote:
>>> On Tue, 2026-11-10 at 15:15 +0100, Johannes Berg wrote:
>>>>> + * @NL80211_ATTR_SMD_SUPPORT: Flag attribute to indicate SMD support. Used with
>>>>> + * multiple commands to indicate appropriate SMD support (refer DOC).
>>>>
>>>> This (with the wiphy flag) is the wrong way to do this, we have extended
>>>> flags that don't need the double enum value and pass through to
>>>> userspace directly.
>>
>> I changed the EXT_FEATURE flag to WIPHY_FLAG based on the comments in v2 and
>> NL80211_ATTR_MLO_SUPPORT implementation.
>>
>
> Yes, but I think then you had more intricate feature advertisement and
> that went away entirely?
>
Start-ap had many SMD config params which are now cleaned up.
>> I will change this back to
>> EXT_FEATURE flag to indicate driver support.
>
> Sounds good.
>
>> NL80211_ATTR_SMD_SUPPORT passed to ieee80211_start_ap is parsed into link_conf
>> and (will be) read by the driver in assign_vif_chanctx drv-op. ath12k
>> implementation needs this indication to instantiate vifs and workflows in both
>> the driver and firmware.
>
> I guess that'll be one of those "trust me FW needs it" cases, but...
> why? I don't see how it has any impact on anything?
>
I will clean this up from start-ap as driver/firmware can manage without this.
> johannes
next prev parent reply other threads:[~2026-11-18 13:54 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 7:58 [PATCH wireless-next v4 00/21] wifi: Add Seamless Mobility Domain (SMD) AP support Pooventhiran G
2026-11-06 7:58 ` [PATCH wireless-next v4 01/21] wifi: nl80211: define Seamless Mobility Domain (SMD) device capability Pooventhiran G
2026-11-10 14:15 ` Johannes Berg
2026-11-10 14:26 ` Johannes Berg
2026-11-13 15:23 ` Pooventhiran G
2026-11-16 10:40 ` Johannes Berg
2026-11-18 13:54 ` Pooventhiran G [this message]
2026-11-06 7:58 ` [PATCH wireless-next v4 02/21] wifi: nl80211/cfg80211: define interfaces for SMD setup and STA update Pooventhiran G
2026-11-10 18:18 ` Johannes Berg
2026-11-06 7:58 ` [PATCH wireless-next v4 03/21] wifi: nl80211: add SMD BSS Transition sub-state STA flags Pooventhiran G
2026-11-10 18:27 ` Johannes Berg
2026-11-16 10:21 ` Pooventhiran G
2026-11-16 10:50 ` Johannes Berg
2026-11-06 7:58 ` [PATCH wireless-next v4 04/21] wifi: cfg80211: define layouts for SMD BSS Transition context Pooventhiran G
2026-11-10 18:39 ` Johannes Berg
2026-11-13 18:15 ` Pooventhiran G
2026-11-16 10:54 ` Johannes Berg
2026-11-18 14:05 ` Pooventhiran G
2026-11-06 7:58 ` [PATCH wireless-next v4 05/21] wifi: nl80211: define interfaces for SMD BSS Transition context transfer Pooventhiran G
2026-11-10 18:45 ` Johannes Berg
2026-11-13 16:45 ` Pooventhiran G
2026-11-06 7:58 ` [PATCH wireless-next v4 06/21] wifi: ieee80211: define APIs for UHR Link Reconfiguration frame checks Pooventhiran G
2026-11-06 7:58 ` [PATCH wireless-next v4 07/21] wifi: ieee80211: define API to check if frame is class 3 Pooventhiran G
2026-11-06 7:58 ` [PATCH wireless-next v4 08/21] wifi: nl80211/cfg80211: pack SMD dynamic context along with frame Pooventhiran G
2026-11-10 18:51 ` Johannes Berg
2026-11-13 18:17 ` Pooventhiran G
2026-11-16 11:00 ` Johannes Berg
2026-11-18 14:10 ` Pooventhiran G
2026-11-11 9:14 ` Allen Ye
2026-11-13 18:19 ` Pooventhiran G
2026-11-16 3:38 ` Allen Ye (葉芷勳)
2026-11-06 7:58 ` [PATCH wireless-next v4 09/21] wifi: nl80211/cfg80211: add support for SMD context programming Pooventhiran G
2026-11-10 18:55 ` Johannes Berg
2026-11-13 17:54 ` Pooventhiran G
2026-11-16 11:13 ` Johannes Berg
2026-11-18 14:14 ` Pooventhiran G
2026-11-06 7:58 ` [PATCH wireless-next v4 10/21] wifi: nl80211/cfg80211: add support for querying SMD context for target AP MLD Pooventhiran G
2026-11-10 19:00 ` Johannes Berg
2026-11-13 18:33 ` Pooventhiran G
2026-11-16 11:20 ` Johannes Berg
2026-11-18 14:18 ` Pooventhiran G
2026-11-06 7:58 ` [PATCH wireless-next v4 11/21] wifi: nl80211/cfg80211: define API to notify SMD Drain completion Pooventhiran G
2026-11-10 19:01 ` Johannes Berg
2026-11-13 18:38 ` Pooventhiran G
2026-11-16 11:23 ` Johannes Berg
2026-11-18 14:19 ` Pooventhiran G
2026-11-06 7:58 ` [PATCH wireless-next v4 12/21] wifi: mac80211: set SMD parameters for AP setup and STA update Pooventhiran G
2026-11-06 7:58 ` [PATCH wireless-next v4 13/21] wifi: mac80211: apply SMD BSS Transition STA sub-states Pooventhiran G
2026-11-10 20:29 ` Johannes Berg
2026-11-13 18:46 ` Pooventhiran G
2026-11-06 7:58 ` [PATCH wireless-next v4 14/21] wifi: mac80211: add driver_op for SMD substate changes Pooventhiran G
2026-11-10 20:38 ` Johannes Berg
2026-11-13 19:20 ` Pooventhiran G
2026-11-16 11:32 ` Johannes Berg
2026-11-18 14:25 ` Pooventhiran G
2026-11-06 7:58 ` [PATCH wireless-next v4 15/21] wifi: mac80211: filter uplink and downlink frames based on SMD states Pooventhiran G
2026-11-06 7:58 ` [PATCH wireless-next v4 16/21] wifi: mac80211: send BlockAck policy in AMPDU action Pooventhiran G
2026-11-10 20:43 ` Johannes Berg
2026-11-16 10:50 ` Pooventhiran G
2026-11-06 7:58 ` [PATCH wireless-next v4 17/21] wifi: mac80211: pass rx_data directly from ieee80211_rx_list() Pooventhiran G
2026-11-06 7:58 ` [PATCH wireless-next v4 18/21] wifi: mac80211: handle UHR Link Reconfiguration frame Pooventhiran G
2026-11-06 7:58 ` [PATCH wireless-next v4 19/21] wifi: mac80211: add mac80211 support to handle NL80211_CMD_SET_SMD_CTX Pooventhiran G
2026-11-06 7:58 ` [PATCH wireless-next v4 20/21] wifi: mac80211: add mac80211 support to handle NL80211_CMD_GET_SMD_CTX Pooventhiran G
2026-11-10 20:47 ` Johannes Berg
2026-11-13 19:22 ` Pooventhiran G
2026-11-06 7:58 ` [PATCH wireless-next v4 21/21] wifi: mac80211: define API to invoke SMD Drain Completion event Pooventhiran G
2026-11-10 20:49 ` Johannes Berg
2026-11-13 19:24 ` Pooventhiran G
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=204b3133-bbad-49cf-9290-9c334509297a@oss.qualcomm.com \
--to=pooventhiran.g@oss.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®