From: Dave Jiang <dave.jiang@intel.com>
To: Anisa Su <anisa.su887@gmail.com>
Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
nvdimm@lists.linux.dev, Dan Williams <djbw@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <iweiny@kernel.org>,
Alison Schofield <alison.schofield@intel.com>,
John Groves <John@groves.net>, Gregory Price <gourry@gourry.net>,
Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH v10 10/31] cxl/mem: Configure dynamic capacity interrupts
Date: Wed, 10 Jun 2026 09:57:35 -0700 [thread overview]
Message-ID: <9c3ab868-27b7-4d33-865b-9308269f764f@intel.com> (raw)
In-Reply-To: <aiZ6TLUwI11Yg1jh@AnisaLaptop.localdomain>
On 6/8/26 1:16 AM, Anisa Su wrote:
> On Thu, May 28, 2026 at 09:21:59AM -0700, Dave Jiang wrote:
>>
>>
>> On 5/23/26 2:43 AM, Anisa Su wrote:
>>> From: Ira Weiny <ira.weiny@intel.com>
>>>
>>> Dynamic Capacity Devices (DCD) support extent change notifications
>>> through the event log mechanism. The interrupt mailbox commands were
>>> extended in CXL 3.1 to support these notifications. Firmware can't
>>> configure DCD events to be FW controlled but can retain control of
>>> memory events.
>>>
>>> Configure DCD event log interrupts on devices supporting dynamic
>>> capacity. Disable DCD if interrupts are not supported.
>>>
>>> Care is taken to preserve the interrupt policy set by the FW if FW first
>>> has been selected by the BIOS.
>>>
>>> Accept the 4-byte CXL 2.0 reply on GET Event Interrupt Policy by setting
>>> min_out to CXL_EVENT_INT_POLICY_BASE_SIZE; pre-CXL 3.1 firmware omits
>>> dcd_settings and would otherwise fail the size check.
>>>
>>> Based on an original patch by Navneet Singh.
>>>
>>> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
>>> Signed-off-by: Anisa Su <anisa.su@samsung.com>
>>>
>>> ---
>>> Changes:
>>> [anisa: rebase]
>>> [anisa: accept 4-byte CXL 2.0 GET reply via min_out]
>>> [anisa: drop Reviewed-by tags now that the patch carries new changes]
>>> ---
>>> drivers/cxl/cxlmem.h | 2 ++
>>> drivers/cxl/pci.c | 75 ++++++++++++++++++++++++++++++++++++--------
>>> 2 files changed, 64 insertions(+), 13 deletions(-)
>>>
>>> diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h
>>> index 10175ca3b7ee..65c009b02da6 100644
>>> --- a/drivers/cxl/cxlmem.h
>>> +++ b/drivers/cxl/cxlmem.h
>>> @@ -218,7 +218,9 @@ struct cxl_event_interrupt_policy {
>>> u8 warn_settings;
>>> u8 failure_settings;
>>> u8 fatal_settings;
>>> + u8 dcd_settings;
>>> } __packed;
>>> +#define CXL_EVENT_INT_POLICY_BASE_SIZE 4 /* info, warn, failure, fatal */
>>>
>>> /**
>>> * struct cxl_event_state - Event log driver state
>>> diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
>>> index 8d12c684d670..83617439bbd3 100644
>>> --- a/drivers/cxl/pci.c
>>> +++ b/drivers/cxl/pci.c
>>> @@ -557,6 +557,8 @@ static int cxl_event_get_int_policy(struct cxl_memdev_state *mds,
>>> .opcode = CXL_MBOX_OP_GET_EVT_INT_POLICY,
>>> .payload_out = policy,
>>> .size_out = sizeof(*policy),
>>> + /* CXL 2.0 firmware omits dcd_settings; accept the shorter reply */
>>> + .min_out = CXL_EVENT_INT_POLICY_BASE_SIZE,
>>> };
>>> int rc;
>>>
>>> @@ -569,23 +571,34 @@ static int cxl_event_get_int_policy(struct cxl_memdev_state *mds,
>>> }
>>>
>>> static int cxl_event_config_msgnums(struct cxl_memdev_state *mds,
>>> - struct cxl_event_interrupt_policy *policy)
>>> + struct cxl_event_interrupt_policy *policy,
>>> + bool native_cxl)
>>> {
>>> struct cxl_mailbox *cxl_mbox = &mds->cxlds.cxl_mbox;
>>> + size_t size_in = CXL_EVENT_INT_POLICY_BASE_SIZE;
>>> struct cxl_mbox_cmd mbox_cmd;
>>> int rc;
>>>
>>> - *policy = (struct cxl_event_interrupt_policy) {
>>> - .info_settings = CXL_INT_MSI_MSIX,
>>> - .warn_settings = CXL_INT_MSI_MSIX,
>>> - .failure_settings = CXL_INT_MSI_MSIX,
>>> - .fatal_settings = CXL_INT_MSI_MSIX,
>>> - };
>>> + /* memory event policy is left if FW has control */
>>> + if (native_cxl) {
>>> + *policy = (struct cxl_event_interrupt_policy) {
>>> + .info_settings = CXL_INT_MSI_MSIX,
>>> + .warn_settings = CXL_INT_MSI_MSIX,
>>> + .failure_settings = CXL_INT_MSI_MSIX,
>>> + .fatal_settings = CXL_INT_MSI_MSIX,
>>> + .dcd_settings = 0,
>>> + };
>>> + }
>>> +
>>> + if (cxl_dcd_supported(mds)) {
>>> + policy->dcd_settings = CXL_INT_MSI_MSIX;
>>> + size_in += sizeof(policy->dcd_settings);
>>> + }
>>>
>>> mbox_cmd = (struct cxl_mbox_cmd) {
>>> .opcode = CXL_MBOX_OP_SET_EVT_INT_POLICY,
>>> .payload_in = policy,
>>> - .size_in = sizeof(*policy),
>>> + .size_in = size_in,
>>> };
>>>
>>> rc = cxl_internal_send_cmd(cxl_mbox, &mbox_cmd);
>>> @@ -632,6 +645,30 @@ static int cxl_event_irqsetup(struct cxl_memdev_state *mds,
>>> return 0;
>>> }
>>>
>>> +static int cxl_irqsetup(struct cxl_memdev_state *mds,
>>> + struct cxl_event_interrupt_policy *policy,
>>> + bool native_cxl)
>>> +{
>>> + struct cxl_dev_state *cxlds = &mds->cxlds;
>>> + int rc;
>>> +
>>> + if (native_cxl) {
>>> + rc = cxl_event_irqsetup(mds, policy);
>>> + if (rc)
>>> + return rc;
>>> + }
>>> +
>>> + if (cxl_dcd_supported(mds)) {
>>> + rc = cxl_event_req_irq(cxlds, policy->dcd_settings);
>>> + if (rc) {
>>> + dev_err(cxlds->dev, "Failed to get interrupt for DCD event log\n");
>>> + cxl_disable_dcd(mds);
>>> + }
>>> + }
>>> +
>>> + return 0;
>>> +}
>>> +
>>> static bool cxl_event_int_is_fw(u8 setting)
>>> {
>>> u8 mode = FIELD_GET(CXLDEV_EVENT_INT_MODE_MASK, setting);
>>> @@ -657,18 +694,26 @@ static bool cxl_event_validate_mem_policy(struct cxl_memdev_state *mds,
>>> static int cxl_event_config(struct pci_host_bridge *host_bridge,
>>> struct cxl_memdev_state *mds, bool irq_avail)
>>> {
>>> - struct cxl_event_interrupt_policy policy;
>>> + struct cxl_event_interrupt_policy policy = { 0 };
>>> + bool native_cxl = host_bridge->native_cxl_error;
>>> int rc;
>>>
>>> /*
>>> * When BIOS maintains CXL error reporting control, it will process
>>> * event records. Only one agent can do so.
>>> + *
>>> + * If BIOS has control of events and DCD is not supported skip event
>>> + * configuration.
>>> */
>>> - if (!host_bridge->native_cxl_error)
>>> + if (!native_cxl && !cxl_dcd_supported(mds))
>>> return 0;
>>>
>>> if (!irq_avail) {
>>> dev_info(mds->cxlds.dev, "No interrupt support, disable event processing.\n");
>>> + if (cxl_dcd_supported(mds)) {
>>> + dev_info(mds->cxlds.dev, "DCD requires interrupts, disable DCD\n");
>>> + cxl_disable_dcd(mds);
>>> + }
>>> return 0;
>>> }
>>>
>>> @@ -676,10 +721,10 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,
>>> if (rc)
>>> return rc;
>>>
>>> - if (!cxl_event_validate_mem_policy(mds, &policy))
>>> + if (native_cxl && !cxl_event_validate_mem_policy(mds, &policy))
>>> return -EBUSY;
>>>
>>> - rc = cxl_event_config_msgnums(mds, &policy);
>>> + rc = cxl_event_config_msgnums(mds, &policy, native_cxl);
>>> if (rc)
>>> return rc;
>>>
>>> @@ -687,12 +732,16 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,
>>> if (rc)
>>> return rc;
>>>
>>> - rc = cxl_event_irqsetup(mds, &policy);
>>> + rc = cxl_irqsetup(mds, &policy, native_cxl);
>>> if (rc)
>>> return rc;
>>>
>>> cxl_mem_get_event_records(mds, CXLDEV_EVENT_STATUS_ALL);
>>
>> Issue that was always there probably, should this check native_cxl so the BIOS owned events are not retrieved?
>>
>> if (native_cxl)
>> cxl_mem_get_event_records(mds, CXLDEV_EVENT_STATUS_ALL);
>>
>>
> That makes sense. Would you prefer the fix as a separate patch?
Yes please.
DJ
next prev parent reply other threads:[~2026-06-10 16:57 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 9:42 [PATCH v10 00/31] DCD: Add support for Dynamic Capacity Devices (DCD) Anisa Su
2026-05-23 9:42 ` [PATCH v10 01/31] cxl/mbox: Flag " Anisa Su
2026-05-27 21:34 ` Dave Jiang
2026-05-30 6:22 ` Anisa Su
2026-05-23 9:42 ` [PATCH v10 02/31] cxl/mem: Read dynamic capacity configuration from the device Anisa Su
2026-05-27 22:28 ` Dave Jiang
2026-05-30 6:40 ` Anisa Su
2026-06-01 15:23 ` Dave Jiang
2026-06-02 9:46 ` Anisa Su
2026-05-23 9:42 ` [PATCH v10 03/31] cxl/cdat: Gather DSMAS data for DCD partitions Anisa Su
2026-05-27 23:16 ` Dave Jiang
2026-05-30 6:45 ` Anisa Su
2026-05-23 9:42 ` [PATCH v10 04/31] cxl/core: Enforce partition order/simplify partition calls Anisa Su
2026-05-27 23:37 ` Dave Jiang
2026-05-30 6:57 ` Anisa Su
2026-05-23 9:42 ` [PATCH v10 05/31] cxl/mem: Expose dynamic ram A partition in sysfs Anisa Su
2026-05-27 23:54 ` Dave Jiang
2026-05-27 23:56 ` Dave Jiang
2026-05-30 7:04 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 06/31] cxl/port: Add 'dynamic_ram_a' to endpoint decoder mode Anisa Su
2026-05-28 0:01 ` Dave Jiang
2026-05-30 7:07 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 07/31] cxl/region: Add DC DAX region support Anisa Su
2026-05-28 0:16 ` Dave Jiang
2026-06-02 9:22 ` Anisa Su
2026-06-02 15:42 ` Dave Jiang
2026-06-18 20:21 ` Alison Schofield
2026-05-23 9:43 ` [PATCH v10 08/31] cxl/events: Split event msgnum configuration from irq setup Anisa Su
2026-05-23 9:43 ` [PATCH v10 09/31] cxl/pci: Factor out interrupt policy check Anisa Su
2026-05-23 9:43 ` [PATCH v10 10/31] cxl/mem: Configure dynamic capacity interrupts Anisa Su
2026-05-28 16:21 ` Dave Jiang
2026-06-08 8:16 ` Anisa Su
2026-06-10 16:57 ` Dave Jiang [this message]
2026-06-11 18:19 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 11/31] cxl/core: Return endpoint decoder information from region search Anisa Su
2026-05-23 9:43 ` [PATCH v10 12/31] cxl/mem: Set up framework for handling DC Events Anisa Su
2026-05-28 16:40 ` Dave Jiang
2026-06-09 17:34 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 13/31] cxl/mem: Add 20 second timeout for stalled DC_ADD_CAPACITY chains Anisa Su
2026-05-28 16:57 ` Dave Jiang
2026-06-09 17:36 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 14/31] cxl/extent: Handle DC Add Capacity events Anisa Su
2026-05-28 19:06 ` Dave Jiang
2026-06-10 3:48 ` Anisa Su
2026-06-24 9:16 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 15/31] cxl/mem: Drop misaligned DCD extent groups Anisa Su
2026-05-28 21:03 ` Dave Jiang
2026-06-11 6:22 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 16/31] cxl/extent: Validate DC extent partition Anisa Su
2026-05-28 21:34 ` Dave Jiang
2026-06-11 7:35 ` Anisa Su
2026-06-24 9:04 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 17/31] cxl/mem: Enforce tag-group semantics Anisa Su
2026-05-23 9:43 ` [PATCH v10 18/31] cxl/extent: Handle DC Release Capacity events Anisa Su
2026-05-28 22:13 ` Dave Jiang
2026-06-12 5:56 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 19/31] cxl/extent: Enforce cross-region tag uniqueness Anisa Su
2026-05-28 22:44 ` Dave Jiang
2026-05-23 9:43 ` [PATCH v10 20/31] cxl/region/extent: Expose dc_extent information in sysfs Anisa Su
2026-05-28 22:54 ` Dave Jiang
2026-06-12 5:58 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 21/31] cxl + dax: Surface dax_resources on DCD Add Capacity events Anisa Su
2026-05-28 23:41 ` Dave Jiang
2026-06-16 8:44 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 22/31] cxl + dax: Release dax_resources on DCD Release " Anisa Su
2026-05-28 23:53 ` Dave Jiang
2026-06-16 8:52 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 23/31] dax/bus: Factor out dev dax resize logic Anisa Su
2026-06-24 8:36 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 24/31] dax/bus: Add uuid sysfs attribute to dax devices Anisa Su
2026-05-29 17:07 ` Dave Jiang
2026-05-23 9:43 ` [PATCH v10 25/31] dax/bus: Reject resize on DC dax devices and enforce 0-size creation Anisa Su
2026-05-29 17:16 ` Dave Jiang
2026-06-16 8:54 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 26/31] dax/bus: Tag-aware uuid claim and show on DC dax devices Anisa Su
2026-05-29 17:53 ` Dave Jiang
2026-06-16 9:01 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 27/31] cxl/region: Read existing extents on region creation Anisa Su
2026-05-29 21:30 ` Dave Jiang
2026-06-16 9:39 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 28/31] cxl/mem: Trace Dynamic capacity Event Record Anisa Su
2026-05-29 22:41 ` Dave Jiang
2026-06-16 9:59 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 29/31] tools/testing/cxl: Make event logs dynamic Anisa Su
2026-05-29 22:58 ` Dave Jiang
2026-06-16 10:29 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 30/31] tools/testing/cxl: Add DC Regions to mock mem data Anisa Su
2026-05-29 23:42 ` Dave Jiang
2026-06-25 11:22 ` Anisa Su
2026-05-23 9:43 ` [PATCH v10 31/31] Documentation/cxl: Document DCD extent handling and DC-backed DAX regions Anisa Su
2026-05-27 18:51 ` [PATCH v10 00/31] DCD: Add support for Dynamic Capacity Devices (DCD) Dave Jiang
2026-05-30 0:16 ` Anisa Su
2026-06-05 5:35 ` Alison Schofield
2026-06-08 7:54 ` Anisa Su
2026-06-24 7:49 ` Anisa Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c3ab868-27b7-4d33-865b-9308269f764f@intel.com \
--to=dave.jiang@intel.com \
--cc=John@groves.net \
--cc=alison.schofield@intel.com \
--cc=anisa.su887@gmail.com \
--cc=dave@stgolabs.net \
--cc=djbw@kernel.org \
--cc=gourry@gourry.net \
--cc=ira.weiny@intel.com \
--cc=iweiny@kernel.org \
--cc=jic23@kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®