* [PATCH v1] soc: qcom: geni-se: Increase MAX_GENI_CFG_RAMn_CNT to 1020 @ 2026-05-22 7:21 Viken Dadhaniya 2026-06-09 15:10 ` Konrad Dybcio 0 siblings, 1 reply; 9+ messages in thread From: Viken Dadhaniya @ 2026-05-22 7:21 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio Cc: linux-arm-msm, linux-kernel, Viken Dadhaniya The current MAX_GENI_CFG_RAMn_CNT value of 455 is insufficient for certain Qualcomm SoCs whose GENI firmware requires up to 1020 RAM entries, causing incorrect bounds checking and preventing firmware loading on those targets. Increase MAX_GENI_CFG_RAMn_CNT to 1020 to match the hardware-supported limit and ensure correct handling of configuration RAM regions across GENI-based SE blocks. Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> --- drivers/soc/qcom/qcom-geni-se.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c index cd1779b6a91a..d0810960f3da 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -152,7 +152,7 @@ struct se_fw_hdr { /*Magic numbers*/ #define SE_MAGIC_NUM 0x57464553 -#define MAX_GENI_CFG_RAMn_CNT 455 +#define MAX_GENI_CFG_RAMn_CNT 1020 #define MI_PBT_NON_PAGED_SEGMENT 0x0 #define MI_PBT_HASH_SEGMENT 0x2 --- base-commit: 550604d6c9b9efc8d068aff94dc301694a7afdee change-id: 20260522-qup-se-increase-ram-cnt-14530f035b55 Best regards, -- Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] soc: qcom: geni-se: Increase MAX_GENI_CFG_RAMn_CNT to 1020 2026-05-22 7:21 [PATCH v1] soc: qcom: geni-se: Increase MAX_GENI_CFG_RAMn_CNT to 1020 Viken Dadhaniya @ 2026-06-09 15:10 ` Konrad Dybcio 2026-06-15 5:28 ` Viken Dadhaniya 0 siblings, 1 reply; 9+ messages in thread From: Konrad Dybcio @ 2026-06-09 15:10 UTC (permalink / raw) To: Viken Dadhaniya, Bjorn Andersson, Konrad Dybcio Cc: linux-arm-msm, linux-kernel On 5/22/26 9:21 AM, Viken Dadhaniya wrote: > The current MAX_GENI_CFG_RAMn_CNT value of 455 is insufficient for > certain Qualcomm SoCs whose GENI firmware requires up to 1020 RAM > entries, causing incorrect bounds checking and preventing firmware > loading on those targets. > > Increase MAX_GENI_CFG_RAMn_CNT to 1020 to match the hardware-supported > limit and ensure correct handling of configuration RAM regions across > GENI-based SE blocks. > > Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> > --- > drivers/soc/qcom/qcom-geni-se.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c > index cd1779b6a91a..d0810960f3da 100644 > --- a/drivers/soc/qcom/qcom-geni-se.c > +++ b/drivers/soc/qcom/qcom-geni-se.c > @@ -152,7 +152,7 @@ struct se_fw_hdr { > /*Magic numbers*/ > #define SE_MAGIC_NUM 0x57464553 > > -#define MAX_GENI_CFG_RAMn_CNT 455 > +#define MAX_GENI_CFG_RAMn_CNT 1020 Is there any SoC where this could overflow the register space (you say "certain Qualcomm SoCs")? Konrad ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] soc: qcom: geni-se: Increase MAX_GENI_CFG_RAMn_CNT to 1020 2026-06-09 15:10 ` Konrad Dybcio @ 2026-06-15 5:28 ` Viken Dadhaniya 2026-06-15 12:00 ` Konrad Dybcio 0 siblings, 1 reply; 9+ messages in thread From: Viken Dadhaniya @ 2026-06-15 5:28 UTC (permalink / raw) To: Konrad Dybcio, Bjorn Andersson, Konrad Dybcio; +Cc: linux-arm-msm, linux-kernel On 6/9/2026 8:40 PM, Konrad Dybcio wrote: > On 5/22/26 9:21 AM, Viken Dadhaniya wrote: >> The current MAX_GENI_CFG_RAMn_CNT value of 455 is insufficient for >> certain Qualcomm SoCs whose GENI firmware requires up to 1020 RAM >> entries, causing incorrect bounds checking and preventing firmware >> loading on those targets. >> >> Increase MAX_GENI_CFG_RAMn_CNT to 1020 to match the hardware-supported >> limit and ensure correct handling of configuration RAM regions across >> GENI-based SE blocks. >> >> Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> >> --- >> drivers/soc/qcom/qcom-geni-se.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c >> index cd1779b6a91a..d0810960f3da 100644 >> --- a/drivers/soc/qcom/qcom-geni-se.c >> +++ b/drivers/soc/qcom/qcom-geni-se.c >> @@ -152,7 +152,7 @@ struct se_fw_hdr { >> /*Magic numbers*/ >> #define SE_MAGIC_NUM 0x57464553 >> >> -#define MAX_GENI_CFG_RAMn_CNT 455 >> +#define MAX_GENI_CFG_RAMn_CNT 1020 > > Is there any SoC where this could overflow the register space > (you say "certain Qualcomm SoCs")? Yes, on Talos (QCS615), the firmware image needs more than 455 CFG RAM entries, so the previous limit could overflow. > > Konrad ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] soc: qcom: geni-se: Increase MAX_GENI_CFG_RAMn_CNT to 1020 2026-06-15 5:28 ` Viken Dadhaniya @ 2026-06-15 12:00 ` Konrad Dybcio 2026-06-15 12:00 ` Konrad Dybcio 0 siblings, 1 reply; 9+ messages in thread From: Konrad Dybcio @ 2026-06-15 12:00 UTC (permalink / raw) To: Viken Dadhaniya, Bjorn Andersson, Konrad Dybcio Cc: linux-arm-msm, linux-kernel On 6/15/26 7:28 AM, Viken Dadhaniya wrote: > > > On 6/9/2026 8:40 PM, Konrad Dybcio wrote: >> On 5/22/26 9:21 AM, Viken Dadhaniya wrote: >>> The current MAX_GENI_CFG_RAMn_CNT value of 455 is insufficient for >>> certain Qualcomm SoCs whose GENI firmware requires up to 1020 RAM >>> entries, causing incorrect bounds checking and preventing firmware >>> loading on those targets. >>> >>> Increase MAX_GENI_CFG_RAMn_CNT to 1020 to match the hardware-supported >>> limit and ensure correct handling of configuration RAM regions across >>> GENI-based SE blocks. >>> >>> Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> >>> --- >>> drivers/soc/qcom/qcom-geni-se.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c >>> index cd1779b6a91a..d0810960f3da 100644 >>> --- a/drivers/soc/qcom/qcom-geni-se.c >>> +++ b/drivers/soc/qcom/qcom-geni-se.c >>> @@ -152,7 +152,7 @@ struct se_fw_hdr { >>> /*Magic numbers*/ >>> #define SE_MAGIC_NUM 0x57464553 >>> >>> -#define MAX_GENI_CFG_RAMn_CNT 455 >>> +#define MAX_GENI_CFG_RAMn_CNT 1020 >> >> Is there any SoC where this could overflow the register space >> (you say "certain Qualcomm SoCs")? > > Yes, on Talos (QCS615), the firmware image needs more than 455 CFG RAM > entries, so the previous limit could overflow. What I'm asking is whether the size of the RAM on any of the SoCs is less than 455 (the previous limit) Konrad ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] soc: qcom: geni-se: Increase MAX_GENI_CFG_RAMn_CNT to 1020 2026-06-15 12:00 ` Konrad Dybcio @ 2026-06-15 12:00 ` Konrad Dybcio 2026-06-22 17:15 ` Viken Dadhaniya 0 siblings, 1 reply; 9+ messages in thread From: Konrad Dybcio @ 2026-06-15 12:00 UTC (permalink / raw) To: Viken Dadhaniya, Bjorn Andersson, Konrad Dybcio Cc: linux-arm-msm, linux-kernel On 6/15/26 2:00 PM, Konrad Dybcio wrote: > On 6/15/26 7:28 AM, Viken Dadhaniya wrote: >> >> >> On 6/9/2026 8:40 PM, Konrad Dybcio wrote: >>> On 5/22/26 9:21 AM, Viken Dadhaniya wrote: >>>> The current MAX_GENI_CFG_RAMn_CNT value of 455 is insufficient for >>>> certain Qualcomm SoCs whose GENI firmware requires up to 1020 RAM >>>> entries, causing incorrect bounds checking and preventing firmware >>>> loading on those targets. >>>> >>>> Increase MAX_GENI_CFG_RAMn_CNT to 1020 to match the hardware-supported >>>> limit and ensure correct handling of configuration RAM regions across >>>> GENI-based SE blocks. >>>> >>>> Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> >>>> --- >>>> drivers/soc/qcom/qcom-geni-se.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c >>>> index cd1779b6a91a..d0810960f3da 100644 >>>> --- a/drivers/soc/qcom/qcom-geni-se.c >>>> +++ b/drivers/soc/qcom/qcom-geni-se.c >>>> @@ -152,7 +152,7 @@ struct se_fw_hdr { >>>> /*Magic numbers*/ >>>> #define SE_MAGIC_NUM 0x57464553 >>>> >>>> -#define MAX_GENI_CFG_RAMn_CNT 455 >>>> +#define MAX_GENI_CFG_RAMn_CNT 1020 >>> >>> Is there any SoC where this could overflow the register space >>> (you say "certain Qualcomm SoCs")? >> >> Yes, on Talos (QCS615), the firmware image needs more than 455 CFG RAM >> entries, so the previous limit could overflow. > > What I'm asking is whether the size of the RAM on any of the SoCs > is less than 455 (the previous limit) *Less than 1020 (the new limit), of course.. Konrad ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] soc: qcom: geni-se: Increase MAX_GENI_CFG_RAMn_CNT to 1020 2026-06-15 12:00 ` Konrad Dybcio @ 2026-06-22 17:15 ` Viken Dadhaniya 2026-06-23 6:50 ` Konrad Dybcio 0 siblings, 1 reply; 9+ messages in thread From: Viken Dadhaniya @ 2026-06-22 17:15 UTC (permalink / raw) To: Konrad Dybcio, Bjorn Andersson, Konrad Dybcio; +Cc: linux-arm-msm, linux-kernel On 6/15/2026 5:30 PM, Konrad Dybcio wrote: > On 6/15/26 2:00 PM, Konrad Dybcio wrote: >> On 6/15/26 7:28 AM, Viken Dadhaniya wrote: >>> >>> >>> On 6/9/2026 8:40 PM, Konrad Dybcio wrote: >>>> On 5/22/26 9:21 AM, Viken Dadhaniya wrote: >>>>> The current MAX_GENI_CFG_RAMn_CNT value of 455 is insufficient for >>>>> certain Qualcomm SoCs whose GENI firmware requires up to 1020 RAM >>>>> entries, causing incorrect bounds checking and preventing firmware >>>>> loading on those targets. >>>>> >>>>> Increase MAX_GENI_CFG_RAMn_CNT to 1020 to match the hardware-supported >>>>> limit and ensure correct handling of configuration RAM regions across >>>>> GENI-based SE blocks. >>>>> >>>>> Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> >>>>> --- >>>>> drivers/soc/qcom/qcom-geni-se.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c >>>>> index cd1779b6a91a..d0810960f3da 100644 >>>>> --- a/drivers/soc/qcom/qcom-geni-se.c >>>>> +++ b/drivers/soc/qcom/qcom-geni-se.c >>>>> @@ -152,7 +152,7 @@ struct se_fw_hdr { >>>>> /*Magic numbers*/ >>>>> #define SE_MAGIC_NUM 0x57464553 >>>>> >>>>> -#define MAX_GENI_CFG_RAMn_CNT 455 >>>>> +#define MAX_GENI_CFG_RAMn_CNT 1020 >>>> >>>> Is there any SoC where this could overflow the register space >>>> (you say "certain Qualcomm SoCs")? >>> >>> Yes, on Talos (QCS615), the firmware image needs more than 455 CFG RAM >>> entries, so the previous limit could overflow. >> >> What I'm asking is whether the size of the RAM on any of the SoCs >> is less than 455 (the previous limit) > > *Less than 1020 (the new limit), of course.. > > Konrad Yes, some SoCs like kodiak, monaco and lemans have CFG RAM smaller than 455. But MAX_GENI_CFG_RAMn_CNT is only a firmware ceiling; the actual programmed size comes from the firmware header. Talos needs ~650 items, so the old 455 limit rejects valid firmware. Raising it to 1020 fixes that without changing programming behavior. Regards, Viken ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] soc: qcom: geni-se: Increase MAX_GENI_CFG_RAMn_CNT to 1020 2026-06-22 17:15 ` Viken Dadhaniya @ 2026-06-23 6:50 ` Konrad Dybcio 2026-06-30 12:22 ` Viken Dadhaniya 0 siblings, 1 reply; 9+ messages in thread From: Konrad Dybcio @ 2026-06-23 6:50 UTC (permalink / raw) To: Viken Dadhaniya, Bjorn Andersson, Konrad Dybcio Cc: linux-arm-msm, linux-kernel On 6/22/26 7:15 PM, Viken Dadhaniya wrote: > > > On 6/15/2026 5:30 PM, Konrad Dybcio wrote: >> On 6/15/26 2:00 PM, Konrad Dybcio wrote: >>> On 6/15/26 7:28 AM, Viken Dadhaniya wrote: >>>> >>>> >>>> On 6/9/2026 8:40 PM, Konrad Dybcio wrote: >>>>> On 5/22/26 9:21 AM, Viken Dadhaniya wrote: >>>>>> The current MAX_GENI_CFG_RAMn_CNT value of 455 is insufficient for >>>>>> certain Qualcomm SoCs whose GENI firmware requires up to 1020 RAM >>>>>> entries, causing incorrect bounds checking and preventing firmware >>>>>> loading on those targets. >>>>>> >>>>>> Increase MAX_GENI_CFG_RAMn_CNT to 1020 to match the hardware-supported >>>>>> limit and ensure correct handling of configuration RAM regions across >>>>>> GENI-based SE blocks. >>>>>> >>>>>> Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> >>>>>> --- >>>>>> drivers/soc/qcom/qcom-geni-se.c | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c >>>>>> index cd1779b6a91a..d0810960f3da 100644 >>>>>> --- a/drivers/soc/qcom/qcom-geni-se.c >>>>>> +++ b/drivers/soc/qcom/qcom-geni-se.c >>>>>> @@ -152,7 +152,7 @@ struct se_fw_hdr { >>>>>> /*Magic numbers*/ >>>>>> #define SE_MAGIC_NUM 0x57464553 >>>>>> >>>>>> -#define MAX_GENI_CFG_RAMn_CNT 455 >>>>>> +#define MAX_GENI_CFG_RAMn_CNT 1020 >>>>> >>>>> Is there any SoC where this could overflow the register space >>>>> (you say "certain Qualcomm SoCs")? >>>> >>>> Yes, on Talos (QCS615), the firmware image needs more than 455 CFG RAM >>>> entries, so the previous limit could overflow. >>> >>> What I'm asking is whether the size of the RAM on any of the SoCs >>> is less than 455 (the previous limit) >> >> *Less than 1020 (the new limit), of course.. >> >> Konrad > > Yes, some SoCs like kodiak, monaco and lemans have CFG RAM smaller than > 455. But MAX_GENI_CFG_RAMn_CNT is only a firmware ceiling; the actual > programmed size comes from the firmware header. Talos needs ~650 items, > so the old 455 limit rejects valid firmware. Raising it to 1020 fixes > that without changing programming behavior. OK I tried to find whether there's a "ram size" register to limit it further (i.e. have a different upper bound for different platforms), but there doesn't seem to be one.. unless we can deduce it from the version register? Konrad ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] soc: qcom: geni-se: Increase MAX_GENI_CFG_RAMn_CNT to 1020 2026-06-23 6:50 ` Konrad Dybcio @ 2026-06-30 12:22 ` Viken Dadhaniya 2026-06-30 12:59 ` Konrad Dybcio 0 siblings, 1 reply; 9+ messages in thread From: Viken Dadhaniya @ 2026-06-30 12:22 UTC (permalink / raw) To: Konrad Dybcio, Bjorn Andersson, Konrad Dybcio; +Cc: linux-arm-msm, linux-kernel On 6/23/2026 12:20 PM, Konrad Dybcio wrote: > On 6/22/26 7:15 PM, Viken Dadhaniya wrote: >> >> >> On 6/15/2026 5:30 PM, Konrad Dybcio wrote: >>> On 6/15/26 2:00 PM, Konrad Dybcio wrote: >>>> On 6/15/26 7:28 AM, Viken Dadhaniya wrote: >>>>> >>>>> >>>>> On 6/9/2026 8:40 PM, Konrad Dybcio wrote: >>>>>> On 5/22/26 9:21 AM, Viken Dadhaniya wrote: >>>>>>> The current MAX_GENI_CFG_RAMn_CNT value of 455 is insufficient for >>>>>>> certain Qualcomm SoCs whose GENI firmware requires up to 1020 RAM >>>>>>> entries, causing incorrect bounds checking and preventing firmware >>>>>>> loading on those targets. >>>>>>> >>>>>>> Increase MAX_GENI_CFG_RAMn_CNT to 1020 to match the hardware-supported >>>>>>> limit and ensure correct handling of configuration RAM regions across >>>>>>> GENI-based SE blocks. >>>>>>> >>>>>>> Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> >>>>>>> --- >>>>>>> drivers/soc/qcom/qcom-geni-se.c | 2 +- >>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>> >>>>>>> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c >>>>>>> index cd1779b6a91a..d0810960f3da 100644 >>>>>>> --- a/drivers/soc/qcom/qcom-geni-se.c >>>>>>> +++ b/drivers/soc/qcom/qcom-geni-se.c >>>>>>> @@ -152,7 +152,7 @@ struct se_fw_hdr { >>>>>>> /*Magic numbers*/ >>>>>>> #define SE_MAGIC_NUM 0x57464553 >>>>>>> >>>>>>> -#define MAX_GENI_CFG_RAMn_CNT 455 >>>>>>> +#define MAX_GENI_CFG_RAMn_CNT 1020 >>>>>> >>>>>> Is there any SoC where this could overflow the register space >>>>>> (you say "certain Qualcomm SoCs")? >>>>> >>>>> Yes, on Talos (QCS615), the firmware image needs more than 455 CFG RAM >>>>> entries, so the previous limit could overflow. >>>> >>>> What I'm asking is whether the size of the RAM on any of the SoCs >>>> is less than 455 (the previous limit) >>> >>> *Less than 1020 (the new limit), of course.. >>> >>> Konrad >> >> Yes, some SoCs like kodiak, monaco and lemans have CFG RAM smaller than >> 455. But MAX_GENI_CFG_RAMn_CNT is only a firmware ceiling; the actual >> programmed size comes from the firmware header. Talos needs ~650 items, >> so the old 455 limit rejects valid firmware. Raising it to 1020 fixes >> that without changing programming behavior. > > OK > > I tried to find whether there's a "ram size" register to limit it further > (i.e. have a different upper bound for different platforms), but there > doesn't seem to be one.. unless we can deduce it from the version > register? > > Konrad Actually, there is: SE_HW_PARAM_2 has a PROG_RAM_DEPTH field that gives the exact CFG RAM depth for the instance. We can read it at runtime and use it as the upper bound directly, which makes the check accurate for all SoCs without hard-coding any constant. Will address this in v2. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] soc: qcom: geni-se: Increase MAX_GENI_CFG_RAMn_CNT to 1020 2026-06-30 12:22 ` Viken Dadhaniya @ 2026-06-30 12:59 ` Konrad Dybcio 0 siblings, 0 replies; 9+ messages in thread From: Konrad Dybcio @ 2026-06-30 12:59 UTC (permalink / raw) To: Viken Dadhaniya, Bjorn Andersson, Konrad Dybcio Cc: linux-arm-msm, linux-kernel On 6/30/26 2:22 PM, Viken Dadhaniya wrote: > > > On 6/23/2026 12:20 PM, Konrad Dybcio wrote: >> On 6/22/26 7:15 PM, Viken Dadhaniya wrote: >>> >>> >>> On 6/15/2026 5:30 PM, Konrad Dybcio wrote: >>>> On 6/15/26 2:00 PM, Konrad Dybcio wrote: >>>>> On 6/15/26 7:28 AM, Viken Dadhaniya wrote: >>>>>> >>>>>> >>>>>> On 6/9/2026 8:40 PM, Konrad Dybcio wrote: >>>>>>> On 5/22/26 9:21 AM, Viken Dadhaniya wrote: >>>>>>>> The current MAX_GENI_CFG_RAMn_CNT value of 455 is insufficient for >>>>>>>> certain Qualcomm SoCs whose GENI firmware requires up to 1020 RAM >>>>>>>> entries, causing incorrect bounds checking and preventing firmware >>>>>>>> loading on those targets. >>>>>>>> >>>>>>>> Increase MAX_GENI_CFG_RAMn_CNT to 1020 to match the hardware-supported >>>>>>>> limit and ensure correct handling of configuration RAM regions across >>>>>>>> GENI-based SE blocks. >>>>>>>> >>>>>>>> Signed-off-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> >>>>>>>> --- >>>>>>>> drivers/soc/qcom/qcom-geni-se.c | 2 +- >>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>>> >>>>>>>> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c >>>>>>>> index cd1779b6a91a..d0810960f3da 100644 >>>>>>>> --- a/drivers/soc/qcom/qcom-geni-se.c >>>>>>>> +++ b/drivers/soc/qcom/qcom-geni-se.c >>>>>>>> @@ -152,7 +152,7 @@ struct se_fw_hdr { >>>>>>>> /*Magic numbers*/ >>>>>>>> #define SE_MAGIC_NUM 0x57464553 >>>>>>>> >>>>>>>> -#define MAX_GENI_CFG_RAMn_CNT 455 >>>>>>>> +#define MAX_GENI_CFG_RAMn_CNT 1020 >>>>>>> >>>>>>> Is there any SoC where this could overflow the register space >>>>>>> (you say "certain Qualcomm SoCs")? >>>>>> >>>>>> Yes, on Talos (QCS615), the firmware image needs more than 455 CFG RAM >>>>>> entries, so the previous limit could overflow. >>>>> >>>>> What I'm asking is whether the size of the RAM on any of the SoCs >>>>> is less than 455 (the previous limit) >>>> >>>> *Less than 1020 (the new limit), of course.. >>>> >>>> Konrad >>> >>> Yes, some SoCs like kodiak, monaco and lemans have CFG RAM smaller than >>> 455. But MAX_GENI_CFG_RAMn_CNT is only a firmware ceiling; the actual >>> programmed size comes from the firmware header. Talos needs ~650 items, >>> so the old 455 limit rejects valid firmware. Raising it to 1020 fixes >>> that without changing programming behavior. >> >> OK >> >> I tried to find whether there's a "ram size" register to limit it further >> (i.e. have a different upper bound for different platforms), but there >> doesn't seem to be one.. unless we can deduce it from the version >> register? >> >> Konrad > > Actually, there is: SE_HW_PARAM_2 has a PROG_RAM_DEPTH field that gives the > exact CFG RAM depth for the instance. We can read it at runtime and use it > as the upper bound directly, which makes the check accurate for all SoCs > without hard-coding any constant. Amazing, nice find! Konrad ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-06-30 12:59 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2026-05-22 7:21 [PATCH v1] soc: qcom: geni-se: Increase MAX_GENI_CFG_RAMn_CNT to 1020 Viken Dadhaniya 2026-06-09 15:10 ` Konrad Dybcio 2026-06-15 5:28 ` Viken Dadhaniya 2026-06-15 12:00 ` Konrad Dybcio 2026-06-15 12:00 ` Konrad Dybcio 2026-06-22 17:15 ` Viken Dadhaniya 2026-06-23 6:50 ` Konrad Dybcio 2026-06-30 12:22 ` Viken Dadhaniya 2026-06-30 12:59 ` Konrad Dybcio
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®