* [PATCH v3 1/6] media: qcom: iris: add helpers for 8bit and 10bit formats
2026-05-11 9:20 ` [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats Neil Armstrong
@ 2026-05-11 9:20 ` Neil Armstrong
2026-05-13 10:25 ` Dmitry Baryshkov
2026-05-13 18:25 ` Vikash Garodia
2026-05-11 9:20 ` [PATCH v3 2/6] media: qcom: iris: add QC10C & P010 buffer size calculations Neil Armstrong
` (7 subsequent siblings)
8 siblings, 2 replies; 49+ messages in thread
From: Neil Armstrong @ 2026-05-11 9:20 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel, Neil Armstrong
To simplify code checking for pixel formats, add helpers to
check for 8bit and 10bit formats.
Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
drivers/media/platform/qcom/iris/iris_utils.c | 12 ++++++++++++
drivers/media/platform/qcom/iris/iris_utils.h | 2 ++
2 files changed, 14 insertions(+)
diff --git a/drivers/media/platform/qcom/iris/iris_utils.c b/drivers/media/platform/qcom/iris/iris_utils.c
index cfc5b576ec56..bdedd6bfa87a 100644
--- a/drivers/media/platform/qcom/iris/iris_utils.c
+++ b/drivers/media/platform/qcom/iris/iris_utils.c
@@ -38,6 +38,18 @@ bool iris_split_mode_enabled(struct iris_inst *inst)
inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC08C;
}
+bool iris_fmt_is_8bit(__u32 pixelformat)
+{
+ return pixelformat == V4L2_PIX_FMT_NV12 ||
+ pixelformat == V4L2_PIX_FMT_QC08C;
+}
+
+bool iris_fmt_is_10bit(__u32 pixelformat)
+{
+ return pixelformat == V4L2_PIX_FMT_P010 ||
+ pixelformat == V4L2_PIX_FMT_QC10C;
+}
+
void iris_helper_buffers_done(struct iris_inst *inst, unsigned int type,
enum vb2_buffer_state state)
{
diff --git a/drivers/media/platform/qcom/iris/iris_utils.h b/drivers/media/platform/qcom/iris/iris_utils.h
index b5705d156431..35337c5da005 100644
--- a/drivers/media/platform/qcom/iris/iris_utils.h
+++ b/drivers/media/platform/qcom/iris/iris_utils.h
@@ -45,6 +45,8 @@ bool iris_res_is_less_than(u32 width, u32 height,
u32 ref_width, u32 ref_height);
int iris_get_mbpf(struct iris_inst *inst);
bool iris_split_mode_enabled(struct iris_inst *inst);
+bool iris_fmt_is_8bit(__u32 pixelformat);
+bool iris_fmt_is_10bit(__u32 pixelformat);
struct iris_inst *iris_get_instance(struct iris_core *core, u32 session_id);
void iris_helper_buffers_done(struct iris_inst *inst, unsigned int type,
enum vb2_buffer_state state);
--
2.34.1
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 1/6] media: qcom: iris: add helpers for 8bit and 10bit formats
2026-05-11 9:20 ` [PATCH v3 1/6] media: qcom: iris: add helpers for 8bit and " Neil Armstrong
@ 2026-05-13 10:25 ` Dmitry Baryshkov
2026-05-13 18:25 ` Vikash Garodia
1 sibling, 0 replies; 49+ messages in thread
From: Dmitry Baryshkov @ 2026-05-13 10:25 UTC (permalink / raw)
To: Neil Armstrong
Cc: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, linux-media,
linux-arm-msm, linux-kernel
On Mon, May 11, 2026 at 11:20:26AM +0200, Neil Armstrong wrote:
> To simplify code checking for pixel formats, add helpers to
> check for 8bit and 10bit formats.
>
> Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> drivers/media/platform/qcom/iris/iris_utils.c | 12 ++++++++++++
> drivers/media/platform/qcom/iris/iris_utils.h | 2 ++
> 2 files changed, 14 insertions(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [PATCH v3 1/6] media: qcom: iris: add helpers for 8bit and 10bit formats
2026-05-11 9:20 ` [PATCH v3 1/6] media: qcom: iris: add helpers for 8bit and " Neil Armstrong
2026-05-13 10:25 ` Dmitry Baryshkov
@ 2026-05-13 18:25 ` Vikash Garodia
1 sibling, 0 replies; 49+ messages in thread
From: Vikash Garodia @ 2026-05-13 18:25 UTC (permalink / raw)
To: Neil Armstrong, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/11/2026 2:50 PM, Neil Armstrong wrote:
> To simplify code checking for pixel formats, add helpers to
> check for 8bit and 10bit formats.
>
> Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> drivers/media/platform/qcom/iris/iris_utils.c | 12 ++++++++++++
> drivers/media/platform/qcom/iris/iris_utils.h | 2 ++
> 2 files changed, 14 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_utils.c b/drivers/media/platform/qcom/iris/iris_utils.c
> index cfc5b576ec56..bdedd6bfa87a 100644
> --- a/drivers/media/platform/qcom/iris/iris_utils.c
> +++ b/drivers/media/platform/qcom/iris/iris_utils.c
> @@ -38,6 +38,18 @@ bool iris_split_mode_enabled(struct iris_inst *inst)
> inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC08C;
> }
>
> +bool iris_fmt_is_8bit(__u32 pixelformat)
u32 please, to maintain consistency with other
> +{
> + return pixelformat == V4L2_PIX_FMT_NV12 ||
> + pixelformat == V4L2_PIX_FMT_QC08C;
> +}
> +
> +bool iris_fmt_is_10bit(__u32 pixelformat)
same
> +{
> + return pixelformat == V4L2_PIX_FMT_P010 ||
> + pixelformat == V4L2_PIX_FMT_QC10C;
> +}
> +
> void iris_helper_buffers_done(struct iris_inst *inst, unsigned int type,
> enum vb2_buffer_state state)
> {
> diff --git a/drivers/media/platform/qcom/iris/iris_utils.h b/drivers/media/platform/qcom/iris/iris_utils.h
> index b5705d156431..35337c5da005 100644
> --- a/drivers/media/platform/qcom/iris/iris_utils.h
> +++ b/drivers/media/platform/qcom/iris/iris_utils.h
> @@ -45,6 +45,8 @@ bool iris_res_is_less_than(u32 width, u32 height,
> u32 ref_width, u32 ref_height);
> int iris_get_mbpf(struct iris_inst *inst);
> bool iris_split_mode_enabled(struct iris_inst *inst);
> +bool iris_fmt_is_8bit(__u32 pixelformat);
> +bool iris_fmt_is_10bit(__u32 pixelformat);
> struct iris_inst *iris_get_instance(struct iris_core *core, u32 session_id);
> void iris_helper_buffers_done(struct iris_inst *inst, unsigned int type,
> enum vb2_buffer_state state);
>
Regards,
Vikash
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v3 2/6] media: qcom: iris: add QC10C & P010 buffer size calculations
2026-05-11 9:20 ` [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats Neil Armstrong
2026-05-11 9:20 ` [PATCH v3 1/6] media: qcom: iris: add helpers for 8bit and " Neil Armstrong
@ 2026-05-11 9:20 ` Neil Armstrong
2026-05-13 18:43 ` Vikash Garodia
2026-05-11 9:20 ` [PATCH v3 3/6] media: qcom: iris: gen2: add support for 10bit decoding Neil Armstrong
` (6 subsequent siblings)
8 siblings, 1 reply; 49+ messages in thread
From: Neil Armstrong @ 2026-05-11 9:20 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel, Neil Armstrong
The P010 (YUV format with 16-bits per pixel with interleaved UV)
and QC10C (P010 compressed mode similar to QC08C) requires specific
buffer calculations to allocate the right buffer size for DPB frames
and frames consumed by userspace.
Similar to 8bit, the 10bit DPB frames uses QC10C format.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
drivers/media/platform/qcom/iris/iris_buffer.c | 195 ++++++++++++++++++++++++-
1 file changed, 194 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media/platform/qcom/iris/iris_buffer.c
index 1d53c7414b75..713a63d0ca0c 100644
--- a/drivers/media/platform/qcom/iris/iris_buffer.c
+++ b/drivers/media/platform/qcom/iris/iris_buffer.c
@@ -15,8 +15,11 @@
#define MAX_WIDTH 4096
#define MAX_HEIGHT 2304
#define Y_STRIDE_ALIGN 128
+#define Y_STRIDE_ALIGN_P010 256
#define UV_STRIDE_ALIGN 128
+#define UV_STRIDE_ALIGN_P010 256
#define Y_SCANLINE_ALIGN 32
+#define Y_SCANLINE_ALIGN_QC10C 16
#define UV_SCANLINE_ALIGN 16
#define UV_SCANLINE_ALIGN_QC08C 32
#define META_STRIDE_ALIGNED 64
@@ -80,6 +83,63 @@ static u32 iris_yuv_buffer_size_nv12(struct iris_inst *inst)
return ALIGN(y_plane + uv_plane, PIXELS_4K);
}
+/*
+ * P010:
+ * YUV 4:2:0 image with a plane of 10 bit Y samples followed
+ * by an interleaved U/V plane containing 10 bit 2x2 subsampled
+ * colour difference samples.
+ *
+ * <-Y/UV_Stride (aligned to 256)->
+ * <----- Width*2 ------->
+ * Y Y Y Y Y Y Y Y Y Y Y Y . . . . ^ ^
+ * Y Y Y Y Y Y Y Y Y Y Y Y . . . . | |
+ * Y Y Y Y Y Y Y Y Y Y Y Y . . . . Height |
+ * Y Y Y Y Y Y Y Y Y Y Y Y . . . . | y_scanlines (aligned to 32)
+ * Y Y Y Y Y Y Y Y Y Y Y Y . . . . | |
+ * Y Y Y Y Y Y Y Y Y Y Y Y . . . . | |
+ * Y Y Y Y Y Y Y Y Y Y Y Y . . . . | |
+ * Y Y Y Y Y Y Y Y Y Y Y Y . . . . V |
+ * . . . . . . . . . . . . . . . . |
+ * . . . . . . . . . . . . . . . . |
+ * . . . . . . . . . . . . . . . . |
+ * . . . . . . . . . . . . . . . . V
+ * U V U V U V U V U V U V . . . . ^
+ * U V U V U V U V U V U V . . . . |
+ * U V U V U V U V U V U V . . . . |
+ * U V U V U V U V U V U V . . . . uv_scanlines (aligned to 16)
+ * . . . . . . . . . . . . . . . . |
+ * . . . . . . . . . . . . . . . . V
+ * . . . . . . . . . . . . . . . . --> Buffer size aligned to 4K
+ *
+ * y_stride : Width*2 aligned to 256
+ * uv_stride : Width*2 aligned to 256
+ * y_scanlines: Height aligned to 32
+ * uv_scanlines: Height/2 aligned to 16
+ * Total size = align((y_stride * y_scanlines
+ * + uv_stride * uv_scanlines , 4096)
+ *
+ * Note: All the alignments are hardware requirements.
+ */
+static u32 iris_yuv_buffer_size_p010(struct iris_inst *inst)
+{
+ u32 y_plane, uv_plane, y_stride, uv_stride, y_scanlines, uv_scanlines;
+ struct v4l2_format *f;
+
+ if (inst->domain == DECODER)
+ f = inst->fmt_dst;
+ else
+ f = inst->fmt_src;
+
+ y_stride = ALIGN(f->fmt.pix_mp.width * 2, Y_STRIDE_ALIGN_P010);
+ uv_stride = ALIGN(f->fmt.pix_mp.width * 2, UV_STRIDE_ALIGN_P010);
+ y_scanlines = ALIGN(f->fmt.pix_mp.height, Y_SCANLINE_ALIGN);
+ uv_scanlines = ALIGN((f->fmt.pix_mp.height + 1) >> 1, UV_SCANLINE_ALIGN);
+ y_plane = y_stride * y_scanlines;
+ uv_plane = uv_stride * uv_scanlines;
+
+ return ALIGN(y_plane + uv_plane, PIXELS_4K);
+}
+
/*
* QC08C:
* Compressed Macro-tile format for NV12.
@@ -204,6 +264,132 @@ static u32 iris_yuv_buffer_size_qc08c(struct iris_inst *inst)
return ALIGN(y_meta_plane + y_plane + uv_meta_plane + uv_plane, PIXELS_4K);
}
+/*
+ * QC10C:
+ * UBWC-compressed format for P010.
+ * Contains 4 planes in the following order -
+ * (A) Y_Meta_Plane
+ * (B) Y_UBWC_Plane
+ * (C) UV_Meta_Plane
+ * (D) UV_UBWC_Plane
+ *
+ * Y_Meta_Plane consists of meta information to decode compressed
+ * tile data in Y_UBWC_Plane.
+ * Y_UBWC_Plane consists of Y data in compressed macro-tile format.
+ * UBWC decoder block will use the Y_Meta_Plane data together with
+ * Y_UBWC_Plane data to produce loss-less uncompressed 10 bit Y samples.
+ *
+ * UV_Meta_Plane consists of meta information to decode compressed
+ * tile data in UV_UBWC_Plane.
+ * UV_UBWC_Plane consists of UV data in compressed macro-tile format.
+ * UBWC decoder block will use UV_Meta_Plane data together with
+ * UV_UBWC_Plane data to produce loss-less uncompressed 10 bit 2x2
+ * subsampled color difference samples.
+ *
+ * Each tile in Y_UBWC_Plane/UV_UBWC_Plane is independently decodable
+ * and randomly accessible. There is no dependency between tiles.
+ *
+ * <----- Y Meta stride -----> (aligned to 64)
+ * <-------- Width ----------> (aligned to 48)
+ * M M M M M M M M M M M M . . ^ ^
+ * M M M M M M M M M M M M . . | |
+ * M M M M M M M M M M M M . . Height |
+ * M M M M M M M M M M M M . . | Meta_Y_Scanlines (aligned to 16)
+ * M M M M M M M M M M M M . . | |
+ * M M M M M M M M M M M M . . | |
+ * M M M M M M M M M M M M . . | |
+ * M M M M M M M M M M M M . . V |
+ * . . . . . . . . . . . . . . |
+ * . . . . . . . . . . . . . . |
+ * . . . . . . . . . . . . . . -------> Buffer size aligned to 4k
+ * . . . . . . . . . . . . . . V
+ * <--Compressed tile Y stride --> (aligned to 256)
+ * <------- Width * 4/3 ---------> (aligned to 48)
+ * Y* Y* Y* Y* Y* Y* Y* Y* . . . . ^ ^
+ * Y* Y* Y* Y* Y* Y* Y* Y* . . . . | |
+ * Y* Y* Y* Y* Y* Y* Y* Y* . . . . Height |
+ * Y* Y* Y* Y* Y* Y* Y* Y* . . . . | Macro_tile_Y_Scanlines (aligned to 16)
+ * Y* Y* Y* Y* Y* Y* Y* Y* . . . . | |
+ * Y* Y* Y* Y* Y* Y* Y* Y* . . . . | |
+ * Y* Y* Y* Y* Y* Y* Y* Y* . . . . | |
+ * Y* Y* Y* Y* Y* Y* Y* Y* . . . . V |
+ * . . . . . . . . . . . . . . . . |
+ * . . . . . . . . . . . . . . . . |
+ * . . . . . . . . . . . . . . . . -------> Buffer size aligned to 4k
+ * . . . . . . . . . . . . . . . . V
+ * <---- UV Meta stride ----> (aligned to 64)
+ * <----- Width / 2 --------> (aligned to 24)
+ * M M M M M M M M M M M M . . ^ ^
+ * M M M M M M M M M M M M . . | |
+ * M M M M M M M M M M M M . . Height/2 |
+ * M M M M M M M M M M M M . . V M_UV_Scanlines (aligned to 16)
+ * . . . . . . . . . . . . . . |
+ * . . . . . . . . . . . . . . V
+ * . . . . . . . . . . . . . . -------> Buffer size aligned to 4k
+ * <--Compressed tile UV stride--> (aligned to 256)
+ * <------- Width * 4/3 ---------> (aligned to 48)
+ * U* V* U* V* U* V* U* V* . . . . ^
+ * U* V* U* V* U* V* U* V* . . . . |
+ * U* V* U* V* U* V* U* V* . . . . |
+ * U* V* U* V* U* V* U* V* . . . . UV_Scanlines (aligned to 16)
+ * . . . . . . . . . . . . . . . . |
+ * . . . . . . . . . . . . . . . . V
+ * . . . . . . . . . . . . . . . . -------> Buffer size aligned to 4k
+ *
+ * y_stride: width aligned to 256
+ * uv_stride: width aligned to 256
+ * y_scanlines: height aligned to 16
+ * uv_scanlines: height aligned to 16
+ * y_plane: buffer size aligned to 4096
+ * uv_plane: buffer size aligned to 4096
+ * y_meta_stride: width aligned to 64
+ * y_meta_scanlines: height aligned to 16
+ * y_meta_plane: buffer size aligned to 4096
+ * uv_meta_stride: width aligned to 64
+ * uv_meta_scanlines: height aligned to 16
+ * uv_meta_plane: buffer size aligned to 4096
+ *
+ * Total size = align( y_plane + uv_plane +
+ * y_meta_plane + uv_meta_plane, 4096)
+ *
+ * Note: All the alignments are hardware requirements.
+ */
+static u32 iris_yuv_buffer_size_qc10c(struct iris_inst *inst)
+{
+ u32 y_plane, uv_plane, y_stride, uv_stride;
+ u32 uv_meta_stride, uv_meta_plane;
+ u32 y_meta_stride, y_meta_plane;
+ struct v4l2_format *f = NULL;
+
+ if (inst->domain == DECODER)
+ f = inst->fmt_dst;
+ else
+ f = inst->fmt_src;
+
+ y_meta_stride = ALIGN(DIV_ROUND_UP(f->fmt.pix_mp.width, 48),
+ META_STRIDE_ALIGNED);
+ y_meta_plane = y_meta_stride * ALIGN(DIV_ROUND_UP(f->fmt.pix_mp.height, 4),
+ META_SCANLINE_ALIGNED);
+ y_meta_plane = ALIGN(y_meta_plane, PIXELS_4K);
+
+ y_stride = ALIGN(f->fmt.pix_mp.width * 4 / 3, Y_STRIDE_ALIGN_P010);
+ y_plane = ALIGN(y_stride * ALIGN(f->fmt.pix_mp.height, Y_SCANLINE_ALIGN_QC10C),
+ PIXELS_4K);
+
+ uv_meta_stride = ALIGN(DIV_ROUND_UP((f->fmt.pix_mp.width + 1) / 2, 24),
+ META_STRIDE_ALIGNED);
+ uv_meta_plane = uv_meta_stride *
+ ALIGN(DIV_ROUND_UP((f->fmt.pix_mp.height + 1) / 2, 4),
+ META_SCANLINE_ALIGNED);
+ uv_meta_plane = ALIGN(uv_meta_plane, PIXELS_4K);
+
+ uv_stride = ALIGN(f->fmt.pix_mp.width * 4 / 3, UV_STRIDE_ALIGN_P010);
+ uv_plane = ALIGN(uv_stride * ALIGN((f->fmt.pix_mp.height + 1) / 2, UV_SCANLINE_ALIGN),
+ PIXELS_4K);
+
+ return ALIGN(y_meta_plane + y_plane + uv_meta_plane + uv_plane, PIXELS_4K);
+}
+
static u32 iris_dec_bitstream_buffer_size(struct iris_inst *inst)
{
struct platform_inst_caps *caps = inst->core->iris_platform_data->inst_caps;
@@ -268,10 +454,17 @@ int iris_get_buffer_size(struct iris_inst *inst,
case BUF_OUTPUT:
if (inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC08C)
return iris_yuv_buffer_size_qc08c(inst);
+ else if (inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC10C)
+ return iris_yuv_buffer_size_qc10c(inst);
+ else if (inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_P010)
+ return iris_yuv_buffer_size_p010(inst);
else
return iris_yuv_buffer_size_nv12(inst);
case BUF_DPB:
- return iris_yuv_buffer_size_qc08c(inst);
+ if (iris_fmt_is_10bit(inst->fmt_dst->fmt.pix_mp.pixelformat))
+ return iris_yuv_buffer_size_qc10c(inst);
+ else
+ return iris_yuv_buffer_size_qc08c(inst);
default:
return 0;
}
--
2.34.1
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 2/6] media: qcom: iris: add QC10C & P010 buffer size calculations
2026-05-11 9:20 ` [PATCH v3 2/6] media: qcom: iris: add QC10C & P010 buffer size calculations Neil Armstrong
@ 2026-05-13 18:43 ` Vikash Garodia
2026-05-21 8:50 ` Neil Armstrong
0 siblings, 1 reply; 49+ messages in thread
From: Vikash Garodia @ 2026-05-13 18:43 UTC (permalink / raw)
To: Neil Armstrong, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/11/2026 2:50 PM, Neil Armstrong wrote:
> The P010 (YUV format with 16-bits per pixel with interleaved UV)
> and QC10C (P010 compressed mode similar to QC08C) requires specific
> buffer calculations to allocate the right buffer size for DPB frames
expand DPB
> and frames consumed by userspace.
>
> Similar to 8bit, the 10bit DPB frames uses QC10C format.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> drivers/media/platform/qcom/iris/iris_buffer.c | 195 ++++++++++++++++++++++++-
> 1 file changed, 194 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media/platform/qcom/iris/iris_buffer.c
> index 1d53c7414b75..713a63d0ca0c 100644
> --- a/drivers/media/platform/qcom/iris/iris_buffer.c
> +++ b/drivers/media/platform/qcom/iris/iris_buffer.c
> @@ -15,8 +15,11 @@
> #define MAX_WIDTH 4096
> #define MAX_HEIGHT 2304
> #define Y_STRIDE_ALIGN 128
> +#define Y_STRIDE_ALIGN_P010 256
> #define UV_STRIDE_ALIGN 128
> +#define UV_STRIDE_ALIGN_P010 256
> #define Y_SCANLINE_ALIGN 32
> +#define Y_SCANLINE_ALIGN_QC10C 16
> #define UV_SCANLINE_ALIGN 16
> #define UV_SCANLINE_ALIGN_QC08C 32
> #define META_STRIDE_ALIGNED 64
> @@ -80,6 +83,63 @@ static u32 iris_yuv_buffer_size_nv12(struct iris_inst *inst)
> return ALIGN(y_plane + uv_plane, PIXELS_4K);
> }
>
> +/*
> + * P010:
> + * YUV 4:2:0 image with a plane of 10 bit Y samples followed
> + * by an interleaved U/V plane containing 10 bit 2x2 subsampled
> + * colour difference samples.
> + *
> + * <-Y/UV_Stride (aligned to 256)->
> + * <----- Width*2 ------->
> + * Y Y Y Y Y Y Y Y Y Y Y Y . . . . ^ ^
> + * Y Y Y Y Y Y Y Y Y Y Y Y . . . . | |
> + * Y Y Y Y Y Y Y Y Y Y Y Y . . . . Height |
> + * Y Y Y Y Y Y Y Y Y Y Y Y . . . . | y_scanlines (aligned to 32)
> + * Y Y Y Y Y Y Y Y Y Y Y Y . . . . | |
> + * Y Y Y Y Y Y Y Y Y Y Y Y . . . . | |
> + * Y Y Y Y Y Y Y Y Y Y Y Y . . . . | |
> + * Y Y Y Y Y Y Y Y Y Y Y Y . . . . V |
> + * . . . . . . . . . . . . . . . . |
> + * . . . . . . . . . . . . . . . . |
> + * . . . . . . . . . . . . . . . . |
> + * . . . . . . . . . . . . . . . . V
> + * U V U V U V U V U V U V . . . . ^
> + * U V U V U V U V U V U V . . . . |
> + * U V U V U V U V U V U V . . . . |
> + * U V U V U V U V U V U V . . . . uv_scanlines (aligned to 16)
> + * . . . . . . . . . . . . . . . . |
> + * . . . . . . . . . . . . . . . . V
> + * . . . . . . . . . . . . . . . . --> Buffer size aligned to 4K
> + *
> + * y_stride : Width*2 aligned to 256
> + * uv_stride : Width*2 aligned to 256
> + * y_scanlines: Height aligned to 32
> + * uv_scanlines: Height/2 aligned to 16
> + * Total size = align((y_stride * y_scanlines
> + * + uv_stride * uv_scanlines , 4096)
> + *
> + * Note: All the alignments are hardware requirements.
> + */
> +static u32 iris_yuv_buffer_size_p010(struct iris_inst *inst)
> +{
> + u32 y_plane, uv_plane, y_stride, uv_stride, y_scanlines, uv_scanlines;
> + struct v4l2_format *f;
> +
> + if (inst->domain == DECODER)
> + f = inst->fmt_dst;
> + else
> + f = inst->fmt_src;
> +
> + y_stride = ALIGN(f->fmt.pix_mp.width * 2, Y_STRIDE_ALIGN_P010);
> + uv_stride = ALIGN(f->fmt.pix_mp.width * 2, UV_STRIDE_ALIGN_P010);
> + y_scanlines = ALIGN(f->fmt.pix_mp.height, Y_SCANLINE_ALIGN);
> + uv_scanlines = ALIGN((f->fmt.pix_mp.height + 1) >> 1, UV_SCANLINE_ALIGN);
> + y_plane = y_stride * y_scanlines;
> + uv_plane = uv_stride * uv_scanlines;
> +
> + return ALIGN(y_plane + uv_plane, PIXELS_4K);
> +}
> +
> /*
> * QC08C:
> * Compressed Macro-tile format for NV12.
> @@ -204,6 +264,132 @@ static u32 iris_yuv_buffer_size_qc08c(struct iris_inst *inst)
> return ALIGN(y_meta_plane + y_plane + uv_meta_plane + uv_plane, PIXELS_4K);
> }
>
> +/*
> + * QC10C:
> + * UBWC-compressed format for P010.
> + * Contains 4 planes in the following order -
> + * (A) Y_Meta_Plane
> + * (B) Y_UBWC_Plane
> + * (C) UV_Meta_Plane
> + * (D) UV_UBWC_Plane
> + *
> + * Y_Meta_Plane consists of meta information to decode compressed
> + * tile data in Y_UBWC_Plane.
> + * Y_UBWC_Plane consists of Y data in compressed macro-tile format.
> + * UBWC decoder block will use the Y_Meta_Plane data together with
> + * Y_UBWC_Plane data to produce loss-less uncompressed 10 bit Y samples.
> + *
> + * UV_Meta_Plane consists of meta information to decode compressed
> + * tile data in UV_UBWC_Plane.
> + * UV_UBWC_Plane consists of UV data in compressed macro-tile format.
> + * UBWC decoder block will use UV_Meta_Plane data together with
> + * UV_UBWC_Plane data to produce loss-less uncompressed 10 bit 2x2
> + * subsampled color difference samples.
> + *
> + * Each tile in Y_UBWC_Plane/UV_UBWC_Plane is independently decodable
> + * and randomly accessible. There is no dependency between tiles.
> + *
> + * <----- Y Meta stride -----> (aligned to 64)
> + * <-------- Width ----------> (aligned to 48)
> + * M M M M M M M M M M M M . . ^ ^
> + * M M M M M M M M M M M M . . | |
> + * M M M M M M M M M M M M . . Height |
> + * M M M M M M M M M M M M . . | Meta_Y_Scanlines (aligned to 16)
> + * M M M M M M M M M M M M . . | |
> + * M M M M M M M M M M M M . . | |
> + * M M M M M M M M M M M M . . | |
> + * M M M M M M M M M M M M . . V |
> + * . . . . . . . . . . . . . . |
> + * . . . . . . . . . . . . . . |
> + * . . . . . . . . . . . . . . -------> Buffer size aligned to 4k
> + * . . . . . . . . . . . . . . V
> + * <--Compressed tile Y stride --> (aligned to 256)
> + * <------- Width * 4/3 ---------> (aligned to 48)
> + * Y* Y* Y* Y* Y* Y* Y* Y* . . . . ^ ^
> + * Y* Y* Y* Y* Y* Y* Y* Y* . . . . | |
> + * Y* Y* Y* Y* Y* Y* Y* Y* . . . . Height |
> + * Y* Y* Y* Y* Y* Y* Y* Y* . . . . | Macro_tile_Y_Scanlines (aligned to 16)
> + * Y* Y* Y* Y* Y* Y* Y* Y* . . . . | |
> + * Y* Y* Y* Y* Y* Y* Y* Y* . . . . | |
> + * Y* Y* Y* Y* Y* Y* Y* Y* . . . . | |
> + * Y* Y* Y* Y* Y* Y* Y* Y* . . . . V |
> + * . . . . . . . . . . . . . . . . |
> + * . . . . . . . . . . . . . . . . |
> + * . . . . . . . . . . . . . . . . -------> Buffer size aligned to 4k
> + * . . . . . . . . . . . . . . . . V
> + * <---- UV Meta stride ----> (aligned to 64)
> + * <----- Width / 2 --------> (aligned to 24)
> + * M M M M M M M M M M M M . . ^ ^
> + * M M M M M M M M M M M M . . | |
> + * M M M M M M M M M M M M . . Height/2 |
> + * M M M M M M M M M M M M . . V M_UV_Scanlines (aligned to 16)
> + * . . . . . . . . . . . . . . |
> + * . . . . . . . . . . . . . . V
> + * . . . . . . . . . . . . . . -------> Buffer size aligned to 4k
> + * <--Compressed tile UV stride--> (aligned to 256)
> + * <------- Width * 4/3 ---------> (aligned to 48)
> + * U* V* U* V* U* V* U* V* . . . . ^
> + * U* V* U* V* U* V* U* V* . . . . |
> + * U* V* U* V* U* V* U* V* . . . . |
> + * U* V* U* V* U* V* U* V* . . . . UV_Scanlines (aligned to 16)
> + * . . . . . . . . . . . . . . . . |
> + * . . . . . . . . . . . . . . . . V
> + * . . . . . . . . . . . . . . . . -------> Buffer size aligned to 4k
> + *
> + * y_stride: width aligned to 256
> + * uv_stride: width aligned to 256
This does not match with above layout
> + * y_scanlines: height aligned to 16
> + * uv_scanlines: height aligned to 16
> + * y_plane: buffer size aligned to 4096
> + * uv_plane: buffer size aligned to 4096
> + * y_meta_stride: width aligned to 64
> + * y_meta_scanlines: height aligned to 16
> + * y_meta_plane: buffer size aligned to 4096
> + * uv_meta_stride: width aligned to 64
> + * uv_meta_scanlines: height aligned to 16
> + * uv_meta_plane: buffer size aligned to 4096
> + *
> + * Total size = align( y_plane + uv_plane +
> + * y_meta_plane + uv_meta_plane, 4096)
> + *
> + * Note: All the alignments are hardware requirements.
> + */
> +static u32 iris_yuv_buffer_size_qc10c(struct iris_inst *inst)
> +{
> + u32 y_plane, uv_plane, y_stride, uv_stride;
> + u32 uv_meta_stride, uv_meta_plane;
> + u32 y_meta_stride, y_meta_plane;
> + struct v4l2_format *f = NULL;
drop NULL
> +
> + if (inst->domain == DECODER)
> + f = inst->fmt_dst;
> + else
> + f = inst->fmt_src;
> +
> + y_meta_stride = ALIGN(DIV_ROUND_UP(f->fmt.pix_mp.width, 48),
> + META_STRIDE_ALIGNED);
> + y_meta_plane = y_meta_stride * ALIGN(DIV_ROUND_UP(f->fmt.pix_mp.height, 4),
> + META_SCANLINE_ALIGNED);
> + y_meta_plane = ALIGN(y_meta_plane, PIXELS_4K);
> +
> + y_stride = ALIGN(f->fmt.pix_mp.width * 4 / 3, Y_STRIDE_ALIGN_P010);
> + y_plane = ALIGN(y_stride * ALIGN(f->fmt.pix_mp.height, Y_SCANLINE_ALIGN_QC10C),
> + PIXELS_4K);
> +
> + uv_meta_stride = ALIGN(DIV_ROUND_UP((f->fmt.pix_mp.width + 1) / 2, 24),
> + META_STRIDE_ALIGNED);
> + uv_meta_plane = uv_meta_stride *
> + ALIGN(DIV_ROUND_UP((f->fmt.pix_mp.height + 1) / 2, 4),
> + META_SCANLINE_ALIGNED);
Please use >> 1 throughout for consistency. I see
iris_yuv_buffer_size_p010() uses them, while
iris_yuv_buffer_size_qc10c() dont.
> + uv_meta_plane = ALIGN(uv_meta_plane, PIXELS_4K);
> +
> + uv_stride = ALIGN(f->fmt.pix_mp.width * 4 / 3, UV_STRIDE_ALIGN_P010);
> + uv_plane = ALIGN(uv_stride * ALIGN((f->fmt.pix_mp.height + 1) / 2, UV_SCANLINE_ALIGN),
> + PIXELS_4K);
> +
> + return ALIGN(y_meta_plane + y_plane + uv_meta_plane + uv_plane, PIXELS_4K);
> +}
> +
> static u32 iris_dec_bitstream_buffer_size(struct iris_inst *inst)
> {
> struct platform_inst_caps *caps = inst->core->iris_platform_data->inst_caps;
> @@ -268,10 +454,17 @@ int iris_get_buffer_size(struct iris_inst *inst,
> case BUF_OUTPUT:
> if (inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC08C)
> return iris_yuv_buffer_size_qc08c(inst);
> + else if (inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC10C)
> + return iris_yuv_buffer_size_qc10c(inst);
> + else if (inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_P010)
> + return iris_yuv_buffer_size_p010(inst);
> else
> return iris_yuv_buffer_size_nv12(inst);
> case BUF_DPB:
> - return iris_yuv_buffer_size_qc08c(inst);
> + if (iris_fmt_is_10bit(inst->fmt_dst->fmt.pix_mp.pixelformat))
> + return iris_yuv_buffer_size_qc10c(inst);
> + else
> + return iris_yuv_buffer_size_qc08c(inst);
> default:
> return 0;
> }
>
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 2/6] media: qcom: iris: add QC10C & P010 buffer size calculations
2026-05-13 18:43 ` Vikash Garodia
@ 2026-05-21 8:50 ` Neil Armstrong
0 siblings, 0 replies; 49+ messages in thread
From: Neil Armstrong @ 2026-05-21 8:50 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/13/26 20:43, Vikash Garodia wrote:
>
> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>> The P010 (YUV format with 16-bits per pixel with interleaved UV)
>> and QC10C (P010 compressed mode similar to QC08C) requires specific
>> buffer calculations to allocate the right buffer size for DPB frames
>
> expand DPB
>
>> and frames consumed by userspace.
>>
>> Similar to 8bit, the 10bit DPB frames uses QC10C format.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> drivers/media/platform/qcom/iris/iris_buffer.c | 195 ++++++++++++++++++++++++-
>> 1 file changed, 194 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media/platform/qcom/iris/iris_buffer.c
>> index 1d53c7414b75..713a63d0ca0c 100644
>> --- a/drivers/media/platform/qcom/iris/iris_buffer.c
>> +++ b/drivers/media/platform/qcom/iris/iris_buffer.c
>> @@ -15,8 +15,11 @@
>> #define MAX_WIDTH 4096
>> #define MAX_HEIGHT 2304
>> #define Y_STRIDE_ALIGN 128
>> +#define Y_STRIDE_ALIGN_P010 256
>> #define UV_STRIDE_ALIGN 128
>> +#define UV_STRIDE_ALIGN_P010 256
>> #define Y_SCANLINE_ALIGN 32
>> +#define Y_SCANLINE_ALIGN_QC10C 16
>> #define UV_SCANLINE_ALIGN 16
>> #define UV_SCANLINE_ALIGN_QC08C 32
>> #define META_STRIDE_ALIGNED 64
>> @@ -80,6 +83,63 @@ static u32 iris_yuv_buffer_size_nv12(struct iris_inst *inst)
>> return ALIGN(y_plane + uv_plane, PIXELS_4K);
>> }
>> +/*
>> + * P010:
>> + * YUV 4:2:0 image with a plane of 10 bit Y samples followed
>> + * by an interleaved U/V plane containing 10 bit 2x2 subsampled
>> + * colour difference samples.
>> + *
>> + * <-Y/UV_Stride (aligned to 256)->
>> + * <----- Width*2 ------->
>> + * Y Y Y Y Y Y Y Y Y Y Y Y . . . . ^ ^
>> + * Y Y Y Y Y Y Y Y Y Y Y Y . . . . | |
>> + * Y Y Y Y Y Y Y Y Y Y Y Y . . . . Height |
>> + * Y Y Y Y Y Y Y Y Y Y Y Y . . . . | y_scanlines (aligned to 32)
>> + * Y Y Y Y Y Y Y Y Y Y Y Y . . . . | |
>> + * Y Y Y Y Y Y Y Y Y Y Y Y . . . . | |
>> + * Y Y Y Y Y Y Y Y Y Y Y Y . . . . | |
>> + * Y Y Y Y Y Y Y Y Y Y Y Y . . . . V |
>> + * . . . . . . . . . . . . . . . . |
>> + * . . . . . . . . . . . . . . . . |
>> + * . . . . . . . . . . . . . . . . |
>> + * . . . . . . . . . . . . . . . . V
>> + * U V U V U V U V U V U V . . . . ^
>> + * U V U V U V U V U V U V . . . . |
>> + * U V U V U V U V U V U V . . . . |
>> + * U V U V U V U V U V U V . . . . uv_scanlines (aligned to 16)
>> + * . . . . . . . . . . . . . . . . |
>> + * . . . . . . . . . . . . . . . . V
>> + * . . . . . . . . . . . . . . . . --> Buffer size aligned to 4K
>> + *
>> + * y_stride : Width*2 aligned to 256
>> + * uv_stride : Width*2 aligned to 256
>> + * y_scanlines: Height aligned to 32
>> + * uv_scanlines: Height/2 aligned to 16
>> + * Total size = align((y_stride * y_scanlines
>> + * + uv_stride * uv_scanlines , 4096)
>> + *
>> + * Note: All the alignments are hardware requirements.
>> + */
>> +static u32 iris_yuv_buffer_size_p010(struct iris_inst *inst)
>> +{
>> + u32 y_plane, uv_plane, y_stride, uv_stride, y_scanlines, uv_scanlines;
>> + struct v4l2_format *f;
>> +
>> + if (inst->domain == DECODER)
>> + f = inst->fmt_dst;
>> + else
>> + f = inst->fmt_src;
>> +
>> + y_stride = ALIGN(f->fmt.pix_mp.width * 2, Y_STRIDE_ALIGN_P010);
>> + uv_stride = ALIGN(f->fmt.pix_mp.width * 2, UV_STRIDE_ALIGN_P010);
>> + y_scanlines = ALIGN(f->fmt.pix_mp.height, Y_SCANLINE_ALIGN);
>> + uv_scanlines = ALIGN((f->fmt.pix_mp.height + 1) >> 1, UV_SCANLINE_ALIGN);
>> + y_plane = y_stride * y_scanlines;
>> + uv_plane = uv_stride * uv_scanlines;
>> +
>> + return ALIGN(y_plane + uv_plane, PIXELS_4K);
>> +}
>> +
>> /*
>> * QC08C:
>> * Compressed Macro-tile format for NV12.
>> @@ -204,6 +264,132 @@ static u32 iris_yuv_buffer_size_qc08c(struct iris_inst *inst)
>> return ALIGN(y_meta_plane + y_plane + uv_meta_plane + uv_plane, PIXELS_4K);
>> }
>> +/*
>> + * QC10C:
>> + * UBWC-compressed format for P010.
>> + * Contains 4 planes in the following order -
>> + * (A) Y_Meta_Plane
>> + * (B) Y_UBWC_Plane
>> + * (C) UV_Meta_Plane
>> + * (D) UV_UBWC_Plane
>> + *
>> + * Y_Meta_Plane consists of meta information to decode compressed
>> + * tile data in Y_UBWC_Plane.
>> + * Y_UBWC_Plane consists of Y data in compressed macro-tile format.
>> + * UBWC decoder block will use the Y_Meta_Plane data together with
>> + * Y_UBWC_Plane data to produce loss-less uncompressed 10 bit Y samples.
>> + *
>> + * UV_Meta_Plane consists of meta information to decode compressed
>> + * tile data in UV_UBWC_Plane.
>> + * UV_UBWC_Plane consists of UV data in compressed macro-tile format.
>> + * UBWC decoder block will use UV_Meta_Plane data together with
>> + * UV_UBWC_Plane data to produce loss-less uncompressed 10 bit 2x2
>> + * subsampled color difference samples.
>> + *
>> + * Each tile in Y_UBWC_Plane/UV_UBWC_Plane is independently decodable
>> + * and randomly accessible. There is no dependency between tiles.
>> + *
>> + * <----- Y Meta stride -----> (aligned to 64)
>> + * <-------- Width ----------> (aligned to 48)
>> + * M M M M M M M M M M M M . . ^ ^
>> + * M M M M M M M M M M M M . . | |
>> + * M M M M M M M M M M M M . . Height |
>> + * M M M M M M M M M M M M . . | Meta_Y_Scanlines (aligned to 16)
>> + * M M M M M M M M M M M M . . | |
>> + * M M M M M M M M M M M M . . | |
>> + * M M M M M M M M M M M M . . | |
>> + * M M M M M M M M M M M M . . V |
>> + * . . . . . . . . . . . . . . |
>> + * . . . . . . . . . . . . . . |
>> + * . . . . . . . . . . . . . . -------> Buffer size aligned to 4k
>> + * . . . . . . . . . . . . . . V
>> + * <--Compressed tile Y stride --> (aligned to 256)
>> + * <------- Width * 4/3 ---------> (aligned to 48)
>> + * Y* Y* Y* Y* Y* Y* Y* Y* . . . . ^ ^
>> + * Y* Y* Y* Y* Y* Y* Y* Y* . . . . | |
>> + * Y* Y* Y* Y* Y* Y* Y* Y* . . . . Height |
>> + * Y* Y* Y* Y* Y* Y* Y* Y* . . . . | Macro_tile_Y_Scanlines (aligned to 16)
>> + * Y* Y* Y* Y* Y* Y* Y* Y* . . . . | |
>> + * Y* Y* Y* Y* Y* Y* Y* Y* . . . . | |
>> + * Y* Y* Y* Y* Y* Y* Y* Y* . . . . | |
>> + * Y* Y* Y* Y* Y* Y* Y* Y* . . . . V |
>> + * . . . . . . . . . . . . . . . . |
>> + * . . . . . . . . . . . . . . . . |
>> + * . . . . . . . . . . . . . . . . -------> Buffer size aligned to 4k
>> + * . . . . . . . . . . . . . . . . V
>> + * <---- UV Meta stride ----> (aligned to 64)
>> + * <----- Width / 2 --------> (aligned to 24)
>> + * M M M M M M M M M M M M . . ^ ^
>> + * M M M M M M M M M M M M . . | |
>> + * M M M M M M M M M M M M . . Height/2 |
>> + * M M M M M M M M M M M M . . V M_UV_Scanlines (aligned to 16)
>> + * . . . . . . . . . . . . . . |
>> + * . . . . . . . . . . . . . . V
>> + * . . . . . . . . . . . . . . -------> Buffer size aligned to 4k
>> + * <--Compressed tile UV stride--> (aligned to 256)
>> + * <------- Width * 4/3 ---------> (aligned to 48)
>> + * U* V* U* V* U* V* U* V* . . . . ^
>> + * U* V* U* V* U* V* U* V* . . . . |
>> + * U* V* U* V* U* V* U* V* . . . . |
>> + * U* V* U* V* U* V* U* V* . . . . UV_Scanlines (aligned to 16)
>> + * . . . . . . . . . . . . . . . . |
>> + * . . . . . . . . . . . . . . . . V
>> + * . . . . . . . . . . . . . . . . -------> Buffer size aligned to 4k
>> + *
>> + * y_stride: width aligned to 256
>> + * uv_stride: width aligned to 256
>
> This does not match with above layout
It does:
>> + * <--Compressed tile Y stride --> (aligned to 256)
...
>> + * <--Compressed tile UV stride--> (aligned to 256)
>
>> + * y_scanlines: height aligned to 16
>> + * uv_scanlines: height aligned to 16
>> + * y_plane: buffer size aligned to 4096
>> + * uv_plane: buffer size aligned to 4096
>> + * y_meta_stride: width aligned to 64
>> + * y_meta_scanlines: height aligned to 16
>> + * y_meta_plane: buffer size aligned to 4096
>> + * uv_meta_stride: width aligned to 64
>> + * uv_meta_scanlines: height aligned to 16
>> + * uv_meta_plane: buffer size aligned to 4096
>> + *
>> + * Total size = align( y_plane + uv_plane +
>> + * y_meta_plane + uv_meta_plane, 4096)
>> + *
>> + * Note: All the alignments are hardware requirements.
>> + */
>> +static u32 iris_yuv_buffer_size_qc10c(struct iris_inst *inst)
>> +{
>> + u32 y_plane, uv_plane, y_stride, uv_stride;
>> + u32 uv_meta_stride, uv_meta_plane;
>> + u32 y_meta_stride, y_meta_plane;
>> + struct v4l2_format *f = NULL;
>
> drop NULL
>
>> +
>> + if (inst->domain == DECODER)
>> + f = inst->fmt_dst;
>> + else
>> + f = inst->fmt_src;
>> +
>> + y_meta_stride = ALIGN(DIV_ROUND_UP(f->fmt.pix_mp.width, 48),
>> + META_STRIDE_ALIGNED);
>> + y_meta_plane = y_meta_stride * ALIGN(DIV_ROUND_UP(f->fmt.pix_mp.height, 4),
>> + META_SCANLINE_ALIGNED);
>> + y_meta_plane = ALIGN(y_meta_plane, PIXELS_4K);
>> +
>> + y_stride = ALIGN(f->fmt.pix_mp.width * 4 / 3, Y_STRIDE_ALIGN_P010);
>> + y_plane = ALIGN(y_stride * ALIGN(f->fmt.pix_mp.height, Y_SCANLINE_ALIGN_QC10C),
>> + PIXELS_4K);
>> +
>> + uv_meta_stride = ALIGN(DIV_ROUND_UP((f->fmt.pix_mp.width + 1) / 2, 24),
>> + META_STRIDE_ALIGNED);
>> + uv_meta_plane = uv_meta_stride *
>> + ALIGN(DIV_ROUND_UP((f->fmt.pix_mp.height + 1) / 2, 4),
>> + META_SCANLINE_ALIGNED);
>
> Please use >> 1 throughout for consistency. I see iris_yuv_buffer_size_p010() uses them, while iris_yuv_buffer_size_qc10c() dont.
>
>> + uv_meta_plane = ALIGN(uv_meta_plane, PIXELS_4K);
>> +
>> + uv_stride = ALIGN(f->fmt.pix_mp.width * 4 / 3, UV_STRIDE_ALIGN_P010);
>> + uv_plane = ALIGN(uv_stride * ALIGN((f->fmt.pix_mp.height + 1) / 2, UV_SCANLINE_ALIGN),
>> + PIXELS_4K);
>> +
>> + return ALIGN(y_meta_plane + y_plane + uv_meta_plane + uv_plane, PIXELS_4K);
>> +}
>> +
>> static u32 iris_dec_bitstream_buffer_size(struct iris_inst *inst)
>> {
>> struct platform_inst_caps *caps = inst->core->iris_platform_data->inst_caps;
>> @@ -268,10 +454,17 @@ int iris_get_buffer_size(struct iris_inst *inst,
>> case BUF_OUTPUT:
>> if (inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC08C)
>> return iris_yuv_buffer_size_qc08c(inst);
>> + else if (inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC10C)
>> + return iris_yuv_buffer_size_qc10c(inst);
>> + else if (inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_P010)
>> + return iris_yuv_buffer_size_p010(inst);
>> else
>> return iris_yuv_buffer_size_nv12(inst);
>> case BUF_DPB:
>> - return iris_yuv_buffer_size_qc08c(inst);
>> + if (iris_fmt_is_10bit(inst->fmt_dst->fmt.pix_mp.pixelformat))
>> + return iris_yuv_buffer_size_qc10c(inst);
>> + else
>> + return iris_yuv_buffer_size_qc08c(inst);
>> default:
>> return 0;
>> }
>>
>
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v3 3/6] media: qcom: iris: gen2: add support for 10bit decoding
2026-05-11 9:20 ` [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats Neil Armstrong
2026-05-11 9:20 ` [PATCH v3 1/6] media: qcom: iris: add helpers for 8bit and " Neil Armstrong
2026-05-11 9:20 ` [PATCH v3 2/6] media: qcom: iris: add QC10C & P010 buffer size calculations Neil Armstrong
@ 2026-05-11 9:20 ` Neil Armstrong
2026-05-13 10:38 ` Dmitry Baryshkov
2026-05-13 18:50 ` Vikash Garodia
2026-05-11 9:20 ` [PATCH v3 4/6] media: qcom: iris: vdec: update size and stride calculations for 10bit formats Neil Armstrong
` (5 subsequent siblings)
8 siblings, 2 replies; 49+ messages in thread
From: Neil Armstrong @ 2026-05-11 9:20 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel, Neil Armstrong
Add the necessary plumbing into the HFi Gen2 to signal the decoder
the right 10bit pixel format and stride when in compressed mode.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
.../platform/qcom/iris/iris_hfi_gen2_command.c | 75 +++++++++++++++++++++-
.../platform/qcom/iris/iris_hfi_gen2_defines.h | 1 +
drivers/media/platform/qcom/iris/iris_utils.c | 4 +-
3 files changed, 76 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
index 30bfd90d423b..89de8c366836 100644
--- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
+++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
@@ -481,8 +481,20 @@ static int iris_hfi_gen2_set_colorformat(struct iris_inst *inst, u32 plane)
if (inst->domain == DECODER) {
pixelformat = inst->fmt_dst->fmt.pix_mp.pixelformat;
- hfi_colorformat = pixelformat == V4L2_PIX_FMT_NV12 ?
- HFI_COLOR_FMT_NV12 : HFI_COLOR_FMT_NV12_UBWC;
+ switch (pixelformat) {
+ case V4L2_PIX_FMT_NV12:
+ hfi_colorformat = HFI_COLOR_FMT_NV12;
+ break;
+ case V4L2_PIX_FMT_QC08C:
+ hfi_colorformat = HFI_COLOR_FMT_NV12_UBWC;
+ break;
+ case V4L2_PIX_FMT_P010:
+ hfi_colorformat = HFI_COLOR_FMT_P010;
+ break;
+ case V4L2_PIX_FMT_QC10C:
+ hfi_colorformat = HFI_COLOR_FMT_TP10_UBWC;
+ break;
+ };
} else {
pixelformat = inst->fmt_src->fmt.pix_mp.pixelformat;
hfi_colorformat = pixelformat == V4L2_PIX_FMT_NV12 ?
@@ -517,7 +529,8 @@ static int iris_hfi_gen2_set_linear_stride_scanline(struct iris_inst *inst, u32
stride_uv = stride_y;
scanline_uv = scanline_y / 2;
- if (pixelformat != V4L2_PIX_FMT_NV12)
+ if (pixelformat != V4L2_PIX_FMT_NV12 &&
+ pixelformat != V4L2_PIX_FMT_P010)
return 0;
payload[0] = stride_y << 16 | scanline_y;
@@ -532,6 +545,61 @@ static int iris_hfi_gen2_set_linear_stride_scanline(struct iris_inst *inst, u32
sizeof(u64));
}
+static int iris_hfi_gen2_set_ubwc_stride_scanline(struct iris_inst *inst, u32 plane)
+{
+ u32 meta_stride_y, meta_scanline_y, meta_stride_uv, meta_scanline_uv;
+ u32 stride_y, scanline_y, stride_uv, scanline_uv;
+ u32 port = iris_hfi_gen2_get_port(inst, plane);
+ u32 pixelformat, width, height;
+ u32 payload[4];
+
+ if (inst->domain != DECODER ||
+ inst->fmt_src->fmt.pix_mp.pixelformat != V4L2_PIX_FMT_AV1)
+ return 0;
+
+ pixelformat = inst->fmt_dst->fmt.pix_mp.pixelformat;
+ width = inst->fmt_dst->fmt.pix_mp.width;
+ height = inst->fmt_dst->fmt.pix_mp.height;
+
+ switch (pixelformat) {
+ case V4L2_PIX_FMT_QC08C:
+ stride_y = ALIGN(width, 128);
+ scanline_y = ALIGN(height, 32);
+ stride_uv = ALIGN(width, 128);
+ scanline_uv = ALIGN((height + 1) >> 1, 32);
+ meta_stride_y = ALIGN(DIV_ROUND_UP(width, 32), 64);
+ meta_scanline_y = ALIGN(DIV_ROUND_UP(height, 8), 16);
+ meta_stride_uv = ALIGN(DIV_ROUND_UP((width + 1) >> 1, 16), 64);
+ meta_scanline_uv = ALIGN(DIV_ROUND_UP((height + 1) >> 1, 8), 16);
+ break;
+ case V4L2_PIX_FMT_QC10C:
+ stride_y = ALIGN(width * 4 / 3, 256);
+ scanline_y = ALIGN(height, 16);
+ stride_uv = ALIGN(width * 4 / 3, 256);
+ scanline_uv = ALIGN((height + 1) >> 1, 16);
+ meta_stride_y = ALIGN(DIV_ROUND_UP(width, 48), 64);
+ meta_scanline_y = ALIGN(DIV_ROUND_UP(height, 4), 16);
+ meta_stride_uv = ALIGN(DIV_ROUND_UP((width + 1) >> 1, 24), 64);
+ meta_scanline_uv = ALIGN(DIV_ROUND_UP((height + 1) >> 1, 4), 16);
+ break;
+ default:
+ return 0;
+ }
+
+ payload[0] = stride_y << 16 | scanline_y;
+ payload[1] = stride_uv << 16 | scanline_uv;
+ payload[2] = meta_stride_y << 16 | meta_scanline_y;
+ payload[3] = meta_stride_uv << 16 | meta_scanline_uv;
+
+ return iris_hfi_gen2_session_set_property(inst,
+ HFI_PROP_UBWC_STRIDE_SCANLINE,
+ HFI_HOST_FLAGS_NONE,
+ port,
+ HFI_PAYLOAD_U32_ARRAY,
+ &payload[0],
+ sizeof(u32) * 4);
+}
+
static int iris_hfi_gen2_set_tier(struct iris_inst *inst, u32 plane)
{
u32 port = iris_hfi_gen2_get_port(inst, V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE);
@@ -620,6 +688,7 @@ static int iris_hfi_gen2_session_set_config_params(struct iris_inst *inst, u32 p
{HFI_PROP_OPB_ENABLE, iris_hfi_gen2_set_opb_enable },
{HFI_PROP_COLOR_FORMAT, iris_hfi_gen2_set_colorformat },
{HFI_PROP_LINEAR_STRIDE_SCANLINE, iris_hfi_gen2_set_linear_stride_scanline },
+ {HFI_PROP_UBWC_STRIDE_SCANLINE, iris_hfi_gen2_set_ubwc_stride_scanline },
{HFI_PROP_TIER, iris_hfi_gen2_set_tier },
{HFI_PROP_FRAME_RATE, iris_hfi_gen2_set_frame_rate },
{HFI_PROP_AV1_FILM_GRAIN_PRESENT, iris_hfi_gen2_set_film_grain },
diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h b/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h
index cecf771c55dd..68f849232906 100644
--- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h
+++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h
@@ -118,6 +118,7 @@ enum hfi_flip {
#define HFI_PROP_OPB_ENABLE 0x03000184
#define HFI_PROP_AV1_TILE_ROWS_COLUMNS 0x03000187
#define HFI_PROP_AV1_DRAP_CONFIG 0x03000189
+#define HFI_PROP_UBWC_STRIDE_SCANLINE 0x03000190
#define HFI_PROP_COMV_BUFFER_COUNT 0x03000193
#define HFI_PROP_AV1_UNIFORM_TILE_SPACING 0x03000197
#define HFI_PROP_END 0x03FFFFFF
diff --git a/drivers/media/platform/qcom/iris/iris_utils.c b/drivers/media/platform/qcom/iris/iris_utils.c
index bdedd6bfa87a..c75dcb8e671e 100644
--- a/drivers/media/platform/qcom/iris/iris_utils.c
+++ b/drivers/media/platform/qcom/iris/iris_utils.c
@@ -35,7 +35,9 @@ int iris_get_mbpf(struct iris_inst *inst)
bool iris_split_mode_enabled(struct iris_inst *inst)
{
return inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_NV12 ||
- inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC08C;
+ inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC08C ||
+ inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_P010 ||
+ inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC10C;
}
bool iris_fmt_is_8bit(__u32 pixelformat)
--
2.34.1
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 3/6] media: qcom: iris: gen2: add support for 10bit decoding
2026-05-11 9:20 ` [PATCH v3 3/6] media: qcom: iris: gen2: add support for 10bit decoding Neil Armstrong
@ 2026-05-13 10:38 ` Dmitry Baryshkov
2026-05-13 18:50 ` Vikash Garodia
1 sibling, 0 replies; 49+ messages in thread
From: Dmitry Baryshkov @ 2026-05-13 10:38 UTC (permalink / raw)
To: Neil Armstrong
Cc: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, linux-media,
linux-arm-msm, linux-kernel
On Mon, May 11, 2026 at 11:20:28AM +0200, Neil Armstrong wrote:
> Add the necessary plumbing into the HFi Gen2 to signal the decoder
> the right 10bit pixel format and stride when in compressed mode.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../platform/qcom/iris/iris_hfi_gen2_command.c | 75 +++++++++++++++++++++-
> .../platform/qcom/iris/iris_hfi_gen2_defines.h | 1 +
> drivers/media/platform/qcom/iris/iris_utils.c | 4 +-
> 3 files changed, 76 insertions(+), 4 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [PATCH v3 3/6] media: qcom: iris: gen2: add support for 10bit decoding
2026-05-11 9:20 ` [PATCH v3 3/6] media: qcom: iris: gen2: add support for 10bit decoding Neil Armstrong
2026-05-13 10:38 ` Dmitry Baryshkov
@ 2026-05-13 18:50 ` Vikash Garodia
2026-05-18 7:32 ` Neil Armstrong
1 sibling, 1 reply; 49+ messages in thread
From: Vikash Garodia @ 2026-05-13 18:50 UTC (permalink / raw)
To: Neil Armstrong, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/11/2026 2:50 PM, Neil Armstrong wrote:
> Add the necessary plumbing into the HFi Gen2 to signal the decoder
> the right 10bit pixel format and stride when in compressed mode.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../platform/qcom/iris/iris_hfi_gen2_command.c | 75 +++++++++++++++++++++-
> .../platform/qcom/iris/iris_hfi_gen2_defines.h | 1 +
> drivers/media/platform/qcom/iris/iris_utils.c | 4 +-
> 3 files changed, 76 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
> index 30bfd90d423b..89de8c366836 100644
> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
> @@ -481,8 +481,20 @@ static int iris_hfi_gen2_set_colorformat(struct iris_inst *inst, u32 plane)
>
> if (inst->domain == DECODER) {
> pixelformat = inst->fmt_dst->fmt.pix_mp.pixelformat;
> - hfi_colorformat = pixelformat == V4L2_PIX_FMT_NV12 ?
> - HFI_COLOR_FMT_NV12 : HFI_COLOR_FMT_NV12_UBWC;
> + switch (pixelformat) {
> + case V4L2_PIX_FMT_NV12:
> + hfi_colorformat = HFI_COLOR_FMT_NV12;
> + break;
> + case V4L2_PIX_FMT_QC08C:
> + hfi_colorformat = HFI_COLOR_FMT_NV12_UBWC;
> + break;
> + case V4L2_PIX_FMT_P010:
> + hfi_colorformat = HFI_COLOR_FMT_P010;
> + break;
> + case V4L2_PIX_FMT_QC10C:
> + hfi_colorformat = HFI_COLOR_FMT_TP10_UBWC;
> + break;
> + };
semicolon ?
> } else {
> pixelformat = inst->fmt_src->fmt.pix_mp.pixelformat;
> hfi_colorformat = pixelformat == V4L2_PIX_FMT_NV12 ?
> @@ -517,7 +529,8 @@ static int iris_hfi_gen2_set_linear_stride_scanline(struct iris_inst *inst, u32
> stride_uv = stride_y;
> scanline_uv = scanline_y / 2;
>
> - if (pixelformat != V4L2_PIX_FMT_NV12)
> + if (pixelformat != V4L2_PIX_FMT_NV12 &&
> + pixelformat != V4L2_PIX_FMT_P010)
> return 0;
>
> payload[0] = stride_y << 16 | scanline_y;
> @@ -532,6 +545,61 @@ static int iris_hfi_gen2_set_linear_stride_scanline(struct iris_inst *inst, u32
> sizeof(u64));
> }
>
> +static int iris_hfi_gen2_set_ubwc_stride_scanline(struct iris_inst *inst, u32 plane)
> +{
> + u32 meta_stride_y, meta_scanline_y, meta_stride_uv, meta_scanline_uv;
> + u32 stride_y, scanline_y, stride_uv, scanline_uv;
> + u32 port = iris_hfi_gen2_get_port(inst, plane);
> + u32 pixelformat, width, height;
> + u32 payload[4];
> +
> + if (inst->domain != DECODER ||
> + inst->fmt_src->fmt.pix_mp.pixelformat != V4L2_PIX_FMT_AV1)
whats the restriction with AV1 here ?
> + return 0;
> +
> + pixelformat = inst->fmt_dst->fmt.pix_mp.pixelformat;
> + width = inst->fmt_dst->fmt.pix_mp.width;
> + height = inst->fmt_dst->fmt.pix_mp.height;
> +
> + switch (pixelformat) {
> + case V4L2_PIX_FMT_QC08C:
> + stride_y = ALIGN(width, 128);
> + scanline_y = ALIGN(height, 32);
> + stride_uv = ALIGN(width, 128);
> + scanline_uv = ALIGN((height + 1) >> 1, 32);
> + meta_stride_y = ALIGN(DIV_ROUND_UP(width, 32), 64);
> + meta_scanline_y = ALIGN(DIV_ROUND_UP(height, 8), 16);
> + meta_stride_uv = ALIGN(DIV_ROUND_UP((width + 1) >> 1, 16), 64);
> + meta_scanline_uv = ALIGN(DIV_ROUND_UP((height + 1) >> 1, 8), 16);
> + break;
> + case V4L2_PIX_FMT_QC10C:
> + stride_y = ALIGN(width * 4 / 3, 256);
> + scanline_y = ALIGN(height, 16);
> + stride_uv = ALIGN(width * 4 / 3, 256);
> + scanline_uv = ALIGN((height + 1) >> 1, 16);
> + meta_stride_y = ALIGN(DIV_ROUND_UP(width, 48), 64);
> + meta_scanline_y = ALIGN(DIV_ROUND_UP(height, 4), 16);
> + meta_stride_uv = ALIGN(DIV_ROUND_UP((width + 1) >> 1, 24), 64);
> + meta_scanline_uv = ALIGN(DIV_ROUND_UP((height + 1) >> 1, 4), 16);
> + break;
> + default:
> + return 0;
> + }
> +
> + payload[0] = stride_y << 16 | scanline_y;
> + payload[1] = stride_uv << 16 | scanline_uv;
> + payload[2] = meta_stride_y << 16 | meta_scanline_y;
> + payload[3] = meta_stride_uv << 16 | meta_scanline_uv;
> +
> + return iris_hfi_gen2_session_set_property(inst,
> + HFI_PROP_UBWC_STRIDE_SCANLINE,
> + HFI_HOST_FLAGS_NONE,
> + port,
> + HFI_PAYLOAD_U32_ARRAY,
> + &payload[0],
> + sizeof(u32) * 4);
> +}
> +
> static int iris_hfi_gen2_set_tier(struct iris_inst *inst, u32 plane)
> {
> u32 port = iris_hfi_gen2_get_port(inst, V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE);
> @@ -620,6 +688,7 @@ static int iris_hfi_gen2_session_set_config_params(struct iris_inst *inst, u32 p
> {HFI_PROP_OPB_ENABLE, iris_hfi_gen2_set_opb_enable },
> {HFI_PROP_COLOR_FORMAT, iris_hfi_gen2_set_colorformat },
> {HFI_PROP_LINEAR_STRIDE_SCANLINE, iris_hfi_gen2_set_linear_stride_scanline },
> + {HFI_PROP_UBWC_STRIDE_SCANLINE, iris_hfi_gen2_set_ubwc_stride_scanline },
alignment
> {HFI_PROP_TIER, iris_hfi_gen2_set_tier },
> {HFI_PROP_FRAME_RATE, iris_hfi_gen2_set_frame_rate },
> {HFI_PROP_AV1_FILM_GRAIN_PRESENT, iris_hfi_gen2_set_film_grain },
> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h b/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h
> index cecf771c55dd..68f849232906 100644
> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h
> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h
> @@ -118,6 +118,7 @@ enum hfi_flip {
> #define HFI_PROP_OPB_ENABLE 0x03000184
> #define HFI_PROP_AV1_TILE_ROWS_COLUMNS 0x03000187
> #define HFI_PROP_AV1_DRAP_CONFIG 0x03000189
> +#define HFI_PROP_UBWC_STRIDE_SCANLINE 0x03000190
> #define HFI_PROP_COMV_BUFFER_COUNT 0x03000193
> #define HFI_PROP_AV1_UNIFORM_TILE_SPACING 0x03000197
> #define HFI_PROP_END 0x03FFFFFF
> diff --git a/drivers/media/platform/qcom/iris/iris_utils.c b/drivers/media/platform/qcom/iris/iris_utils.c
> index bdedd6bfa87a..c75dcb8e671e 100644
> --- a/drivers/media/platform/qcom/iris/iris_utils.c
> +++ b/drivers/media/platform/qcom/iris/iris_utils.c
> @@ -35,7 +35,9 @@ int iris_get_mbpf(struct iris_inst *inst)
> bool iris_split_mode_enabled(struct iris_inst *inst)
> {
> return inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_NV12 ||
> - inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC08C;
> + inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC08C ||
> + inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_P010 ||
> + inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC10C;
> }
>
> bool iris_fmt_is_8bit(__u32 pixelformat)
>
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 3/6] media: qcom: iris: gen2: add support for 10bit decoding
2026-05-13 18:50 ` Vikash Garodia
@ 2026-05-18 7:32 ` Neil Armstrong
2026-05-21 9:44 ` Vikash Garodia
0 siblings, 1 reply; 49+ messages in thread
From: Neil Armstrong @ 2026-05-18 7:32 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/13/26 20:50, Vikash Garodia wrote:
>
> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>> Add the necessary plumbing into the HFi Gen2 to signal the decoder
>> the right 10bit pixel format and stride when in compressed mode.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> .../platform/qcom/iris/iris_hfi_gen2_command.c | 75 +++++++++++++++++++++-
>> .../platform/qcom/iris/iris_hfi_gen2_defines.h | 1 +
>> drivers/media/platform/qcom/iris/iris_utils.c | 4 +-
>> 3 files changed, 76 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
>> index 30bfd90d423b..89de8c366836 100644
>> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
>> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
>> @@ -481,8 +481,20 @@ static int iris_hfi_gen2_set_colorformat(struct iris_inst *inst, u32 plane)
>> if (inst->domain == DECODER) {
>> pixelformat = inst->fmt_dst->fmt.pix_mp.pixelformat;
>> - hfi_colorformat = pixelformat == V4L2_PIX_FMT_NV12 ?
>> - HFI_COLOR_FMT_NV12 : HFI_COLOR_FMT_NV12_UBWC;
>> + switch (pixelformat) {
>> + case V4L2_PIX_FMT_NV12:
>> + hfi_colorformat = HFI_COLOR_FMT_NV12;
>> + break;
>> + case V4L2_PIX_FMT_QC08C:
>> + hfi_colorformat = HFI_COLOR_FMT_NV12_UBWC;
>> + break;
>> + case V4L2_PIX_FMT_P010:
>> + hfi_colorformat = HFI_COLOR_FMT_P010;
>> + break;
>> + case V4L2_PIX_FMT_QC10C:
>> + hfi_colorformat = HFI_COLOR_FMT_TP10_UBWC;
>> + break;
>> + };
>
> semicolon ?
Ack
>
>> } else {
>> pixelformat = inst->fmt_src->fmt.pix_mp.pixelformat;
>> hfi_colorformat = pixelformat == V4L2_PIX_FMT_NV12 ?
>> @@ -517,7 +529,8 @@ static int iris_hfi_gen2_set_linear_stride_scanline(struct iris_inst *inst, u32
>> stride_uv = stride_y;
>> scanline_uv = scanline_y / 2;
>> - if (pixelformat != V4L2_PIX_FMT_NV12)
>> + if (pixelformat != V4L2_PIX_FMT_NV12 &&
>> + pixelformat != V4L2_PIX_FMT_P010)
>> return 0;
>> payload[0] = stride_y << 16 | scanline_y;
>> @@ -532,6 +545,61 @@ static int iris_hfi_gen2_set_linear_stride_scanline(struct iris_inst *inst, u32
>> sizeof(u64));
>> }
>> +static int iris_hfi_gen2_set_ubwc_stride_scanline(struct iris_inst *inst, u32 plane)
>> +{
>> + u32 meta_stride_y, meta_scanline_y, meta_stride_uv, meta_scanline_uv;
>> + u32 stride_y, scanline_y, stride_uv, scanline_uv;
>> + u32 port = iris_hfi_gen2_get_port(inst, plane);
>> + u32 pixelformat, width, height;
>> + u32 payload[4];
>> +
>> + if (inst->domain != DECODER ||
>> + inst->fmt_src->fmt.pix_mp.pixelformat != V4L2_PIX_FMT_AV1)
>
> whats the restriction with AV1 here ?
This restriction is used in downstream driver and Dikshita reported we shouldn't
call HFI_PROP_UBWC_STRIDE_SCANLINE except for AV1.
Could you please check if it's necessary ?
>
>> + return 0;
>> +
>> + pixelformat = inst->fmt_dst->fmt.pix_mp.pixelformat;
>> + width = inst->fmt_dst->fmt.pix_mp.width;
>> + height = inst->fmt_dst->fmt.pix_mp.height;
>> +
>> + switch (pixelformat) {
>> + case V4L2_PIX_FMT_QC08C:
>> + stride_y = ALIGN(width, 128);
>> + scanline_y = ALIGN(height, 32);
>> + stride_uv = ALIGN(width, 128);
>> + scanline_uv = ALIGN((height + 1) >> 1, 32);
>> + meta_stride_y = ALIGN(DIV_ROUND_UP(width, 32), 64);
>> + meta_scanline_y = ALIGN(DIV_ROUND_UP(height, 8), 16);
>> + meta_stride_uv = ALIGN(DIV_ROUND_UP((width + 1) >> 1, 16), 64);
>> + meta_scanline_uv = ALIGN(DIV_ROUND_UP((height + 1) >> 1, 8), 16);
>> + break;
>> + case V4L2_PIX_FMT_QC10C:
>> + stride_y = ALIGN(width * 4 / 3, 256);
>> + scanline_y = ALIGN(height, 16);
>> + stride_uv = ALIGN(width * 4 / 3, 256);
>> + scanline_uv = ALIGN((height + 1) >> 1, 16);
>> + meta_stride_y = ALIGN(DIV_ROUND_UP(width, 48), 64);
>> + meta_scanline_y = ALIGN(DIV_ROUND_UP(height, 4), 16);
>> + meta_stride_uv = ALIGN(DIV_ROUND_UP((width + 1) >> 1, 24), 64);
>> + meta_scanline_uv = ALIGN(DIV_ROUND_UP((height + 1) >> 1, 4), 16);
>> + break;
>> + default:
>> + return 0;
>> + }
>> +
>> + payload[0] = stride_y << 16 | scanline_y;
>> + payload[1] = stride_uv << 16 | scanline_uv;
>> + payload[2] = meta_stride_y << 16 | meta_scanline_y;
>> + payload[3] = meta_stride_uv << 16 | meta_scanline_uv;
>> +
>> + return iris_hfi_gen2_session_set_property(inst,
>> + HFI_PROP_UBWC_STRIDE_SCANLINE,
>> + HFI_HOST_FLAGS_NONE,
>> + port,
>> + HFI_PAYLOAD_U32_ARRAY,
>> + &payload[0],
>> + sizeof(u32) * 4);
>> +}
>> +
>> static int iris_hfi_gen2_set_tier(struct iris_inst *inst, u32 plane)
>> {
>> u32 port = iris_hfi_gen2_get_port(inst, V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE);
>> @@ -620,6 +688,7 @@ static int iris_hfi_gen2_session_set_config_params(struct iris_inst *inst, u32 p
>> {HFI_PROP_OPB_ENABLE, iris_hfi_gen2_set_opb_enable },
>> {HFI_PROP_COLOR_FORMAT, iris_hfi_gen2_set_colorformat },
>> {HFI_PROP_LINEAR_STRIDE_SCANLINE, iris_hfi_gen2_set_linear_stride_scanline },
>> + {HFI_PROP_UBWC_STRIDE_SCANLINE, iris_hfi_gen2_set_ubwc_stride_scanline },
>
> alignment
>
>> {HFI_PROP_TIER, iris_hfi_gen2_set_tier },
>> {HFI_PROP_FRAME_RATE, iris_hfi_gen2_set_frame_rate },
>> {HFI_PROP_AV1_FILM_GRAIN_PRESENT, iris_hfi_gen2_set_film_grain },
>> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h b/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h
>> index cecf771c55dd..68f849232906 100644
>> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h
>> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h
>> @@ -118,6 +118,7 @@ enum hfi_flip {
>> #define HFI_PROP_OPB_ENABLE 0x03000184
>> #define HFI_PROP_AV1_TILE_ROWS_COLUMNS 0x03000187
>> #define HFI_PROP_AV1_DRAP_CONFIG 0x03000189
>> +#define HFI_PROP_UBWC_STRIDE_SCANLINE 0x03000190
>> #define HFI_PROP_COMV_BUFFER_COUNT 0x03000193
>> #define HFI_PROP_AV1_UNIFORM_TILE_SPACING 0x03000197
>> #define HFI_PROP_END 0x03FFFFFF
>> diff --git a/drivers/media/platform/qcom/iris/iris_utils.c b/drivers/media/platform/qcom/iris/iris_utils.c
>> index bdedd6bfa87a..c75dcb8e671e 100644
>> --- a/drivers/media/platform/qcom/iris/iris_utils.c
>> +++ b/drivers/media/platform/qcom/iris/iris_utils.c
>> @@ -35,7 +35,9 @@ int iris_get_mbpf(struct iris_inst *inst)
>> bool iris_split_mode_enabled(struct iris_inst *inst)
>> {
>> return inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_NV12 ||
>> - inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC08C;
>> + inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC08C ||
>> + inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_P010 ||
>> + inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC10C;
>> }
>> bool iris_fmt_is_8bit(__u32 pixelformat)
>>
>
Thanks,
Neil
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 3/6] media: qcom: iris: gen2: add support for 10bit decoding
2026-05-18 7:32 ` Neil Armstrong
@ 2026-05-21 9:44 ` Vikash Garodia
2026-05-21 12:57 ` Neil Armstrong
0 siblings, 1 reply; 49+ messages in thread
From: Vikash Garodia @ 2026-05-21 9:44 UTC (permalink / raw)
To: Neil Armstrong, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/18/2026 1:02 PM, Neil Armstrong wrote:
> On 5/13/26 20:50, Vikash Garodia wrote:
>>
>> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>>> Add the necessary plumbing into the HFi Gen2 to signal the decoder
>>> the right 10bit pixel format and stride when in compressed mode.
>>>
>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>> ---
>>> .../platform/qcom/iris/iris_hfi_gen2_command.c | 75 +++++++++++
>>> ++++++++++-
>>> .../platform/qcom/iris/iris_hfi_gen2_defines.h | 1 +
>>> drivers/media/platform/qcom/iris/iris_utils.c | 4 +-
>>> 3 files changed, 76 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
>>> b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
>>> index 30bfd90d423b..89de8c366836 100644
>>> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
>>> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
>>> @@ -481,8 +481,20 @@ static int iris_hfi_gen2_set_colorformat(struct
>>> iris_inst *inst, u32 plane)
>>> if (inst->domain == DECODER) {
>>> pixelformat = inst->fmt_dst->fmt.pix_mp.pixelformat;
>>> - hfi_colorformat = pixelformat == V4L2_PIX_FMT_NV12 ?
>>> - HFI_COLOR_FMT_NV12 : HFI_COLOR_FMT_NV12_UBWC;
>>> + switch (pixelformat) {
>>> + case V4L2_PIX_FMT_NV12:
>>> + hfi_colorformat = HFI_COLOR_FMT_NV12;
>>> + break;
>>> + case V4L2_PIX_FMT_QC08C:
>>> + hfi_colorformat = HFI_COLOR_FMT_NV12_UBWC;
>>> + break;
>>> + case V4L2_PIX_FMT_P010:
>>> + hfi_colorformat = HFI_COLOR_FMT_P010;
>>> + break;
>>> + case V4L2_PIX_FMT_QC10C:
>>> + hfi_colorformat = HFI_COLOR_FMT_TP10_UBWC;
>>> + break;
>>> + };
>>
>> semicolon ?
>
> Ack
>
>>
>>> } else {
>>> pixelformat = inst->fmt_src->fmt.pix_mp.pixelformat;
>>> hfi_colorformat = pixelformat == V4L2_PIX_FMT_NV12 ?
>>> @@ -517,7 +529,8 @@ static int
>>> iris_hfi_gen2_set_linear_stride_scanline(struct iris_inst *inst, u32
>>> stride_uv = stride_y;
>>> scanline_uv = scanline_y / 2;
>>> - if (pixelformat != V4L2_PIX_FMT_NV12)
>>> + if (pixelformat != V4L2_PIX_FMT_NV12 &&
>>> + pixelformat != V4L2_PIX_FMT_P010)
>>> return 0;
>>> payload[0] = stride_y << 16 | scanline_y;
>>> @@ -532,6 +545,61 @@ static int
>>> iris_hfi_gen2_set_linear_stride_scanline(struct iris_inst *inst, u32
>>> sizeof(u64));
>>> }
>>> +static int iris_hfi_gen2_set_ubwc_stride_scanline(struct iris_inst
>>> *inst, u32 plane)
>>> +{
>>> + u32 meta_stride_y, meta_scanline_y, meta_stride_uv,
>>> meta_scanline_uv;
>>> + u32 stride_y, scanline_y, stride_uv, scanline_uv;
>>> + u32 port = iris_hfi_gen2_get_port(inst, plane);
>>> + u32 pixelformat, width, height;
>>> + u32 payload[4];
>>> +
>>> + if (inst->domain != DECODER ||
>>> + inst->fmt_src->fmt.pix_mp.pixelformat != V4L2_PIX_FMT_AV1)
>>
>> whats the restriction with AV1 here ?
>
> This restriction is used in downstream driver and Dikshita reported we
> shouldn't
> call HFI_PROP_UBWC_STRIDE_SCANLINE except for AV1.
>
> Could you please check if it's necessary ?
>
I discussed this with firmware folks. As per them, this interface is
effective for AV1, and for others, it might lead to higher size due to
host demanded alignment.
As per firmware team,
"While the documentation states it is applicable "for AV1 ONLY", sending
it for HEVC, VP9, or H.264 will physically work—forcing the UBWC output
buffers into the Host's fixed stride layout. However, because older
codecs handle resolution changes natively by triggering a standard Port
Settings Change (PSC) to reallocate buffers, using this property for
them is largely unnecessary and will persist statically, potentially
leading to wasted memory due to over-allocated padding"
Regards,
Vikash
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 3/6] media: qcom: iris: gen2: add support for 10bit decoding
2026-05-21 9:44 ` Vikash Garodia
@ 2026-05-21 12:57 ` Neil Armstrong
0 siblings, 0 replies; 49+ messages in thread
From: Neil Armstrong @ 2026-05-21 12:57 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/21/26 11:44, Vikash Garodia wrote:
>
> On 5/18/2026 1:02 PM, Neil Armstrong wrote:
>> On 5/13/26 20:50, Vikash Garodia wrote:
>>>
>>> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>>>> Add the necessary plumbing into the HFi Gen2 to signal the decoder
>>>> the right 10bit pixel format and stride when in compressed mode.
>>>>
>>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>>> ---
>>>> .../platform/qcom/iris/iris_hfi_gen2_command.c | 75 +++++++++++ ++++++++++-
>>>> .../platform/qcom/iris/iris_hfi_gen2_defines.h | 1 +
>>>> drivers/media/platform/qcom/iris/iris_utils.c | 4 +-
>>>> 3 files changed, 76 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
>>>> index 30bfd90d423b..89de8c366836 100644
>>>> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
>>>> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
>>>> @@ -481,8 +481,20 @@ static int iris_hfi_gen2_set_colorformat(struct iris_inst *inst, u32 plane)
>>>> if (inst->domain == DECODER) {
>>>> pixelformat = inst->fmt_dst->fmt.pix_mp.pixelformat;
>>>> - hfi_colorformat = pixelformat == V4L2_PIX_FMT_NV12 ?
>>>> - HFI_COLOR_FMT_NV12 : HFI_COLOR_FMT_NV12_UBWC;
>>>> + switch (pixelformat) {
>>>> + case V4L2_PIX_FMT_NV12:
>>>> + hfi_colorformat = HFI_COLOR_FMT_NV12;
>>>> + break;
>>>> + case V4L2_PIX_FMT_QC08C:
>>>> + hfi_colorformat = HFI_COLOR_FMT_NV12_UBWC;
>>>> + break;
>>>> + case V4L2_PIX_FMT_P010:
>>>> + hfi_colorformat = HFI_COLOR_FMT_P010;
>>>> + break;
>>>> + case V4L2_PIX_FMT_QC10C:
>>>> + hfi_colorformat = HFI_COLOR_FMT_TP10_UBWC;
>>>> + break;
>>>> + };
>>>
>>> semicolon ?
>>
>> Ack
>>
>>>
>>>> } else {
>>>> pixelformat = inst->fmt_src->fmt.pix_mp.pixelformat;
>>>> hfi_colorformat = pixelformat == V4L2_PIX_FMT_NV12 ?
>>>> @@ -517,7 +529,8 @@ static int iris_hfi_gen2_set_linear_stride_scanline(struct iris_inst *inst, u32
>>>> stride_uv = stride_y;
>>>> scanline_uv = scanline_y / 2;
>>>> - if (pixelformat != V4L2_PIX_FMT_NV12)
>>>> + if (pixelformat != V4L2_PIX_FMT_NV12 &&
>>>> + pixelformat != V4L2_PIX_FMT_P010)
>>>> return 0;
>>>> payload[0] = stride_y << 16 | scanline_y;
>>>> @@ -532,6 +545,61 @@ static int iris_hfi_gen2_set_linear_stride_scanline(struct iris_inst *inst, u32
>>>> sizeof(u64));
>>>> }
>>>> +static int iris_hfi_gen2_set_ubwc_stride_scanline(struct iris_inst *inst, u32 plane)
>>>> +{
>>>> + u32 meta_stride_y, meta_scanline_y, meta_stride_uv, meta_scanline_uv;
>>>> + u32 stride_y, scanline_y, stride_uv, scanline_uv;
>>>> + u32 port = iris_hfi_gen2_get_port(inst, plane);
>>>> + u32 pixelformat, width, height;
>>>> + u32 payload[4];
>>>> +
>>>> + if (inst->domain != DECODER ||
>>>> + inst->fmt_src->fmt.pix_mp.pixelformat != V4L2_PIX_FMT_AV1)
>>>
>>> whats the restriction with AV1 here ?
>>
>> This restriction is used in downstream driver and Dikshita reported we shouldn't
>> call HFI_PROP_UBWC_STRIDE_SCANLINE except for AV1.
>>
>> Could you please check if it's necessary ?
>>
> I discussed this with firmware folks. As per them, this interface is effective for AV1, and for others, it might lead to higher size due to host demanded alignment.
>
> As per firmware team,
> "While the documentation states it is applicable "for AV1 ONLY", sending it for HEVC, VP9, or H.264 will physically work—forcing the UBWC output buffers into the Host's fixed stride layout. However, because older codecs handle resolution changes natively by triggering a standard Port Settings Change (PSC) to reallocate buffers, using this property for them is largely unnecessary and will persist statically, potentially leading to wasted memory due to over-allocated padding"
Thanks a lot for asking, I will leave it as is for now until we have a stride issue we can enable it for other codecs.
Neil
>
> Regards,
> Vikash
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v3 4/6] media: qcom: iris: vdec: update size and stride calculations for 10bit formats
2026-05-11 9:20 ` [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats Neil Armstrong
` (2 preceding siblings ...)
2026-05-11 9:20 ` [PATCH v3 3/6] media: qcom: iris: gen2: add support for 10bit decoding Neil Armstrong
@ 2026-05-11 9:20 ` Neil Armstrong
2026-05-13 10:39 ` Dmitry Baryshkov
2026-05-13 19:05 ` Vikash Garodia
2026-05-11 9:20 ` [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and " Neil Armstrong
` (4 subsequent siblings)
8 siblings, 2 replies; 49+ messages in thread
From: Neil Armstrong @ 2026-05-11 9:20 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel, Neil Armstrong
Update the gen2 response and vdec s_fmt code to take in account
the P010 and QC010 when calculating the width, height and stride.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
.../platform/qcom/iris/iris_hfi_gen2_response.c | 21 ++++++++++++++++---
drivers/media/platform/qcom/iris/iris_vdec.c | 24 +++++++++++++++++++---
2 files changed, 39 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
index 8e19f61bbbf9..0541e02d7507 100644
--- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
+++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
@@ -542,9 +542,24 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
pixmp_ip->width = width;
pixmp_ip->height = height;
- pixmp_op->width = ALIGN(width, 128);
- pixmp_op->height = ALIGN(height, 32);
- pixmp_op->plane_fmt[0].bytesperline = ALIGN(width, 128);
+ switch (pixmp_op->pixelformat) {
+ case V4L2_PIX_FMT_P010:
+ pixmp_op->width = ALIGN(width, 128);
+ pixmp_op->height = ALIGN(height, 32);
+ pixmp_op->plane_fmt[0].bytesperline = ALIGN(width * 2, 256);
+ break;
+ case V4L2_PIX_FMT_QC10C:
+ pixmp_op->width = roundup(width, 192);
+ pixmp_op->height = ALIGN(height, 16);
+ pixmp_op->plane_fmt[0].bytesperline = ALIGN(pixmp_op->width * 4 / 3, 256);
+ break;
+ case V4L2_PIX_FMT_NV12:
+ case V4L2_PIX_FMT_QC08C:
+ pixmp_op->width = ALIGN(width, 128);
+ pixmp_op->height = ALIGN(height, 32);
+ pixmp_op->plane_fmt[0].bytesperline = pixmp_op->width;
+ break;
+ }
pixmp_op->plane_fmt[0].sizeimage = iris_get_buffer_size(inst, BUF_OUTPUT);
matrix_coeff = subsc_params.color_info & 0xFF;
diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c
index 99d544e2af4f..eea69f937147 100644
--- a/drivers/media/platform/qcom/iris/iris_vdec.c
+++ b/drivers/media/platform/qcom/iris/iris_vdec.c
@@ -266,10 +266,28 @@ int iris_vdec_s_fmt(struct iris_inst *inst, struct v4l2_format *f)
fmt = inst->fmt_dst;
fmt->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
fmt->fmt.pix_mp.pixelformat = f->fmt.pix_mp.pixelformat;
- fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128);
- fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32);
fmt->fmt.pix_mp.num_planes = 1;
- fmt->fmt.pix_mp.plane_fmt[0].bytesperline = ALIGN(f->fmt.pix_mp.width, 128);
+ switch (f->fmt.pix_mp.pixelformat) {
+ case V4L2_PIX_FMT_P010:
+ fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128);
+ fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32);
+ fmt->fmt.pix_mp.plane_fmt[0].bytesperline =
+ ALIGN(f->fmt.pix_mp.width * 2, 256);
+ break;
+ case V4L2_PIX_FMT_QC10C:
+ fmt->fmt.pix_mp.width = roundup(f->fmt.pix_mp.width, 192);
+ fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 16);
+ fmt->fmt.pix_mp.plane_fmt[0].bytesperline =
+ ALIGN(f->fmt.pix_mp.width * 4 / 3, 256);
+ break;
+ case V4L2_PIX_FMT_NV12:
+ case V4L2_PIX_FMT_QC08C:
+ fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128);
+ fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32);
+ fmt->fmt.pix_mp.plane_fmt[0].bytesperline =
+ ALIGN(f->fmt.pix_mp.width, 128);
+ break;
+ }
fmt->fmt.pix_mp.plane_fmt[0].sizeimage = iris_get_buffer_size(inst, BUF_OUTPUT);
inst->buffers[BUF_OUTPUT].min_count = iris_vpu_buf_count(inst, BUF_OUTPUT);
inst->buffers[BUF_OUTPUT].size = fmt->fmt.pix_mp.plane_fmt[0].sizeimage;
--
2.34.1
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 4/6] media: qcom: iris: vdec: update size and stride calculations for 10bit formats
2026-05-11 9:20 ` [PATCH v3 4/6] media: qcom: iris: vdec: update size and stride calculations for 10bit formats Neil Armstrong
@ 2026-05-13 10:39 ` Dmitry Baryshkov
2026-05-13 19:05 ` Vikash Garodia
1 sibling, 0 replies; 49+ messages in thread
From: Dmitry Baryshkov @ 2026-05-13 10:39 UTC (permalink / raw)
To: Neil Armstrong
Cc: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, linux-media,
linux-arm-msm, linux-kernel
On Mon, May 11, 2026 at 11:20:29AM +0200, Neil Armstrong wrote:
> Update the gen2 response and vdec s_fmt code to take in account
> the P010 and QC010 when calculating the width, height and stride.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../platform/qcom/iris/iris_hfi_gen2_response.c | 21 ++++++++++++++++---
> drivers/media/platform/qcom/iris/iris_vdec.c | 24 +++++++++++++++++++---
> 2 files changed, 39 insertions(+), 6 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [PATCH v3 4/6] media: qcom: iris: vdec: update size and stride calculations for 10bit formats
2026-05-11 9:20 ` [PATCH v3 4/6] media: qcom: iris: vdec: update size and stride calculations for 10bit formats Neil Armstrong
2026-05-13 10:39 ` Dmitry Baryshkov
@ 2026-05-13 19:05 ` Vikash Garodia
2026-05-18 7:33 ` Neil Armstrong
1 sibling, 1 reply; 49+ messages in thread
From: Vikash Garodia @ 2026-05-13 19:05 UTC (permalink / raw)
To: Neil Armstrong, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/11/2026 2:50 PM, Neil Armstrong wrote:
> Update the gen2 response and vdec s_fmt code to take in account
> the P010 and QC010 when calculating the width, height and stride.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../platform/qcom/iris/iris_hfi_gen2_response.c | 21 ++++++++++++++++---
> drivers/media/platform/qcom/iris/iris_vdec.c | 24 +++++++++++++++++++---
> 2 files changed, 39 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> index 8e19f61bbbf9..0541e02d7507 100644
> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> @@ -542,9 +542,24 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
> pixmp_ip->width = width;
> pixmp_ip->height = height;
>
> - pixmp_op->width = ALIGN(width, 128);
> - pixmp_op->height = ALIGN(height, 32);
> - pixmp_op->plane_fmt[0].bytesperline = ALIGN(width, 128);
> + switch (pixmp_op->pixelformat) {
> + case V4L2_PIX_FMT_P010:
> + pixmp_op->width = ALIGN(width, 128);
> + pixmp_op->height = ALIGN(height, 32);
> + pixmp_op->plane_fmt[0].bytesperline = ALIGN(width * 2, 256);
> + break;
> + case V4L2_PIX_FMT_QC10C:
> + pixmp_op->width = roundup(width, 192);
> + pixmp_op->height = ALIGN(height, 16);
> + pixmp_op->plane_fmt[0].bytesperline = ALIGN(pixmp_op->width * 4 / 3, 256);
> + break;
> + case V4L2_PIX_FMT_NV12:
> + case V4L2_PIX_FMT_QC08C:
> + pixmp_op->width = ALIGN(width, 128);
> + pixmp_op->height = ALIGN(height, 32);
> + pixmp_op->plane_fmt[0].bytesperline = pixmp_op->width;
> + break;
client facing api, good to have a default here
> + }
> pixmp_op->plane_fmt[0].sizeimage = iris_get_buffer_size(inst, BUF_OUTPUT);
>
> matrix_coeff = subsc_params.color_info & 0xFF;
> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c
> index 99d544e2af4f..eea69f937147 100644
> --- a/drivers/media/platform/qcom/iris/iris_vdec.c
> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c
> @@ -266,10 +266,28 @@ int iris_vdec_s_fmt(struct iris_inst *inst, struct v4l2_format *f)
> fmt = inst->fmt_dst;
> fmt->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
> fmt->fmt.pix_mp.pixelformat = f->fmt.pix_mp.pixelformat;
> - fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128);
> - fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32);
> fmt->fmt.pix_mp.num_planes = 1;
> - fmt->fmt.pix_mp.plane_fmt[0].bytesperline = ALIGN(f->fmt.pix_mp.width, 128);
> + switch (f->fmt.pix_mp.pixelformat) {
> + case V4L2_PIX_FMT_P010:
> + fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128);
> + fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32);
> + fmt->fmt.pix_mp.plane_fmt[0].bytesperline =
> + ALIGN(f->fmt.pix_mp.width * 2, 256);
> + break;
> + case V4L2_PIX_FMT_QC10C:
> + fmt->fmt.pix_mp.width = roundup(f->fmt.pix_mp.width, 192);
ALIGN ?
> + fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 16);
> + fmt->fmt.pix_mp.plane_fmt[0].bytesperline =
> + ALIGN(f->fmt.pix_mp.width * 4 / 3, 256);
> + break;
> + case V4L2_PIX_FMT_NV12:
> + case V4L2_PIX_FMT_QC08C:
> + fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128);
> + fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32);
> + fmt->fmt.pix_mp.plane_fmt[0].bytesperline =
> + ALIGN(f->fmt.pix_mp.width, 128);
> + break;
> + }
> fmt->fmt.pix_mp.plane_fmt[0].sizeimage = iris_get_buffer_size(inst, BUF_OUTPUT);
> inst->buffers[BUF_OUTPUT].min_count = iris_vpu_buf_count(inst, BUF_OUTPUT);
> inst->buffers[BUF_OUTPUT].size = fmt->fmt.pix_mp.plane_fmt[0].sizeimage;
>
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 4/6] media: qcom: iris: vdec: update size and stride calculations for 10bit formats
2026-05-13 19:05 ` Vikash Garodia
@ 2026-05-18 7:33 ` Neil Armstrong
2026-05-20 15:55 ` Vikash Garodia
0 siblings, 1 reply; 49+ messages in thread
From: Neil Armstrong @ 2026-05-18 7:33 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/13/26 21:05, Vikash Garodia wrote:
>
>
> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>> Update the gen2 response and vdec s_fmt code to take in account
>> the P010 and QC010 when calculating the width, height and stride.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> .../platform/qcom/iris/iris_hfi_gen2_response.c | 21 ++++++++++++++++---
>> drivers/media/platform/qcom/iris/iris_vdec.c | 24 +++++++++++++++++++---
>> 2 files changed, 39 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
>> index 8e19f61bbbf9..0541e02d7507 100644
>> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
>> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
>> @@ -542,9 +542,24 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
>> pixmp_ip->width = width;
>> pixmp_ip->height = height;
>> - pixmp_op->width = ALIGN(width, 128);
>> - pixmp_op->height = ALIGN(height, 32);
>> - pixmp_op->plane_fmt[0].bytesperline = ALIGN(width, 128);
>> + switch (pixmp_op->pixelformat) {
>> + case V4L2_PIX_FMT_P010:
>> + pixmp_op->width = ALIGN(width, 128);
>> + pixmp_op->height = ALIGN(height, 32);
>> + pixmp_op->plane_fmt[0].bytesperline = ALIGN(width * 2, 256);
>> + break;
>> + case V4L2_PIX_FMT_QC10C:
>> + pixmp_op->width = roundup(width, 192);
>> + pixmp_op->height = ALIGN(height, 16);
>> + pixmp_op->plane_fmt[0].bytesperline = ALIGN(pixmp_op->width * 4 / 3, 256);
>> + break;
>> + case V4L2_PIX_FMT_NV12:
>> + case V4L2_PIX_FMT_QC08C:
>> + pixmp_op->width = ALIGN(width, 128);
>> + pixmp_op->height = ALIGN(height, 32);
>> + pixmp_op->plane_fmt[0].bytesperline = pixmp_op->width;
>> + break;
>
> client facing api, good to have a default here
>
>> + }
>> pixmp_op->plane_fmt[0].sizeimage = iris_get_buffer_size(inst, BUF_OUTPUT);
>> matrix_coeff = subsc_params.color_info & 0xFF;
>> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c
>> index 99d544e2af4f..eea69f937147 100644
>> --- a/drivers/media/platform/qcom/iris/iris_vdec.c
>> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c
>> @@ -266,10 +266,28 @@ int iris_vdec_s_fmt(struct iris_inst *inst, struct v4l2_format *f)
>> fmt = inst->fmt_dst;
>> fmt->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
>> fmt->fmt.pix_mp.pixelformat = f->fmt.pix_mp.pixelformat;
>> - fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128);
>> - fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32);
>> fmt->fmt.pix_mp.num_planes = 1;
>> - fmt->fmt.pix_mp.plane_fmt[0].bytesperline = ALIGN(f->fmt.pix_mp.width, 128);
>> + switch (f->fmt.pix_mp.pixelformat) {
>> + case V4L2_PIX_FMT_P010:
>> + fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128);
>> + fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32);
>> + fmt->fmt.pix_mp.plane_fmt[0].bytesperline =
>> + ALIGN(f->fmt.pix_mp.width * 2, 256);
>> + break;
>> + case V4L2_PIX_FMT_QC10C:
>> + fmt->fmt.pix_mp.width = roundup(f->fmt.pix_mp.width, 192);
>
> ALIGN ?
ALIGN only works with Power-Of-Two numbers, so we can't use ALIGN here.
>
>> + fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 16);
>> + fmt->fmt.pix_mp.plane_fmt[0].bytesperline =
>> + ALIGN(f->fmt.pix_mp.width * 4 / 3, 256);
>> + break;
>> + case V4L2_PIX_FMT_NV12:
>> + case V4L2_PIX_FMT_QC08C:
>> + fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128);
>> + fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32);
>> + fmt->fmt.pix_mp.plane_fmt[0].bytesperline =
>> + ALIGN(f->fmt.pix_mp.width, 128);
>> + break;
>> + }
>> fmt->fmt.pix_mp.plane_fmt[0].sizeimage = iris_get_buffer_size(inst, BUF_OUTPUT);
>> inst->buffers[BUF_OUTPUT].min_count = iris_vpu_buf_count(inst, BUF_OUTPUT);
>> inst->buffers[BUF_OUTPUT].size = fmt->fmt.pix_mp.plane_fmt[0].sizeimage;
>>
>
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 4/6] media: qcom: iris: vdec: update size and stride calculations for 10bit formats
2026-05-18 7:33 ` Neil Armstrong
@ 2026-05-20 15:55 ` Vikash Garodia
0 siblings, 0 replies; 49+ messages in thread
From: Vikash Garodia @ 2026-05-20 15:55 UTC (permalink / raw)
To: Neil Armstrong, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/18/2026 1:03 PM, Neil Armstrong wrote:
> On 5/13/26 21:05, Vikash Garodia wrote:
>>
>>
>> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>>> Update the gen2 response and vdec s_fmt code to take in account
>>> the P010 and QC010 when calculating the width, height and stride.
>>>
>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>> ---
>>> .../platform/qcom/iris/iris_hfi_gen2_response.c | 21 +++++++++++
>>> +++++---
>>> drivers/media/platform/qcom/iris/iris_vdec.c | 24 +++++++++++
>>> ++++++++---
>>> 2 files changed, 39 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/media/platform/qcom/iris/
>>> iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/
>>> iris_hfi_gen2_response.c
>>> index 8e19f61bbbf9..0541e02d7507 100644
>>> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
>>> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
>>> @@ -542,9 +542,24 @@ static void
>>> iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
>>> pixmp_ip->width = width;
>>> pixmp_ip->height = height;
>>> - pixmp_op->width = ALIGN(width, 128);
>>> - pixmp_op->height = ALIGN(height, 32);
>>> - pixmp_op->plane_fmt[0].bytesperline = ALIGN(width, 128);
>>> + switch (pixmp_op->pixelformat) {
>>> + case V4L2_PIX_FMT_P010:
>>> + pixmp_op->width = ALIGN(width, 128);
>>> + pixmp_op->height = ALIGN(height, 32);
>>> + pixmp_op->plane_fmt[0].bytesperline = ALIGN(width * 2, 256);
>>> + break;
>>> + case V4L2_PIX_FMT_QC10C:
>>> + pixmp_op->width = roundup(width, 192);
>>> + pixmp_op->height = ALIGN(height, 16);
>>> + pixmp_op->plane_fmt[0].bytesperline = ALIGN(pixmp_op->width
>>> * 4 / 3, 256);
>>> + break;
>>> + case V4L2_PIX_FMT_NV12:
>>> + case V4L2_PIX_FMT_QC08C:
>>> + pixmp_op->width = ALIGN(width, 128);
>>> + pixmp_op->height = ALIGN(height, 32);
>>> + pixmp_op->plane_fmt[0].bytesperline = pixmp_op->width;
>>> + break;
>>
>> client facing api, good to have a default here
>>
>>> + }
>>> pixmp_op->plane_fmt[0].sizeimage = iris_get_buffer_size(inst,
>>> BUF_OUTPUT);
>>> matrix_coeff = subsc_params.color_info & 0xFF;
>>> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/
>>> media/platform/qcom/iris/iris_vdec.c
>>> index 99d544e2af4f..eea69f937147 100644
>>> --- a/drivers/media/platform/qcom/iris/iris_vdec.c
>>> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c
>>> @@ -266,10 +266,28 @@ int iris_vdec_s_fmt(struct iris_inst *inst,
>>> struct v4l2_format *f)
>>> fmt = inst->fmt_dst;
>>> fmt->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
>>> fmt->fmt.pix_mp.pixelformat = f->fmt.pix_mp.pixelformat;
>>> - fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128);
>>> - fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32);
>>> fmt->fmt.pix_mp.num_planes = 1;
>>> - fmt->fmt.pix_mp.plane_fmt[0].bytesperline = ALIGN(f-
>>> >fmt.pix_mp.width, 128);
>>> + switch (f->fmt.pix_mp.pixelformat) {
>>> + case V4L2_PIX_FMT_P010:
>>> + fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128);
>>> + fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32);
>>> + fmt->fmt.pix_mp.plane_fmt[0].bytesperline =
>>> + ALIGN(f->fmt.pix_mp.width * 2, 256);
>>> + break;
>>> + case V4L2_PIX_FMT_QC10C:
>>> + fmt->fmt.pix_mp.width = roundup(f->fmt.pix_mp.width, 192);
>>
>> ALIGN ?
>
> ALIGN only works with Power-Of-Two numbers, so we can't use ALIGN here.
Ack
>
>>
>>> + fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 16);
>>> + fmt->fmt.pix_mp.plane_fmt[0].bytesperline =
>>> + ALIGN(f->fmt.pix_mp.width * 4 / 3, 256);
>>> + break;
>>> + case V4L2_PIX_FMT_NV12:
>>> + case V4L2_PIX_FMT_QC08C:
>>> + fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128);
>>> + fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32);
>>> + fmt->fmt.pix_mp.plane_fmt[0].bytesperline =
>>> + ALIGN(f->fmt.pix_mp.width, 128);
>>> + break;
>>> + }
>>> fmt->fmt.pix_mp.plane_fmt[0].sizeimage =
>>> iris_get_buffer_size(inst, BUF_OUTPUT);
>>> inst->buffers[BUF_OUTPUT].min_count =
>>> iris_vpu_buf_count(inst, BUF_OUTPUT);
>>> inst->buffers[BUF_OUTPUT].size = fmt-
>>> >fmt.pix_mp.plane_fmt[0].sizeimage;
>>>
>>
>
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats
2026-05-11 9:20 ` [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats Neil Armstrong
` (3 preceding siblings ...)
2026-05-11 9:20 ` [PATCH v3 4/6] media: qcom: iris: vdec: update size and stride calculations for 10bit formats Neil Armstrong
@ 2026-05-11 9:20 ` Neil Armstrong
2026-05-13 10:47 ` Dmitry Baryshkov
` (3 more replies)
2026-05-11 9:20 ` [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format Neil Armstrong
` (3 subsequent siblings)
8 siblings, 4 replies; 49+ messages in thread
From: Neil Armstrong @ 2026-05-11 9:20 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel, Neil Armstrong
The 10bit pixel format can be only used when the decoder identifies the
stream as decoding into 10bit pixel format buffers, so update the
find_format helper to filter the formats and only allow the proper
formats when setting or trying a capture format.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
drivers/media/platform/qcom/iris/iris_platform_common.h | 1 +
drivers/media/platform/qcom/iris/iris_vdec.c | 10 ++++++++++
2 files changed, 11 insertions(+)
diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h
index 5a489917580e..cd3509da4b75 100644
--- a/drivers/media/platform/qcom/iris/iris_platform_common.h
+++ b/drivers/media/platform/qcom/iris/iris_platform_common.h
@@ -18,6 +18,7 @@ struct iris_inst;
#define REGISTER_BIT_DEPTH(luma, chroma) ((luma) << 16 | (chroma))
#define BIT_DEPTH_8 REGISTER_BIT_DEPTH(8, 8)
+#define BIT_DEPTH_10 REGISTER_BIT_DEPTH(10, 10)
#define CODED_FRAMES_PROGRESSIVE 0x0
#define DEFAULT_MAX_HOST_BUF_COUNT 64
#define DEFAULT_MAX_HOST_BURST_BUF_COUNT 256
diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c
index eea69f937147..f4d9951ed04c 100644
--- a/drivers/media/platform/qcom/iris/iris_vdec.c
+++ b/drivers/media/platform/qcom/iris/iris_vdec.c
@@ -99,6 +99,16 @@ find_format(struct iris_inst *inst, u32 pixfmt, u32 type)
if (i == size || fmt[i].type != type)
return NULL;
+ if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
+ if (iris_fmt_is_8bit(fmt[i].pixfmt) &&
+ inst->fw_caps[BIT_DEPTH].value == BIT_DEPTH_10)
+ return NULL;
+
+ if (iris_fmt_is_10bit(fmt[i].pixfmt) &&
+ inst->fw_caps[BIT_DEPTH].value != BIT_DEPTH_10)
+ return NULL;
+ }
+
return &fmt[i];
}
--
2.34.1
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats
2026-05-11 9:20 ` [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and " Neil Armstrong
@ 2026-05-13 10:47 ` Dmitry Baryshkov
2026-05-13 19:27 ` Vikash Garodia
` (2 subsequent siblings)
3 siblings, 0 replies; 49+ messages in thread
From: Dmitry Baryshkov @ 2026-05-13 10:47 UTC (permalink / raw)
To: Neil Armstrong
Cc: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, linux-media,
linux-arm-msm, linux-kernel
On Mon, May 11, 2026 at 11:20:30AM +0200, Neil Armstrong wrote:
> The 10bit pixel format can be only used when the decoder identifies the
> stream as decoding into 10bit pixel format buffers, so update the
> find_format helper to filter the formats and only allow the proper
> formats when setting or trying a capture format.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> drivers/media/platform/qcom/iris/iris_platform_common.h | 1 +
> drivers/media/platform/qcom/iris/iris_vdec.c | 10 ++++++++++
> 2 files changed, 11 insertions(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats
2026-05-11 9:20 ` [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and " Neil Armstrong
2026-05-13 10:47 ` Dmitry Baryshkov
@ 2026-05-13 19:27 ` Vikash Garodia
2026-05-18 7:36 ` Neil Armstrong
2026-05-15 9:37 ` Bryan O'Donoghue
2026-05-15 9:42 ` Bryan O'Donoghue
3 siblings, 1 reply; 49+ messages in thread
From: Vikash Garodia @ 2026-05-13 19:27 UTC (permalink / raw)
To: Neil Armstrong, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/11/2026 2:50 PM, Neil Armstrong wrote:
> The 10bit pixel format can be only used when the decoder identifies the
> stream as decoding into 10bit pixel format buffers, so update the
> find_format helper to filter the formats and only allow the proper
> formats when setting or trying a capture format.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> drivers/media/platform/qcom/iris/iris_platform_common.h | 1 +
> drivers/media/platform/qcom/iris/iris_vdec.c | 10 ++++++++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h
> index 5a489917580e..cd3509da4b75 100644
> --- a/drivers/media/platform/qcom/iris/iris_platform_common.h
> +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h
> @@ -18,6 +18,7 @@ struct iris_inst;
>
> #define REGISTER_BIT_DEPTH(luma, chroma) ((luma) << 16 | (chroma))
> #define BIT_DEPTH_8 REGISTER_BIT_DEPTH(8, 8)
> +#define BIT_DEPTH_10 REGISTER_BIT_DEPTH(10, 10)
> #define CODED_FRAMES_PROGRESSIVE 0x0
> #define DEFAULT_MAX_HOST_BUF_COUNT 64
> #define DEFAULT_MAX_HOST_BURST_BUF_COUNT 256
> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c
> index eea69f937147..f4d9951ed04c 100644
> --- a/drivers/media/platform/qcom/iris/iris_vdec.c
> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c
> @@ -99,6 +99,16 @@ find_format(struct iris_inst *inst, u32 pixfmt, u32 type)
> if (i == size || fmt[i].type != type)
> return NULL;
>
> + if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
> + if (iris_fmt_is_8bit(fmt[i].pixfmt) &&
> + inst->fw_caps[BIT_DEPTH].value == BIT_DEPTH_10)
> + return NULL;
> +
> + if (iris_fmt_is_10bit(fmt[i].pixfmt) &&
> + inst->fw_caps[BIT_DEPTH].value != BIT_DEPTH_10)
> + return NULL;
> + }
similar logic would be now needed while enumerating fmt.
VIDIOC_ENUM_FMT will now enumerate all capture formats (NV12, QC08C,
QC10C..) regardless of the stream's bit depth, while VIDIOC_S_FMT will
reject the wrong-depth formats.
userspace will see formats via ENUM_FMT that it cannot successfully set
with S_FMT.
> +
> return &fmt[i];
> }
>
>
Regards,
Vikash
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats
2026-05-13 19:27 ` Vikash Garodia
@ 2026-05-18 7:36 ` Neil Armstrong
2026-05-20 15:30 ` Vikash Garodia
0 siblings, 1 reply; 49+ messages in thread
From: Neil Armstrong @ 2026-05-18 7:36 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/13/26 21:27, Vikash Garodia wrote:
>
>
> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>> The 10bit pixel format can be only used when the decoder identifies the
>> stream as decoding into 10bit pixel format buffers, so update the
>> find_format helper to filter the formats and only allow the proper
>> formats when setting or trying a capture format.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> drivers/media/platform/qcom/iris/iris_platform_common.h | 1 +
>> drivers/media/platform/qcom/iris/iris_vdec.c | 10 ++++++++++
>> 2 files changed, 11 insertions(+)
>>
>> diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h
>> index 5a489917580e..cd3509da4b75 100644
>> --- a/drivers/media/platform/qcom/iris/iris_platform_common.h
>> +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h
>> @@ -18,6 +18,7 @@ struct iris_inst;
>> #define REGISTER_BIT_DEPTH(luma, chroma) ((luma) << 16 | (chroma))
>> #define BIT_DEPTH_8 REGISTER_BIT_DEPTH(8, 8)
>> +#define BIT_DEPTH_10 REGISTER_BIT_DEPTH(10, 10)
>> #define CODED_FRAMES_PROGRESSIVE 0x0
>> #define DEFAULT_MAX_HOST_BUF_COUNT 64
>> #define DEFAULT_MAX_HOST_BURST_BUF_COUNT 256
>> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c
>> index eea69f937147..f4d9951ed04c 100644
>> --- a/drivers/media/platform/qcom/iris/iris_vdec.c
>> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c
>> @@ -99,6 +99,16 @@ find_format(struct iris_inst *inst, u32 pixfmt, u32 type)
>> if (i == size || fmt[i].type != type)
>> return NULL;
>> + if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
>> + if (iris_fmt_is_8bit(fmt[i].pixfmt) &&
>> + inst->fw_caps[BIT_DEPTH].value == BIT_DEPTH_10)
>> + return NULL;
>> +
>> + if (iris_fmt_is_10bit(fmt[i].pixfmt) &&
>> + inst->fw_caps[BIT_DEPTH].value != BIT_DEPTH_10)
>> + return NULL;
>> + }
>
> similar logic would be now needed while enumerating fmt.
>
> VIDIOC_ENUM_FMT will now enumerate all capture formats (NV12, QC08C, QC10C..) regardless of the stream's bit depth, while VIDIOC_S_FMT will reject the wrong-depth formats.
>
> userspace will see formats via ENUM_FMT that it cannot successfully set with S_FMT.
So initially I did that, but I reverted since it broke decoding with gstreamer when trying
to use QC10C since it requires negociating the src/sink before sending the fist buffer
and then get the source format change to switch to 10bit.
I checked and none of the other v4l2 drivers supporting 10bit does that, so it seems right
to allow enumerating all possibly supported formats and only accept the session supported
one with S_FMT.
>
>> +
>> return &fmt[i];
>> }
>>
>
> Regards,
> Vikash
>
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats
2026-05-18 7:36 ` Neil Armstrong
@ 2026-05-20 15:30 ` Vikash Garodia
2026-05-20 15:39 ` Neil Armstrong
0 siblings, 1 reply; 49+ messages in thread
From: Vikash Garodia @ 2026-05-20 15:30 UTC (permalink / raw)
To: Neil Armstrong, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, nicolas Dufresne,
Hans Verkuil
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/18/2026 1:06 PM, Neil Armstrong wrote:
> On 5/13/26 21:27, Vikash Garodia wrote:
>>
>>
>> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>>> The 10bit pixel format can be only used when the decoder identifies the
>>> stream as decoding into 10bit pixel format buffers, so update the
>>> find_format helper to filter the formats and only allow the proper
>>> formats when setting or trying a capture format.
>>>
>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>> ---
>>> drivers/media/platform/qcom/iris/iris_platform_common.h | 1 +
>>> drivers/media/platform/qcom/iris/iris_vdec.c | 10 ++++++
>>> ++++
>>> 2 files changed, 11 insertions(+)
>>>
>>> diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h
>>> b/drivers/media/platform/qcom/iris/iris_platform_common.h
>>> index 5a489917580e..cd3509da4b75 100644
>>> --- a/drivers/media/platform/qcom/iris/iris_platform_common.h
>>> +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h
>>> @@ -18,6 +18,7 @@ struct iris_inst;
>>> #define REGISTER_BIT_DEPTH(luma, chroma) ((luma) << 16 | (chroma))
>>> #define BIT_DEPTH_8 REGISTER_BIT_DEPTH(8, 8)
>>> +#define BIT_DEPTH_10 REGISTER_BIT_DEPTH(10, 10)
>>> #define CODED_FRAMES_PROGRESSIVE 0x0
>>> #define DEFAULT_MAX_HOST_BUF_COUNT 64
>>> #define DEFAULT_MAX_HOST_BURST_BUF_COUNT 256
>>> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/
>>> media/platform/qcom/iris/iris_vdec.c
>>> index eea69f937147..f4d9951ed04c 100644
>>> --- a/drivers/media/platform/qcom/iris/iris_vdec.c
>>> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c
>>> @@ -99,6 +99,16 @@ find_format(struct iris_inst *inst, u32 pixfmt,
>>> u32 type)
>>> if (i == size || fmt[i].type != type)
>>> return NULL;
>>> + if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
>>> + if (iris_fmt_is_8bit(fmt[i].pixfmt) &&
>>> + inst->fw_caps[BIT_DEPTH].value == BIT_DEPTH_10)
>>> + return NULL;
>>> +
>>> + if (iris_fmt_is_10bit(fmt[i].pixfmt) &&
>>> + inst->fw_caps[BIT_DEPTH].value != BIT_DEPTH_10)
>>> + return NULL;
>>> + }
>>
>> similar logic would be now needed while enumerating fmt.
>>
>> VIDIOC_ENUM_FMT will now enumerate all capture formats (NV12, QC08C,
>> QC10C..) regardless of the stream's bit depth, while VIDIOC_S_FMT will
>> reject the wrong-depth formats.
>>
>> userspace will see formats via ENUM_FMT that it cannot successfully
>> set with S_FMT.
>
> So initially I did that, but I reverted since it broke decoding with
> gstreamer when trying
> to use QC10C since it requires negociating the src/sink before sending
> the fist buffer
> and then get the source format change to switch to 10bit.
Does that mean that src is still producing the data in Q10c, while sink
is configured to NV12 (8bit) ?
>
> I checked and none of the other v4l2 drivers supporting 10bit does that,
> so it seems right
> to allow enumerating all possibly supported formats and only accept the
> session supported
> one with S_FMT.
I was reading the documentation on this aspects, and it says to keep all
the supported ones, instead of changing runtime and limit it to 10bit
ones, in this case.
+ing Nico and Hans incase they would like to comment on this.
>
>>
>>> +
>>> return &fmt[i];
>>> }
>>>
>>
>> Regards,
>> Vikash
>>
>
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats
2026-05-20 15:30 ` Vikash Garodia
@ 2026-05-20 15:39 ` Neil Armstrong
2026-05-20 15:47 ` Vikash Garodia
0 siblings, 1 reply; 49+ messages in thread
From: Neil Armstrong @ 2026-05-20 15:39 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, nicolas Dufresne,
Hans Verkuil
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/20/26 17:30, Vikash Garodia wrote:
>
> On 5/18/2026 1:06 PM, Neil Armstrong wrote:
>> On 5/13/26 21:27, Vikash Garodia wrote:
>>>
>>>
>>> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>>>> The 10bit pixel format can be only used when the decoder identifies the
>>>> stream as decoding into 10bit pixel format buffers, so update the
>>>> find_format helper to filter the formats and only allow the proper
>>>> formats when setting or trying a capture format.
>>>>
>>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>>> ---
>>>> drivers/media/platform/qcom/iris/iris_platform_common.h | 1 +
>>>> drivers/media/platform/qcom/iris/iris_vdec.c | 10 ++++++ ++++
>>>> 2 files changed, 11 insertions(+)
>>>>
>>>> diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h
>>>> index 5a489917580e..cd3509da4b75 100644
>>>> --- a/drivers/media/platform/qcom/iris/iris_platform_common.h
>>>> +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h
>>>> @@ -18,6 +18,7 @@ struct iris_inst;
>>>> #define REGISTER_BIT_DEPTH(luma, chroma) ((luma) << 16 | (chroma))
>>>> #define BIT_DEPTH_8 REGISTER_BIT_DEPTH(8, 8)
>>>> +#define BIT_DEPTH_10 REGISTER_BIT_DEPTH(10, 10)
>>>> #define CODED_FRAMES_PROGRESSIVE 0x0
>>>> #define DEFAULT_MAX_HOST_BUF_COUNT 64
>>>> #define DEFAULT_MAX_HOST_BURST_BUF_COUNT 256
>>>> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/ media/platform/qcom/iris/iris_vdec.c
>>>> index eea69f937147..f4d9951ed04c 100644
>>>> --- a/drivers/media/platform/qcom/iris/iris_vdec.c
>>>> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c
>>>> @@ -99,6 +99,16 @@ find_format(struct iris_inst *inst, u32 pixfmt, u32 type)
>>>> if (i == size || fmt[i].type != type)
>>>> return NULL;
>>>> + if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
>>>> + if (iris_fmt_is_8bit(fmt[i].pixfmt) &&
>>>> + inst->fw_caps[BIT_DEPTH].value == BIT_DEPTH_10)
>>>> + return NULL;
>>>> +
>>>> + if (iris_fmt_is_10bit(fmt[i].pixfmt) &&
>>>> + inst->fw_caps[BIT_DEPTH].value != BIT_DEPTH_10)
>>>> + return NULL;
>>>> + }
>>>
>>> similar logic would be now needed while enumerating fmt.
>>>
>>> VIDIOC_ENUM_FMT will now enumerate all capture formats (NV12, QC08C, QC10C..) regardless of the stream's bit depth, while VIDIOC_S_FMT will reject the wrong-depth formats.
>>>
>>> userspace will see formats via ENUM_FMT that it cannot successfully set with S_FMT.
>>
>> So initially I did that, but I reverted since it broke decoding with gstreamer when trying
>> to use QC10C since it requires negociating the src/sink before sending the fist buffer
>> and then get the source format change to switch to 10bit.
>
> Does that mean that src is still producing the data in Q10c, while sink is configured to NV12 (8bit) ?
No, it's early src/sink negociation capabilities with the special DRM DMABUF format to handle the QC10c, way before playback starts and starts the v4l2 dance.
>
>>
>> I checked and none of the other v4l2 drivers supporting 10bit does that, so it seems right
>> to allow enumerating all possibly supported formats and only accept the session supported
>> one with S_FMT.
>
> I was reading the documentation on this aspects, and it says to keep all the supported ones, instead of changing runtime and limit it to 10bit ones, in this case.
Hmm, so my change is correct ?
>
> +ing Nico and Hans incase they would like to comment on this.
>
>>
>>>
>>>> +
>>>> return &fmt[i];
>>>> }
>>>>
>>>
>>> Regards,
>>> Vikash
>>>
>>
>
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats
2026-05-20 15:39 ` Neil Armstrong
@ 2026-05-20 15:47 ` Vikash Garodia
2026-05-21 7:18 ` Neil Armstrong
0 siblings, 1 reply; 49+ messages in thread
From: Vikash Garodia @ 2026-05-20 15:47 UTC (permalink / raw)
To: Neil Armstrong, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, nicolas Dufresne,
Hans Verkuil
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/20/2026 9:09 PM, Neil Armstrong wrote:
> On 5/20/26 17:30, Vikash Garodia wrote:
>>
>> On 5/18/2026 1:06 PM, Neil Armstrong wrote:
>>> On 5/13/26 21:27, Vikash Garodia wrote:
>>>>
>>>>
>>>> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>>>>> The 10bit pixel format can be only used when the decoder identifies
>>>>> the
>>>>> stream as decoding into 10bit pixel format buffers, so update the
>>>>> find_format helper to filter the formats and only allow the proper
>>>>> formats when setting or trying a capture format.
>>>>>
>>>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>>>> ---
>>>>> drivers/media/platform/qcom/iris/iris_platform_common.h | 1 +
>>>>> drivers/media/platform/qcom/iris/iris_vdec.c | 10 ++++
>>>>> ++ ++++
>>>>> 2 files changed, 11 insertions(+)
>>>>>
>>>>> diff --git a/drivers/media/platform/qcom/iris/
>>>>> iris_platform_common.h b/drivers/media/platform/qcom/iris/
>>>>> iris_platform_common.h
>>>>> index 5a489917580e..cd3509da4b75 100644
>>>>> --- a/drivers/media/platform/qcom/iris/iris_platform_common.h
>>>>> +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h
>>>>> @@ -18,6 +18,7 @@ struct iris_inst;
>>>>> #define REGISTER_BIT_DEPTH(luma, chroma) ((luma) << 16 |
>>>>> (chroma))
>>>>> #define BIT_DEPTH_8 REGISTER_BIT_DEPTH(8, 8)
>>>>> +#define BIT_DEPTH_10 REGISTER_BIT_DEPTH(10, 10)
>>>>> #define CODED_FRAMES_PROGRESSIVE 0x0
>>>>> #define DEFAULT_MAX_HOST_BUF_COUNT 64
>>>>> #define DEFAULT_MAX_HOST_BURST_BUF_COUNT 256
>>>>> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/
>>>>> drivers/ media/platform/qcom/iris/iris_vdec.c
>>>>> index eea69f937147..f4d9951ed04c 100644
>>>>> --- a/drivers/media/platform/qcom/iris/iris_vdec.c
>>>>> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c
>>>>> @@ -99,6 +99,16 @@ find_format(struct iris_inst *inst, u32 pixfmt,
>>>>> u32 type)
>>>>> if (i == size || fmt[i].type != type)
>>>>> return NULL;
>>>>> + if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
>>>>> + if (iris_fmt_is_8bit(fmt[i].pixfmt) &&
>>>>> + inst->fw_caps[BIT_DEPTH].value == BIT_DEPTH_10)
>>>>> + return NULL;
>>>>> +
>>>>> + if (iris_fmt_is_10bit(fmt[i].pixfmt) &&
>>>>> + inst->fw_caps[BIT_DEPTH].value != BIT_DEPTH_10)
>>>>> + return NULL;
>>>>> + }
>>>>
>>>> similar logic would be now needed while enumerating fmt.
>>>>
>>>> VIDIOC_ENUM_FMT will now enumerate all capture formats (NV12, QC08C,
>>>> QC10C..) regardless of the stream's bit depth, while VIDIOC_S_FMT
>>>> will reject the wrong-depth formats.
>>>>
>>>> userspace will see formats via ENUM_FMT that it cannot successfully
>>>> set with S_FMT.
>>>
>>> So initially I did that, but I reverted since it broke decoding with
>>> gstreamer when trying
>>> to use QC10C since it requires negociating the src/sink before
>>> sending the fist buffer
>>> and then get the source format change to switch to 10bit.
>>
>> Does that mean that src is still producing the data in Q10c, while
>> sink is configured to NV12 (8bit) ?
>
> No, it's early src/sink negociation capabilities with the special DRM
> DMABUF format to handle the QC10c, way before playback starts and starts
> the v4l2 dance.
>
How will it know its Q10c, even before the playback starts ?
>>
>>>
>>> I checked and none of the other v4l2 drivers supporting 10bit does
>>> that, so it seems right
>>> to allow enumerating all possibly supported formats and only accept
>>> the session supported
>>> one with S_FMT.
>>
>> I was reading the documentation on this aspects, and it says to keep
>> all the supported ones, instead of changing runtime and limit it to
>> 10bit ones, in this case.
>
> Hmm, so my change is correct ?
Yes, to me.
>
>>
>> +ing Nico and Hans incase they would like to comment on this.
>>
>>>
>>>>
>>>>> +
>>>>> return &fmt[i];
>>>>> }
>>>>>
>>>>
>>>> Regards,
>>>> Vikash
>>>>
>>>
>>
>
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats
2026-05-20 15:47 ` Vikash Garodia
@ 2026-05-21 7:18 ` Neil Armstrong
0 siblings, 0 replies; 49+ messages in thread
From: Neil Armstrong @ 2026-05-21 7:18 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, nicolas Dufresne,
Hans Verkuil
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/20/26 17:47, Vikash Garodia wrote:
>
> On 5/20/2026 9:09 PM, Neil Armstrong wrote:
>> On 5/20/26 17:30, Vikash Garodia wrote:
>>>
>>> On 5/18/2026 1:06 PM, Neil Armstrong wrote:
>>>> On 5/13/26 21:27, Vikash Garodia wrote:
>>>>>
>>>>>
>>>>> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>>>>>> The 10bit pixel format can be only used when the decoder identifies the
>>>>>> stream as decoding into 10bit pixel format buffers, so update the
>>>>>> find_format helper to filter the formats and only allow the proper
>>>>>> formats when setting or trying a capture format.
>>>>>>
>>>>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>>>>> ---
>>>>>> drivers/media/platform/qcom/iris/iris_platform_common.h | 1 +
>>>>>> drivers/media/platform/qcom/iris/iris_vdec.c | 10 ++++ ++ ++++
>>>>>> 2 files changed, 11 insertions(+)
>>>>>>
>>>>>> diff --git a/drivers/media/platform/qcom/iris/ iris_platform_common.h b/drivers/media/platform/qcom/iris/ iris_platform_common.h
>>>>>> index 5a489917580e..cd3509da4b75 100644
>>>>>> --- a/drivers/media/platform/qcom/iris/iris_platform_common.h
>>>>>> +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h
>>>>>> @@ -18,6 +18,7 @@ struct iris_inst;
>>>>>> #define REGISTER_BIT_DEPTH(luma, chroma) ((luma) << 16 | (chroma))
>>>>>> #define BIT_DEPTH_8 REGISTER_BIT_DEPTH(8, 8)
>>>>>> +#define BIT_DEPTH_10 REGISTER_BIT_DEPTH(10, 10)
>>>>>> #define CODED_FRAMES_PROGRESSIVE 0x0
>>>>>> #define DEFAULT_MAX_HOST_BUF_COUNT 64
>>>>>> #define DEFAULT_MAX_HOST_BURST_BUF_COUNT 256
>>>>>> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/ drivers/ media/platform/qcom/iris/iris_vdec.c
>>>>>> index eea69f937147..f4d9951ed04c 100644
>>>>>> --- a/drivers/media/platform/qcom/iris/iris_vdec.c
>>>>>> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c
>>>>>> @@ -99,6 +99,16 @@ find_format(struct iris_inst *inst, u32 pixfmt, u32 type)
>>>>>> if (i == size || fmt[i].type != type)
>>>>>> return NULL;
>>>>>> + if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
>>>>>> + if (iris_fmt_is_8bit(fmt[i].pixfmt) &&
>>>>>> + inst->fw_caps[BIT_DEPTH].value == BIT_DEPTH_10)
>>>>>> + return NULL;
>>>>>> +
>>>>>> + if (iris_fmt_is_10bit(fmt[i].pixfmt) &&
>>>>>> + inst->fw_caps[BIT_DEPTH].value != BIT_DEPTH_10)
>>>>>> + return NULL;
>>>>>> + }
>>>>>
>>>>> similar logic would be now needed while enumerating fmt.
>>>>>
>>>>> VIDIOC_ENUM_FMT will now enumerate all capture formats (NV12, QC08C, QC10C..) regardless of the stream's bit depth, while VIDIOC_S_FMT will reject the wrong-depth formats.
>>>>>
>>>>> userspace will see formats via ENUM_FMT that it cannot successfully set with S_FMT.
>>>>
>>>> So initially I did that, but I reverted since it broke decoding with gstreamer when trying
>>>> to use QC10C since it requires negociating the src/sink before sending the fist buffer
>>>> and then get the source format change to switch to 10bit.
>>>
>>> Does that mean that src is still producing the data in Q10c, while sink is configured to NV12 (8bit) ?
>>
>> No, it's early src/sink negociation capabilities with the special DRM DMABUF format to handle the QC10c, way before playback starts and starts the v4l2 dance.
>>
>
> How will it know its Q10c, even before the playback starts ?
So in the way upstream gstreamer wants to support QC8C/QC10C, the format must be specified like:
gst-launch-1.0 -v -m filesrc location=Big_Buck_Bunny_1080_10s_30MB.h265 ! h265parse ! v4l2h265dec ! "video/x-raw(memory:DMABuf), format=DMA_DRM, drm-format=NV12:0x0500000000000001" ! kmssink
or
gst-launch-1.0 -v -m filesrc location=Big_Buck_Bunny_1080_10s_30MB_main10.h265 ! h265parse ! v4l2h265dec ! "video/x-raw(memory:DMABuf), format=DMA_DRM, drm-format=P010:0x0500000000000001" ! kmssink
so this means the QC8C/QC10C format must be listed in the VIDIOC_ENUM_FMT so the v4l2h265dec element can enums them as supported (and translated as drm-format=NV12:0x0500000000000001/drm-format=P010:0x0500000000000001)
Neil
>
>>>
>>>>
>>>> I checked and none of the other v4l2 drivers supporting 10bit does that, so it seems right
>>>> to allow enumerating all possibly supported formats and only accept the session supported
>>>> one with S_FMT.
>>>
>>> I was reading the documentation on this aspects, and it says to keep all the supported ones, instead of changing runtime and limit it to 10bit ones, in this case.
>>
>> Hmm, so my change is correct ?
>
> Yes, to me.
>
>>
>>>
>>> +ing Nico and Hans incase they would like to comment on this.
>>>
>>>>
>>>>>
>>>>>> +
>>>>>> return &fmt[i];
>>>>>> }
>>>>>>
>>>>>
>>>>> Regards,
>>>>> Vikash
>>>>>
>>>>
>>>
>>
>
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats
2026-05-11 9:20 ` [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and " Neil Armstrong
2026-05-13 10:47 ` Dmitry Baryshkov
2026-05-13 19:27 ` Vikash Garodia
@ 2026-05-15 9:37 ` Bryan O'Donoghue
2026-05-15 9:42 ` Bryan O'Donoghue
3 siblings, 0 replies; 49+ messages in thread
From: Bryan O'Donoghue @ 2026-05-15 9:37 UTC (permalink / raw)
To: Neil Armstrong, Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 11/05/2026 10:20, Neil Armstrong wrote:
> The 10bit pixel format can be only used when the decoder identifies the
> stream as decoding into 10bit pixel format buffers, so update the
> find_format helper to filter the formats and only allow the proper
> formats when setting or trying a capture format.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> drivers/media/platform/qcom/iris/iris_platform_common.h | 1 +
> drivers/media/platform/qcom/iris/iris_vdec.c | 10 ++++++++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h
> index 5a489917580e..cd3509da4b75 100644
> --- a/drivers/media/platform/qcom/iris/iris_platform_common.h
> +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h
> @@ -18,6 +18,7 @@ struct iris_inst;
>
> #define REGISTER_BIT_DEPTH(luma, chroma) ((luma) << 16 | (chroma))
> #define BIT_DEPTH_8 REGISTER_BIT_DEPTH(8, 8)
> +#define BIT_DEPTH_10 REGISTER_BIT_DEPTH(10, 10)
> #define CODED_FRAMES_PROGRESSIVE 0x0
> #define DEFAULT_MAX_HOST_BUF_COUNT 64
> #define DEFAULT_MAX_HOST_BURST_BUF_COUNT 256
> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c
> index eea69f937147..f4d9951ed04c 100644
> --- a/drivers/media/platform/qcom/iris/iris_vdec.c
> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c
> @@ -99,6 +99,16 @@ find_format(struct iris_inst *inst, u32 pixfmt, u32 type)
> if (i == size || fmt[i].type != type)
> return NULL;
>
> + if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
> + if (iris_fmt_is_8bit(fmt[i].pixfmt) &&
> + inst->fw_caps[BIT_DEPTH].value == BIT_DEPTH_10)
> + return NULL;
> +
> + if (iris_fmt_is_10bit(fmt[i].pixfmt) &&
> + inst->fw_caps[BIT_DEPTH].value != BIT_DEPTH_10)
> + return NULL;
> + }
> +
> return &fmt[i];
> }
>
>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats
2026-05-11 9:20 ` [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and " Neil Armstrong
` (2 preceding siblings ...)
2026-05-15 9:37 ` Bryan O'Donoghue
@ 2026-05-15 9:42 ` Bryan O'Donoghue
3 siblings, 0 replies; 49+ messages in thread
From: Bryan O'Donoghue @ 2026-05-15 9:42 UTC (permalink / raw)
To: Neil Armstrong, Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 11/05/2026 10:20, Neil Armstrong wrote:
> The 10bit pixel format can be only used when the decoder identifies the
> stream as decoding into 10bit pixel format buffers, so update the
> find_format helper to filter the formats and only allow the proper
> formats when setting or trying a capture format.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> drivers/media/platform/qcom/iris/iris_platform_common.h | 1 +
> drivers/media/platform/qcom/iris/iris_vdec.c | 10 ++++++++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h
> index 5a489917580e..cd3509da4b75 100644
> --- a/drivers/media/platform/qcom/iris/iris_platform_common.h
> +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h
> @@ -18,6 +18,7 @@ struct iris_inst;
>
> #define REGISTER_BIT_DEPTH(luma, chroma) ((luma) << 16 | (chroma))
> #define BIT_DEPTH_8 REGISTER_BIT_DEPTH(8, 8)
> +#define BIT_DEPTH_10 REGISTER_BIT_DEPTH(10, 10)
> #define CODED_FRAMES_PROGRESSIVE 0x0
> #define DEFAULT_MAX_HOST_BUF_COUNT 64
> #define DEFAULT_MAX_HOST_BURST_BUF_COUNT 256
> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c
> index eea69f937147..f4d9951ed04c 100644
> --- a/drivers/media/platform/qcom/iris/iris_vdec.c
> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c
> @@ -99,6 +99,16 @@ find_format(struct iris_inst *inst, u32 pixfmt, u32 type)
> if (i == size || fmt[i].type != type)
> return NULL;
>
> + if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
> + if (iris_fmt_is_8bit(fmt[i].pixfmt) &&
> + inst->fw_caps[BIT_DEPTH].value == BIT_DEPTH_10)
> + return NULL;
> +
> + if (iris_fmt_is_10bit(fmt[i].pixfmt) &&
> + inst->fw_caps[BIT_DEPTH].value != BIT_DEPTH_10)
> + return NULL;
> + }
> +
> return &fmt[i];
> }
>
>
> --
> 2.34.1
>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 49+ messages in thread
* [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
2026-05-11 9:20 ` [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats Neil Armstrong
` (4 preceding siblings ...)
2026-05-11 9:20 ` [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and " Neil Armstrong
@ 2026-05-11 9:20 ` Neil Armstrong
2026-05-13 10:45 ` Dmitry Baryshkov
2026-05-13 19:39 ` Vikash Garodia
2026-05-13 8:50 ` [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats Wangao Wang
` (2 subsequent siblings)
8 siblings, 2 replies; 49+ messages in thread
From: Neil Armstrong @ 2026-05-11 9:20 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel, Neil Armstrong
Add the necessary bits into the gen2 platforms tables and handlers
to allow decoding streams into 10bit pixel formats.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
.../media/platform/qcom/iris/iris_hfi_gen2_response.c | 16 +++++++++++++++-
drivers/media/platform/qcom/iris/iris_instance.h | 2 ++
drivers/media/platform/qcom/iris/iris_platform_gen2.c | 8 +++++---
drivers/media/platform/qcom/iris/iris_vdec.c | 8 ++++++++
4 files changed, 30 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
index 0541e02d7507..b6d815c01f1d 100644
--- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
+++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
@@ -542,6 +542,15 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
pixmp_ip->width = width;
pixmp_ip->height = height;
+ if (subsc_params.bit_depth == BIT_DEPTH_8 &&
+ pixmp_op->pixelformat != V4L2_PIX_FMT_NV12 &&
+ pixmp_op->pixelformat != V4L2_PIX_FMT_QC08C)
+ pixmp_op->pixelformat = V4L2_PIX_FMT_NV12;
+ else if (subsc_params.bit_depth == BIT_DEPTH_10 &&
+ pixmp_op->pixelformat != V4L2_PIX_FMT_P010 &&
+ pixmp_op->pixelformat != V4L2_PIX_FMT_QC10C)
+ pixmp_op->pixelformat = V4L2_PIX_FMT_P010;
+
switch (pixmp_op->pixelformat) {
case V4L2_PIX_FMT_P010:
pixmp_op->width = ALIGN(width, 128);
@@ -625,7 +634,12 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
inst->fw_caps[POC].value = subsc_params.pic_order_cnt;
inst->fw_caps[TIER].value = subsc_params.tier;
- if (subsc_params.bit_depth != BIT_DEPTH_8 ||
+ if (subsc_params.bit_depth == BIT_DEPTH_8)
+ inst->fw_caps[BIT_DEPTH].value = BIT_DEPTH_8;
+ else
+ inst->fw_caps[BIT_DEPTH].value = BIT_DEPTH_10;
+
+ if ((subsc_params.bit_depth != BIT_DEPTH_8 && subsc_params.bit_depth != BIT_DEPTH_10) ||
!(subsc_params.coded_frames & HFI_BITMASK_FRAME_MBS_ONLY_FLAG)) {
dev_err(core->dev, "unsupported content, bit depth: %x, pic_struct = %x\n",
subsc_params.bit_depth, subsc_params.coded_frames);
diff --git a/drivers/media/platform/qcom/iris/iris_instance.h b/drivers/media/platform/qcom/iris/iris_instance.h
index 16965150f427..16424d1e94a6 100644
--- a/drivers/media/platform/qcom/iris/iris_instance.h
+++ b/drivers/media/platform/qcom/iris/iris_instance.h
@@ -25,6 +25,8 @@ enum iris_fmt_type_out {
enum iris_fmt_type_cap {
IRIS_FMT_NV12,
IRIS_FMT_QC08C,
+ IRIS_FMT_TP10,
+ IRIS_FMT_QC10C,
};
struct iris_fmt {
diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
index 5da90d47f9c6..ceed4b5d96ca 100644
--- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c
+++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
@@ -56,9 +56,10 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8550_dec[] = {
{
.cap_id = PROFILE_HEVC,
.min = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN,
- .max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE,
+ .max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10,
.step_or_mask = BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN) |
- BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE),
+ BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE) |
+ BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10),
.value = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN,
.hfi_id = HFI_PROP_PROFILE,
.flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_MENU,
@@ -287,7 +288,7 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8550_dec[] = {
{
.cap_id = BIT_DEPTH,
.min = BIT_DEPTH_8,
- .max = BIT_DEPTH_8,
+ .max = BIT_DEPTH_10,
.step_or_mask = 1,
.value = BIT_DEPTH_8,
.hfi_id = HFI_PROP_LUMA_CHROMA_BIT_DEPTH,
@@ -866,6 +867,7 @@ static const u32 sm8550_vdec_output_config_params[] = {
HFI_PROP_OPB_ENABLE,
HFI_PROP_COLOR_FORMAT,
HFI_PROP_LINEAR_STRIDE_SCANLINE,
+ HFI_PROP_UBWC_STRIDE_SCANLINE,
};
static const u32 sm8550_venc_output_config_params[] = {
diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c
index f4d9951ed04c..65cf509e4aef 100644
--- a/drivers/media/platform/qcom/iris/iris_vdec.c
+++ b/drivers/media/platform/qcom/iris/iris_vdec.c
@@ -70,6 +70,14 @@ static const struct iris_fmt iris_vdec_formats_cap[] = {
.pixfmt = V4L2_PIX_FMT_QC08C,
.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
},
+ [IRIS_FMT_TP10] = {
+ .pixfmt = V4L2_PIX_FMT_P010,
+ .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
+ },
+ [IRIS_FMT_QC10C] = {
+ .pixfmt = V4L2_PIX_FMT_QC10C,
+ .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
+ },
};
static const struct iris_fmt *
--
2.34.1
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
2026-05-11 9:20 ` [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format Neil Armstrong
@ 2026-05-13 10:45 ` Dmitry Baryshkov
2026-05-13 11:59 ` Neil Armstrong
2026-05-13 19:39 ` Vikash Garodia
1 sibling, 1 reply; 49+ messages in thread
From: Dmitry Baryshkov @ 2026-05-13 10:45 UTC (permalink / raw)
To: Neil Armstrong
Cc: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, linux-media,
linux-arm-msm, linux-kernel
On Mon, May 11, 2026 at 11:20:31AM +0200, Neil Armstrong wrote:
> Add the necessary bits into the gen2 platforms tables and handlers
> to allow decoding streams into 10bit pixel formats.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../media/platform/qcom/iris/iris_hfi_gen2_response.c | 16 +++++++++++++++-
> drivers/media/platform/qcom/iris/iris_instance.h | 2 ++
> drivers/media/platform/qcom/iris/iris_platform_gen2.c | 8 +++++---
> drivers/media/platform/qcom/iris/iris_vdec.c | 8 ++++++++
> 4 files changed, 30 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> index 0541e02d7507..b6d815c01f1d 100644
> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> @@ -542,6 +542,15 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
> pixmp_ip->width = width;
> pixmp_ip->height = height;
>
> + if (subsc_params.bit_depth == BIT_DEPTH_8 &&
> + pixmp_op->pixelformat != V4L2_PIX_FMT_NV12 &&
> + pixmp_op->pixelformat != V4L2_PIX_FMT_QC08C)
> + pixmp_op->pixelformat = V4L2_PIX_FMT_NV12;
> + else if (subsc_params.bit_depth == BIT_DEPTH_10 &&
> + pixmp_op->pixelformat != V4L2_PIX_FMT_P010 &&
> + pixmp_op->pixelformat != V4L2_PIX_FMT_QC10C)
> + pixmp_op->pixelformat = V4L2_PIX_FMT_P010;
Do we support decoding of 10-bit videos to NV12 buffers?
> +
> switch (pixmp_op->pixelformat) {
> case V4L2_PIX_FMT_P010:
> pixmp_op->width = ALIGN(width, 128);
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
2026-05-13 10:45 ` Dmitry Baryshkov
@ 2026-05-13 11:59 ` Neil Armstrong
2026-05-13 12:04 ` Dmitry Baryshkov
0 siblings, 1 reply; 49+ messages in thread
From: Neil Armstrong @ 2026-05-13 11:59 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, linux-media,
linux-arm-msm, linux-kernel
On 5/13/26 12:45, Dmitry Baryshkov wrote:
> On Mon, May 11, 2026 at 11:20:31AM +0200, Neil Armstrong wrote:
>> Add the necessary bits into the gen2 platforms tables and handlers
>> to allow decoding streams into 10bit pixel formats.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> .../media/platform/qcom/iris/iris_hfi_gen2_response.c | 16 +++++++++++++++-
>> drivers/media/platform/qcom/iris/iris_instance.h | 2 ++
>> drivers/media/platform/qcom/iris/iris_platform_gen2.c | 8 +++++---
>> drivers/media/platform/qcom/iris/iris_vdec.c | 8 ++++++++
>> 4 files changed, 30 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
>> index 0541e02d7507..b6d815c01f1d 100644
>> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
>> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
>> @@ -542,6 +542,15 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
>> pixmp_ip->width = width;
>> pixmp_ip->height = height;
>>
>> + if (subsc_params.bit_depth == BIT_DEPTH_8 &&
>> + pixmp_op->pixelformat != V4L2_PIX_FMT_NV12 &&
>> + pixmp_op->pixelformat != V4L2_PIX_FMT_QC08C)
>> + pixmp_op->pixelformat = V4L2_PIX_FMT_NV12;
>> + else if (subsc_params.bit_depth == BIT_DEPTH_10 &&
>> + pixmp_op->pixelformat != V4L2_PIX_FMT_P010 &&
>> + pixmp_op->pixelformat != V4L2_PIX_FMT_QC10C)
>> + pixmp_op->pixelformat = V4L2_PIX_FMT_P010;
>
> Do we support decoding of 10-bit videos to NV12 buffers?
AFAIK no, I found no sign of that in the downstream driver but I may be wrong.
Neil
>
>> +
>> switch (pixmp_op->pixelformat) {
>> case V4L2_PIX_FMT_P010:
>> pixmp_op->width = ALIGN(width, 128);
>
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
2026-05-13 11:59 ` Neil Armstrong
@ 2026-05-13 12:04 ` Dmitry Baryshkov
0 siblings, 0 replies; 49+ messages in thread
From: Dmitry Baryshkov @ 2026-05-13 12:04 UTC (permalink / raw)
To: Neil Armstrong
Cc: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, linux-media,
linux-arm-msm, linux-kernel
On Wed, May 13, 2026 at 01:59:19PM +0200, Neil Armstrong wrote:
> On 5/13/26 12:45, Dmitry Baryshkov wrote:
> > On Mon, May 11, 2026 at 11:20:31AM +0200, Neil Armstrong wrote:
> > > Add the necessary bits into the gen2 platforms tables and handlers
> > > to allow decoding streams into 10bit pixel formats.
> > >
> > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> > > ---
> > > .../media/platform/qcom/iris/iris_hfi_gen2_response.c | 16 +++++++++++++++-
> > > drivers/media/platform/qcom/iris/iris_instance.h | 2 ++
> > > drivers/media/platform/qcom/iris/iris_platform_gen2.c | 8 +++++---
> > > drivers/media/platform/qcom/iris/iris_vdec.c | 8 ++++++++
> > > 4 files changed, 30 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> > > index 0541e02d7507..b6d815c01f1d 100644
> > > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> > > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> > > @@ -542,6 +542,15 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
> > > pixmp_ip->width = width;
> > > pixmp_ip->height = height;
> > > + if (subsc_params.bit_depth == BIT_DEPTH_8 &&
> > > + pixmp_op->pixelformat != V4L2_PIX_FMT_NV12 &&
> > > + pixmp_op->pixelformat != V4L2_PIX_FMT_QC08C)
> > > + pixmp_op->pixelformat = V4L2_PIX_FMT_NV12;
> > > + else if (subsc_params.bit_depth == BIT_DEPTH_10 &&
> > > + pixmp_op->pixelformat != V4L2_PIX_FMT_P010 &&
> > > + pixmp_op->pixelformat != V4L2_PIX_FMT_QC10C)
> > > + pixmp_op->pixelformat = V4L2_PIX_FMT_P010;
> >
> > Do we support decoding of 10-bit videos to NV12 buffers?
>
> AFAIK no, I found no sign of that in the downstream driver but I may be wrong.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
2026-05-11 9:20 ` [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format Neil Armstrong
2026-05-13 10:45 ` Dmitry Baryshkov
@ 2026-05-13 19:39 ` Vikash Garodia
2026-05-18 7:39 ` Neil Armstrong
1 sibling, 1 reply; 49+ messages in thread
From: Vikash Garodia @ 2026-05-13 19:39 UTC (permalink / raw)
To: Neil Armstrong, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/11/2026 2:50 PM, Neil Armstrong wrote:
> Add the necessary bits into the gen2 platforms tables and handlers
> to allow decoding streams into 10bit pixel formats.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../media/platform/qcom/iris/iris_hfi_gen2_response.c | 16 +++++++++++++++-
> drivers/media/platform/qcom/iris/iris_instance.h | 2 ++
> drivers/media/platform/qcom/iris/iris_platform_gen2.c | 8 +++++---
> drivers/media/platform/qcom/iris/iris_vdec.c | 8 ++++++++
> 4 files changed, 30 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> index 0541e02d7507..b6d815c01f1d 100644
> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
> @@ -542,6 +542,15 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
> pixmp_ip->width = width;
> pixmp_ip->height = height;
>
> + if (subsc_params.bit_depth == BIT_DEPTH_8 &&
> + pixmp_op->pixelformat != V4L2_PIX_FMT_NV12 &&
> + pixmp_op->pixelformat != V4L2_PIX_FMT_QC08C)
> + pixmp_op->pixelformat = V4L2_PIX_FMT_NV12;
> + else if (subsc_params.bit_depth == BIT_DEPTH_10 &&
> + pixmp_op->pixelformat != V4L2_PIX_FMT_P010 &&
> + pixmp_op->pixelformat != V4L2_PIX_FMT_QC10C)
> + pixmp_op->pixelformat = V4L2_PIX_FMT_P010;
> +
> switch (pixmp_op->pixelformat) {
> case V4L2_PIX_FMT_P010:
> pixmp_op->width = ALIGN(width, 128);
> @@ -625,7 +634,12 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
> inst->fw_caps[POC].value = subsc_params.pic_order_cnt;
> inst->fw_caps[TIER].value = subsc_params.tier;
>
> - if (subsc_params.bit_depth != BIT_DEPTH_8 ||
> + if (subsc_params.bit_depth == BIT_DEPTH_8)
> + inst->fw_caps[BIT_DEPTH].value = BIT_DEPTH_8;
> + else
> + inst->fw_caps[BIT_DEPTH].value = BIT_DEPTH_10;
> +
> + if ((subsc_params.bit_depth != BIT_DEPTH_8 && subsc_params.bit_depth != BIT_DEPTH_10) ||
> !(subsc_params.coded_frames & HFI_BITMASK_FRAME_MBS_ONLY_FLAG)) {
> dev_err(core->dev, "unsupported content, bit depth: %x, pic_struct = %x\n",
> subsc_params.bit_depth, subsc_params.coded_frames);
> diff --git a/drivers/media/platform/qcom/iris/iris_instance.h b/drivers/media/platform/qcom/iris/iris_instance.h
> index 16965150f427..16424d1e94a6 100644
> --- a/drivers/media/platform/qcom/iris/iris_instance.h
> +++ b/drivers/media/platform/qcom/iris/iris_instance.h
> @@ -25,6 +25,8 @@ enum iris_fmt_type_out {
> enum iris_fmt_type_cap {
> IRIS_FMT_NV12,
> IRIS_FMT_QC08C,
> + IRIS_FMT_TP10,
> + IRIS_FMT_QC10C,
> };
>
> struct iris_fmt {
> diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
> index 5da90d47f9c6..ceed4b5d96ca 100644
> --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c
> +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
> @@ -56,9 +56,10 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8550_dec[] = {
> {
> .cap_id = PROFILE_HEVC,
> .min = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN,
> - .max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE,
> + .max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10,
what about gen1 platforms ?
> .step_or_mask = BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN) |
> - BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE),
> + BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE) |
> + BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10),
> .value = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN,
> .hfi_id = HFI_PROP_PROFILE,
> .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_MENU,
> @@ -287,7 +288,7 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8550_dec[] = {
> {
> .cap_id = BIT_DEPTH,
> .min = BIT_DEPTH_8,
> - .max = BIT_DEPTH_8,
> + .max = BIT_DEPTH_10,
> .step_or_mask = 1,
> .value = BIT_DEPTH_8,
> .hfi_id = HFI_PROP_LUMA_CHROMA_BIT_DEPTH,
> @@ -866,6 +867,7 @@ static const u32 sm8550_vdec_output_config_params[] = {
> HFI_PROP_OPB_ENABLE,
> HFI_PROP_COLOR_FORMAT,
> HFI_PROP_LINEAR_STRIDE_SCANLINE,
> + HFI_PROP_UBWC_STRIDE_SCANLINE,
> };
>
> static const u32 sm8550_venc_output_config_params[] = {
> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c
> index f4d9951ed04c..65cf509e4aef 100644
> --- a/drivers/media/platform/qcom/iris/iris_vdec.c
> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c
> @@ -70,6 +70,14 @@ static const struct iris_fmt iris_vdec_formats_cap[] = {
> .pixfmt = V4L2_PIX_FMT_QC08C,
> .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
> },
> + [IRIS_FMT_TP10] = {
> + .pixfmt = V4L2_PIX_FMT_P010,
> + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
> + },
> + [IRIS_FMT_QC10C] = {
> + .pixfmt = V4L2_PIX_FMT_QC10C,
> + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
> + },
> };
>
> static const struct iris_fmt *
>
Regards,
Vikash
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
2026-05-13 19:39 ` Vikash Garodia
@ 2026-05-18 7:39 ` Neil Armstrong
2026-05-20 15:55 ` Vikash Garodia
0 siblings, 1 reply; 49+ messages in thread
From: Neil Armstrong @ 2026-05-18 7:39 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/13/26 21:39, Vikash Garodia wrote:
>
> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>> Add the necessary bits into the gen2 platforms tables and handlers
>> to allow decoding streams into 10bit pixel formats.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> .../media/platform/qcom/iris/iris_hfi_gen2_response.c | 16 +++++++++++++++-
>> drivers/media/platform/qcom/iris/iris_instance.h | 2 ++
>> drivers/media/platform/qcom/iris/iris_platform_gen2.c | 8 +++++---
>> drivers/media/platform/qcom/iris/iris_vdec.c | 8 ++++++++
>> 4 files changed, 30 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
>> index 0541e02d7507..b6d815c01f1d 100644
>> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
>> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
>> @@ -542,6 +542,15 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
>> pixmp_ip->width = width;
>> pixmp_ip->height = height;
>> + if (subsc_params.bit_depth == BIT_DEPTH_8 &&
>> + pixmp_op->pixelformat != V4L2_PIX_FMT_NV12 &&
>> + pixmp_op->pixelformat != V4L2_PIX_FMT_QC08C)
>> + pixmp_op->pixelformat = V4L2_PIX_FMT_NV12;
>> + else if (subsc_params.bit_depth == BIT_DEPTH_10 &&
>> + pixmp_op->pixelformat != V4L2_PIX_FMT_P010 &&
>> + pixmp_op->pixelformat != V4L2_PIX_FMT_QC10C)
>> + pixmp_op->pixelformat = V4L2_PIX_FMT_P010;
>> +
>> switch (pixmp_op->pixelformat) {
>> case V4L2_PIX_FMT_P010:
>> pixmp_op->width = ALIGN(width, 128);
>> @@ -625,7 +634,12 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
>> inst->fw_caps[POC].value = subsc_params.pic_order_cnt;
>> inst->fw_caps[TIER].value = subsc_params.tier;
>> - if (subsc_params.bit_depth != BIT_DEPTH_8 ||
>> + if (subsc_params.bit_depth == BIT_DEPTH_8)
>> + inst->fw_caps[BIT_DEPTH].value = BIT_DEPTH_8;
>> + else
>> + inst->fw_caps[BIT_DEPTH].value = BIT_DEPTH_10;
>> +
>> + if ((subsc_params.bit_depth != BIT_DEPTH_8 && subsc_params.bit_depth != BIT_DEPTH_10) ||
>> !(subsc_params.coded_frames & HFI_BITMASK_FRAME_MBS_ONLY_FLAG)) {
>> dev_err(core->dev, "unsupported content, bit depth: %x, pic_struct = %x\n",
>> subsc_params.bit_depth, subsc_params.coded_frames);
>> diff --git a/drivers/media/platform/qcom/iris/iris_instance.h b/drivers/media/platform/qcom/iris/iris_instance.h
>> index 16965150f427..16424d1e94a6 100644
>> --- a/drivers/media/platform/qcom/iris/iris_instance.h
>> +++ b/drivers/media/platform/qcom/iris/iris_instance.h
>> @@ -25,6 +25,8 @@ enum iris_fmt_type_out {
>> enum iris_fmt_type_cap {
>> IRIS_FMT_NV12,
>> IRIS_FMT_QC08C,
>> + IRIS_FMT_TP10,
>> + IRIS_FMT_QC10C,
>> };
>> struct iris_fmt {
>> diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
>> index 5da90d47f9c6..ceed4b5d96ca 100644
>> --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c
>> +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
>> @@ -56,9 +56,10 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8550_dec[] = {
>> {
>> .cap_id = PROFILE_HEVC,
>> .min = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN,
>> - .max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE,
>> + .max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10,
>
> what about gen1 platforms ?
With this patchset gen platforms will reject 10bit since all the
plumbing in the HFI response handling is missing.
Once the Gen1 HFI gets the bit_depth and calculates the buffer sizes, it
should work. But looking at Venus, the 10bit buffer calculation seems much
more complex in Gen1.
>
>> .step_or_mask = BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN) |
>> - BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE),
>> + BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE) |
>> + BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10),
>> .value = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN,
>> .hfi_id = HFI_PROP_PROFILE,
>> .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_MENU,
>> @@ -287,7 +288,7 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8550_dec[] = {
>> {
>> .cap_id = BIT_DEPTH,
>> .min = BIT_DEPTH_8,
>> - .max = BIT_DEPTH_8,
>> + .max = BIT_DEPTH_10,
>> .step_or_mask = 1,
>> .value = BIT_DEPTH_8,
>> .hfi_id = HFI_PROP_LUMA_CHROMA_BIT_DEPTH,
>> @@ -866,6 +867,7 @@ static const u32 sm8550_vdec_output_config_params[] = {
>> HFI_PROP_OPB_ENABLE,
>> HFI_PROP_COLOR_FORMAT,
>> HFI_PROP_LINEAR_STRIDE_SCANLINE,
>> + HFI_PROP_UBWC_STRIDE_SCANLINE,
>> };
>> static const u32 sm8550_venc_output_config_params[] = {
>> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c
>> index f4d9951ed04c..65cf509e4aef 100644
>> --- a/drivers/media/platform/qcom/iris/iris_vdec.c
>> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c
>> @@ -70,6 +70,14 @@ static const struct iris_fmt iris_vdec_formats_cap[] = {
>> .pixfmt = V4L2_PIX_FMT_QC08C,
>> .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
>> },
>> + [IRIS_FMT_TP10] = {
>> + .pixfmt = V4L2_PIX_FMT_P010,
>> + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
>> + },
>> + [IRIS_FMT_QC10C] = {
>> + .pixfmt = V4L2_PIX_FMT_QC10C,
>> + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
>> + },
>> };
>> static const struct iris_fmt *
>>
>
> Regards,
> Vikash
>
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
2026-05-18 7:39 ` Neil Armstrong
@ 2026-05-20 15:55 ` Vikash Garodia
2026-05-21 7:27 ` Neil Armstrong
0 siblings, 1 reply; 49+ messages in thread
From: Vikash Garodia @ 2026-05-20 15:55 UTC (permalink / raw)
To: Neil Armstrong, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/18/2026 1:09 PM, Neil Armstrong wrote:
> On 5/13/26 21:39, Vikash Garodia wrote:
>>
>> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>>> Add the necessary bits into the gen2 platforms tables and handlers
>>> to allow decoding streams into 10bit pixel formats.
>>>
>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>> ---
>>> .../media/platform/qcom/iris/iris_hfi_gen2_response.c | 16 +++++
>>> ++++++++++-
>>> drivers/media/platform/qcom/iris/iris_instance.h | 2 ++
>>> drivers/media/platform/qcom/iris/iris_platform_gen2.c | 8 +++++---
>>> drivers/media/platform/qcom/iris/iris_vdec.c | 8 ++++++++
>>> 4 files changed, 30 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/media/platform/qcom/iris/
>>> iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/
>>> iris_hfi_gen2_response.c
>>> index 0541e02d7507..b6d815c01f1d 100644
>>> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
>>> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
>>> @@ -542,6 +542,15 @@ static void
>>> iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
>>> pixmp_ip->width = width;
>>> pixmp_ip->height = height;
>>> + if (subsc_params.bit_depth == BIT_DEPTH_8 &&
>>> + pixmp_op->pixelformat != V4L2_PIX_FMT_NV12 &&
>>> + pixmp_op->pixelformat != V4L2_PIX_FMT_QC08C)
>>> + pixmp_op->pixelformat = V4L2_PIX_FMT_NV12;
>>> + else if (subsc_params.bit_depth == BIT_DEPTH_10 &&
>>> + pixmp_op->pixelformat != V4L2_PIX_FMT_P010 &&
>>> + pixmp_op->pixelformat != V4L2_PIX_FMT_QC10C)
>>> + pixmp_op->pixelformat = V4L2_PIX_FMT_P010;
>>> +
>>> switch (pixmp_op->pixelformat) {
>>> case V4L2_PIX_FMT_P010:
>>> pixmp_op->width = ALIGN(width, 128);
>>> @@ -625,7 +634,12 @@ static void
>>> iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
>>> inst->fw_caps[POC].value = subsc_params.pic_order_cnt;
>>> inst->fw_caps[TIER].value = subsc_params.tier;
>>> - if (subsc_params.bit_depth != BIT_DEPTH_8 ||
>>> + if (subsc_params.bit_depth == BIT_DEPTH_8)
>>> + inst->fw_caps[BIT_DEPTH].value = BIT_DEPTH_8;
>>> + else
>>> + inst->fw_caps[BIT_DEPTH].value = BIT_DEPTH_10;
>>> +
>>> + if ((subsc_params.bit_depth != BIT_DEPTH_8 &&
>>> subsc_params.bit_depth != BIT_DEPTH_10) ||
>>> !(subsc_params.coded_frames &
>>> HFI_BITMASK_FRAME_MBS_ONLY_FLAG)) {
>>> dev_err(core->dev, "unsupported content, bit depth: %x,
>>> pic_struct = %x\n",
>>> subsc_params.bit_depth, subsc_params.coded_frames);
>>> diff --git a/drivers/media/platform/qcom/iris/iris_instance.h b/
>>> drivers/media/platform/qcom/iris/iris_instance.h
>>> index 16965150f427..16424d1e94a6 100644
>>> --- a/drivers/media/platform/qcom/iris/iris_instance.h
>>> +++ b/drivers/media/platform/qcom/iris/iris_instance.h
>>> @@ -25,6 +25,8 @@ enum iris_fmt_type_out {
>>> enum iris_fmt_type_cap {
>>> IRIS_FMT_NV12,
>>> IRIS_FMT_QC08C,
>>> + IRIS_FMT_TP10,
>>> + IRIS_FMT_QC10C,
>>> };
>>> struct iris_fmt {
>>> diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/
>>> drivers/media/platform/qcom/iris/iris_platform_gen2.c
>>> index 5da90d47f9c6..ceed4b5d96ca 100644
>>> --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c
>>> +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
>>> @@ -56,9 +56,10 @@ static const struct platform_inst_fw_cap
>>> inst_fw_cap_sm8550_dec[] = {
>>> {
>>> .cap_id = PROFILE_HEVC,
>>> .min = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN,
>>> - .max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE,
>>> + .max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10,
>>
>> what about gen1 platforms ?
>
> With this patchset gen platforms will reject 10bit since all the
> plumbing in the HFI response handling is missing.
>
> Once the Gen1 HFI gets the bit_depth and calculates the buffer sizes, it
> should work. But looking at Venus, the 10bit buffer calculation seems much
> more complex in Gen1.
Is it more than accommodating higher buffer size by adding 25% extra for
higher bits for decode scenario ?
>
>>
>>> .step_or_mask = BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN) |
>>> - BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE),
>>> + BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE) |
>>> + BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10),
>>> .value = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN,
>>> .hfi_id = HFI_PROP_PROFILE,
>>> .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_MENU,
>>> @@ -287,7 +288,7 @@ static const struct platform_inst_fw_cap
>>> inst_fw_cap_sm8550_dec[] = {
>>> {
>>> .cap_id = BIT_DEPTH,
>>> .min = BIT_DEPTH_8,
>>> - .max = BIT_DEPTH_8,
>>> + .max = BIT_DEPTH_10,
>>> .step_or_mask = 1,
>>> .value = BIT_DEPTH_8,
>>> .hfi_id = HFI_PROP_LUMA_CHROMA_BIT_DEPTH,
>>> @@ -866,6 +867,7 @@ static const u32
>>> sm8550_vdec_output_config_params[] = {
>>> HFI_PROP_OPB_ENABLE,
>>> HFI_PROP_COLOR_FORMAT,
>>> HFI_PROP_LINEAR_STRIDE_SCANLINE,
>>> + HFI_PROP_UBWC_STRIDE_SCANLINE,
>>> };
>>> static const u32 sm8550_venc_output_config_params[] = {
>>> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/
>>> media/platform/qcom/iris/iris_vdec.c
>>> index f4d9951ed04c..65cf509e4aef 100644
>>> --- a/drivers/media/platform/qcom/iris/iris_vdec.c
>>> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c
>>> @@ -70,6 +70,14 @@ static const struct iris_fmt
>>> iris_vdec_formats_cap[] = {
>>> .pixfmt = V4L2_PIX_FMT_QC08C,
>>> .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
>>> },
>>> + [IRIS_FMT_TP10] = {
>>> + .pixfmt = V4L2_PIX_FMT_P010,
>>> + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
>>> + },
>>> + [IRIS_FMT_QC10C] = {
>>> + .pixfmt = V4L2_PIX_FMT_QC10C,
>>> + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
>>> + },
>>> };
>>> static const struct iris_fmt *
>>>
>>
>> Regards,
>> Vikash
>>
>
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
2026-05-20 15:55 ` Vikash Garodia
@ 2026-05-21 7:27 ` Neil Armstrong
2026-05-21 9:52 ` Vikash Garodia
0 siblings, 1 reply; 49+ messages in thread
From: Neil Armstrong @ 2026-05-21 7:27 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/20/26 17:55, Vikash Garodia wrote:
>
> On 5/18/2026 1:09 PM, Neil Armstrong wrote:
>> On 5/13/26 21:39, Vikash Garodia wrote:
>>>
>>> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>>>> Add the necessary bits into the gen2 platforms tables and handlers
>>>> to allow decoding streams into 10bit pixel formats.
>>>>
>>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>>> ---
>>>> .../media/platform/qcom/iris/iris_hfi_gen2_response.c | 16 +++++ ++++++++++-
>>>> drivers/media/platform/qcom/iris/iris_instance.h | 2 ++
>>>> drivers/media/platform/qcom/iris/iris_platform_gen2.c | 8 +++++---
>>>> drivers/media/platform/qcom/iris/iris_vdec.c | 8 ++++++++
>>>> 4 files changed, 30 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/drivers/media/platform/qcom/iris/ iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/ iris_hfi_gen2_response.c
>>>> index 0541e02d7507..b6d815c01f1d 100644
>>>> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
>>>> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
>>>> @@ -542,6 +542,15 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
>>>> pixmp_ip->width = width;
>>>> pixmp_ip->height = height;
>>>> + if (subsc_params.bit_depth == BIT_DEPTH_8 &&
>>>> + pixmp_op->pixelformat != V4L2_PIX_FMT_NV12 &&
>>>> + pixmp_op->pixelformat != V4L2_PIX_FMT_QC08C)
>>>> + pixmp_op->pixelformat = V4L2_PIX_FMT_NV12;
>>>> + else if (subsc_params.bit_depth == BIT_DEPTH_10 &&
>>>> + pixmp_op->pixelformat != V4L2_PIX_FMT_P010 &&
>>>> + pixmp_op->pixelformat != V4L2_PIX_FMT_QC10C)
>>>> + pixmp_op->pixelformat = V4L2_PIX_FMT_P010;
>>>> +
>>>> switch (pixmp_op->pixelformat) {
>>>> case V4L2_PIX_FMT_P010:
>>>> pixmp_op->width = ALIGN(width, 128);
>>>> @@ -625,7 +634,12 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
>>>> inst->fw_caps[POC].value = subsc_params.pic_order_cnt;
>>>> inst->fw_caps[TIER].value = subsc_params.tier;
>>>> - if (subsc_params.bit_depth != BIT_DEPTH_8 ||
>>>> + if (subsc_params.bit_depth == BIT_DEPTH_8)
>>>> + inst->fw_caps[BIT_DEPTH].value = BIT_DEPTH_8;
>>>> + else
>>>> + inst->fw_caps[BIT_DEPTH].value = BIT_DEPTH_10;
>>>> +
>>>> + if ((subsc_params.bit_depth != BIT_DEPTH_8 && subsc_params.bit_depth != BIT_DEPTH_10) ||
>>>> !(subsc_params.coded_frames & HFI_BITMASK_FRAME_MBS_ONLY_FLAG)) {
>>>> dev_err(core->dev, "unsupported content, bit depth: %x, pic_struct = %x\n",
>>>> subsc_params.bit_depth, subsc_params.coded_frames);
>>>> diff --git a/drivers/media/platform/qcom/iris/iris_instance.h b/ drivers/media/platform/qcom/iris/iris_instance.h
>>>> index 16965150f427..16424d1e94a6 100644
>>>> --- a/drivers/media/platform/qcom/iris/iris_instance.h
>>>> +++ b/drivers/media/platform/qcom/iris/iris_instance.h
>>>> @@ -25,6 +25,8 @@ enum iris_fmt_type_out {
>>>> enum iris_fmt_type_cap {
>>>> IRIS_FMT_NV12,
>>>> IRIS_FMT_QC08C,
>>>> + IRIS_FMT_TP10,
>>>> + IRIS_FMT_QC10C,
>>>> };
>>>> struct iris_fmt {
>>>> diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/ drivers/media/platform/qcom/iris/iris_platform_gen2.c
>>>> index 5da90d47f9c6..ceed4b5d96ca 100644
>>>> --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c
>>>> +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
>>>> @@ -56,9 +56,10 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8550_dec[] = {
>>>> {
>>>> .cap_id = PROFILE_HEVC,
>>>> .min = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN,
>>>> - .max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE,
>>>> + .max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10,
>>>
>>> what about gen1 platforms ?
>>
>> With this patchset gen platforms will reject 10bit since all the
>> plumbing in the HFI response handling is missing.
>>
>> Once the Gen1 HFI gets the bit_depth and calculates the buffer sizes, it
>> should work. But looking at Venus, the 10bit buffer calculation seems much
>> more complex in Gen1.
>
> Is it more than accommodating higher buffer size by adding 25% extra for higher bits for decode scenario ?
No idea, I haven't looked closely how to implement 10bit on gen1, I just checked if this patchset
wouldn't cause any regressions.
It may show P010 and QC10C in enum_fmt, but the PROFILE_HEVC and would not expose MAIN10 on gen1.
>
>>
>>>
>>>> .step_or_mask = BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN) |
>>>> - BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE),
>>>> + BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE) |
>>>> + BIT(V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10),
>>>> .value = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN,
>>>> .hfi_id = HFI_PROP_PROFILE,
>>>> .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_MENU,
>>>> @@ -287,7 +288,7 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8550_dec[] = {
>>>> {
>>>> .cap_id = BIT_DEPTH,
>>>> .min = BIT_DEPTH_8,
>>>> - .max = BIT_DEPTH_8,
>>>> + .max = BIT_DEPTH_10,
>>>> .step_or_mask = 1,
>>>> .value = BIT_DEPTH_8,
>>>> .hfi_id = HFI_PROP_LUMA_CHROMA_BIT_DEPTH,
>>>> @@ -866,6 +867,7 @@ static const u32 sm8550_vdec_output_config_params[] = {
>>>> HFI_PROP_OPB_ENABLE,
>>>> HFI_PROP_COLOR_FORMAT,
>>>> HFI_PROP_LINEAR_STRIDE_SCANLINE,
>>>> + HFI_PROP_UBWC_STRIDE_SCANLINE,
>>>> };
>>>> static const u32 sm8550_venc_output_config_params[] = {
>>>> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/ media/platform/qcom/iris/iris_vdec.c
>>>> index f4d9951ed04c..65cf509e4aef 100644
>>>> --- a/drivers/media/platform/qcom/iris/iris_vdec.c
>>>> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c
>>>> @@ -70,6 +70,14 @@ static const struct iris_fmt iris_vdec_formats_cap[] = {
>>>> .pixfmt = V4L2_PIX_FMT_QC08C,
>>>> .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
>>>> },
>>>> + [IRIS_FMT_TP10] = {
>>>> + .pixfmt = V4L2_PIX_FMT_P010,
>>>> + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
>>>> + },
>>>> + [IRIS_FMT_QC10C] = {
>>>> + .pixfmt = V4L2_PIX_FMT_QC10C,
>>>> + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
>>>> + },
>>>> };
>>>> static const struct iris_fmt *
>>>>
>>>
>>> Regards,
>>> Vikash
>>>
>>
>
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
2026-05-21 7:27 ` Neil Armstrong
@ 2026-05-21 9:52 ` Vikash Garodia
0 siblings, 0 replies; 49+ messages in thread
From: Vikash Garodia @ 2026-05-21 9:52 UTC (permalink / raw)
To: Neil Armstrong, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/21/2026 12:57 PM, Neil Armstrong wrote:
> On 5/20/26 17:55, Vikash Garodia wrote:
>>
>> On 5/18/2026 1:09 PM, Neil Armstrong wrote:
>>> On 5/13/26 21:39, Vikash Garodia wrote:
>>>>
>>>> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>>>>> Add the necessary bits into the gen2 platforms tables and handlers
>>>>> to allow decoding streams into 10bit pixel formats.
>>>>>
>>>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>>>> ---
>>>>> .../media/platform/qcom/iris/iris_hfi_gen2_response.c | 16 +++
>>>>> ++ ++++++++++-
>>>>> drivers/media/platform/qcom/iris/iris_instance.h | 2 ++
>>>>> drivers/media/platform/qcom/iris/iris_platform_gen2.c | 8 +++
>>>>> ++---
>>>>> drivers/media/platform/qcom/iris/iris_vdec.c | 8 +++
>>>>> +++++
>>>>> 4 files changed, 30 insertions(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/drivers/media/platform/qcom/iris/
>>>>> iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/
>>>>> iris_hfi_gen2_response.c
>>>>> index 0541e02d7507..b6d815c01f1d 100644
>>>>> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
>>>>> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
>>>>> @@ -542,6 +542,15 @@ static void
>>>>> iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
>>>>> pixmp_ip->width = width;
>>>>> pixmp_ip->height = height;
>>>>> + if (subsc_params.bit_depth == BIT_DEPTH_8 &&
>>>>> + pixmp_op->pixelformat != V4L2_PIX_FMT_NV12 &&
>>>>> + pixmp_op->pixelformat != V4L2_PIX_FMT_QC08C)
>>>>> + pixmp_op->pixelformat = V4L2_PIX_FMT_NV12;
>>>>> + else if (subsc_params.bit_depth == BIT_DEPTH_10 &&
>>>>> + pixmp_op->pixelformat != V4L2_PIX_FMT_P010 &&
>>>>> + pixmp_op->pixelformat != V4L2_PIX_FMT_QC10C)
>>>>> + pixmp_op->pixelformat = V4L2_PIX_FMT_P010;
>>>>> +
>>>>> switch (pixmp_op->pixelformat) {
>>>>> case V4L2_PIX_FMT_P010:
>>>>> pixmp_op->width = ALIGN(width, 128);
>>>>> @@ -625,7 +634,12 @@ static void
>>>>> iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst)
>>>>> inst->fw_caps[POC].value = subsc_params.pic_order_cnt;
>>>>> inst->fw_caps[TIER].value = subsc_params.tier;
>>>>> - if (subsc_params.bit_depth != BIT_DEPTH_8 ||
>>>>> + if (subsc_params.bit_depth == BIT_DEPTH_8)
>>>>> + inst->fw_caps[BIT_DEPTH].value = BIT_DEPTH_8;
>>>>> + else
>>>>> + inst->fw_caps[BIT_DEPTH].value = BIT_DEPTH_10;
>>>>> +
>>>>> + if ((subsc_params.bit_depth != BIT_DEPTH_8 &&
>>>>> subsc_params.bit_depth != BIT_DEPTH_10) ||
>>>>> !(subsc_params.coded_frames &
>>>>> HFI_BITMASK_FRAME_MBS_ONLY_FLAG)) {
>>>>> dev_err(core->dev, "unsupported content, bit depth: %x,
>>>>> pic_struct = %x\n",
>>>>> subsc_params.bit_depth, subsc_params.coded_frames);
>>>>> diff --git a/drivers/media/platform/qcom/iris/iris_instance.h b/
>>>>> drivers/media/platform/qcom/iris/iris_instance.h
>>>>> index 16965150f427..16424d1e94a6 100644
>>>>> --- a/drivers/media/platform/qcom/iris/iris_instance.h
>>>>> +++ b/drivers/media/platform/qcom/iris/iris_instance.h
>>>>> @@ -25,6 +25,8 @@ enum iris_fmt_type_out {
>>>>> enum iris_fmt_type_cap {
>>>>> IRIS_FMT_NV12,
>>>>> IRIS_FMT_QC08C,
>>>>> + IRIS_FMT_TP10,
>>>>> + IRIS_FMT_QC10C,
>>>>> };
>>>>> struct iris_fmt {
>>>>> diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c
>>>>> b/ drivers/media/platform/qcom/iris/iris_platform_gen2.c
>>>>> index 5da90d47f9c6..ceed4b5d96ca 100644
>>>>> --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c
>>>>> +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
>>>>> @@ -56,9 +56,10 @@ static const struct platform_inst_fw_cap
>>>>> inst_fw_cap_sm8550_dec[] = {
>>>>> {
>>>>> .cap_id = PROFILE_HEVC,
>>>>> .min = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN,
>>>>> - .max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_STILL_PICTURE,
>>>>> + .max = V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10,
>>>>
>>>> what about gen1 platforms ?
>>>
>>> With this patchset gen platforms will reject 10bit since all the
>>> plumbing in the HFI response handling is missing.
>>>
>>> Once the Gen1 HFI gets the bit_depth and calculates the buffer sizes, it
>>> should work. But looking at Venus, the 10bit buffer calculation seems
>>> much
>>> more complex in Gen1.
>>
>> Is it more than accommodating higher buffer size by adding 25% extra
>> for higher bits for decode scenario ?
>
> No idea, I haven't looked closely how to implement 10bit on gen1, I just
> checked if this patchset
> wouldn't cause any regressions.
>
> It may show P010 and QC10C in enum_fmt, but the PROFILE_HEVC and would
> not expose MAIN10 on gen1.
>
I can sense this could lead to compliance failure on gen1 as the driver
exposes 10bit as supported format but does not allow the configuration.
I could be wrong here though.
Regards,
Vikash
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats
2026-05-11 9:20 ` [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats Neil Armstrong
` (5 preceding siblings ...)
2026-05-11 9:20 ` [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format Neil Armstrong
@ 2026-05-13 8:50 ` Wangao Wang
2026-05-13 12:11 ` Neil Armstrong
2026-05-13 17:33 ` Vikash Garodia
2026-05-15 9:35 ` Bryan O'Donoghue
8 siblings, 1 reply; 49+ messages in thread
From: Wangao Wang @ 2026-05-13 8:50 UTC (permalink / raw)
To: Neil Armstrong, Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: wangao.wang, linux-media, linux-arm-msm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 12263 bytes --]
I did testing on Purwa and found that the decoded raw data only has one
frame, and there is also an alignment issue. Screenshots are in the
attachment.
I used the command you provided to generate the HDR H.265 stream, and
tested with the same v4l2-ctrl command. Is there anything in the testing
details that I might have missed?
On 2026/5/11 17:20, Neil Armstrong wrote:
> This adds the plumbing to support decoding HEVC, VP9 and AV1
> streams into 10bit pixel formats, linear and compressed.
>
> This has only been tested on SM8550 & SM8650 with HEVC, and was
> inspired by Venus, DRM MSM and the downstream vidc driver for the
> buffer calculations and HFI messages.
>
> I was unable to get 10bit decoding working with ffmpeg since P010
> support for v4l2 decoding is missing, but v4l2-ctl works with:
> v4l2-ctl --verbose --set-fmt-video-out=pixelformat=HEVC --set-fmt-video=pixelformat=P010 --stream-mmap --stream-out-mmap --stream-from-hdr Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr --stream-to out.P010
> v4l2-ctl --verbose --set-fmt-video-out=pixelformat=HEVC --set-fmt-video=pixelformat=Q10C --stream-mmap --stream-out-mmap --stream-from-hdr Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr --stream-to out.QC10
>
> The non-10bit decoding still works as before.
>
> With Big_Buck_Bunny_1080_10s_30MB reencoded in 10-bit profile
> and tranformed in v4l2 header format with [1]:
> ffmpeg -i Big_Buck_Bunny_1080_10s_30MB.h264 -pix_fmt yuv420p10le -c:v libx265 -crf 28 -x265-params profile=main10 Big_Buck_Bunny_1080_10s_30MB_main10.h265
> /path/to/mkhdr.sh Big_Buck_Bunny_1080_10s_30MB_main10.h265 raw Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr
>
> Fluster HEVC results on SM8650:
>
> ./fluster.py run -ts JCT-VC-HEVC_V1 -d GStreamer-H.265-V4L2-Gst1.0 - 131/147
> The failing test case:
> - Pixel Format mismatch
> - TSUNEQBD_A_MAIN10_Technicolor_2 - Gstreamer waits NV12 but decoder returns P010
> - Unsupported resolution
> - PICSIZE_A_Bossen_1 - resolution is higher than max supported
> - PICSIZE_B_Bossen_1 - resolution is higher than max supported
> - WPP_D_ericsson_MAIN_2 - resolution is lower than min supported
> - WPP_D_ericsson_MAIN10_2 - resolution is lower than min supported
> - CRC mismatch
> - RAP_A_docomo_6
> - CRC mismatch - bitstream issue - fails with ffmpeg sw decoder as well
> - VPSSPSPPS_A_MainConcept_1
>
> v4l2-compliance results on SM8550 & SM8650:
>
> $ v4l2-compliance -d /dev/video1 -s
> v4l2-compliance 1.33.0-5456, 64 bits, 64-bit time_t
> v4l2-compliance SHA: 8aa593bda182 2026-04-11 10:54:25
>
> Compliance test for iris_driver device /dev/video1:
>
> Driver Info:
> Driver name : iris_driver
> Card type : Iris Encoder
> Bus info : platform:aa00000.video-codec
> Driver version : 7.0.0
> Capabilities : 0x84204000
> Video Memory-to-Memory Multiplanar
> Streaming
> Extended Pix Format
> Device Capabilities
> Device Caps : 0x04204000
> Video Memory-to-Memory Multiplanar
> Streaming
> Extended Pix Format
> Detected Stateful Encoder
>
> Required ioctls:
> test VIDIOC_QUERYCAP: OK
> test invalid ioctls: OK
>
> Allow for multiple opens:
> test second /dev/video1 open: OK
> test VIDIOC_QUERYCAP: OK
> test VIDIOC_G/S_PRIORITY: OK
> test for unlimited opens: OK
>
> Debug ioctls:
> test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
> test VIDIOC_LOG_STATUS: OK (Not Supported)
>
> Input ioctls:
> test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
> test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
> test VIDIOC_ENUMAUDIO: OK (Not Supported)
> test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
> test VIDIOC_G/S_AUDIO: OK (Not Supported)
> Inputs: 0 Audio Inputs: 0 Tuners: 0
>
> Output ioctls:
> test VIDIOC_G/S_MODULATOR: OK (Not Supported)
> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
> test VIDIOC_ENUMAUDOUT: OK (Not Supported)
> test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
> test VIDIOC_G/S_AUDOUT: OK (Not Supported)
> Outputs: 0 Audio Outputs: 0 Modulators: 0
>
> Input/Output configuration ioctls:
> test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
> test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
> test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
> test VIDIOC_G/S_EDID: OK (Not Supported)
>
> Control ioctls:
> test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
> test VIDIOC_QUERYCTRL: OK
> test VIDIOC_G/S_CTRL: OK
> test VIDIOC_G/S/TRY_EXT_CTRLS: OK
> test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
> test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
> Standard Controls: 43 Private Controls: 0
>
> Format ioctls:
> test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
> test VIDIOC_G/S_PARM: OK
> test VIDIOC_G_FBUF: OK (Not Supported)
> test VIDIOC_G_FMT: OK
> test VIDIOC_TRY_FMT: OK
> test VIDIOC_S_FMT: OK
> test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
> test Cropping: OK
> test Composing: OK (Not Supported)
> test Scaling: OK (Not Supported)
>
> Codec ioctls:
> test VIDIOC_(TRY_)ENCODER_CMD: OK
> test VIDIOC_G_ENC_INDEX: OK (Not Supported)
> test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
>
> Buffer ioctls:
> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
> test CREATE_BUFS maximum buffers: OK
> test VIDIOC_REMOVE_BUFS: OK
> test VIDIOC_EXPBUF: OK
> test Requests: OK (Not Supported)
> test blocking wait: OK
>
> Test input 0:
>
> Streaming ioctls:
> test read/write: OK (Not Supported)
> Video Capture Multiplanar: Captured 61 buffers
> test MMAP (select, REQBUFS): OK
> Video Capture Multiplanar: Captured 61 buffers
> test MMAP (epoll, REQBUFS): OK
> Video Capture Multiplanar: Captured 61 buffers
> test MMAP (select, CREATE_BUFS): OK
> Video Capture Multiplanar: Captured 61 buffers
> test MMAP (epoll, CREATE_BUFS): OK
> test USERPTR (select): OK (Not Supported)
> test DMABUF: Cannot test, specify --expbuf-device
>
> Total for iris_driver device /dev/video1: 54, Succeeded: 54, Failed: 0, Warnings: 0
>
> $ v4l2-compliance -d /dev/video0 -s5 --stream-from=test_video_10s.h264
> v4l2-compliance 1.33.0-5456, 64 bits, 64-bit time_t
> v4l2-compliance SHA: 8aa593bda182 2026-04-11 10:54:25
>
> Compliance test for iris_driver device /dev/video0:
>
> Driver Info:
> Driver name : iris_driver
> Card type : Iris Decoder
> Bus info : platform:aa00000.video-codec
> Driver version : 7.0.0
> Capabilities : 0x84204000
> Video Memory-to-Memory Multiplanar
> Streaming
> Extended Pix Format
> Device Capabilities
> Device Caps : 0x04204000
> Video Memory-to-Memory Multiplanar
> Streaming
> Extended Pix Format
> Detected Stateful Decoder
>
> Required ioctls:
> test VIDIOC_QUERYCAP: OK
> test invalid ioctls: OK
>
> Allow for multiple opens:
> test second /dev/video0 open: OK
> test VIDIOC_QUERYCAP: OK
> test VIDIOC_G/S_PRIORITY: OK
> test for unlimited opens: OK
>
> Debug ioctls:
> test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
> test VIDIOC_LOG_STATUS: OK (Not Supported)
>
> Input ioctls:
> test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
> test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
> test VIDIOC_ENUMAUDIO: OK (Not Supported)
> test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
> test VIDIOC_G/S_AUDIO: OK (Not Supported)
> Inputs: 0 Audio Inputs: 0 Tuners: 0
>
> Output ioctls:
> test VIDIOC_G/S_MODULATOR: OK (Not Supported)
> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
> test VIDIOC_ENUMAUDOUT: OK (Not Supported)
> test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
> test VIDIOC_G/S_AUDOUT: OK (Not Supported)
> Outputs: 0 Audio Outputs: 0 Modulators: 0
>
> Input/Output configuration ioctls:
> test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
> test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
> test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
> test VIDIOC_G/S_EDID: OK (Not Supported)
>
> Control ioctls:
> test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
> test VIDIOC_QUERYCTRL: OK
> test VIDIOC_G/S_CTRL: OK
> test VIDIOC_G/S/TRY_EXT_CTRLS: OK
> test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
> test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
> Standard Controls: 12 Private Controls: 0
>
> Format ioctls:
> test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
> test VIDIOC_G/S_PARM: OK (Not Supported)
> test VIDIOC_G_FBUF: OK (Not Supported)
> test VIDIOC_G_FMT: OK
> test VIDIOC_TRY_FMT: OK
> test VIDIOC_S_FMT: OK
> test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
> test Cropping: OK
> test Composing: OK
> test Scaling: OK (Not Supported)
>
> Codec ioctls:
> test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
> test VIDIOC_G_ENC_INDEX: OK (Not Supported)
> test VIDIOC_(TRY_)DECODER_CMD: OK
>
> Buffer ioctls:
> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
> test CREATE_BUFS maximum buffers: OK
> test VIDIOC_REMOVE_BUFS: OK
> test VIDIOC_EXPBUF: OK
> test Requests: OK (Not Supported)
> test blocking wait: OK
>
> Test input 0:
>
> Streaming ioctls:
> test read/write: OK (Not Supported)
> the input file is smaller than 7077888 bytes
> Video Capture Multiplanar: Captured 601 buffers
> test MMAP (select, REQBUFS): OK
> the input file is smaller than 7077888 bytes
> Video Capture Multiplanar: Captured 601 buffers
> test MMAP (epoll, REQBUFS): OK
> the input file is smaller than 7077888 bytes
> Video Capture Multiplanar: Captured 601 buffers
> test MMAP (select, CREATE_BUFS): OK
> the input file is smaller than 7077888 bytes
> Video Capture Multiplanar: Captured 601 buffers
> test MMAP (epoll, CREATE_BUFS): OK
> test USERPTR (select): OK (Not Supported)
> test DMABUF: Cannot test, specify --expbuf-device
>
> Total for iris_driver device /dev/video0: 54, Succeeded: 54, Failed: 0, Warnings: 0
>
> [1] https://github.com/superna9999/pyv4l2compliance
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Changes in v3:
> - Added review tag on patch 1
> - Limited stride command to AV1 decoding only
> - Link to v2: https://patch.msgid.link/20260417-topic-sm8x50-iris-10bit-decoding-v2-0-c987b65a31d5@linaro.org
>
> Changes in v2:
> - Fixed bug breaking 8bit decoding
> - Dropped filtering on G_FMT while waiting for soure change
> - Dropped format filtering on ENUMFMT
> - Switched ALIGN(x, 192) to roundup(x, 192) because ALIGN works only with Power Of Two numbers
> - Cleaned and refactors the width/height/stride calculations
> - Cleaned and redesigned the buffer calculations functions with proper comments and var names
> - Passed fluster and v4l2-compliance to check for non regression
> - Tested on SM8550
> - Added missing V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10 with made gstreamer fail decoding
> - Link to v1: https://patch.msgid.link/20260408-topic-sm8x50-iris-10bit-decoding-v1-0-428c1ec2e3f3@linaro.org
>
> ---
> Neil Armstrong (6):
> media: qcom: iris: add helpers for 8bit and 10bit formats
> media: qcom: iris: add QC10C & P010 buffer size calculations
> media: qcom: iris: gen2: add support for 10bit decoding
> media: qcom: iris: vdec: update size and stride calculations for 10bit formats
> media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats
> media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
>
> drivers/media/platform/qcom/iris/iris_buffer.c | 195 ++++++++++++++++++++-
> .../platform/qcom/iris/iris_hfi_gen2_command.c | 75 +++++++-
> .../platform/qcom/iris/iris_hfi_gen2_defines.h | 1 +
> .../platform/qcom/iris/iris_hfi_gen2_response.c | 37 +++-
> drivers/media/platform/qcom/iris/iris_instance.h | 2 +
> .../platform/qcom/iris/iris_platform_common.h | 1 +
> .../media/platform/qcom/iris/iris_platform_gen2.c | 8 +-
> drivers/media/platform/qcom/iris/iris_utils.c | 16 +-
> drivers/media/platform/qcom/iris/iris_utils.h | 2 +
> drivers/media/platform/qcom/iris/iris_vdec.c | 42 ++++-
> 10 files changed, 364 insertions(+), 15 deletions(-)
> ---
> base-commit: 76671814f2843482d97feca12e95c06f0b05bc8a
> change-id: 20260408-topic-sm8x50-iris-10bit-decoding-074c3ac7975c
>
> Best regards,
> --
> Neil Armstrong <neil.armstrong@linaro.org>
>
>
--
Best Regards,
Wangao
[-- Attachment #2: screenshot 2026-05-13 111131.png --]
[-- Type: image/png, Size: 1263431 bytes --]
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats
2026-05-13 8:50 ` [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats Wangao Wang
@ 2026-05-13 12:11 ` Neil Armstrong
2026-05-13 16:02 ` Neil Armstrong
0 siblings, 1 reply; 49+ messages in thread
From: Neil Armstrong @ 2026-05-13 12:11 UTC (permalink / raw)
To: Wangao Wang, Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
Hi,
On 5/13/26 10:50, Wangao Wang wrote:
> I did testing on Purwa and found that the decoded raw data only has one frame, and there is also an alignment issue. Screenshots are in the attachment.
> I used the command you provided to generate the HDR H.265 stream, and tested with the same v4l2-ctrl command. Is there anything in the testing details that I might have missed?
Thanks for testing.
The screenshot you sent would imply the UV plane offset has an aligment
and is not directly after the Y plane as expected.
Let me check on my side, because I was able to successfully import
and display via GL, Vulkan and DRM on SM8550 and SM8650.
Neil
>
> On 2026/5/11 17:20, Neil Armstrong wrote:
>> This adds the plumbing to support decoding HEVC, VP9 and AV1
>> streams into 10bit pixel formats, linear and compressed.
>>
>> This has only been tested on SM8550 & SM8650 with HEVC, and was
>> inspired by Venus, DRM MSM and the downstream vidc driver for the
>> buffer calculations and HFI messages.
>>
>> I was unable to get 10bit decoding working with ffmpeg since P010
>> support for v4l2 decoding is missing, but v4l2-ctl works with:
>> v4l2-ctl --verbose --set-fmt-video-out=pixelformat=HEVC --set-fmt-video=pixelformat=P010 --stream-mmap --stream-out-mmap --stream-from-hdr Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr --stream-to out.P010
>> v4l2-ctl --verbose --set-fmt-video-out=pixelformat=HEVC --set-fmt-video=pixelformat=Q10C --stream-mmap --stream-out-mmap --stream-from-hdr Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr --stream-to out.QC10
>>
>> The non-10bit decoding still works as before.
>>
>> With Big_Buck_Bunny_1080_10s_30MB reencoded in 10-bit profile
>> and tranformed in v4l2 header format with [1]:
>> ffmpeg -i Big_Buck_Bunny_1080_10s_30MB.h264 -pix_fmt yuv420p10le -c:v libx265 -crf 28 -x265-params profile=main10 Big_Buck_Bunny_1080_10s_30MB_main10.h265
>> /path/to/mkhdr.sh Big_Buck_Bunny_1080_10s_30MB_main10.h265 raw Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr
>>
>> Fluster HEVC results on SM8650:
>>
>> ./fluster.py run -ts JCT-VC-HEVC_V1 -d GStreamer-H.265-V4L2-Gst1.0 - 131/147
>> The failing test case:
>> - Pixel Format mismatch
>> - TSUNEQBD_A_MAIN10_Technicolor_2 - Gstreamer waits NV12 but decoder returns P010
>> - Unsupported resolution
>> - PICSIZE_A_Bossen_1 - resolution is higher than max supported
>> - PICSIZE_B_Bossen_1 - resolution is higher than max supported
>> - WPP_D_ericsson_MAIN_2 - resolution is lower than min supported
>> - WPP_D_ericsson_MAIN10_2 - resolution is lower than min supported
>> - CRC mismatch
>> - RAP_A_docomo_6
>> - CRC mismatch - bitstream issue - fails with ffmpeg sw decoder as well
>> - VPSSPSPPS_A_MainConcept_1
>>
>> v4l2-compliance results on SM8550 & SM8650:
>>
>> $ v4l2-compliance -d /dev/video1 -s
>> v4l2-compliance 1.33.0-5456, 64 bits, 64-bit time_t
>> v4l2-compliance SHA: 8aa593bda182 2026-04-11 10:54:25
>>
>> Compliance test for iris_driver device /dev/video1:
>>
>> Driver Info:
>> Driver name : iris_driver
>> Card type : Iris Encoder
>> Bus info : platform:aa00000.video-codec
>> Driver version : 7.0.0
>> Capabilities : 0x84204000
>> Video Memory-to-Memory Multiplanar
>> Streaming
>> Extended Pix Format
>> Device Capabilities
>> Device Caps : 0x04204000
>> Video Memory-to-Memory Multiplanar
>> Streaming
>> Extended Pix Format
>> Detected Stateful Encoder
>>
>> Required ioctls:
>> test VIDIOC_QUERYCAP: OK
>> test invalid ioctls: OK
>>
>> Allow for multiple opens:
>> test second /dev/video1 open: OK
>> test VIDIOC_QUERYCAP: OK
>> test VIDIOC_G/S_PRIORITY: OK
>> test for unlimited opens: OK
>>
>> Debug ioctls:
>> test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
>> test VIDIOC_LOG_STATUS: OK (Not Supported)
>>
>> Input ioctls:
>> test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
>> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>> test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
>> test VIDIOC_ENUMAUDIO: OK (Not Supported)
>> test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
>> test VIDIOC_G/S_AUDIO: OK (Not Supported)
>> Inputs: 0 Audio Inputs: 0 Tuners: 0
>>
>> Output ioctls:
>> test VIDIOC_G/S_MODULATOR: OK (Not Supported)
>> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>> test VIDIOC_ENUMAUDOUT: OK (Not Supported)
>> test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
>> test VIDIOC_G/S_AUDOUT: OK (Not Supported)
>> Outputs: 0 Audio Outputs: 0 Modulators: 0
>>
>> Input/Output configuration ioctls:
>> test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
>> test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
>> test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
>> test VIDIOC_G/S_EDID: OK (Not Supported)
>>
>> Control ioctls:
>> test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
>> test VIDIOC_QUERYCTRL: OK
>> test VIDIOC_G/S_CTRL: OK
>> test VIDIOC_G/S/TRY_EXT_CTRLS: OK
>> test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
>> test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
>> Standard Controls: 43 Private Controls: 0
>>
>> Format ioctls:
>> test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
>> test VIDIOC_G/S_PARM: OK
>> test VIDIOC_G_FBUF: OK (Not Supported)
>> test VIDIOC_G_FMT: OK
>> test VIDIOC_TRY_FMT: OK
>> test VIDIOC_S_FMT: OK
>> test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
>> test Cropping: OK
>> test Composing: OK (Not Supported)
>> test Scaling: OK (Not Supported)
>>
>> Codec ioctls:
>> test VIDIOC_(TRY_)ENCODER_CMD: OK
>> test VIDIOC_G_ENC_INDEX: OK (Not Supported)
>> test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
>>
>> Buffer ioctls:
>> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
>> test CREATE_BUFS maximum buffers: OK
>> test VIDIOC_REMOVE_BUFS: OK
>> test VIDIOC_EXPBUF: OK
>> test Requests: OK (Not Supported)
>> test blocking wait: OK
>>
>> Test input 0:
>>
>> Streaming ioctls:
>> test read/write: OK (Not Supported)
>> Video Capture Multiplanar: Captured 61 buffers
>> test MMAP (select, REQBUFS): OK
>> Video Capture Multiplanar: Captured 61 buffers
>> test MMAP (epoll, REQBUFS): OK
>> Video Capture Multiplanar: Captured 61 buffers
>> test MMAP (select, CREATE_BUFS): OK
>> Video Capture Multiplanar: Captured 61 buffers
>> test MMAP (epoll, CREATE_BUFS): OK
>> test USERPTR (select): OK (Not Supported)
>> test DMABUF: Cannot test, specify --expbuf-device
>>
>> Total for iris_driver device /dev/video1: 54, Succeeded: 54, Failed: 0, Warnings: 0
>>
>> $ v4l2-compliance -d /dev/video0 -s5 --stream-from=test_video_10s.h264
>> v4l2-compliance 1.33.0-5456, 64 bits, 64-bit time_t
>> v4l2-compliance SHA: 8aa593bda182 2026-04-11 10:54:25
>>
>> Compliance test for iris_driver device /dev/video0:
>>
>> Driver Info:
>> Driver name : iris_driver
>> Card type : Iris Decoder
>> Bus info : platform:aa00000.video-codec
>> Driver version : 7.0.0
>> Capabilities : 0x84204000
>> Video Memory-to-Memory Multiplanar
>> Streaming
>> Extended Pix Format
>> Device Capabilities
>> Device Caps : 0x04204000
>> Video Memory-to-Memory Multiplanar
>> Streaming
>> Extended Pix Format
>> Detected Stateful Decoder
>>
>> Required ioctls:
>> test VIDIOC_QUERYCAP: OK
>> test invalid ioctls: OK
>>
>> Allow for multiple opens:
>> test second /dev/video0 open: OK
>> test VIDIOC_QUERYCAP: OK
>> test VIDIOC_G/S_PRIORITY: OK
>> test for unlimited opens: OK
>>
>> Debug ioctls:
>> test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
>> test VIDIOC_LOG_STATUS: OK (Not Supported)
>>
>> Input ioctls:
>> test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
>> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>> test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
>> test VIDIOC_ENUMAUDIO: OK (Not Supported)
>> test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
>> test VIDIOC_G/S_AUDIO: OK (Not Supported)
>> Inputs: 0 Audio Inputs: 0 Tuners: 0
>>
>> Output ioctls:
>> test VIDIOC_G/S_MODULATOR: OK (Not Supported)
>> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>> test VIDIOC_ENUMAUDOUT: OK (Not Supported)
>> test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
>> test VIDIOC_G/S_AUDOUT: OK (Not Supported)
>> Outputs: 0 Audio Outputs: 0 Modulators: 0
>>
>> Input/Output configuration ioctls:
>> test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
>> test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
>> test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
>> test VIDIOC_G/S_EDID: OK (Not Supported)
>>
>> Control ioctls:
>> test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
>> test VIDIOC_QUERYCTRL: OK
>> test VIDIOC_G/S_CTRL: OK
>> test VIDIOC_G/S/TRY_EXT_CTRLS: OK
>> test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
>> test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
>> Standard Controls: 12 Private Controls: 0
>>
>> Format ioctls:
>> test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
>> test VIDIOC_G/S_PARM: OK (Not Supported)
>> test VIDIOC_G_FBUF: OK (Not Supported)
>> test VIDIOC_G_FMT: OK
>> test VIDIOC_TRY_FMT: OK
>> test VIDIOC_S_FMT: OK
>> test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
>> test Cropping: OK
>> test Composing: OK
>> test Scaling: OK (Not Supported)
>>
>> Codec ioctls:
>> test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
>> test VIDIOC_G_ENC_INDEX: OK (Not Supported)
>> test VIDIOC_(TRY_)DECODER_CMD: OK
>>
>> Buffer ioctls:
>> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
>> test CREATE_BUFS maximum buffers: OK
>> test VIDIOC_REMOVE_BUFS: OK
>> test VIDIOC_EXPBUF: OK
>> test Requests: OK (Not Supported)
>> test blocking wait: OK
>>
>> Test input 0:
>>
>> Streaming ioctls:
>> test read/write: OK (Not Supported)
>> the input file is smaller than 7077888 bytes
>> Video Capture Multiplanar: Captured 601 buffers
>> test MMAP (select, REQBUFS): OK
>> the input file is smaller than 7077888 bytes
>> Video Capture Multiplanar: Captured 601 buffers
>> test MMAP (epoll, REQBUFS): OK
>> the input file is smaller than 7077888 bytes
>> Video Capture Multiplanar: Captured 601 buffers
>> test MMAP (select, CREATE_BUFS): OK
>> the input file is smaller than 7077888 bytes
>> Video Capture Multiplanar: Captured 601 buffers
>> test MMAP (epoll, CREATE_BUFS): OK
>> test USERPTR (select): OK (Not Supported)
>> test DMABUF: Cannot test, specify --expbuf-device
>>
>> Total for iris_driver device /dev/video0: 54, Succeeded: 54, Failed: 0, Warnings: 0
>>
>> [1] https://github.com/superna9999/pyv4l2compliance
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> Changes in v3:
>> - Added review tag on patch 1
>> - Limited stride command to AV1 decoding only
>> - Link to v2: https://patch.msgid.link/20260417-topic-sm8x50-iris-10bit-decoding-v2-0-c987b65a31d5@linaro.org
>>
>> Changes in v2:
>> - Fixed bug breaking 8bit decoding
>> - Dropped filtering on G_FMT while waiting for soure change
>> - Dropped format filtering on ENUMFMT
>> - Switched ALIGN(x, 192) to roundup(x, 192) because ALIGN works only with Power Of Two numbers
>> - Cleaned and refactors the width/height/stride calculations
>> - Cleaned and redesigned the buffer calculations functions with proper comments and var names
>> - Passed fluster and v4l2-compliance to check for non regression
>> - Tested on SM8550
>> - Added missing V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10 with made gstreamer fail decoding
>> - Link to v1: https://patch.msgid.link/20260408-topic-sm8x50-iris-10bit-decoding-v1-0-428c1ec2e3f3@linaro.org
>>
>> ---
>> Neil Armstrong (6):
>> media: qcom: iris: add helpers for 8bit and 10bit formats
>> media: qcom: iris: add QC10C & P010 buffer size calculations
>> media: qcom: iris: gen2: add support for 10bit decoding
>> media: qcom: iris: vdec: update size and stride calculations for 10bit formats
>> media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats
>> media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
>>
>> drivers/media/platform/qcom/iris/iris_buffer.c | 195 ++++++++++++++++++++-
>> .../platform/qcom/iris/iris_hfi_gen2_command.c | 75 +++++++-
>> .../platform/qcom/iris/iris_hfi_gen2_defines.h | 1 +
>> .../platform/qcom/iris/iris_hfi_gen2_response.c | 37 +++-
>> drivers/media/platform/qcom/iris/iris_instance.h | 2 +
>> .../platform/qcom/iris/iris_platform_common.h | 1 +
>> .../media/platform/qcom/iris/iris_platform_gen2.c | 8 +-
>> drivers/media/platform/qcom/iris/iris_utils.c | 16 +-
>> drivers/media/platform/qcom/iris/iris_utils.h | 2 +
>> drivers/media/platform/qcom/iris/iris_vdec.c | 42 ++++-
>> 10 files changed, 364 insertions(+), 15 deletions(-)
>> ---
>> base-commit: 76671814f2843482d97feca12e95c06f0b05bc8a
>> change-id: 20260408-topic-sm8x50-iris-10bit-decoding-074c3ac7975c
>>
>> Best regards,
>> --
>> Neil Armstrong <neil.armstrong@linaro.org>
>>
>>
>
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats
2026-05-13 12:11 ` Neil Armstrong
@ 2026-05-13 16:02 ` Neil Armstrong
2026-05-13 16:04 ` Dmitry Baryshkov
0 siblings, 1 reply; 49+ messages in thread
From: Neil Armstrong @ 2026-05-13 16:02 UTC (permalink / raw)
To: Wangao Wang, Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/13/26 14:11, Neil Armstrong wrote:
> Hi,
>
> On 5/13/26 10:50, Wangao Wang wrote:
>> I did testing on Purwa and found that the decoded raw data only has one frame, and there is also an alignment issue. Screenshots are in the attachment.
>> I used the command you provided to generate the HDR H.265 stream, and tested with the same v4l2-ctrl command. Is there anything in the testing details that I might have missed?
>
> Thanks for testing.
>
> The screenshot you sent would imply the UV plane offset has an aligment
> and is not directly after the Y plane as expected.
>
> Let me check on my side, because I was able to successfully import
> and display via GL, Vulkan and DRM on SM8550 and SM8650.
v4l2-ctl doesn't properly handle the events, could you try dumping with gstreamer instead ?
gst-launch-1.0 -v -m filesrc location=Big_Buck_Bunny_1080_10s_30MB_main10.h265 ! h265parse ! v4l2h265dec ! filesink location=out.yuv
The dump I have is good, the UV plane is right after the Y plane.
and also try to pass fluster:
fluster download -c h.265
fluster run -d GStreamer-H.265-V4L2 -ts JCT-VC-HEVC_V1 -q -s -j1
You should have 9/11 main10 streams passing.
Neil
>
> Neil
>
>>
>> On 2026/5/11 17:20, Neil Armstrong wrote:
>>> This adds the plumbing to support decoding HEVC, VP9 and AV1
>>> streams into 10bit pixel formats, linear and compressed.
>>>
>>> This has only been tested on SM8550 & SM8650 with HEVC, and was
>>> inspired by Venus, DRM MSM and the downstream vidc driver for the
>>> buffer calculations and HFI messages.
>>>
>>> I was unable to get 10bit decoding working with ffmpeg since P010
>>> support for v4l2 decoding is missing, but v4l2-ctl works with:
>>> v4l2-ctl --verbose --set-fmt-video-out=pixelformat=HEVC --set-fmt-video=pixelformat=P010 --stream-mmap --stream-out-mmap --stream-from-hdr Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr --stream-to out.P010
>>> v4l2-ctl --verbose --set-fmt-video-out=pixelformat=HEVC --set-fmt-video=pixelformat=Q10C --stream-mmap --stream-out-mmap --stream-from-hdr Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr --stream-to out.QC10
>>>
>>> The non-10bit decoding still works as before.
>>>
>>> With Big_Buck_Bunny_1080_10s_30MB reencoded in 10-bit profile
>>> and tranformed in v4l2 header format with [1]:
>>> ffmpeg -i Big_Buck_Bunny_1080_10s_30MB.h264 -pix_fmt yuv420p10le -c:v libx265 -crf 28 -x265-params profile=main10 Big_Buck_Bunny_1080_10s_30MB_main10.h265
>>> /path/to/mkhdr.sh Big_Buck_Bunny_1080_10s_30MB_main10.h265 raw Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr
>>>
>>> Fluster HEVC results on SM8650:
>>>
>>> ./fluster.py run -ts JCT-VC-HEVC_V1 -d GStreamer-H.265-V4L2-Gst1.0 - 131/147
>>> The failing test case:
>>> - Pixel Format mismatch
>>> - TSUNEQBD_A_MAIN10_Technicolor_2 - Gstreamer waits NV12 but decoder returns P010
>>> - Unsupported resolution
>>> - PICSIZE_A_Bossen_1 - resolution is higher than max supported
>>> - PICSIZE_B_Bossen_1 - resolution is higher than max supported
>>> - WPP_D_ericsson_MAIN_2 - resolution is lower than min supported
>>> - WPP_D_ericsson_MAIN10_2 - resolution is lower than min supported
>>> - CRC mismatch
>>> - RAP_A_docomo_6
>>> - CRC mismatch - bitstream issue - fails with ffmpeg sw decoder as well
>>> - VPSSPSPPS_A_MainConcept_1
>>>
>>> v4l2-compliance results on SM8550 & SM8650:
>>>
>>> $ v4l2-compliance -d /dev/video1 -s
>>> v4l2-compliance 1.33.0-5456, 64 bits, 64-bit time_t
>>> v4l2-compliance SHA: 8aa593bda182 2026-04-11 10:54:25
>>>
>>> Compliance test for iris_driver device /dev/video1:
>>>
>>> Driver Info:
>>> Driver name : iris_driver
>>> Card type : Iris Encoder
>>> Bus info : platform:aa00000.video-codec
>>> Driver version : 7.0.0
>>> Capabilities : 0x84204000
>>> Video Memory-to-Memory Multiplanar
>>> Streaming
>>> Extended Pix Format
>>> Device Capabilities
>>> Device Caps : 0x04204000
>>> Video Memory-to-Memory Multiplanar
>>> Streaming
>>> Extended Pix Format
>>> Detected Stateful Encoder
>>>
>>> Required ioctls:
>>> test VIDIOC_QUERYCAP: OK
>>> test invalid ioctls: OK
>>>
>>> Allow for multiple opens:
>>> test second /dev/video1 open: OK
>>> test VIDIOC_QUERYCAP: OK
>>> test VIDIOC_G/S_PRIORITY: OK
>>> test for unlimited opens: OK
>>>
>>> Debug ioctls:
>>> test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
>>> test VIDIOC_LOG_STATUS: OK (Not Supported)
>>>
>>> Input ioctls:
>>> test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
>>> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>>> test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
>>> test VIDIOC_ENUMAUDIO: OK (Not Supported)
>>> test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
>>> test VIDIOC_G/S_AUDIO: OK (Not Supported)
>>> Inputs: 0 Audio Inputs: 0 Tuners: 0
>>>
>>> Output ioctls:
>>> test VIDIOC_G/S_MODULATOR: OK (Not Supported)
>>> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>>> test VIDIOC_ENUMAUDOUT: OK (Not Supported)
>>> test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
>>> test VIDIOC_G/S_AUDOUT: OK (Not Supported)
>>> Outputs: 0 Audio Outputs: 0 Modulators: 0
>>>
>>> Input/Output configuration ioctls:
>>> test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
>>> test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
>>> test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
>>> test VIDIOC_G/S_EDID: OK (Not Supported)
>>>
>>> Control ioctls:
>>> test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
>>> test VIDIOC_QUERYCTRL: OK
>>> test VIDIOC_G/S_CTRL: OK
>>> test VIDIOC_G/S/TRY_EXT_CTRLS: OK
>>> test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
>>> test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
>>> Standard Controls: 43 Private Controls: 0
>>>
>>> Format ioctls:
>>> test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
>>> test VIDIOC_G/S_PARM: OK
>>> test VIDIOC_G_FBUF: OK (Not Supported)
>>> test VIDIOC_G_FMT: OK
>>> test VIDIOC_TRY_FMT: OK
>>> test VIDIOC_S_FMT: OK
>>> test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
>>> test Cropping: OK
>>> test Composing: OK (Not Supported)
>>> test Scaling: OK (Not Supported)
>>>
>>> Codec ioctls:
>>> test VIDIOC_(TRY_)ENCODER_CMD: OK
>>> test VIDIOC_G_ENC_INDEX: OK (Not Supported)
>>> test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
>>>
>>> Buffer ioctls:
>>> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
>>> test CREATE_BUFS maximum buffers: OK
>>> test VIDIOC_REMOVE_BUFS: OK
>>> test VIDIOC_EXPBUF: OK
>>> test Requests: OK (Not Supported)
>>> test blocking wait: OK
>>>
>>> Test input 0:
>>>
>>> Streaming ioctls:
>>> test read/write: OK (Not Supported)
>>> Video Capture Multiplanar: Captured 61 buffers
>>> test MMAP (select, REQBUFS): OK
>>> Video Capture Multiplanar: Captured 61 buffers
>>> test MMAP (epoll, REQBUFS): OK
>>> Video Capture Multiplanar: Captured 61 buffers
>>> test MMAP (select, CREATE_BUFS): OK
>>> Video Capture Multiplanar: Captured 61 buffers
>>> test MMAP (epoll, CREATE_BUFS): OK
>>> test USERPTR (select): OK (Not Supported)
>>> test DMABUF: Cannot test, specify --expbuf-device
>>>
>>> Total for iris_driver device /dev/video1: 54, Succeeded: 54, Failed: 0, Warnings: 0
>>>
>>> $ v4l2-compliance -d /dev/video0 -s5 --stream-from=test_video_10s.h264
>>> v4l2-compliance 1.33.0-5456, 64 bits, 64-bit time_t
>>> v4l2-compliance SHA: 8aa593bda182 2026-04-11 10:54:25
>>>
>>> Compliance test for iris_driver device /dev/video0:
>>>
>>> Driver Info:
>>> Driver name : iris_driver
>>> Card type : Iris Decoder
>>> Bus info : platform:aa00000.video-codec
>>> Driver version : 7.0.0
>>> Capabilities : 0x84204000
>>> Video Memory-to-Memory Multiplanar
>>> Streaming
>>> Extended Pix Format
>>> Device Capabilities
>>> Device Caps : 0x04204000
>>> Video Memory-to-Memory Multiplanar
>>> Streaming
>>> Extended Pix Format
>>> Detected Stateful Decoder
>>>
>>> Required ioctls:
>>> test VIDIOC_QUERYCAP: OK
>>> test invalid ioctls: OK
>>>
>>> Allow for multiple opens:
>>> test second /dev/video0 open: OK
>>> test VIDIOC_QUERYCAP: OK
>>> test VIDIOC_G/S_PRIORITY: OK
>>> test for unlimited opens: OK
>>>
>>> Debug ioctls:
>>> test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
>>> test VIDIOC_LOG_STATUS: OK (Not Supported)
>>>
>>> Input ioctls:
>>> test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
>>> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>>> test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
>>> test VIDIOC_ENUMAUDIO: OK (Not Supported)
>>> test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
>>> test VIDIOC_G/S_AUDIO: OK (Not Supported)
>>> Inputs: 0 Audio Inputs: 0 Tuners: 0
>>>
>>> Output ioctls:
>>> test VIDIOC_G/S_MODULATOR: OK (Not Supported)
>>> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>>> test VIDIOC_ENUMAUDOUT: OK (Not Supported)
>>> test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
>>> test VIDIOC_G/S_AUDOUT: OK (Not Supported)
>>> Outputs: 0 Audio Outputs: 0 Modulators: 0
>>>
>>> Input/Output configuration ioctls:
>>> test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
>>> test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
>>> test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
>>> test VIDIOC_G/S_EDID: OK (Not Supported)
>>>
>>> Control ioctls:
>>> test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
>>> test VIDIOC_QUERYCTRL: OK
>>> test VIDIOC_G/S_CTRL: OK
>>> test VIDIOC_G/S/TRY_EXT_CTRLS: OK
>>> test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
>>> test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
>>> Standard Controls: 12 Private Controls: 0
>>>
>>> Format ioctls:
>>> test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
>>> test VIDIOC_G/S_PARM: OK (Not Supported)
>>> test VIDIOC_G_FBUF: OK (Not Supported)
>>> test VIDIOC_G_FMT: OK
>>> test VIDIOC_TRY_FMT: OK
>>> test VIDIOC_S_FMT: OK
>>> test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
>>> test Cropping: OK
>>> test Composing: OK
>>> test Scaling: OK (Not Supported)
>>>
>>> Codec ioctls:
>>> test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
>>> test VIDIOC_G_ENC_INDEX: OK (Not Supported)
>>> test VIDIOC_(TRY_)DECODER_CMD: OK
>>>
>>> Buffer ioctls:
>>> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
>>> test CREATE_BUFS maximum buffers: OK
>>> test VIDIOC_REMOVE_BUFS: OK
>>> test VIDIOC_EXPBUF: OK
>>> test Requests: OK (Not Supported)
>>> test blocking wait: OK
>>>
>>> Test input 0:
>>>
>>> Streaming ioctls:
>>> test read/write: OK (Not Supported)
>>> the input file is smaller than 7077888 bytes
>>> Video Capture Multiplanar: Captured 601 buffers
>>> test MMAP (select, REQBUFS): OK
>>> the input file is smaller than 7077888 bytes
>>> Video Capture Multiplanar: Captured 601 buffers
>>> test MMAP (epoll, REQBUFS): OK
>>> the input file is smaller than 7077888 bytes
>>> Video Capture Multiplanar: Captured 601 buffers
>>> test MMAP (select, CREATE_BUFS): OK
>>> the input file is smaller than 7077888 bytes
>>> Video Capture Multiplanar: Captured 601 buffers
>>> test MMAP (epoll, CREATE_BUFS): OK
>>> test USERPTR (select): OK (Not Supported)
>>> test DMABUF: Cannot test, specify --expbuf-device
>>>
>>> Total for iris_driver device /dev/video0: 54, Succeeded: 54, Failed: 0, Warnings: 0
>>>
>>> [1] https://github.com/superna9999/pyv4l2compliance
>>>
>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>> ---
>>> Changes in v3:
>>> - Added review tag on patch 1
>>> - Limited stride command to AV1 decoding only
>>> - Link to v2: https://patch.msgid.link/20260417-topic-sm8x50-iris-10bit-decoding-v2-0-c987b65a31d5@linaro.org
>>>
>>> Changes in v2:
>>> - Fixed bug breaking 8bit decoding
>>> - Dropped filtering on G_FMT while waiting for soure change
>>> - Dropped format filtering on ENUMFMT
>>> - Switched ALIGN(x, 192) to roundup(x, 192) because ALIGN works only with Power Of Two numbers
>>> - Cleaned and refactors the width/height/stride calculations
>>> - Cleaned and redesigned the buffer calculations functions with proper comments and var names
>>> - Passed fluster and v4l2-compliance to check for non regression
>>> - Tested on SM8550
>>> - Added missing V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10 with made gstreamer fail decoding
>>> - Link to v1: https://patch.msgid.link/20260408-topic-sm8x50-iris-10bit-decoding-v1-0-428c1ec2e3f3@linaro.org
>>>
>>> ---
>>> Neil Armstrong (6):
>>> media: qcom: iris: add helpers for 8bit and 10bit formats
>>> media: qcom: iris: add QC10C & P010 buffer size calculations
>>> media: qcom: iris: gen2: add support for 10bit decoding
>>> media: qcom: iris: vdec: update size and stride calculations for 10bit formats
>>> media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats
>>> media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
>>>
>>> drivers/media/platform/qcom/iris/iris_buffer.c | 195 ++++++++++++++++++++-
>>> .../platform/qcom/iris/iris_hfi_gen2_command.c | 75 +++++++-
>>> .../platform/qcom/iris/iris_hfi_gen2_defines.h | 1 +
>>> .../platform/qcom/iris/iris_hfi_gen2_response.c | 37 +++-
>>> drivers/media/platform/qcom/iris/iris_instance.h | 2 +
>>> .../platform/qcom/iris/iris_platform_common.h | 1 +
>>> .../media/platform/qcom/iris/iris_platform_gen2.c | 8 +-
>>> drivers/media/platform/qcom/iris/iris_utils.c | 16 +-
>>> drivers/media/platform/qcom/iris/iris_utils.h | 2 +
>>> drivers/media/platform/qcom/iris/iris_vdec.c | 42 ++++-
>>> 10 files changed, 364 insertions(+), 15 deletions(-)
>>> ---
>>> base-commit: 76671814f2843482d97feca12e95c06f0b05bc8a
>>> change-id: 20260408-topic-sm8x50-iris-10bit-decoding-074c3ac7975c
>>>
>>> Best regards,
>>> --
>>> Neil Armstrong <neil.armstrong@linaro.org>
>>>
>>>
>>
>
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats
2026-05-13 16:02 ` Neil Armstrong
@ 2026-05-13 16:04 ` Dmitry Baryshkov
0 siblings, 0 replies; 49+ messages in thread
From: Dmitry Baryshkov @ 2026-05-13 16:04 UTC (permalink / raw)
To: Neil Armstrong
Cc: Wangao Wang, Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, linux-media,
linux-arm-msm, linux-kernel
On Wed, May 13, 2026 at 06:02:19PM +0200, Neil Armstrong wrote:
> On 5/13/26 14:11, Neil Armstrong wrote:
> > Hi,
> >
> > On 5/13/26 10:50, Wangao Wang wrote:
> > > I did testing on Purwa and found that the decoded raw data only has one frame, and there is also an alignment issue. Screenshots are in the attachment.
> > > I used the command you provided to generate the HDR H.265 stream, and tested with the same v4l2-ctrl command. Is there anything in the testing details that I might have missed?
> >
> > Thanks for testing.
> >
> > The screenshot you sent would imply the UV plane offset has an aligment
> > and is not directly after the Y plane as expected.
> >
> > Let me check on my side, because I was able to successfully import
> > and display via GL, Vulkan and DRM on SM8550 and SM8650.
>
> v4l2-ctl doesn't properly handle the events, could you try dumping with gstreamer instead ?
>
> gst-launch-1.0 -v -m filesrc location=Big_Buck_Bunny_1080_10s_30MB_main10.h265 ! h265parse ! v4l2h265dec ! filesink location=out.yuv
>
> The dump I have is good, the UV plane is right after the Y plane.
>
> and also try to pass fluster:
> fluster download -c h.265
> fluster run -d GStreamer-H.265-V4L2 -ts JCT-VC-HEVC_V1 -q -s -j1
>
> You should have 9/11 main10 streams passing.
Or it might be an error (or miscommunication) specific to Purwa.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats
2026-05-11 9:20 ` [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats Neil Armstrong
` (6 preceding siblings ...)
2026-05-13 8:50 ` [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats Wangao Wang
@ 2026-05-13 17:33 ` Vikash Garodia
2026-05-18 7:42 ` Neil Armstrong
2026-05-15 9:35 ` Bryan O'Donoghue
8 siblings, 1 reply; 49+ messages in thread
From: Vikash Garodia @ 2026-05-13 17:33 UTC (permalink / raw)
To: Neil Armstrong, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/11/2026 2:50 PM, Neil Armstrong wrote:
> This adds the plumbing to support decoding HEVC, VP9 and AV1
> streams into 10bit pixel formats, linear and compressed.
>
> This has only been tested on SM8550 & SM8650 with HEVC, and was
> inspired by Venus, DRM MSM and the downstream vidc driver for the
> buffer calculations and HFI messages.
>
> I was unable to get 10bit decoding working with ffmpeg since P010
> support for v4l2 decoding is missing, but v4l2-ctl works with:
> v4l2-ctl --verbose --set-fmt-video-out=pixelformat=HEVC --set-fmt-video=pixelformat=P010 --stream-mmap --stream-out-mmap --stream-from-hdr Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr --stream-to out.P010
> v4l2-ctl --verbose --set-fmt-video-out=pixelformat=HEVC --set-fmt-video=pixelformat=Q10C --stream-mmap --stream-out-mmap --stream-from-hdr Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr --stream-to out.QC10
>
> The non-10bit decoding still works as before.
>
> With Big_Buck_Bunny_1080_10s_30MB reencoded in 10-bit profile
> and tranformed in v4l2 header format with [1]:
> ffmpeg -i Big_Buck_Bunny_1080_10s_30MB.h264 -pix_fmt yuv420p10le -c:v libx265 -crf 28 -x265-params profile=main10 Big_Buck_Bunny_1080_10s_30MB_main10.h265
> /path/to/mkhdr.sh Big_Buck_Bunny_1080_10s_30MB_main10.h265 raw Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr
>
> Fluster HEVC results on SM8650:
>
> ./fluster.py run -ts JCT-VC-HEVC_V1 -d GStreamer-H.265-V4L2-Gst1.0 - 131/147
> The failing test case:
> - Pixel Format mismatch
> - TSUNEQBD_A_MAIN10_Technicolor_2 - Gstreamer waits NV12 but decoder returns P010
> - Unsupported resolution
> - PICSIZE_A_Bossen_1 - resolution is higher than max supported
> - PICSIZE_B_Bossen_1 - resolution is higher than max supported
> - WPP_D_ericsson_MAIN_2 - resolution is lower than min supported
> - WPP_D_ericsson_MAIN10_2 - resolution is lower than min supported
> - CRC mismatch
> - RAP_A_docomo_6
> - CRC mismatch - bitstream issue - fails with ffmpeg sw decoder as well
> - VPSSPSPPS_A_MainConcept_1
From earlier SOC reports, 10bit tests which were failing were
- DBLK_A_MAIN10_VIXS_4
- INITQP_B_Main10_Sony_1
- TSUNEQBD_A_MAIN10_Technicolor_2
- WP_A_MAIN10_Toshiba_3
- WP_MAIN10_B_Toshiba_3
- WPP_A_ericsson_MAIN10_2
- WPP_B_ericsson_MAIN10_2
- WPP_C_ericsson_MAIN10_2
- WPP_E_ericsson_MAIN10_2
- WPP_F_ericsson_MAIN10_2
I was in the opinion that once we enable 10bit, these tests would pass.
Though i do not see these in your failing tests, but the count of
131/147 have not improved. Could you check if these tests are passing
and count is better than 131 pass ?
Regards,
Vikash
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats
2026-05-13 17:33 ` Vikash Garodia
@ 2026-05-18 7:42 ` Neil Armstrong
2026-05-20 15:44 ` Vikash Garodia
0 siblings, 1 reply; 49+ messages in thread
From: Neil Armstrong @ 2026-05-18 7:42 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/13/26 19:33, Vikash Garodia wrote:
>
> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>> This adds the plumbing to support decoding HEVC, VP9 and AV1
>> streams into 10bit pixel formats, linear and compressed.
>>
>> This has only been tested on SM8550 & SM8650 with HEVC, and was
>> inspired by Venus, DRM MSM and the downstream vidc driver for the
>> buffer calculations and HFI messages.
>>
>> I was unable to get 10bit decoding working with ffmpeg since P010
>> support for v4l2 decoding is missing, but v4l2-ctl works with:
>> v4l2-ctl --verbose --set-fmt-video-out=pixelformat=HEVC --set-fmt-video=pixelformat=P010 --stream-mmap --stream-out-mmap --stream-from-hdr Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr --stream-to out.P010
>> v4l2-ctl --verbose --set-fmt-video-out=pixelformat=HEVC --set-fmt-video=pixelformat=Q10C --stream-mmap --stream-out-mmap --stream-from-hdr Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr --stream-to out.QC10
>>
>> The non-10bit decoding still works as before.
>>
>> With Big_Buck_Bunny_1080_10s_30MB reencoded in 10-bit profile
>> and tranformed in v4l2 header format with [1]:
>> ffmpeg -i Big_Buck_Bunny_1080_10s_30MB.h264 -pix_fmt yuv420p10le -c:v libx265 -crf 28 -x265-params profile=main10 Big_Buck_Bunny_1080_10s_30MB_main10.h265
>> /path/to/mkhdr.sh Big_Buck_Bunny_1080_10s_30MB_main10.h265 raw Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr
>>
>> Fluster HEVC results on SM8650:
>>
>> ./fluster.py run -ts JCT-VC-HEVC_V1 -d GStreamer-H.265-V4L2-Gst1.0 - 131/147
>> The failing test case:
>> - Pixel Format mismatch
>> - TSUNEQBD_A_MAIN10_Technicolor_2 - Gstreamer waits NV12 but decoder returns P010
>> - Unsupported resolution
>> - PICSIZE_A_Bossen_1 - resolution is higher than max supported
>> - PICSIZE_B_Bossen_1 - resolution is higher than max supported
>> - WPP_D_ericsson_MAIN_2 - resolution is lower than min supported
>> - WPP_D_ericsson_MAIN10_2 - resolution is lower than min supported
>> - CRC mismatch
>> - RAP_A_docomo_6
>> - CRC mismatch - bitstream issue - fails with ffmpeg sw decoder as well
>> - VPSSPSPPS_A_MainConcept_1
>
> From earlier SOC reports, 10bit tests which were failing were
> - DBLK_A_MAIN10_VIXS_4
> - INITQP_B_Main10_Sony_1
> - TSUNEQBD_A_MAIN10_Technicolor_2
> - WP_A_MAIN10_Toshiba_3
> - WP_MAIN10_B_Toshiba_3
> - WPP_A_ericsson_MAIN10_2
> - WPP_B_ericsson_MAIN10_2
> - WPP_C_ericsson_MAIN10_2
> - WPP_E_ericsson_MAIN10_2
> - WPP_F_ericsson_MAIN10_2
>
> I was in the opinion that once we enable 10bit, these tests would pass. Though i do not see these in your failing tests, but the count of 131/147 have not improved. Could you check if these tests are passing and count is better than 131 pass ?
Sorry there's a copy paste error I'll fix on v4, here's the fluster log:
|Test|GStreamer-H.265-V4L2|
|-|-|
|TOTAL|141/147|
|TOTAL TIME|8.600s|
|-|-|
...
|PICSIZE_A_Bossen_1|☠|
|PICSIZE_B_Bossen_1|☠|
...
|RAP_A_docomo_6|❌|
...
|TSUNEQBD_A_MAIN10_Technicolor_2|☠|
...
|WPP_D_ericsson_MAIN10_2|☠|
|WPP_D_ericsson_MAIN_2|☠|
...
|-|-|
|Test|GStreamer-H.265-V4L2|
|TOTAL|140/147|
|TOTAL TIME|8.600s|
|-|-|
|Profile|GStreamer-H.265-V4L2|
|MAIN|131/135|
|MAIN_10|9/11|
|MAIN_STILL_PICTURE|1/1|
So the failing cases:
- Pixel Format mismatch
- TSUNEQBD_A_MAIN10_Technicolor_2 - Gstreamer waits NV12 but decoder returns P010
- Unsupported resolution
- PICSIZE_A_Bossen_1 - resolution is higher than max supported
- PICSIZE_B_Bossen_1 - resolution is higher than max supported
- WPP_D_ericsson_MAIN_2 - resolution is lower than min supported
- WPP_D_ericsson_MAIN10_2 - resolution is lower than min supported
- CRC mismatch
- RAP_A_docomo_6
>
> Regards,
> Vikash
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats
2026-05-18 7:42 ` Neil Armstrong
@ 2026-05-20 15:44 ` Vikash Garodia
2026-05-21 7:24 ` Neil Armstrong
0 siblings, 1 reply; 49+ messages in thread
From: Vikash Garodia @ 2026-05-20 15:44 UTC (permalink / raw)
To: Neil Armstrong, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/18/2026 1:12 PM, Neil Armstrong wrote:
> On 5/13/26 19:33, Vikash Garodia wrote:
>>
>> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>>> This adds the plumbing to support decoding HEVC, VP9 and AV1
>>> streams into 10bit pixel formats, linear and compressed.
>>>
>>> This has only been tested on SM8550 & SM8650 with HEVC, and was
>>> inspired by Venus, DRM MSM and the downstream vidc driver for the
>>> buffer calculations and HFI messages.
>>>
>>> I was unable to get 10bit decoding working with ffmpeg since P010
>>> support for v4l2 decoding is missing, but v4l2-ctl works with:
>>> v4l2-ctl --verbose --set-fmt-video-out=pixelformat=HEVC --set-fmt-
>>> video=pixelformat=P010 --stream-mmap --stream-out-mmap --stream-from-
>>> hdr Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr --stream-to out.P010
>>> v4l2-ctl --verbose --set-fmt-video-out=pixelformat=HEVC --set-fmt-
>>> video=pixelformat=Q10C --stream-mmap --stream-out-mmap --stream-from-
>>> hdr Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr --stream-to out.QC10
>>>
>>> The non-10bit decoding still works as before.
>>>
>>> With Big_Buck_Bunny_1080_10s_30MB reencoded in 10-bit profile
>>> and tranformed in v4l2 header format with [1]:
>>> ffmpeg -i Big_Buck_Bunny_1080_10s_30MB.h264 -pix_fmt yuv420p10le -c:v
>>> libx265 -crf 28 -x265-params profile=main10
>>> Big_Buck_Bunny_1080_10s_30MB_main10.h265
>>> /path/to/mkhdr.sh Big_Buck_Bunny_1080_10s_30MB_main10.h265 raw
>>> Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr
>>>
>>> Fluster HEVC results on SM8650:
>>>
>>> ./fluster.py run -ts JCT-VC-HEVC_V1 -d GStreamer-H.265-V4L2-Gst1.0 -
>>> 131/147
>>> The failing test case:
>>> - Pixel Format mismatch
>>> - TSUNEQBD_A_MAIN10_Technicolor_2 - Gstreamer waits NV12 but
>>> decoder returns P010
>>> - Unsupported resolution
>>> - PICSIZE_A_Bossen_1 - resolution is higher than max supported
>>> - PICSIZE_B_Bossen_1 - resolution is higher than max supported
>>> - WPP_D_ericsson_MAIN_2 - resolution is lower than min supported
>>> - WPP_D_ericsson_MAIN10_2 - resolution is lower than min supported
>>> - CRC mismatch
>>> - RAP_A_docomo_6
>>> - CRC mismatch - bitstream issue - fails with ffmpeg sw decoder as well
>>> - VPSSPSPPS_A_MainConcept_1
>>
>> From earlier SOC reports, 10bit tests which were failing were
>> - DBLK_A_MAIN10_VIXS_4
>> - INITQP_B_Main10_Sony_1
>> - TSUNEQBD_A_MAIN10_Technicolor_2
>> - WP_A_MAIN10_Toshiba_3
>> - WP_MAIN10_B_Toshiba_3
>> - WPP_A_ericsson_MAIN10_2
>> - WPP_B_ericsson_MAIN10_2
>> - WPP_C_ericsson_MAIN10_2
>> - WPP_E_ericsson_MAIN10_2
>> - WPP_F_ericsson_MAIN10_2
>>
>> I was in the opinion that once we enable 10bit, these tests would
>> pass. Though i do not see these in your failing tests, but the count
>> of 131/147 have not improved. Could you check if these tests are
>> passing and count is better than 131 pass ?
>
> Sorry there's a copy paste error I'll fix on v4, here's the fluster log:
>
>
> |Test|GStreamer-H.265-V4L2|
> |-|-|
> |TOTAL|141/147|
> |TOTAL TIME|8.600s|
> |-|-|
> ...
> |PICSIZE_A_Bossen_1|☠|
> |PICSIZE_B_Bossen_1|☠|
> ...
> |RAP_A_docomo_6|❌|
> ...
> |TSUNEQBD_A_MAIN10_Technicolor_2|☠|
> ...
> |WPP_D_ericsson_MAIN10_2|☠|
> |WPP_D_ericsson_MAIN_2|☠|
> ...
> |-|-|
> |Test|GStreamer-H.265-V4L2|
> |TOTAL|140/147|
> |TOTAL TIME|8.600s|
>
> |-|-|
> |Profile|GStreamer-H.265-V4L2|
> |MAIN|131/135|
> |MAIN_10|9/11|
> |MAIN_STILL_PICTURE|1/1|
>
> So the failing cases:
> - Pixel Format mismatch
> - TSUNEQBD_A_MAIN10_Technicolor_2 - Gstreamer waits NV12 but decoder
> returns P010
Why would gstreamer expect NV12 for MAIN10 usecase ? Is this something
to do with format negotiation ?
> - Unsupported resolution
> - PICSIZE_A_Bossen_1 - resolution is higher than max supported
> - PICSIZE_B_Bossen_1 - resolution is higher than max supported
> - WPP_D_ericsson_MAIN_2 - resolution is lower than min supported
> - WPP_D_ericsson_MAIN10_2 - resolution is lower than min supported
> - CRC mismatch
> - RAP_A_docomo_6
>
>>
>> Regards,
>> Vikash
>
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats
2026-05-20 15:44 ` Vikash Garodia
@ 2026-05-21 7:24 ` Neil Armstrong
2026-05-21 9:33 ` Vikash Garodia
0 siblings, 1 reply; 49+ messages in thread
From: Neil Armstrong @ 2026-05-21 7:24 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/20/26 17:44, Vikash Garodia wrote:
>
> On 5/18/2026 1:12 PM, Neil Armstrong wrote:
>> On 5/13/26 19:33, Vikash Garodia wrote:
>>>
>>> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>>>> This adds the plumbing to support decoding HEVC, VP9 and AV1
>>>> streams into 10bit pixel formats, linear and compressed.
>>>>
>>>> This has only been tested on SM8550 & SM8650 with HEVC, and was
>>>> inspired by Venus, DRM MSM and the downstream vidc driver for the
>>>> buffer calculations and HFI messages.
>>>>
>>>> I was unable to get 10bit decoding working with ffmpeg since P010
>>>> support for v4l2 decoding is missing, but v4l2-ctl works with:
>>>> v4l2-ctl --verbose --set-fmt-video-out=pixelformat=HEVC --set-fmt- video=pixelformat=P010 --stream-mmap --stream-out-mmap --stream-from- hdr Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr --stream-to out.P010
>>>> v4l2-ctl --verbose --set-fmt-video-out=pixelformat=HEVC --set-fmt- video=pixelformat=Q10C --stream-mmap --stream-out-mmap --stream-from- hdr Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr --stream-to out.QC10
>>>>
>>>> The non-10bit decoding still works as before.
>>>>
>>>> With Big_Buck_Bunny_1080_10s_30MB reencoded in 10-bit profile
>>>> and tranformed in v4l2 header format with [1]:
>>>> ffmpeg -i Big_Buck_Bunny_1080_10s_30MB.h264 -pix_fmt yuv420p10le -c:v libx265 -crf 28 -x265-params profile=main10 Big_Buck_Bunny_1080_10s_30MB_main10.h265
>>>> /path/to/mkhdr.sh Big_Buck_Bunny_1080_10s_30MB_main10.h265 raw Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr
>>>>
>>>> Fluster HEVC results on SM8650:
>>>>
>>>> ./fluster.py run -ts JCT-VC-HEVC_V1 -d GStreamer-H.265-V4L2-Gst1.0 - 131/147
>>>> The failing test case:
>>>> - Pixel Format mismatch
>>>> - TSUNEQBD_A_MAIN10_Technicolor_2 - Gstreamer waits NV12 but decoder returns P010
>>>> - Unsupported resolution
>>>> - PICSIZE_A_Bossen_1 - resolution is higher than max supported
>>>> - PICSIZE_B_Bossen_1 - resolution is higher than max supported
>>>> - WPP_D_ericsson_MAIN_2 - resolution is lower than min supported
>>>> - WPP_D_ericsson_MAIN10_2 - resolution is lower than min supported
>>>> - CRC mismatch
>>>> - RAP_A_docomo_6
>>>> - CRC mismatch - bitstream issue - fails with ffmpeg sw decoder as well
>>>> - VPSSPSPPS_A_MainConcept_1
>>>
>>> From earlier SOC reports, 10bit tests which were failing were
>>> - DBLK_A_MAIN10_VIXS_4
>>> - INITQP_B_Main10_Sony_1
>>> - TSUNEQBD_A_MAIN10_Technicolor_2
>>> - WP_A_MAIN10_Toshiba_3
>>> - WP_MAIN10_B_Toshiba_3
>>> - WPP_A_ericsson_MAIN10_2
>>> - WPP_B_ericsson_MAIN10_2
>>> - WPP_C_ericsson_MAIN10_2
>>> - WPP_E_ericsson_MAIN10_2
>>> - WPP_F_ericsson_MAIN10_2
>>>
>>> I was in the opinion that once we enable 10bit, these tests would pass. Though i do not see these in your failing tests, but the count of 131/147 have not improved. Could you check if these tests are passing and count is better than 131 pass ?
>>
>> Sorry there's a copy paste error I'll fix on v4, here's the fluster log:
>>
>>
>> |Test|GStreamer-H.265-V4L2|
>> |-|-|
>> |TOTAL|141/147|
>> |TOTAL TIME|8.600s|
>> |-|-|
>> ...
>> |PICSIZE_A_Bossen_1|☠|
>> |PICSIZE_B_Bossen_1|☠|
>> ...
>> |RAP_A_docomo_6|❌|
>> ...
>> |TSUNEQBD_A_MAIN10_Technicolor_2|☠|
>> ...
>> |WPP_D_ericsson_MAIN10_2|☠|
>> |WPP_D_ericsson_MAIN_2|☠|
>> ...
>> |-|-|
>> |Test|GStreamer-H.265-V4L2|
>> |TOTAL|140/147|
>> |TOTAL TIME|8.600s|
>>
>> |-|-|
>> |Profile|GStreamer-H.265-V4L2|
>> |MAIN|131/135|
>> |MAIN_10|9/11|
>> |MAIN_STILL_PICTURE|1/1|
>>
>> So the failing cases:
>> - Pixel Format mismatch
>> - TSUNEQBD_A_MAIN10_Technicolor_2 - Gstreamer waits NV12 but decoder returns P010
>
> Why would gstreamer expect NV12 for MAIN10 usecase ? Is this something to do with format negotiation ?
# Feature: Test unequal luma and chroma bitdepth
# setting. The luma bitdepth is higher than the chroma
# bitdepth.
# Luma is 10 bit, chroma is 9 bit
This particular test uses different bit depth for luma and chroma, and the fw upscales all to 10bit
while the sw decoder seems to downscale to 8bit. And it seems other HW decoder does the same as iris.
I think the HW decoder is right here, but this use case will probably never occur in real life.
>
>> - Unsupported resolution
>> - PICSIZE_A_Bossen_1 - resolution is higher than max supported
>> - PICSIZE_B_Bossen_1 - resolution is higher than max supported
>> - WPP_D_ericsson_MAIN_2 - resolution is lower than min supported
>> - WPP_D_ericsson_MAIN10_2 - resolution is lower than min supported
>> - CRC mismatch
>> - RAP_A_docomo_6
>>
>>>
>>> Regards,
>>> Vikash
>>
>
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats
2026-05-21 7:24 ` Neil Armstrong
@ 2026-05-21 9:33 ` Vikash Garodia
0 siblings, 0 replies; 49+ messages in thread
From: Vikash Garodia @ 2026-05-21 9:33 UTC (permalink / raw)
To: Neil Armstrong, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, Nicolas Dufresne
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/21/2026 12:54 PM, Neil Armstrong wrote:
> On 5/20/26 17:44, Vikash Garodia wrote:
>>
>> On 5/18/2026 1:12 PM, Neil Armstrong wrote:
>>> On 5/13/26 19:33, Vikash Garodia wrote:
>>>>
>>>> On 5/11/2026 2:50 PM, Neil Armstrong wrote:
>>>>> This adds the plumbing to support decoding HEVC, VP9 and AV1
>>>>> streams into 10bit pixel formats, linear and compressed.
>>>>>
>>>>> This has only been tested on SM8550 & SM8650 with HEVC, and was
>>>>> inspired by Venus, DRM MSM and the downstream vidc driver for the
>>>>> buffer calculations and HFI messages.
>>>>>
>>>>> I was unable to get 10bit decoding working with ffmpeg since P010
>>>>> support for v4l2 decoding is missing, but v4l2-ctl works with:
>>>>> v4l2-ctl --verbose --set-fmt-video-out=pixelformat=HEVC --set-fmt-
>>>>> video=pixelformat=P010 --stream-mmap --stream-out-mmap --stream-
>>>>> from- hdr Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr --stream-to
>>>>> out.P010
>>>>> v4l2-ctl --verbose --set-fmt-video-out=pixelformat=HEVC --set-fmt-
>>>>> video=pixelformat=Q10C --stream-mmap --stream-out-mmap --stream-
>>>>> from- hdr Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr --stream-to
>>>>> out.QC10
>>>>>
>>>>> The non-10bit decoding still works as before.
>>>>>
>>>>> With Big_Buck_Bunny_1080_10s_30MB reencoded in 10-bit profile
>>>>> and tranformed in v4l2 header format with [1]:
>>>>> ffmpeg -i Big_Buck_Bunny_1080_10s_30MB.h264 -pix_fmt yuv420p10le -
>>>>> c:v libx265 -crf 28 -x265-params profile=main10
>>>>> Big_Buck_Bunny_1080_10s_30MB_main10.h265
>>>>> /path/to/mkhdr.sh Big_Buck_Bunny_1080_10s_30MB_main10.h265 raw
>>>>> Big_Buck_Bunny_1080_10s_30MB_main10.h265.hdr
>>>>>
>>>>> Fluster HEVC results on SM8650:
>>>>>
>>>>> ./fluster.py run -ts JCT-VC-HEVC_V1 -d GStreamer-H.265-V4L2-Gst1.0
>>>>> - 131/147
>>>>> The failing test case:
>>>>> - Pixel Format mismatch
>>>>> - TSUNEQBD_A_MAIN10_Technicolor_2 - Gstreamer waits NV12 but
>>>>> decoder returns P010
>>>>> - Unsupported resolution
>>>>> - PICSIZE_A_Bossen_1 - resolution is higher than max supported
>>>>> - PICSIZE_B_Bossen_1 - resolution is higher than max supported
>>>>> - WPP_D_ericsson_MAIN_2 - resolution is lower than min supported
>>>>> - WPP_D_ericsson_MAIN10_2 - resolution is lower than min supported
>>>>> - CRC mismatch
>>>>> - RAP_A_docomo_6
>>>>> - CRC mismatch - bitstream issue - fails with ffmpeg sw decoder as
>>>>> well
>>>>> - VPSSPSPPS_A_MainConcept_1
>>>>
>>>> From earlier SOC reports, 10bit tests which were failing were
>>>> - DBLK_A_MAIN10_VIXS_4
>>>> - INITQP_B_Main10_Sony_1
>>>> - TSUNEQBD_A_MAIN10_Technicolor_2
>>>> - WP_A_MAIN10_Toshiba_3
>>>> - WP_MAIN10_B_Toshiba_3
>>>> - WPP_A_ericsson_MAIN10_2
>>>> - WPP_B_ericsson_MAIN10_2
>>>> - WPP_C_ericsson_MAIN10_2
>>>> - WPP_E_ericsson_MAIN10_2
>>>> - WPP_F_ericsson_MAIN10_2
>>>>
>>>> I was in the opinion that once we enable 10bit, these tests would
>>>> pass. Though i do not see these in your failing tests, but the count
>>>> of 131/147 have not improved. Could you check if these tests are
>>>> passing and count is better than 131 pass ?
>>>
>>> Sorry there's a copy paste error I'll fix on v4, here's the fluster log:
>>>
>>>
>>> |Test|GStreamer-H.265-V4L2|
>>> |-|-|
>>> |TOTAL|141/147|
>>> |TOTAL TIME|8.600s|
>>> |-|-|
>>> ...
>>> |PICSIZE_A_Bossen_1|☠|
>>> |PICSIZE_B_Bossen_1|☠|
>>> ...
>>> |RAP_A_docomo_6|❌|
>>> ...
>>> |TSUNEQBD_A_MAIN10_Technicolor_2|☠|
>>> ...
>>> |WPP_D_ericsson_MAIN10_2|☠|
>>> |WPP_D_ericsson_MAIN_2|☠|
>>> ...
>>> |-|-|
>>> |Test|GStreamer-H.265-V4L2|
>>> |TOTAL|140/147|
>>> |TOTAL TIME|8.600s|
>>>
>>> |-|-|
>>> |Profile|GStreamer-H.265-V4L2|
>>> |MAIN|131/135|
>>> |MAIN_10|9/11|
>>> |MAIN_STILL_PICTURE|1/1|
>>>
>>> So the failing cases:
>>> - Pixel Format mismatch
>>> - TSUNEQBD_A_MAIN10_Technicolor_2 - Gstreamer waits NV12 but
>>> decoder returns P010
>>
>> Why would gstreamer expect NV12 for MAIN10 usecase ? Is this something
>> to do with format negotiation ?
>
> # Feature: Test unequal luma and chroma bitdepth
> # setting. The luma bitdepth is higher than the
> chroma
> # bitdepth.
> # Luma is 10 bit, chroma is 9 bit
>
> This particular test uses different bit depth for luma and chroma, and
> the fw upscales all to 10bit
> while the sw decoder seems to downscale to 8bit. And it seems other HW
> decoder does the same as iris.
>
> I think the HW decoder is right here, but this use case will probably
> never occur in real life.
Have not seen such case either, where luma and chrome have different
bitdepth. We can mark them as not supported by VPU
+ing Nico if he has any comments on this test.
Regards,
Vikash
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats
2026-05-11 9:20 ` [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats Neil Armstrong
` (7 preceding siblings ...)
2026-05-13 17:33 ` Vikash Garodia
@ 2026-05-15 9:35 ` Bryan O'Donoghue
2026-05-15 9:38 ` Vikash Garodia
2026-05-21 8:56 ` Neil Armstrong
8 siblings, 2 replies; 49+ messages in thread
From: Bryan O'Donoghue @ 2026-05-15 9:35 UTC (permalink / raw)
To: Neil Armstrong, Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
Can you rebase off of:
https://gitlab.freedesktop.org/linux-media/media-committers/-/tree/next
and ideally make sure everything applies against
https://gitlab.freedesktop.org/linux-media/users/bodonoghue/-/tree/next+fixes
bod-media-committers-next-plaform-qcom(next-smoketest*)$ b4 shazam
20260511-topic-sm8x50-iris-10bit-decoding-v3-0-7fc049b93042@linaro.org
Grabbing thread from
lore.kernel.org/all/20260511-topic-sm8x50-iris-10bit-decoding-v3-0-7fc049b93042@linaro.org/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 25 messages in the thread
Analyzing 12 code-review messages
Checking attestation on all messages, may take a moment...
---
✓ [PATCH v3 1/6] media: qcom: iris: add helpers for 8bit and 10bit
formats
+ Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
✓ [PATCH v3 2/6] media: qcom: iris: add QC10C & P010 buffer size
calculations
✓ [PATCH v3 3/6] media: qcom: iris: gen2: add support for 10bit decoding
+ Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
✓ [PATCH v3 4/6] media: qcom: iris: vdec: update size and stride
calculations for 10bit formats
+ Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
✓ [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to
handle 8bit and 10bit formats
+ Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
✓ [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into
10bit format
+ Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
✓ Signed: openpgp/neil.armstrong@linaro.org
---
NOTE: install dkimpy for DKIM signature verification
---
Total patches: 6
---
Base: base-commit 76671814f2843482d97feca12e95c06f0b05bc8a not known,
ignoring
Applying: media: qcom: iris: add helpers for 8bit and 10bit formats
Applying: media: qcom: iris: add QC10C & P010 buffer size calculations
Applying: media: qcom: iris: gen2: add support for 10bit decoding
Applying: media: qcom: iris: vdec: update size and stride calculations
for 10bit formats
Applying: media: qcom: iris: vdec: update find_format to handle 8bit and
10bit formats
Applying: media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
Patch failed at 0006 media: qcom: iris: vdec: allow GEN2 decoding into
10bit format
error: drivers/media/platform/qcom/iris/iris_platform_gen2.c: does not
exist in index
that file got zapped in:
commit 53a5e095636acbab817a7fb98a67ce76cac59fdf
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Date: Sun Mar 29 02:33:10 2026 +0200
media: qcom: iris: split platform data from firmware data
Finalize the logical separation of the software and hardware interface
descriptions by moving hardware properties to the files specific to the
particular VPU version.
Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
diff --git a/drivers/media/platform/qcom/iris/Makefile
b/drivers/media/platform/qcom/iris/Makefile
index 2fde45f817276..48e415cbc4390 100644
--- a/drivers/media/platform/qcom/iris/Makefile
+++ b/drivers/media/platform/qcom/iris/Makefile
@@ -4,14 +4,16 @@ qcom-iris-objs += iris_buffer.o \
iris_ctrls.o \
iris_firmware.o \
iris_hfi_common.o \
+ iris_hfi_gen1.o \
iris_hfi_gen1_command.o \
iris_hfi_gen1_response.o \
+ iris_hfi_gen2.o \
iris_hfi_gen2_command.o \
iris_hfi_gen2_packet.o \
iris_hfi_gen2_response.o \
iris_hfi_queue.o \
- iris_platform_gen1.o \
- iris_platform_gen2.o \
+ iris_platform_vpu2.o \
+ iris_platform_vpu3x.o \
iris_power.o \
iris_probe.o \
iris_resources.o \
---
bod
^ permalink raw reply [flat|nested] 49+ messages in thread* Re: [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats
2026-05-15 9:35 ` Bryan O'Donoghue
@ 2026-05-15 9:38 ` Vikash Garodia
2026-05-21 8:56 ` Neil Armstrong
1 sibling, 0 replies; 49+ messages in thread
From: Vikash Garodia @ 2026-05-15 9:38 UTC (permalink / raw)
To: Bryan O'Donoghue, Neil Armstrong, Dikshita Agarwal,
Abhinav Kumar, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/15/2026 3:05 PM, Bryan O'Donoghue wrote:
>
> Can you rebase off of:
>
> https://gitlab.freedesktop.org/linux-media/media-committers/-/tree/next
>
> and ideally make sure everything applies against
>
> https://gitlab.freedesktop.org/linux-media/users/bodonoghue/-/tree/
> next+fixes
>
there are issues reported and review comments open in this series. You
need to wait for them to be addressed.
> bod-media-committers-next-plaform-qcom(next-smoketest*)$ b4 shazam
> 20260511-topic-sm8x50-iris-10bit-decoding-v3-0-7fc049b93042@linaro.org
> Grabbing thread from lore.kernel.org/all/20260511-topic-sm8x50-
> iris-10bit-decoding-v3-0-7fc049b93042@linaro.org/t.mbox.gz
> Checking for newer revisions
> Grabbing search results from lore.kernel.org
> Analyzing 25 messages in the thread
> Analyzing 12 code-review messages
> Checking attestation on all messages, may take a moment...
> ---
> ✓ [PATCH v3 1/6] media: qcom: iris: add helpers for 8bit and 10bit
> formats
> + Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ✓ [PATCH v3 2/6] media: qcom: iris: add QC10C & P010 buffer size
> calculations
> ✓ [PATCH v3 3/6] media: qcom: iris: gen2: add support for 10bit decoding
> + Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ✓ [PATCH v3 4/6] media: qcom: iris: vdec: update size and stride
> calculations for 10bit formats
> + Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ✓ [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to
> handle 8bit and 10bit formats
> + Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ✓ [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into
> 10bit format
> + Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> ✓ Signed: openpgp/neil.armstrong@linaro.org
> ---
> NOTE: install dkimpy for DKIM signature verification
> ---
> Total patches: 6
> ---
> Base: base-commit 76671814f2843482d97feca12e95c06f0b05bc8a not known,
> ignoring
> Applying: media: qcom: iris: add helpers for 8bit and 10bit formats
> Applying: media: qcom: iris: add QC10C & P010 buffer size calculations
> Applying: media: qcom: iris: gen2: add support for 10bit decoding
> Applying: media: qcom: iris: vdec: update size and stride calculations
> for 10bit formats
> Applying: media: qcom: iris: vdec: update find_format to handle 8bit and
> 10bit formats
> Applying: media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
> Patch failed at 0006 media: qcom: iris: vdec: allow GEN2 decoding into
> 10bit format
> error: drivers/media/platform/qcom/iris/iris_platform_gen2.c: does not
> exist in index
>
> that file got zapped in:
>
> commit 53a5e095636acbab817a7fb98a67ce76cac59fdf
> Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Date: Sun Mar 29 02:33:10 2026 +0200
>
> media: qcom: iris: split platform data from firmware data
>
> Finalize the logical separation of the software and hardware interface
> descriptions by moving hardware properties to the files specific to
> the
> particular VPU version.
>
> Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
>
> diff --git a/drivers/media/platform/qcom/iris/Makefile b/drivers/media/
> platform/qcom/iris/Makefile
> index 2fde45f817276..48e415cbc4390 100644
> --- a/drivers/media/platform/qcom/iris/Makefile
> +++ b/drivers/media/platform/qcom/iris/Makefile
> @@ -4,14 +4,16 @@ qcom-iris-objs += iris_buffer.o \
> iris_ctrls.o \
> iris_firmware.o \
> iris_hfi_common.o \
> + iris_hfi_gen1.o \
> iris_hfi_gen1_command.o \
> iris_hfi_gen1_response.o \
> + iris_hfi_gen2.o \
> iris_hfi_gen2_command.o \
> iris_hfi_gen2_packet.o \
> iris_hfi_gen2_response.o \
> iris_hfi_queue.o \
> - iris_platform_gen1.o \
> - iris_platform_gen2.o \
> + iris_platform_vpu2.o \
> + iris_platform_vpu3x.o \
> iris_power.o \
> iris_probe.o \
> iris_resources.o \
>
> ---
> bod
^ permalink raw reply [flat|nested] 49+ messages in thread
* Re: [PATCH v3 0/6] media: qcom: iris: add support for decoding 10bit formats
2026-05-15 9:35 ` Bryan O'Donoghue
2026-05-15 9:38 ` Vikash Garodia
@ 2026-05-21 8:56 ` Neil Armstrong
1 sibling, 0 replies; 49+ messages in thread
From: Neil Armstrong @ 2026-05-21 8:56 UTC (permalink / raw)
To: Bryan O'Donoghue, Vikash Garodia, Dikshita Agarwal,
Abhinav Kumar, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 5/15/26 11:35, Bryan O'Donoghue wrote:
>
> Can you rebase off of:
>
> https://gitlab.freedesktop.org/linux-media/media-committers/-/tree/next
>
> and ideally make sure everything applies against
>
> https://gitlab.freedesktop.org/linux-media/users/bodonoghue/-/tree/next+fixes
Ack, I rebased and it applies cleanly.
Will post v4 after testing with fixes asked by Vikash
Neil
>
> bod-media-committers-next-plaform-qcom(next-smoketest*)$ b4 shazam 20260511-topic-sm8x50-iris-10bit-decoding-v3-0-7fc049b93042@linaro.org
> Grabbing thread from lore.kernel.org/all/20260511-topic-sm8x50-iris-10bit-decoding-v3-0-7fc049b93042@linaro.org/t.mbox.gz
> Checking for newer revisions
> Grabbing search results from lore.kernel.org
> Analyzing 25 messages in the thread
> Analyzing 12 code-review messages
> Checking attestation on all messages, may take a moment...
> ---
> ✓ [PATCH v3 1/6] media: qcom: iris: add helpers for 8bit and 10bit formats
> + Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ✓ [PATCH v3 2/6] media: qcom: iris: add QC10C & P010 buffer size calculations
> ✓ [PATCH v3 3/6] media: qcom: iris: gen2: add support for 10bit decoding
> + Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ✓ [PATCH v3 4/6] media: qcom: iris: vdec: update size and stride calculations for 10bit formats
> + Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ✓ [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats
> + Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ✓ [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
> + Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> ✓ Signed: openpgp/neil.armstrong@linaro.org
> ---
> NOTE: install dkimpy for DKIM signature verification
> ---
> Total patches: 6
> ---
> Base: base-commit 76671814f2843482d97feca12e95c06f0b05bc8a not known, ignoring
> Applying: media: qcom: iris: add helpers for 8bit and 10bit formats
> Applying: media: qcom: iris: add QC10C & P010 buffer size calculations
> Applying: media: qcom: iris: gen2: add support for 10bit decoding
> Applying: media: qcom: iris: vdec: update size and stride calculations for 10bit formats
> Applying: media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats
> Applying: media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
> Patch failed at 0006 media: qcom: iris: vdec: allow GEN2 decoding into 10bit format
> error: drivers/media/platform/qcom/iris/iris_platform_gen2.c: does not exist in index
>
> that file got zapped in:
>
> commit 53a5e095636acbab817a7fb98a67ce76cac59fdf
> Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Date: Sun Mar 29 02:33:10 2026 +0200
>
> media: qcom: iris: split platform data from firmware data
>
> Finalize the logical separation of the software and hardware interface
> descriptions by moving hardware properties to the files specific to the
> particular VPU version.
>
> Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
>
> diff --git a/drivers/media/platform/qcom/iris/Makefile b/drivers/media/platform/qcom/iris/Makefile
> index 2fde45f817276..48e415cbc4390 100644
> --- a/drivers/media/platform/qcom/iris/Makefile
> +++ b/drivers/media/platform/qcom/iris/Makefile
> @@ -4,14 +4,16 @@ qcom-iris-objs += iris_buffer.o \
> iris_ctrls.o \
> iris_firmware.o \
> iris_hfi_common.o \
> + iris_hfi_gen1.o \
> iris_hfi_gen1_command.o \
> iris_hfi_gen1_response.o \
> + iris_hfi_gen2.o \
> iris_hfi_gen2_command.o \
> iris_hfi_gen2_packet.o \
> iris_hfi_gen2_response.o \
> iris_hfi_queue.o \
> - iris_platform_gen1.o \
> - iris_platform_gen2.o \
> + iris_platform_vpu2.o \
> + iris_platform_vpu3x.o \
> iris_power.o \
> iris_probe.o \
> iris_resources.o \
>
> ---
> bod
^ permalink raw reply [flat|nested] 49+ messages in thread